systems-assistant[bot]
16334bc15d
SWDEV-525244 - Additional graph validation test ( #584 )
...
* SWDEV-525244 - Additional graph validation test
* SWDEV-525244 - Change capture mode to relaxed
* SWDEV-525244 - Additional comments
---------
Co-authored-by: Vladana Stojiljkovic <Vladana.Stojiljkovic@amd.com >
2025-11-05 09:32:47 +01:00
vstojilj
18d4fc460b
SWDEV-541362 - Fix error code mismatch in test ( #1377 )
2025-11-05 09:31:30 +01:00
vstojilj
7d078b9875
SWDEV-553920 - Fix Unit_hipStreamCreateWithPriority_ValidateWithEvents ( #1622 )
2025-11-05 09:31:01 +01:00
pcritchl-amd
8d31383dfe
SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 ( #1587 )
...
Co-authored-by: Rakesh Roy <137397847+rakesroy@users.noreply.github.com >
2025-11-05 10:37:45 +05:30
Sourabh U Betigeri
78e9e47852
SWDEV-551244 - Fixes CUDA 13 compilation issues ( #1237 )
2025-11-04 16:56:49 -08:00
David Galiffi
1e501dd89a
Free runner disk space ( #1693 )
...
Motivation:
Basic runners are frequently running out of space
Technical Details:
Running autoclean after package installations.
Use the jlumbroso/free-disk-space action.
2025-11-04 17:31:23 -05:00
Scott Todd
fdbafd7757
Revert "SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags ( #1057 )" ( #1690 )
...
Reverts ROCm/rocm-systems#1057
Suspected of breaking the build, see https://github.com/ROCm/rocm-systems/pull/1057#issuecomment-3487715129
Logs: https://github.com/ROCm/rocm-systems/actions/runs/19062134668/job/54444052479#step:12:315
```
[rocprofiler-sdk] FAILED: source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o
[rocprofiler-sdk] ccache /opt/rh/gcc-toolset-12/root/usr/bin/c++ -DAMD_INTERNAL_BUILD=1 -DGLOG_USE_GLOG_EXPORT -DROCPROFILER_DL=1 -DROCPROFILER_HAS_GHC_LIB_FILESYSTEM=1 -DROCPROFILER_SDK_USE_SYSTEM_RCCL=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCDECODE=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCJPEG=0 -DUSE_PROF_API=1 -DYAML_CPP_STATIC_DEFINE -D__HIP_PLATFORM_AMD__=1 -Drocprofiler_EXPORTS=1 -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/yaml-cpp/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/ptl/source -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/ptl/source -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/clr/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/ROCR-Runtime/dist/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/filesystem/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/glog -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/glog/src -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/fmt/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/elfio -isystem /__w/rocm-systems/rocm-systems/TheRock/build/compiler/amd-comgr-stub/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include/libdrm -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/elfutils/build/dist/lib/rocm_sysdeps/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -W -Wall -Wno-unknown-pragmas -faligned-new -rdynamic -fstack-protector-strong -Wstack-protector -MD -MT source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -MF source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o.d -o source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -c /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp
[rocprofiler-sdk] In file included from /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp:26:
[rocprofiler-sdk] /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/common/abi.hpp:62:27: error: static assertion failed: size of the API table struct has changed. Update the STEP_VERSION number (or in rare cases, the MAJOR_VERSION number)
[rocprofiler-sdk] 62 | sizeof(TABLE) == ::rocprofiler::common::abi::compute_table_offset(NUM), \
```
2025-11-04 14:29:58 -08:00
marandje
811609c0e1
SWDEV-523137 - Fix and enable a few negative tests on NV ( #1157 )
2025-11-04 23:28:11 +01:00
David Galiffi
4b0fb2cdf5
Rename "corr_id" to "stack_id" in Perfetto annotations to match new n… ( #1618 )
...
* Rename "corr_id" to "stack_id" in Perfetto annotations to match new naming in schema.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
* correlation_id.ancestor was not added until ROCPROFILER_VERSION 1.0
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2025-11-04 14:20:11 -05:00
Joseph Macaranas
b19cf0aadf
Revert "Disable therock summary check, make it always positive ( #1675 )" ( #1686 )
...
This reverts commit 0c32b90130 .
2025-11-04 14:17:37 -05:00
Pratik Basyal
6356c179ff
[ROCm Systems Profiler] 7.1.0 Formatting updated for understanding rocpd output docs" ( #1663 )
...
* Formatting udpated for ROCm Systems rocpd docs"
* Minor change
* Formatting in profiler script fixed"
* Sphinx warnings and formatting fixes
* Formatting fixed
* Formatting fixed
* Collapsible code block added
* Dixygne change reverted
2025-11-04 12:48:02 -05:00
Pratik Basyal
9d84958527
JSON profiler option removed ( #1649 )
2025-11-04 17:49:22 +01:00
Sam Ruscica
757de39caa
Updated amdFileRead/Write in rocdevice to support windows build ( #1435 )
...
* Updated amdFileRead in rocdevice to support windows build
* Updated amdFileRead in rocdevice to support windows build
2025-11-04 10:03:03 -05:00
Danylo Lytovchenko
0c32b90130
Disable therock summary check, make it always positive ( #1675 )
2025-11-04 12:58:53 +01:00
marantic-amd
f4a65875d5
Added SQLite3 as a external submodule to rocprofiler-systems ( #1348 )
2025-11-04 11:33:25 +01:00
Todd tiantuo Li
7573fa168d
SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags ( #1057 )
2025-11-04 00:16:12 -08:00
MachineTom
fb006546d0
SWDEV-1 - Fix a typo ( #1615 )
...
* SWDEV-1 - Fix a typo
Fix a typo.
Remove unnecessary log.
* Removing patch
---------
Co-authored-by: geomin12 <geomin12@amd.com >
Co-authored-by: Scott Todd <scott.todd0@gmail.com >
2025-11-03 12:59:00 -08:00
marandje
d411d101fb
SWDEV-557363 - Fix and enable Unit_hipWallClock64_Positive_Basic ( #1223 )
2025-11-03 21:08:33 +01:00
marandje
1ccc0ce2e4
SWDEV-555299 - Fix and enable Unit_Device_modf_modff_Negative_RTC ( #1012 )
2025-11-03 21:08:09 +01:00
Ammar ELWazir
da297d46e8
[ROCProfiler-sdk] [Docs CI] Refactor Git setup and CMake commands in workflow ( #1662 )
2025-11-03 12:12:35 -06:00
German Andryeyev
ee1158b7b8
rocr: Fix Windows build and Ctz implementation ( #1634 )
2025-11-03 12:07:11 -05:00
Ajay GunaShekar
d998a5280a
Revert "clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue ( #1316 )" ( #1654 )
...
This reverts commit f5bbb09c0d .
windows build failure and requires PAL update
2025-11-03 08:17:26 -08:00
Ammar ELWazir
9fa1d1b97e
[ROCProfiler-SDK] Remove 'gfx900' and 'gfx940' from GPU targets ( #1661 )
...
* [ROCProfiler-SDK] Remove 'gfx900' and 'gfx940' from GPU targets
* Remove unsupported GPU targets from workflow
* Remove gfx900 and gfx940 from GPU targets
2025-11-03 11:09:29 -05:00
Kian Cossettini
2a080641a1
[rocprofiler-systems] Consolidate CTests to tests/ folder ( #1461 )
...
* Consolidate CTests to tests/ folder
* Remove comment
* Consolidate CTests to tests/ folder
* Remove comment
* Separate source code and test code for thread-limit into appropriate folders
* Remove sleeper.cpp and instead use linux sleep cmd
* Merge python-console tests into python-tests
2025-11-03 11:03:35 -05:00
sluzynsk-amd
9f940c7265
Add missing API calls to rocprofiler ( #1599 )
...
Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com >
2025-11-03 09:40:16 -06:00
Ammar ELWazir
fee5bd9a4e
Fixing ROCProfiler Register CI & ROCProfiler-SDK Docs CI ( #1570 )
...
---------
Co-authored-by: bgopesh <gopesh.bhardwaj@amd.com >
2025-11-03 09:24:32 -06:00
systems-assistant[bot]
740b27528f
kfdtest: Enable GPU selection via CLI for multi-GPU tests ( #245 )
...
* kfdtest: Enable GPU selection via CLI for multi-GPU tests
Replaced environment variable-based GPU selection with
GPU selection via command-line parameter --concurrentnodes (-c)
Modified g_TestGPUsNum to be passed in via command-line
parameter --testnodenum (t)
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
* kfdtest: Enable GPU selection via CLI for multi-GPU tests
Replaced environment variable-based GPU selection with
GPU selection via command-line parameter --concurrentnodes (-c)
Modified g_TestGPUsNum to be passed in via command-line
parameter --testnodenum (t)
---------
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com >
Co-authored-by: Alysa Liu <Alysa.Liu@amd.com >
2025-11-03 09:27:38 -05:00
vedithal-amd
bb5fd1d4ae
[rocprofiler-compute] Update analysis db for visualizer integration ( #1548 )
...
* Analysis db changes for visualizer
* Add support for per kernel analysis metrics
* Add support for dispatch timeline visualiztion
* Show median instead of mean of dispatch duration in kernel view
* Add test case to validate analysis db schema
* Analysis db schema updte
* Add Kernel table and make Metric and Dispatch table its children
* Kernel table is a child of Workload table
* Update metric_view to show kernel_name column
* Add disptach timestamps to Dispatch table for dispatch timeline
visualization
* Update kernel_view to show duration_ns_median instead of mean
duration
* Add mean duation in kernel view
* update changelog
---------
Co-authored-by: Fei Zheng <44449748+feizheng10@users.noreply.github.com >
2025-11-03 09:25:12 -05:00
vedithal-amd
dbb361c606
[rocprofiler-compute] fix parser to prevent missing metrics in analysis mode ( #1613 )
...
* fix parser
* fix parser
* fix parser
---------
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Co-authored-by: ywang103-amd <ywang103@amd.com >
2025-11-03 09:23:22 -05:00
Victor Zhang
437ce0b8df
fix atomics SystemTest() use after free ( #1595 )
2025-11-02 21:45:44 -05:00
arvindcheru
fb1d32c15c
SWDEV-530465 Update share/doc/<pkgnm> License Folder for hsa-rocr ( #923 )
...
* SWDEV-530465 Update share/doc/<pkgnm> License Folder for hsa-rocr
* Review Comments Updated - reverted to usage of DOCDIR
2025-10-31 23:21:22 -04:00
lmoriche
f5bbb09c0d
clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue ( #1316 )
...
* clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue
To simplify the shader debugger implementation, maintain the relevant
parts of the emulated AQL queue's MQD (amd_queue_t): read_dispatch_id,
write_dispatch_id, compute_tmpring_size.
With this MQD, the shader debugger can handle the emulated AQL queue
the same way it does the real AQL queue, no specialization is required.
* clr: SWDEV-547890 - Conservatively update the MQD's read_dispatch_id
The read_dispatch_id cannot be smaller than the current aql_packet_id
- hsa_queue.size for the debugger to work correctly.
The read_dispatch_id really should be updated when the CmdBuf is marked
as complete. Left a FIXME to address it in a future commit.
2025-10-31 16:07:02 -04:00
Satyanvesh Dittakavi
f332888366
SWDEV-560304 - Fix segfault with invalid stream ( #1360 )
2025-11-01 00:04:44 +05:30
David Galiffi
5850d5b973
Updating documentation ( #1602 )
...
* Update rocprof-sys-feature-set.rst
* Update configuring-runtime-options.rst
2025-10-31 14:30:25 -04:00
Jaydeep
10763f0e7a
SWDEV-559505 - Enable back memset optimization and handle the cases when setParam can change the number of AQL packets for memset graph node. ( #1320 )
...
Co-authored-by: jaydeeppatel1111 <jaypatel@amd.com >
2025-10-31 22:49:14 +05:30
Ossian O'Reilly
b9de7baaa9
Update README.md ( #1611 )
...
* Update README.md
Add missing directory in git sparse-checkout instructions
* Update README.md typo
---------
Co-authored-by: Young Hui - AMD <145490163+yhuiYH@users.noreply.github.com >
2025-10-31 13:16:09 -04:00
Yiannis Papadopoulos
37bbc9062a
rocr/aie: Detect AIE architecture and marketing name ( #1459 )
...
* rocr/aie: Detect AIE architecture and marketing name
* rocr/aie: Modernize code, update comments
2025-10-31 09:10:18 -05:00
Yiannis Papadopoulos
82d68fc772
rocrtst: Assume that AIE agent memory is system RAM ( #1231 )
2025-10-31 09:10:00 -05:00
Kian Cossettini
883caf2719
[rocprofiler-systems] Overhaul skip condition of implicit_task and add ROCPD validation test ( #1589 )
...
- Add rocpd validation check and fix implicit_task check
- SWDEV-562896
2025-10-31 09:59:23 -04:00
Ioannis Assiouras
1dd0237cb2
SWDEV-563752 - Allow hipMemLocationTypeHost in hipMemSetAccess even if memory was created on the device ( #1620 )
...
Co-authored-by: Rahul Manocha <rmanocha@amd.com >
2025-10-31 13:57:36 +00:00
ywang103-amd
24cb8c4deb
fix crashs related to metric generator and add copy right ( #1608 )
...
* fix crash created by path and arg for pc_sampling and add copyright for mat_mul
* resolve fomat issue of line too long
* bugfixes
* copy gfx9 config template to analysis config in src
---------
Co-authored-by: Wang <ywang103@ctr2-alola-login-01.amd.com >
Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com >
2025-10-30 16:36:56 -04:00
gabrpham_amdeng
9739611239
Fixed Namspace has no attribute 'pcie' error in set command
...
Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com >
2025-10-30 15:17:48 -05:00
gabrpham_amdeng
4d29ff8a2d
Fixed Namspace has no attribute 'pcie' error in set command
...
Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com >
[ROCm/amdsmi commit: 9739611239 ]
2025-10-30 15:17:48 -05:00
adapryor
4abb69f9d9
Fix evicted_time
2025-10-30 14:01:44 -05:00
adapryor
5c95a1485f
Fix evicted_time
...
[ROCm/amdsmi commit: 4abb69f9d9 ]
2025-10-30 14:01:44 -05:00
Dmitrii
a2cff3c84d
[RDC] Fix GPU_COUNT metric to only count GPUs ( #1453 )
...
* [RDC] Fix GPU_COUNT metric to only count GPUs
* [RDC] Clean up float->double casts
---------
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2025-10-30 12:50:47 -05:00
Galantsev, Dmitrii
a375479386
Use system gtest instead of building from source
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2025-10-30 12:38:11 -05:00
Galantsev, Dmitrii
adaf3c9966
Use system gtest instead of building from source
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/amdsmi commit: a375479386 ]
2025-10-30 12:38:11 -05:00
Galantsev, Dmitrii
ad20d57162
Find libamd_smi.so and librocm-core.so relative to wrapper.py
...
Allow amdsmi to find libamd_smi.so and librocm-core.so relative to
amdsmi_wrapper.py location.
The amdsmi_wrapper.py file is located in
_rocm_sdk_core/share/amd_smi/amdsmi and the libraries are in
_rocm_sdk_core/lib/libamd_smi.so.26.
_rocm_sdk_core/lib/librocm-core.so.1.
2025-10-30 12:35:06 -05:00
Galantsev, Dmitrii
55f999f3ce
Find libamd_smi.so and librocm-core.so relative to wrapper.py
...
Allow amdsmi to find libamd_smi.so and librocm-core.so relative to
amdsmi_wrapper.py location.
The amdsmi_wrapper.py file is located in
_rocm_sdk_core/share/amd_smi/amdsmi and the libraries are in
_rocm_sdk_core/lib/libamd_smi.so.26.
_rocm_sdk_core/lib/librocm-core.so.1.
[ROCm/amdsmi commit: ad20d57162 ]
2025-10-30 12:35:06 -05:00