Commit Graph

1018 Commits

Author SHA1 Message Date
Rahul Garg 3e3cebe614 Merge pull request #1598 from lmoriche/master
Fix a code object memory corruption

[ROCm/hip commit: 782cf1c007]
2019-10-31 17:12:24 -07:00
Rahul Garg 75cf902cdb Add stream
[ROCm/hip commit: 85d70086cb]
2019-10-31 12:15:56 -04:00
Rahul Garg 73ca647852 Fix HIP init calls in hipMemcpy2DFromArray
[ROCm/hip commit: efe6fa86dc]
2019-10-31 12:15:56 -04:00
Rahul Garg 7e742b1216 Merge pull request #1515 from ansurya/tex_unbind_issue_fix
Fix undefined ref to hipUnbindTexture for texture types

[ROCm/hip commit: ba8105e0cd]
2019-10-30 17:54:15 -07:00
Laurent Morichetti 1056ca35dc Addressed review comments
Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy


[ROCm/hip commit: 91748f4e6c]
2019-10-30 13:14:41 -07:00
Rahul Garg 70449cfa92 Revert "Fix occupany APIs (#1560)"
This reverts commit 4f23f9cb18.


[ROCm/hip commit: e4a1e44162]
2019-10-29 11:41:08 -07:00
Laurent Morichetti 86dd262e9b Fix a code object memory corruption
The lifetime of the buffer given to
hsa_code_object_reader_create_from_memory must exceed that of the
code object reader. We need to create a copy of the code object
binary memory (file) that is kept allocated until the code object
reader is destroyed.


[ROCm/hip commit: 7473140a76]
2019-10-29 08:23:57 -07:00
Anusha Godavarthy Surya 5c77b7d19a Merge branch 'master' into tex_unbind_issue_fix
[ROCm/hip commit: 03623cc3f1]
2019-10-25 15:54:25 +05:30
Anusha Godavarthy Surya 196bdea9c0 merge from master
[ROCm/hip commit: 5f47e99ffe]
2019-10-25 15:52:09 +05:30
Rahul Garg c315da2028 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/hip commit: 356765a223]
2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 3007505d30 Merge branch 'master' into tex_unbind_issue_fix
[ROCm/hip commit: 259d8b4cdf]
2019-10-25 15:36:55 +05:30
satyanveshd 4f23f9cb18 Fix occupany APIs (#1560)
Addresses SWDEV-205006 

[ROCm/hip commit: af351d7e1b]
2019-10-24 17:44:47 +05:30
searlmc1 4d668d5a52 Improve performance of v2 arg handling (#1539)
* Improve performance of v2 arg handling

* Missing change to `std::string`


[ROCm/hip commit: c4a51f3679]
2019-10-24 17:44:05 +05:30
Aryan Salmanpour 9ab561dd66 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/hip commit: 359dc79101]
2019-10-24 17:43:30 +05:30
Rahul Garg f82e9cd090 Merge pull request #1544 from vsytch/master
QoL changes to the hipMemset family

[ROCm/hip commit: e1aac060da]
2019-10-16 18:54:20 -07:00
Nick Curtis d2e9718d23 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528)
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis


[ROCm/hip commit: 73ca2b0083]
2019-10-16 10:49:56 +05:30
Vladislav Sytchenko 370d039d24 Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
[ROCm/hip commit: 0b52c1d9d8]
2019-10-15 14:18:42 -04:00
Anusha Godavarthy Surya 04080d4bb1 Fix undefine ref to hipUbindTexture for texture types
[ROCm/hip commit: af5f195e46]
2019-10-09 16:26:06 +05:30
Evgeny 8c0b43156e tracing layer unifying with hcc: removing API_ID_ANY
[ROCm/hip commit: 4e93833035]
2019-10-08 19:09:43 -05:00
Rahul Garg 4f899d487c Fix PCI Domain ID query (#1424)
* Fix PCI Domain ID query

* Update BDF comment


[ROCm/hip commit: 96530cba3b]
2019-10-07 14:11:52 +05:30
mhbliao 4b05ebc194 [hip] Add the missing header <sstream>. (#1498)
[ROCm/hip commit: 4d632166bb]
2019-10-04 13:39:29 +05:30
Rahul Garg 3b9b5fca8d Add texref get APIs support (#1471)
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress



[ROCm/hip commit: bec725dec2]
2019-10-04 13:38:45 +05:30
ansurya 66e94b1b1f Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/hip commit: ba9c6e13e4]
2019-10-04 13:36:31 +05:30
Siu Chi Chan 0f9074b568 fix kernel descriptor bug with code object v3
Change-Id: I9306b2baf36d338e36c5ab1226f74373a61a5ae0


[ROCm/hip commit: dcf70ff9a2]
2019-10-03 10:56:35 -04:00
satyanveshd bfb64c43a4 Reimplement hipMemGetInfo (#1447)
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.


[ROCm/hip commit: 3d661e4706]
2019-10-01 12:40:36 +05:30
Jeff Daily dcd73a1a87 hipModuleUnload should remove global variables from memtracker (#1464)
[ROCm/hip commit: 56f67e5e36]
2019-09-30 10:41:20 +05:30
Sarbojit2019 7f7a5a3712 [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/hip commit: 0fa42af08c]
2019-09-26 13:53:33 +05:30
satyanveshd fe1fae3ec2 Fix checks in hipMemcpy[D/H]to[D/H]() (#1397)
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/hip commit: cfbd0e77fe]
2019-09-16 08:32:38 +00:00
ansurya b5549f4397 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/hip commit: ceb734b917]
2019-09-16 08:31:30 +00:00
Aryan Salmanpour 9e9a505b39 [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368)
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting


[ROCm/hip commit: bac52d3729]
2019-09-16 08:31:17 +00:00
Rahul Garg 60adfab243 Fix typo and colon in comment
[ROCm/hip commit: f0a1f95864]
2019-09-13 03:09:01 +05:30
Rahul Garg e79f2d0ff8 [HACK] Temporary fix for hipFree for hipManagedMalloc
[ROCm/hip commit: fe47b2185c]
2019-09-13 02:10:21 +05:30
Jeff Daily 191482e1e4 fix bug where HIP_DB=1 seg faults at startup (#1388)
[ROCm/hip commit: 8384f487ad]
2019-09-05 10:04:19 +00:00
Rahul Garg 83d9c2769b Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 7dca0455e9.

[ROCm/hip commit: 6545521d6c]
2019-09-03 05:13:46 +00:00
Sarbojit2019 73e5c52d0d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/hip commit: 0722704f35]
2019-08-29 01:02:59 +00:00
Sarbojit2019 74a3171c6b [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/hip commit: 5c4f78bac3]
2019-08-29 01:02:41 +00:00
Aryan Salmanpour 0fc745b3a6 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/hip commit: 5066700ace]
2019-08-23 09:19:35 +00:00
Rahul Garg 4aa011eec6 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++


[ROCm/hip commit: 71559200c0]
2019-08-23 09:19:18 +00:00
Jatin Chaudhary 7dca0455e9 Using HSA API for hipMemsetAsync (#1346)
[ROCm/hip commit: ac62d7a5c0]
2019-08-21 10:00:10 +00:00
Rahul Garg 74443e34ab Fix build issues seen with hip-clang path (#1331)
[ROCm/hip commit: 47b832bba7]
2019-08-16 02:13:45 +00:00
Rahul Garg a984acf245 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/hip commit: 2405621f62]
2019-08-16 02:13:16 +00:00
Rahul Garg 3c8f84a5c3 Fix undefined identifier issue for hipExtModuleLaunchKernel
[ROCm/hip commit: 3dd0e988b1]
2019-08-14 16:46:32 -04:00
Rahul Garg d42844182c Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/hip commit: 45b73e0961]
2019-08-09 11:50:37 +00:00
Siu Chi Chan 83269bea32 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/hip commit: 83af327ef2]
2019-08-08 08:33:04 +00:00
Rahul Garg d429ba57e1 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/hip commit: 6ce86f409d]
2019-08-08 08:27:41 +00:00
Alex Voicu 4509df8151 Fix hip_throw. (#1285)
* Fix hip_throw.

* Fix typo

* No, really fix typo


[ROCm/hip commit: fbbed603ff]
2019-08-05 09:52:22 +00:00
Jeff Daily 9b44993343 consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/hip commit: 1eb3dbf065]
2019-08-05 09:51:02 +00:00
Maneesh Gupta ba14b149d4 Merge pull request #1278 from gargrahul/fix_hipfuncGetAttribute_logstatus
Fix missing logstatus in hipFuncGetAttributes

[ROCm/hip commit: f52245d440]
2019-08-02 10:00:38 +00:00
wkwchau b663dbc5ce Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247)
[ROCm/hip commit: aaec4f73a6]
2019-08-02 10:00:25 +00:00
Rahul Garg 8b597565c4 Fix missing logstatus in hipFuncGetAttributes
[ROCm/hip commit: 474bf0effc]
2019-08-02 11:51:34 +05:30