Commit Graph

4961 Commits

Author SHA1 Message Date
Aryan Salmanpour 9ec79d899a Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247


[ROCm/hip commit: c6904623aa]
2020-10-13 11:14:41 -04:00
Lakhan singh Thakur 66aba3ea21 [dtest] Adding Test case for hipFuncSetSharedMemConfig() and hipFuncSetAttribute()
SWDEV-251504 - QA task for validation

Change-Id: I11ed98f648352cb32161c41290516c77231236bc


[ROCm/hip commit: 548ec20ffd]
2020-10-13 11:11:00 -04:00
Rupam Chetia 3e98b823d3 [dtest] hipModuleLoad and related API tests
APIs: hipModuleLoad, hipModuleLoadData and hipModuleLoadDataEx,
      hipModuleGetGlobal(), hipModuleGetFunction
Functional and negative tests
Repeated call to ModuleLoadXX/ModuleUnloadXX
Few tests are disabled now, will be enabled when functional

SWDEV-238517 for enhancing hip unit tests

Change-Id: I65c12027e32db80213468fdee1c5cc1aa3e60bfd


[ROCm/hip commit: 71ba35eb2c]
2020-10-13 11:10:11 -04:00
Julia Jiang 3a44adf0ed SWDEV-249487-remove two HCC related APIs
Change-Id: Icf90ece0808643e0c5f0cc00b6644d5171b553d8


[ROCm/hip commit: c2a3d19acb]
2020-10-13 11:08:37 -04:00
agodavar 0ed2d37bb4 SWDEV-255853: CUDA device P2P attributes
Change-Id: I7deffd04101b565f68a72a179f9faeaa22cab97d


[ROCm/hip commit: e0be2ca8dd]
2020-10-13 05:32:29 -04:00
agodavar 075976bc1a SWDEV-254909:Support for missing texture/array cuda driver types
Change-Id: I9c769f6335ec3e7feacaa8929719c666bff91934


[ROCm/hip commit: d96e810ccd]
2020-10-13 05:30:31 -04:00
Freddy Paul 4adc690374 HIP:Break dependency to rocm-dev package
Check for rocm_agent_enumerator instead of rocminfo or
.info/version.

Change-Id: I1718bd4f70b3e527ea3afe19c1a685ab7ed70808


[ROCm/hip commit: 863082c528]
2020-10-12 17:53:53 -04:00
agodavar 81b6ad7d35 SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ia19e6806a476d3c6ecd3e9a89c3ed72953a4900c


[ROCm/hip commit: dc1459cfb1]
2020-10-12 06:04:14 -04:00
Tao Sang 4a8a95a8e9 Revert "Make directed_test support static libs"
This reverts commit 37282c6132.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ib2d1084ea21461f70f96f95c6025a08f88288357


[ROCm/hip commit: 5b7533e49f]
2020-10-12 00:01:13 -04:00
Sameer Sahasrabuddhe 7f1648354b Do not inline the body of __assert_fail()
The device side assertion calls printf to write out a message. In the
device compiler, printf is expanded into a series of hostcalls that
transmit the printf payload to the host. This expansion increases the
length of the kernel, resulting in sub-optimal compilation. The
solution is to ensure that the assert() implementation is not inlined
into the kernel.

Change-Id: Ia3a075461a755cf007218f262b0863e1926c76aa


[ROCm/hip commit: c36c0bad22]
2020-10-10 01:03:04 -04:00
Yaxun (Sam) Liu 9aae6104f7 Disable wave64 support on GFX10 for HIP
Change-Id: Ie3d4fe91516167ea26ce704689b6b6f1951a7521


[ROCm/hip commit: dc20086cbb]
2020-10-09 17:02:56 -04:00
Tao Sang 37282c6132 Make directed_test support static libs
1.Make directed_test apps linked against static libs
of hip, rocclr, rocr, roct and amd_comgr.
2.Remove custom_target amdhip64_static_combiner.
3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
4.Simplify argument list parsing.
5.Fix hip_pch.o missing issue in samples' build.
6.Fix some original small bugs.

Change-Id: I30f5e65367613152ce86b80b13e1c9f2a28da803


[ROCm/hip commit: b41a769517]
2020-10-08 22:46:58 -04:00
Jason Tang 69b0429a5e Add hipStreamSynchronize to hipModuleLoadDataMultThreadOnMultGPU test
hipStreamDestroy() by definition doesn't guarantee waiting for all stream operations.

Change-Id: Ibfd21c48d71741ebcbcb9898c8b5ac235bdc570b


[ROCm/hip commit: 2299459ce0]
2020-10-08 11:06:39 -04:00
Payam 32d79cd4cc Cleaning lintian warning SWDEV-247996 Part1
Change-Id: Ie024912b65125c3e14ecc278ac12e07912df6354


[ROCm/hip commit: b444061f7e]
2020-10-08 05:44:58 -04:00
German Andryeyev 4577f0f1bb Use more managed memory interfaces
Add extra API calls for managed memory: hipMemAdvise, hipMemPrefetchAsync,
hipMemRangeGetAttribute

Change-Id: Ifb09744acdf7582d278453707373c89c30e3ed03


[ROCm/hip commit: 67c19cb10b]
2020-10-07 16:45:25 -04:00
sumanthtg b92a369a11 [dtest] Tests for atomicAdd/atomicAddnoRet
Positive and negative test cases for atomicAdd and
AtomicAddnoRet device functions

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id20ba2550d20f224004f105cdcd087002cb80e56


[ROCm/hip commit: 543dc8cea5]
2020-10-07 13:20:12 -04:00
sumanthtg 3a634bb965 [dtest] Additional tests for hipOccupancyMax APIs
Additional tests for following APIs
- hipOccupancyMaxActiveBlocksPerMultiprocessor
- hipOccupancyMaxPotentialBlockSize

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ib9441c1366f46a082e10eb1a572bc7d8ebe1ee37


[ROCm/hip commit: 2bee071530]
2020-10-07 13:19:06 -04:00
Sourabh Betigeri 6198eaf88e SWDEV-247768: Added new perf test - SampleRate
Change-Id: I3aee07dff3759a0ac56a1afb384168bb94394187


[ROCm/hip commit: 979c5d4d6f]
2020-10-06 12:46:13 -04:00
Sarbojit Sarkar d58970c94e [perf]hipMalloc perf optimization
Change-Id: I9cd1d29205cb0c9938d26bb8e336fc9fe8a262ed


[ROCm/hip commit: 718ac775f7]
2020-10-06 12:22:57 -04:00
Vladislav Sytchenko e428310a56 Change __HIP_ENABLE_PCH to be an option
Currently all the logic checks if __HIP_ENABLE_PCH is set, so setting it
to OFF will still enable PCH.

Switching __HIP_ENABLE_PCH to be a CMake option will enable correct
build behaviour.

Change-Id: I77a663589ffb5f2595c6ad3d144eb9466adcf250


[ROCm/hip commit: 3949675ab0]
2020-10-06 11:17:47 -04:00
kjayapra-amd 644e635e64 SWDEV-254363 - Checks to make sure kernel is launched on the same device as it was launched.
Change-Id: I2f273a70b1a5fc0e9fc9c6144eabd32466ff4e59


[ROCm/hip commit: c4505bede3]
2020-10-06 08:38:09 -04:00
Rahul Garg a3a8ca1359 Remove libhip_hcc references
These were added in commit 08ab76d58f.

Change-Id: I5815c90bb83ac74730f6bce114eb353f54b86670


[ROCm/hip commit: b673a56fcb]
2020-10-06 04:29:35 -04:00
Sarbojit Sarkar 0eebd71062 SWDEV:253548 : remove gfx-arch macros
Change-Id: I1ef0b4e080c15a9c6228f48ecd6a65b134d0a72d


[ROCm/hip commit: a2f9a2d469]
2020-10-06 01:15:58 -04:00
Yaxun (Sam) Liu 8811d4d1a8 Fix warpSize for gfx10
Change-Id: I8029ebeb91db1efa8e166ad349aaae6364e8069d


[ROCm/hip commit: c7ac5531d3]
2020-10-05 20:45:07 -04:00
Rahul Garg 11ee314c11 Bump version to 3.10
Change-Id: I7410996510fa24d2db0a4ecb2a2642e2e95058cf


[ROCm/hip commit: ee75be9cd4]
2020-10-05 20:26:38 -04:00
Vladislav Sytchenko e4caaa2a77 Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
This reverts commit 28b17d3dbd.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9


[ROCm/hip commit: ad2d55c144]
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko 28b17d3dbd Revert "Merge branch 'amd-master-next' into amd-npi-next"
This reverts commit 258d79bca7.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721


[ROCm/hip commit: 374ead1d19]
2020-10-05 13:02:39 -04:00
German Andryeyev 980b4302e3 Fix error codes in HMM interfaces
Change-Id: I16490c575f2840b1116a4135431a611cf812f3a4


[ROCm/hip commit: 23a9cb15eb]
2020-10-05 12:54:16 -04:00
Vladislav Sytchenko 258d79bca7 Merge branch 'amd-master-next' into amd-npi-next
Change-Id: I0587f67e28cec51c2ae753e986d2c7ce21db271e


[ROCm/hip commit: 73558e3363]
2020-10-05 09:51:06 -04:00
Jatin Chaudhary 51f811ac67 Use availableRegistersPerCU_ to populate number of registers
Change-Id: I58f2323bf454f910d22ab31f05aa3024a3d1106f


[ROCm/hip commit: a8ce1881bc]
2020-10-05 00:33:27 -04:00
mshivama 539a50b9de Fix bug reported in SWDEV-251619
Unit testing of CG threadRank api in multi-grid environment requires
some changes as grid id of particular device is not known apriori.

Change-Id: Ie7941a09337653f3ada5eedfb7c64a93a234498b


[ROCm/hip commit: f45f9e37dd]
2020-10-02 13:39:10 -04:00
Pruthvi Madugundu b786f545bf Update to the REGEX in hip-config.cmake
- Matching the output "hipcc --version" for Installed directory
  to get the llvm compiler path, wasnt done properly.
- Adding fallback for HIP_CLANG_ROOT on ROCM_PATH if defined in env
- Changed the mode of get_filename_component to DIRECTORY

Signed-off-by: Pruthvi Madugundu <pruthvi.madugundu@amd.com>
Change-Id: Ia38e234f34cabb5b419906c7094b327083292b0e


[ROCm/hip commit: ff3cbd1778]
2020-10-02 13:03:49 -04:00
Srinivasan Subramanian e23c2e2065 hipcc doesn't find libhsakmt without ldconf entries
Signed-off-by: Srinivasan Subramanian <srinivasan.subramanian@amd.com>
Change-Id: Iea6a43786f05c9e44dcf863f4f96a53f81384dbd


[ROCm/hip commit: 966ee44aae]
2020-10-02 12:55:00 -04:00
Aryan Salmanpour bc0b4f2f7e enable building cooperative directed tests on NV platform
Change-Id: I9a658b28010176d4f9401010b9c4b4be7ae86b92


[ROCm/hip commit: 3c0bff0878]
2020-10-02 00:59:40 -04:00
Cole Nelson 9157abcf47 CMakeLists.txt: Conformant package naming
Change-Id: I1c70559208606de8cc00909132cba38a2cc2ccd6
Signed-off-by: Cole Nelson <cole.nelson@amd.com>


[ROCm/hip commit: 318867a438]
2020-10-01 18:25:15 -04:00
Aryan Salmanpour 40d44e2c8d [dtest] move all the cooperative related tests into one location
Change-Id: I9b44027d795ebfbf42f78af8e69d26ac8109692a


[ROCm/hip commit: e1cb711e66]
2020-10-01 16:01:46 -04:00
Aryan Salmanpour 42870c3a84 rename abort in nvcc path
[background] There is currently a compilation issue when both hip/hip_runtime.h and hip/hip_cooperative_groups.h included
in a file and hipcc used to compile it on NV platform. The issue is that an abort is defined in hip/nvcc_detail/hip_runtime.h
and it is also defined in the CUDA cooperative groups header (/cuda/include/cooperative_groups/details/helpers.h).
this is problematic and leads to a compilation issue in hipcc on NV platform.

Change-Id: I2ab6982ac4103822a1a4a0ced942cd604d6c19c1


[ROCm/hip commit: 3c72e7beea]
2020-10-01 14:28:51 -04:00
Aryan Salmanpour 4a73a44f95 fix a bug for calculating the prev_sum of MGSyncInfo struct used in multi-gpu cooperative launch
SWDEV-251619

Change-Id: I6566bfc9384bb4677562085991a7a01d3cea3935


[ROCm/hip commit: 677a854f4f]
2020-10-01 14:05:22 -04:00
mshivama 75fda6da3d Add missing definitions for class static members
The static members __HIP_Coordinates::x, ::y and ::z must be defined
outside the class. Otherwise, linker throws `undefined reference error`
when these definitions are needed in the HIP application.

Change-Id: Iabc09744b478c22e4b13cf9824877ec9cfdd4f7a


[ROCm/hip commit: b8640f1f0d]
2020-09-30 03:38:24 -04:00
Sarbojit Sarkar fcba52f6f5 SWDEV-253247: add ulong and ulonglong version of__shfl*
Change-Id: I40ab6cfa12175f334e8392b71f567054d8256e2a


[ROCm/hip commit: bf20337fc1]
2020-09-30 01:58:22 -04:00
mshivama bd685759d2 Layout the cooperative group related headers to target Nvidia
Change-Id: I530ffc72d6fae1e273b5322d508629221e11ea6f


[ROCm/hip commit: 4b6d92798f]
2020-09-29 21:32:24 -04:00
Sarbojit Sarkar de746bc845 SWDEV-253654 : Added invalid parameter checks
Change-Id: I8a2ae1ee6898f111aac1c68663a653cca410daec


[ROCm/hip commit: 464e27829c]
2020-09-29 13:20:27 -04:00
Julia Jiang 50910964ea SWDEV-247518-fix HPC multi gpu test performance drop
Change-Id: I2f07d9ba183cf88b3845d8d61607a8a0462d015f


[ROCm/hip commit: 9f1a177dc7]
2020-09-29 12:04:40 -04:00
Sarbojit Sarkar 52a06d5016 SWDEV-252337: Fix for V100 compilation issue
Change-Id: Ib57ff3ac28f0a581f395f32181974e64eca6d858


[ROCm/hip commit: 0be1f7843a]
2020-09-25 21:55:22 -04:00
Julia Jiang c36e95852f SWDEV-253250-update instruction for hip sample
Change-Id: Iebc2887a3687e6c565999f4faf1cd4cf893e24cd


[ROCm/hip commit: ad8a61545a]
2020-09-25 13:51:19 -04:00
Aryan Salmanpour f28066dd40 fix a pagefault when wrong argument (extent) passed in hipMemset3D API
Change-Id: I779fc14ccd7c942d1ae0a938ebfd3c2e728ff761


[ROCm/hip commit: e46dc7b96d]
2020-09-25 10:57:37 -04:00
kjayapra-amd 84b764eacc SWDEV-241896 - Remove extern support in ROCclr/HIP since compiler added Texture reference support.
Change-Id: I1b0a7377b803b4e2b94ffef6ffd91e376fdb2b2f


[ROCm/hip commit: dcaec76d41]
2020-09-24 14:28:16 -04:00
Rahul Garg 4bb97d3f6a Return hipMemoryTypeHost as memory type for hipHostRegistered pointer
Fixes SWDEV-253741
Change-Id: I42c2c9df00862157314d5767b6f175a0d2f28b47


[ROCm/hip commit: a3e5e6360f]
2020-09-24 12:27:32 -04:00
agodavar 53fa367039 SWDEV-249870 - Short-Term solution for Pre-Compiled Headers for Online Compilation
Change-Id: Iec989787e546ff2eb68c4b146dc540655698b569


[ROCm/hip commit: 288fbe5af3]
2020-09-24 12:18:06 -04:00
Lakhan singh Thakur 0b3c2c3c27 [dtest] Additional tests for hipMallocManaged() api
5 scenarios were added for hipMallocManaged including negative
test.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibba53fb64502d6df798e4e63100dcb8c5f94553f


[ROCm/hip commit: 8f4cc3017f]
2020-09-24 10:05:21 -04:00