Commit Graph

264 Commits

Author SHA1 Message Date
Dittakavi, Satyanvesh 2c173c6da4 SWDEV-512756 - SWDEV-510954 - Add appropriate checks during active stream capture (#375)
- hipStreamAddCallback is not permitted during stream capture for all modes
- hipModuleUnload is permitted only for relaxed mode during stream capture

Change-Id: I79ca5d2f6b61bd2e169fee7c13da4cd46e472a10
2025-05-22 13:24:49 +05:30
Brzak, Branislav 88f15877f6 SWDEV-508964 - Match hip launch kernel retuns with cuda (#357) 2025-05-21 21:59:11 +05:30
Jayaprakash, Karthik fa55557f46 SWDEV-493805 - Cleaning up launch parameters arguments. (#241) 2025-05-06 15:06:13 -04:00
Godavarthy Surya, Anusha fb92683d86 SWDEV-469422 - Avoid using of hipStream_t in internal methods (#69)
Change-Id: Ifd5362f371c846a88241927383cb95cf046548ef
2025-04-28 15:09:11 +05:30
GunaShekar, Ajay 64d6f5714a SWDEV-523281 - CHANGELOG.md and negative test return values : hipLaunchKernelEx, hipLaunchKernelExC, hipDrvLaunchKernelEx (#155) 2025-04-22 21:47:37 +05:30
Arandjelovic, Marko 5fe080fd67 SWDEV-523137 - function ptrs should match across all devices (#171) 2025-04-16 10:35:48 +02:00
Patel, Jaydeepkumar 8531cd3bbe SWDEV-508973 - If total # of threads/block is more than HW capacity, it's invalid config issue and should return invalid config error. (#25) 2025-04-10 15:16:16 +05:30
Betigeri, Sourabh 8c6b90996e SWDEV-523281 - [clr] Implementation of hipLaunchKernelExC and hipDrvLaunchKernelEx API with support for cooperative launch (#92) 2025-04-03 20:10:05 +09:00
Saleel Kudchadker e03e4f3b5d SWDEV-502365 - Track last used command
- This change tries to save extra synchronization packets we may insert
  as we didnt track the completion signals for every command. We track
the current enqueued command until it exits the enqueue stage. We also
record the exit scope to know if we flushed the caches
- Handle correct release scopes and store completion signal as HW events
- Use a new finishCommand implementation to only wait for the command
  passed as the argument

Change-Id: Ie4350c5dd24f5d48dfa6ccbabd892f0544caadcc
2025-03-04 16:05:02 -05:00
Rahul Manocha 5930f047bb SWDEV-489106 - Linker API addition to runtime
1) Add Linker APIs to runtime to support SPIRV linking
2) Migrate Internal implementations to runtime and share with rtc
3) Add Support to bundled and unbundled SPIRV Code object linking.

Change-Id: Ic1fd4431f842a208a2468e8aec54a65b5fa6b0e3
2025-02-22 13:39:23 -05:00
Ioannis Assiouras 1cdfbfd270 SWDEV-514686 - Fixed hipEventSynchronize/hipStreamWaitEvent for IPC events
Resolved an issue where hipEventSynchronize and hipStreamWaitEvent APIs
did not function correctly for events created with the hipEventInterprocess flag.
The bug caused the event to be incorrectly marked as "recorded,"
leading to these APIs failing to wait for the event as expected.

Change-Id: Ic9fdfaab2393beb93d6e0b83661545e902a63499
2025-02-11 18:43:06 -05:00
Vladana Stojiljkovic 30cb2d0e67 SWDEV-498061 - Add capture support for hipModuleLaunchCooperativeKernel
Change-Id: I5ed188e046c680c2785b3952391f59ed1d0c21b8
2025-01-16 10:54:30 -05:00
Marko Arandjelovic c46f843b99 SWDEV-504084 - Make hipModuleGetFunction use the device the module is loaded on
If a module is loaded on one device, hipModuleGetFunction and other similar APIs should be able to run successfully from another device.

Change-Id: I96084cbd6c6dcf2a81019779a6ab1842ef2f35d1
2025-01-16 10:16:42 -05:00
Vladana Stojiljkovic b75b0d9a53 SWDEV-494612- Add capture support for hipLaunchCooperativeKernel
Change-Id: I6b3c6af55c60cffd43ce6f47b75998f750b75703
2024-11-29 08:17:41 -05:00
Ioannis Assiouras 1a710dabcf SWDEV-496003 - Add support for dynamic functions in hipFuncSetAttribute
Modified hipFuncSetAttribute to handle pointers to dynamic functions
returned by hipModuleGetFunction.

Change-Id: I54b98f9d31a79630dd7edcd363fad81f1d89219b
2024-11-19 04:50:15 -05:00
Sourabh Betigeri 64e1b15551 SWDEV-450052 - Return if numDevices is more than device count on the platform
Change-Id: I538106d1b02084df9cd06b41427629207312e76f
2024-10-24 17:07:11 -04:00
Saleel Kudchadker 0f2342bc13 SWDEV-491375 - Optimize multithreaded dispatches
- Fix typo

Change-Id: If4c68455dcfa03fee18cb4720e8b5b438642703c
2024-10-17 17:02:23 -04:00
Rahul Manocha 0d20383ef9 [SWDEV-467733] - Add Param checking for SetCacheConfig APIs
Change-Id: I9e777fa0fae6791ebab539e49346e6956a6ff196
2024-09-27 11:32:58 -04:00
Ajay c9955a1cea SWDEV-465215 - hipFuncSetAttribute hipFuncGetAttributes fixes
Change-Id: I2151e4470d63918ff6b809a8fdeaae5bea5cc899
2024-09-13 14:05:25 -04:00
Jaydeep Patel b0047d690a SWDEV-465220 - Validate stream on which Kernel is planned to be launched.
Change-Id: I34c679bd888c275584c11ad3e8346d4d542976f9
2024-08-06 00:31:22 -04:00
Marko Arandjelovic be5f097e8e SWDEV-465204 - Fix hipModuleLaunchKernel data validation
Change-Id: I129f265a5eb79d0a13da4f12e78e06ba307b17ee
2024-08-01 05:09:23 -04:00
kjayapra-amd 9c03f85f46 SWDEV-460948 - Remove dflock, since kernel arguments are part of command now.
Change-Id: I6b5a229307b41bd24ffa0bc172c64ad1154df474
2024-07-22 16:02:01 -04:00
Julia Jiang dd30e0e893 SWDEV-472710 - Adding gitattributes and remove trailing spaces
Change-Id: Ic8ad2071745f0ffe6a2e120bfebb6d90bf270f87
2024-07-15 12:39:56 -04:00
kjayapra-amd 892071aeb2 SWDEV-460948 - Changes to alloc, set, capture under single function.
Change-Id: I7b2d40e99e812b97c53535c5e63c41ad64a8f543
2024-06-06 16:57:53 -04:00
Ajay 6ec5074d74 SWDEV-439581 - hip event flags clean up
Change-Id: I2197762d912da41a8b53b32b3446f0a958c988a6
2024-05-28 06:31:10 +00:00
Tao Sang a1350fe8c1 Revert "SWDEV-433371 - use comgr to unbundle code objects"
This reverts commit e53df57ffe.

Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object.   Will create a new patch to use old path for uncompressed , new unbundling api for compressed . 

Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52
2024-05-28 06:31:10 +00:00
taosang2 e53df57ffe SWDEV-433371 - use comgr to unbundle code objects
1.Make runtime use comgr to unbundle code objects
2.Support compressed/uncompressed modes
3.Remove HIP_USE_RUNTIME_UNBUNDLER and
  HIPRTC_USE_RUNTIME_UNBUNDLER to simplify logics
4.Add comgr wrapper for
  amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: Ic41b1ad1b64cca1e31986437983a5146d52a7329
2024-05-01 16:09:12 -04:00
Rahul Manocha 59051ed3af [SWDEV-442583] - Fix hipLaunchCooperativeKernel API error codes
Change-Id: Id3cb4b58b9efd3aceec4377d4d1d3a053c50333e
2024-05-01 11:36:59 -04:00
Jaydeep Patel 09328f45b3 SWDEV-446992 - Request can be for bytes OR dptr OR both.
Change-Id: Ib479c744b90125b74d99cbf18b7f4b8cf765bf1c
2024-03-26 11:10:24 -04:00
Satyanvesh Dittakavi 684fd60c8f SWDEV-444021 - Implement hipGetFuncBySymbol
Change-Id: I7ef13d02c5b5c6ce2386ccb92b5602d005b35988
2024-03-14 02:56:30 -04:00
Jaydeep Patel d1b75659f2 SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667

Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664
2024-02-14 00:05:41 -05:00
Anusha GodavarthySurya a1b2cbe44e SWDEV-439637 - Updated to compile with clang compiler
Change-Id: Ib0a8e1cc007f083fb1d1f4363cf89ba76ad3c4f2
2024-02-06 23:57:13 -05:00
Anusha GodavarthySurya 9b6cf0f74b SWDEV-351966 - Rename hip::__hipExtModuleLaunchKernel to hip::hipExtModuleLaunchKernel
Change-Id: Ie922760f37bf0c9abf2653d36e32705a12ab5a90
2023-12-20 22:50:01 -05:00
Saleel Kudchadker 058b2702db SWDEV-301667 - Logging refactor
- Remove newline from logging as log function internally inserts a new
line

Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8
2023-12-07 12:12:57 -05:00
Anusha GodavarthySurya 5e21f0c6bd SWDEV-351966 - Dispatch table for hip runtime
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325
2023-11-22 01:11:19 -05:00
sdashmiz 2d83abaca6 SWDEV-389530 - [ABI Break]Match error with cuda
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9
2023-10-16 07:31:34 -04:00
Ioannis Assiouras bf31109241 SWDEV-425129 - Revert "SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute"
This reverts commit c469f18e91.

Change-Id: I02d6e77f0874fc37f22de267435917edd4fdede3
2023-10-03 11:32:19 +01:00
Ioannis Assiouras c469f18e91 SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute
Change-Id: I9b9f7979e9b8dd422d9064c17c79a25bf7248d30
2023-10-01 06:52:12 -04:00
pghafari 96f41fad07 SWDEV-369567 - [ABI Break] updating gridY and Z max dimension check
Change-Id: If515fda4938d3c5f455a02b4a65adaad76dc0aed
2023-09-22 04:52:27 -04:00
Ioannis Assiouras fe2d747bcc SWDEV-401489 - [ABI Break] Removed hipModuleLaunchKernelExt
Change-Id: I0b31d9db755f8a89ead203dbd238a93c18b76855
2023-09-21 23:50:16 -04:00
Ioannis Assiouras 315082e554 SWDEV-419996 - Allow both kernelParams and extra arguments to be set to null
When kernel function expects no parameters no error should be returned
if both kernelParams and extra arguments are set to null.

Change-Id: I5941bcc400b6fb380e623bdae0233ae3e4f73815
2023-09-07 12:57:46 -04:00
Maneesh Gupta 76a4bd1d7f Revert "SWDEV-389530 - [ABI Break]Match error with cuda"
This reverts commit c7d8557eee.

Change-Id: I07aac68c76b3bc42b595330fdbbb04646b35a814
2023-07-31 21:41:54 -04:00
sdashmiz c7d8557eee SWDEV-389530 - [ABI Break]Match error with cuda
- match error for invalid params

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2faf1191f665d8bd06d6ba315f440e87b1a5b8ab
2023-07-26 20:32:41 -04:00
pghafari 9e08ecdd16 SWDEV-406821 - use int32 for grid y,z till rocm 6
Change-Id: If9eee4dd5553cc81e283cb2211cc69884808d5c1
2023-06-22 09:42:00 -04:00
pghafari fb82b292c2 SWDEV-399734, SWDEV-399733 - update maxGridDim for y and z
Change-Id: Id5b1dd2491798dd20a0672362f445ab4de164f6d
2023-05-17 19:03:04 -04:00
pghafari 31b362bf6e SWDEV-369567 - dimension check update
Change-Id: I31deb5070d4852db7dd6d37f9a514965f387698e
2023-05-02 08:04:04 -04:00
German Andryeyev e82eecf33e SWDEV-231145 - Add a validation for uniform launch
Change-Id: I68d61690c50060d9dcca117b248dddf69204a23f
2023-04-18 12:56:09 -04:00
German Andryeyev 73698479a9 SWDEV-382359 - Workaround a non-uniform launch in MIOpen
Change-Id: I0abff25fb20143225739e771c4d3bae5c2a054b9
2023-04-18 11:36:10 -04:00
Ioannis Assiouras e6520ddf8a SWDEV-388278 - Fix return HIP_RETURN(x)
Change-Id: I940ee3660a2427eade8690a9318966fb04a1fbe8
2023-03-13 13:32:55 +00:00
Saleel Kudchadker 7fc5ae2226 SWDEV-364604 - Add support for hipEventDisableSystemFence
Change-Id: I1a6451c873fb22729ac61e4e80f8531251e990f0
2023-02-21 23:11:40 -05:00