Commit Graph

68442 Commits

Author SHA1 Message Date
Belton-Schure, Aidan 88c1717658 SWDEV-515426 - Remove HIP_USE_RUNTIME_UNBUNDLER (#205)
* remove HIP_USE_RUNTIME_UNBUNDLER
* clang-format
* Generic to use comgr
* Remove HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION flag
* Removes runtime unbundling unused and debug Code
* Removes stale functions

[ROCm/clr commit: 81238db679]
2025-07-08 21:45:31 +05:30
Belton-Schure, Aidan 81238db679 SWDEV-515426 - Remove HIP_USE_RUNTIME_UNBUNDLER (#205)
* remove HIP_USE_RUNTIME_UNBUNDLER
* clang-format
* Generic to use comgr
* Remove HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION flag
* Removes runtime unbundling unused and debug Code
* Removes stale functions
2025-07-08 21:45:31 +05:30
xuchen-amd bac7fde4f4 Add tui cmake install. (#794)
[ROCm/rocprofiler-compute commit: 60a50e681b]
2025-07-08 11:18:26 -04:00
xuchen-amd 60a50e681b Add tui cmake install. (#794) 2025-07-08 11:18:26 -04:00
Kian Cossettini ec683aefa7 Added compatibility matrix for docker-build script (#268)
- matrix -m argument for build-docker.sh that lists compatible OS + ROCm combinations.
- ${DISTRO} is now case-insensitive.
- Added note to README.md to mention this flag.
- Removed --build-arg AMDGPU_RPM=${ROCM_RPM}, which is no longer used

[ROCm/rocprofiler-systems commit: 67bc147780]
2025-07-08 11:05:14 -04:00
Kian Cossettini 67bc147780 Added compatibility matrix for docker-build script (#268)
- matrix -m argument for build-docker.sh that lists compatible OS + ROCm combinations.
- ${DISTRO} is now case-insensitive.
- Added note to README.md to mention this flag.
- Removed --build-arg AMDGPU_RPM=${ROCM_RPM}, which is no longer used
2025-07-08 11:05:14 -04:00
Sang, Tao fb408b70d1 SWDEV-508776 - support VGPRs validation (#77)
Add hipDeviceAttributeMaxAvailableVgprsPerThread attribute

[ROCm/hip commit: 3b6b7642a7]
2025-07-08 10:03:57 -04:00
Sang, Tao 3b6b7642a7 SWDEV-508776 - support VGPRs validation (#77)
Add hipDeviceAttributeMaxAvailableVgprsPerThread attribute
2025-07-08 10:03:57 -04:00
Fei Zheng 09ec955554 PC Sampling: fix potential_end_offset (#792)
* fix potential_end_offset

* format code: unrelated

[ROCm/rocprofiler-compute commit: 1b7445faa4]
2025-07-08 08:52:01 -04:00
Fei Zheng 1b7445faa4 PC Sampling: fix potential_end_offset (#792)
* fix potential_end_offset

* format code: unrelated
2025-07-08 08:52:01 -04:00
Fei Zheng c867eaa9cd format with isort (#793)
[ROCm/rocprofiler-compute commit: 239e6550f4]
2025-07-08 08:51:20 -04:00
Fei Zheng 239e6550f4 format with isort (#793) 2025-07-08 08:51:20 -04:00
fxmarty-amd a91e3f74f3 fix normalization (#789)
[ROCm/rocprofiler-compute commit: c58ee9e73b]
2025-07-08 08:50:41 -04:00
fxmarty-amd c58ee9e73b fix normalization (#789) 2025-07-08 08:50:41 -04:00
Patel, Jaydeepkumar 068f506131 SWDEV-535070 - In windows 2 separate commands may not go back to back and hence actual time taken should be always more than expected but not necessary to be close. (#219)
[ROCm/hip-tests commit: f94fe3c26c]
2025-07-08 15:55:49 +05:30
Patel, Jaydeepkumar f94fe3c26c SWDEV-535070 - In windows 2 separate commands may not go back to back and hence actual time taken should be always more than expected but not necessary to be close. (#219) 2025-07-08 15:55:49 +05:30
Gollamandala, Srinivasarao f05c8ddb2b SWDEV-532640-[catch2][dtest]-Prefetch all arguments and keep 0 hidden args if possible-PerfTest (#242)
* SWDEV-532640-[catch2][dtest]-Prefetch all arguments and keep 0 hidden args if possible-PerfTest

* SWDEV-532640-Addressed review comment

* SWDEV-532640-Fixed Neg clock time issue

* SWDEV-532640-Fixed Neg clock time issue

* SWDEV-532640-Addressed clang format issue

* SWDEV-532640-Fixed Clang Format issues

[ROCm/hip-tests commit: 2060125dfd]
2025-07-08 15:24:52 +05:30
Gollamandala, Srinivasarao 2060125dfd SWDEV-532640-[catch2][dtest]-Prefetch all arguments and keep 0 hidden args if possible-PerfTest (#242)
* SWDEV-532640-[catch2][dtest]-Prefetch all arguments and keep 0 hidden args if possible-PerfTest

* SWDEV-532640-Addressed review comment

* SWDEV-532640-Fixed Neg clock time issue

* SWDEV-532640-Fixed Neg clock time issue

* SWDEV-532640-Addressed clang format issue

* SWDEV-532640-Fixed Clang Format issues
2025-07-08 15:24:52 +05:30
Robin Voetter 2d5e4bd3fe fix typo in hipBatchMemOpParamsTocudaBatchMemOpParams 2025-07-08 11:10:45 +02:00
Manocha, Rahul 8e8dc41cf0 SWDEV-532420 - Fix kokkos P2P copy failure with vmheap (#426)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>

[ROCm/clr commit: 22b1ca4d8c]
2025-07-07 17:27:13 -07:00
Manocha, Rahul 22b1ca4d8c SWDEV-532420 - Fix kokkos P2P copy failure with vmheap (#426)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-07-07 17:27:13 -07:00
Pryor, Adam ca9d8c4bae Adam/bill cleanup (#209)
Co-authored-by: Bill(Shuzhou) Liu <shuzhou.liu@amd.com>
2025-07-07 15:41:22 -05:00
Pryor, Adam 07346922f5 Adam/bill cleanup (#209)
Co-authored-by: Bill(Shuzhou) Liu <shuzhou.liu@amd.com>


[ROCm/rdc commit: ca9d8c4bae]
2025-07-07 15:41:22 -05:00
Castillo, Juan 34f465bfc5 [SWDEV-531904] Removed Handle Exceptions function (#531)
Removed:
- handle_exceptions() Exposes, silences, and logs AMDSMI exceptions to users returns success/failure

Signed-off-by: Juan Castillo <juan.castillo@amd.com>
2025-07-07 13:26:26 -05:00
Castillo, Juan c9d14c1c93 [SWDEV-531904] Removed Handle Exceptions function (#531)
Removed:
- handle_exceptions() Exposes, silences, and logs AMDSMI exceptions to users returns success/failure

Signed-off-by: Juan Castillo <juan.castillo@amd.com>

[ROCm/amdsmi commit: 34f465bfc5]
2025-07-07 13:26:26 -05:00
Sajina PK 329183b112 Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity (#272)
* Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity

Modify ROCPROFSYS_THROW to only include backtraces when:
  debug mode is enabled, OR
  verbose level is >= 2, OR
  running in CI environment

* Fix formatting errors

[ROCm/rocprofiler-systems commit: b0ff07b4fe]
2025-07-07 14:14:02 -04:00
Sajina PK b0ff07b4fe Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity (#272)
* Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity

Modify ROCPROFSYS_THROW to only include backtraces when:
  debug mode is enabled, OR
  verbose level is >= 2, OR
  running in CI environment

* Fix formatting errors
2025-07-07 14:14:02 -04:00
Kanangot Balakrishnan, Bindhiya ce230efaaa [SWDEV-537852] Update process name help text (#517)
* [SWDEV-537852] Update process name help text

Currently process name displays N/A if that need elevated
permissions. Updated the default amd-smi, process and monitor
commands help texts to display elevated permission requirement.

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
2025-07-07 11:26:10 -05:00
Kanangot Balakrishnan, Bindhiya a59cd4c25e [SWDEV-537852] Update process name help text (#517)
* [SWDEV-537852] Update process name help text

Currently process name displays N/A if that need elevated
permissions. Updated the default amd-smi, process and monitor
commands help texts to display elevated permission requirement.

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: ce230efaaa]
2025-07-07 11:26:10 -05:00
Poag, Charis 88473b7fd0 [SWDEV-533305] Remove partition info from amd-smi static (-p/--partition still available) + CLI API call cleanup (#529)
Updates:
- Separate extra APIs calls from amd-smi CLI to target specific CLI commands that need them.
- Remove extra current_compute_partition SYSFS calls from amd-smi static.
- Remove the partition information from the default `amd-smi static` CLI command.
- Users must now use the `-p` argument to view partition information with `amd-smi static`.
- The help text for the `partition` argument has been updated to reflect this change.
- The partition information can still be accessed using the `amd-smi partition -c -m` or `sudo amd-smi partition -a` commands.

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-07-07 11:21:46 -05:00
Poag, Charis 92f926b43b [SWDEV-533305] Remove partition info from amd-smi static (-p/--partition still available) + CLI API call cleanup (#529)
Updates:
- Separate extra APIs calls from amd-smi CLI to target specific CLI commands that need them.
- Remove extra current_compute_partition SYSFS calls from amd-smi static.
- Remove the partition information from the default `amd-smi static` CLI command.
- Users must now use the `-p` argument to view partition information with `amd-smi static`.
- The help text for the `partition` argument has been updated to reflect this change.
- The partition information can still be accessed using the `amd-smi partition -c -m` or `sudo amd-smi partition -a` commands.

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>

[ROCm/amdsmi commit: 88473b7fd0]
2025-07-07 11:21:46 -05:00
Park, Peter 8039ab9449 Fix links in docs (#532)
* fix links in amdsmi_cli/README.md
* fix xrefs to install docs
* rm rocm-smi examples and add cli tutorial
* rm disclaimer and add amd smi contributing guidelines to index

Signed-off-by: Peter Park <Peter.Park@amd.com>
2025-07-07 11:18:40 -05:00
Park, Peter aecda316c4 Fix links in docs (#532)
* fix links in amdsmi_cli/README.md
* fix xrefs to install docs
* rm rocm-smi examples and add cli tutorial
* rm disclaimer and add amd smi contributing guidelines to index

Signed-off-by: Peter Park <Peter.Park@amd.com>

[ROCm/amdsmi commit: 8039ab9449]
2025-07-07 11:18:40 -05:00
Narlo, Joseph 2cf6272b53 [SWDEV-541675] Remove Unnecessary API from amdsmi.h (#530)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
2025-07-07 11:14:27 -05:00
Narlo, Joseph 540ecd41bd [SWDEV-541675] Remove Unnecessary API from amdsmi.h (#530)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>

[ROCm/amdsmi commit: 2cf6272b53]
2025-07-07 11:14:27 -05:00
Saeed, Oosman 5b95d227bc [SWDEV-538308] CPER CLI 20 limit bug (#499)
The bug was reproduced like this.

In terminal #1, run command:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

In terminal #2, inject errors:
while true; do sudo amdgpuras -b 7 -s 1 -m 6 -t 2; sleep 2; done

The terminal #1 starts dumping cper entry information that it captures. After 20 entries have been captured, open terminal #3 and run same command as terminal #1:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

From terminal #3, there will be no output, even when terminal #1 continues capturing and printing information.

The fix:

Since we already have more than 20 CPER entries available in the GPU buffer, when we run the command from terminal #3 to start capturing from the beginning and pass 20 buffers to copy entries to, the C++ API returns a code saying there is more data available.

The Python CLI should not treat this as an error, but should continue to print what the API returned.

---------

Signed-off-by: Oosman Saeed <oossaeed@amd.com>
2025-07-07 11:11:13 -05:00
Saeed, Oosman 1c60502d5f [SWDEV-538308] CPER CLI 20 limit bug (#499)
The bug was reproduced like this.

In terminal #1, run command:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

In terminal #2, inject errors:
while true; do sudo amdgpuras -b 7 -s 1 -m 6 -t 2; sleep 2; done

The terminal #1 starts dumping cper entry information that it captures. After 20 entries have been captured, open terminal #3 and run same command as terminal #1:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

From terminal #3, there will be no output, even when terminal #1 continues capturing and printing information.

The fix:

Since we already have more than 20 CPER entries available in the GPU buffer, when we run the command from terminal #3 to start capturing from the beginning and pass 20 buffers to copy entries to, the C++ API returns a code saying there is more data available.

The Python CLI should not treat this as an error, but should continue to print what the API returned.

---------

Signed-off-by: Oosman Saeed <oossaeed@amd.com>

[ROCm/amdsmi commit: 5b95d227bc]
2025-07-07 11:11:13 -05:00
Bhardwaj, Gopesh 99a7fe5ff0 Ignoring aligned attribute warning (#70)
ignoring aligned attribute warning

[ROCm/roctracer commit: dd745ed9c7]
2025-07-07 09:34:39 -05:00
Bhardwaj, Gopesh dd745ed9c7 Ignoring aligned attribute warning (#70)
ignoring aligned attribute warning
2025-07-07 09:34:39 -05:00
Swargam, Rambabu eb2710785e SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure (#247)
* SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure

* SWDEV-532647 - Restricted to Linux, removed comment for mismatch error code

* SWDEV-532647 - Disabled tests for AMD due to hang issue

* SWDEV-532647 - Fixed clang format issues

[ROCm/hip-tests commit: 9741b347e5]
2025-07-07 17:49:00 +05:30
Swargam, Rambabu 9741b347e5 SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure (#247)
* SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure

* SWDEV-532647 - Restricted to Linux, removed comment for mismatch error code

* SWDEV-532647 - Disabled tests for AMD due to hang issue

* SWDEV-532647 - Fixed clang format issues
2025-07-07 17:49:00 +05:30
Venkatesh, Anavena 882d176c50 SWDEV-526521 : Inter GPU copy performance improvements (#240)
* SWDEV-532641 Inter GPU copy performance improvements

* SWDEV-532641 changed source data pointer type to vector type

[ROCm/hip-tests commit: feaa82ac46]
2025-07-07 17:45:20 +05:30
Venkatesh, Anavena feaa82ac46 SWDEV-526521 : Inter GPU copy performance improvements (#240)
* SWDEV-532641 Inter GPU copy performance improvements

* SWDEV-532641 changed source data pointer type to vector type
2025-07-07 17:45:20 +05:30
Swargam, Rambabu d9642dbbc2 SWDEV-532114 - [catch2][dtest] Test cases for hipMemGetHandleForAddessRange (#221)
[ROCm/hip-tests commit: c217bb601c]
2025-07-07 17:43:22 +05:30
Swargam, Rambabu c217bb601c SWDEV-532114 - [catch2][dtest] Test cases for hipMemGetHandleForAddessRange (#221) 2025-07-07 17:43:22 +05:30
Swargam, Rambabu b35d4e70ad SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's (#157)
* SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's

* Modified Cmake file

[ROCm/hip-tests commit: ea366c7aa5]
2025-07-07 17:42:45 +05:30
Swargam, Rambabu ea366c7aa5 SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's (#157)
* SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's

* Modified Cmake file
2025-07-07 17:42:45 +05:30
Apurv Mishra 3115384874 kfdtest: Temporarily blacklist KFDEvictTest suite
blacklist the KFDEvictTest suite until the defects
SWDEV 535386 and 537002, where these test cases fail
inconsistently, are fixed

Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
2025-07-04 11:47:20 -04:00
Apurv Mishra 6c89d61cef kfdtest: Temporarily blacklist KFDEvictTest suite
blacklist the KFDEvictTest suite until the defects
SWDEV 535386 and 537002, where these test cases fail
inconsistently, are fixed

Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>


[ROCm/ROCR-Runtime commit: 3115384874]
2025-07-04 11:47:20 -04:00
Roy, Rakesh 05b674651c Fix find_if build error for RHEL10 (#499)
overriding Jonathan's final approval ( as it is a long weekend in US/NA)
adding algorithm header to recognize stdlib's find_if looks fine

[ROCm/rocprofiler-sdk commit: 30e239d1b7]
2025-07-04 09:20:23 -04:00