AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,218 Commits 3 Branches 0 Tags
9f1cc590d8106f5d9d2a3fd0400a29dd1fd226cd
Commit Graph

13218 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matt Arsenault 1f0c398a6f Use find_package to find ROCclr 
Maintain compatability with the old finding for now for the
convenience of commit order.

Change-Id: I99b236cbb3d61b00650e3da7fe5931d4c4b3fec6
 2020-05-12 09:28:19 -04:00
kjayapra-amd aaf3002567 SWDEV-227602 - Fixing hipFuncGetAttribute parameters 
Change-Id: I46bd079372f453cabfaa2c709e2b30c69400dd33
 2020-05-12 09:15:43 -04:00
kjayapra-amd c97ef9f84a SWDEV-232464 - Use Fstat to retrieve file size. 
Change-Id: I4051645cd322c2afaf89e014452657db1a1fdc2c
 2020-05-12 08:53:51 -04:00
Chauncey Hui 81ed982f27 SWDEV-2 - Change OpenCL version number from 3140 to 3141 2020-05-12 03:00:04 -04:00
Matt Arsenault a92dc8c25c Use project relative include dir for generated header paths 
Change-Id: I8c0834d68e6dac00b41a7059a978cbd2ebb933f9
 2020-05-11 21:57:25 -04:00
Payam Ghafari 37371835c0 Merge "updating hipDeviceProps_t-< arch flags according to SWDEV-234277" into amd-master-next 2020-05-11 21:28:43 -04:00
Christophe Paquot 163fdd6b74 HPC : Intermittent hangs are observed while running Gromacs benchmarks 
SWDEV-235579
Move the lock before destroying the queue as there's a multithreaded race condition if the queue
is being destroy and right after we set queue_ to nullptr, another thread can call ihipWaitStreams
which will then call create on that same stream because queue is now nullptr.
Moving the lock on streamSet prevents this from happening because we would remove the stream from that
list and therefore ihipWait will not try to call asHostQueue which tries to create the queue if not created yet
since the stream won't be in the list anymore

Change-Id: I3108657ab403d39d4123e83294fcf1f0880e5563
 2020-05-11 16:35:13 -07:00
Icarus Sparry b0900de0fb Merge "Fix runtime failure on windows" into amd-master-next 2020-05-11 18:58:17 -04:00
Icarus Sparry 3c855b543a Fix runtime failure on windows 
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
Change-Id: I6c991a943e04ef29eff2905becbed0038c3b8ab9
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
 2020-05-11 17:30:47 -04:00
Freddy Paul e43d427cdd opencl-on-vdi:Add symlink for libopencl lib to ROCm lib 
Move libOpenCL.so from rocm-opencl-dev package to rocm-opencl.
Having the libOpenCL.so alone and that too just a symlink pointing
to a file in another package is not the right way.

Adding a symlink for libOpenCL... to rocm/lib will make package
deployment easier.

Change-Id: Icc98d2280253c8a485ef906e97fc75129ad6d064
 2020-05-11 14:02:37 -07:00
Payam 005a033c53 updating hipDeviceProps_t-< arch flags according to SWDEV-234277 
Change-Id: I6238edf9a2df15a5dfe420dbb8723e10a0725f98
 2020-05-11 16:43:13 -04:00
German Andryeyev ae4aceb55e Make sure the list of HSA agents is valid 
If HIP_VISIBLE_DEVICES is active, then make sure the list of HSA
agents contains the valid agents

Change-Id: I584aad999a230ab7f88a0cfe20dcd0abe79c43a5
 2020-05-11 15:49:30 -04:00
Matt Arsenault 28cb3e5496 Start cleaning up rocclr include paths 
Use target_include_directories instead of global includes.

Change-Id: I3adadc905843f152a548c71b2f12701476065207
 2020-05-11 15:24:19 -04:00
Matt Arsenault 03ebfd2d49 Remove some asm declarations for intrinsics 
This technique should never be used, and only accessed through
__builtins.

There's currently no builtin for groupstaticsize. I left ds_swizzle
since for some reason it switches to the builtin based on __HCC__ or
not.

Change-Id: If1e1394221dba83ea4add6db5e94d6b715552044
 2020-05-11 15:20:58 -04:00
Michael Hong Bin Liao 8194edb2a2 Merge "[hip] Fix -Wduplicate-decl-specifier warning. NFC." into amd-master-next 2020-05-11 15:18:57 -04:00
jujiang bc9351f904 SWDEV-230009-Cltrace log is not created as expected-fix build errors on windows 
Change-Id: I9eaa15f39fff0f65858f4a0b8b43ef4288ea97b1
 2020-05-11 13:51:55 -04:00
Julia Jiang 984d6545e6 Merge "SWDEV-230009-Cltrace log is not created as expected-Update return type to vdi_agent" into amd-master-next 2020-05-11 13:50:59 -04:00
Christophe Paquot 3ed185307e Fix cooperative flag for hsa_queue creation in case they're not available 
SWDEV-233766

Change-Id: If410ecfed61f2b3bb50b847cf2ededc573139494
 2020-05-11 13:40:50 -04:00
Icarus Sparry 635c8208e1 Merge "Correct quoting of arguments" into amd-master-next 2020-05-11 11:39:47 -04:00
Michael LIAO 7c707dd41c [hip] Fix -Wduplicate-decl-specifier warning. NFC. 
Change-Id: Iae48bbb7805c39f1005c920df8e76504426f2d3b
 2020-05-11 10:12:33 -04:00
Dittakavi Satyanvesh dcf94dcd2a search path logic updated for extractkernel SWDEV-230929 
Change-Id: I48d6332502774485d7ced3fee065a74f15774500
 2020-05-11 02:27:40 -04:00
Icarus Sparry 9f31801831 Correct quoting of arguments 
The hipcc script takes arguments and uses this to build up a new
command. Characters which are special to the shell need to be quoted
to prevent them being interpreted.

In particular adding
     --Wl,--enable-new-dtags -Wl,--rpath,'$ORIGIN:$ORIGIN/../lib'
to the command should pass quoted dollar signs into the resulting
string so the shell passes them on, rather than substituting the
values.

The arguments are processed in a conventional loop, but can be altered
during the course of the loop, and also by linker response files.

Tested by running
  HIPCC_VERBOSE=7 HIP_COMPILER=clang hipcc --cxxflags \
      fred.c -Wl,,--rpath,'$ORIGIN:$ORIGIN:/../lib'
and observing "-Wl,--rpath,\$ORIGIN\:\$ORIGIN\:..\/lib" in the
displayed hipcc-cmd output (and ignoring the errors due to rocm not
being installed)

Change-Id: I26b62f09ff3518cceeb85fa8823bb12a95c1c78e
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
 2020-05-10 18:16:48 -04:00
Vlad Sytchenko a88e52ba80 Correct HIP_FUNC_ATTRIBUTE_NUM_REGS query 
Change-Id: I526cc7871c690260df0fa8c1b3b4b15fbc5af219
 2020-05-09 12:42:30 -04:00
Chauncey Hui da8c217e6f SWDEV-2 - Change OpenCL version number from 3139 to 3140 2020-05-09 03:00:03 -04:00
jujiang 1662b25dc6 SWDEV-230009-Cltrace log is not created as expected-Update return type to vdi_agent 
Change-Id: Ice4083d0d3a061867f886119a4cc541e2048a328
 2020-05-08 18:56:25 -04:00
Christophe Paquot 2a02026696 Add gpu().hasPendingDispatch() in the SDMA path 
SWDEV-234947

Change-Id: I8aa501f8755d136708b0d12ee3c30229c238660d
 2020-05-08 18:19:51 -04:00
Christophe Paquot 6c05f34e6d Merge "Don't add a null command to waitList in hipMemcpy" into amd-master-next 2020-05-08 17:01:38 -04:00
Christophe Paquot 8c2c4c3b27 Don't add a null command to waitList in hipMemcpy 
SWDEV-235345

Change-Id: Ib1abd0ba6414d081891a9f5209df083c45734aee
 2020-05-08 12:43:41 -07:00
Vlad Sytchenko b5f9d2f818 Correct HIP_FUNC_ATTRIBUTE_MAX_THREADS_PER_BLOCK query 
We should be returning the max workgroup size calculated by the compiler.

Change-Id: If86590efbb9b291f470bdbe87e5df992e661c539
 2020-05-08 14:36:47 -04:00
Vlad Sytchenko 276bfc9667 Fix confusion in hipFuncGetAttribute() 
Cuda shared == OpenCL local

Cuda local == OpenCL private

Change-Id: I5a204945ecde35919b9e9def20bbb2662fffea2b
 2020-05-08 14:36:36 -04:00
Jason Tang 372ebe7b00 Add dependency of hsa-rocr-dev and hsa-ext-rocr-dev 
in-line with hip-on-vdi.

Change-Id: Ib0e1a5180eef409cfd0f1b5b9a42a2b663dfc0d3
 2020-05-08 13:23:37 -04:00
Matt Arsenault 1ff46e24c5 Don't add llvm includes to rocclr build 
There are no llvm includes here.

Change-Id: I0567c6e47e717580819f3854782ba08501bd069d
 2020-05-08 12:24:49 -04:00
Anusha Godavarthy Surya 59cf312bcd Merge "SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall" into amd-master-next 2020-05-08 12:12:06 -04:00
agodavar e069cf6511 SWDEV-234447:Fix error Use of uninitialized value in concatenation (.) 
Change-Id: Ia6f8d23f100826438f152c175d10ac3096ee024e
 2020-05-08 12:07:24 -04:00
Matt Arsenault 72675bf079 Don't write generated version.h to source directory 
Change-Id: Ib4e7c3171cd227725ae35fed66167df528a4c431
 2020-05-08 10:59:28 -04:00
Vlad Sytchenko 6e985845b3 Take into account dynamic LDS size when validating the launch parameters. 
Bottom layers don't error check this value, so we might and up writing a bad value to a register and cause the SPI to hang.

Change-Id: I6da4ae71c66a25c63ebb804da4afe4ca7fb831b7
 2020-05-08 09:37:06 -04:00
Aaron Enye Shi c70a32c5a7 SWDEV-234954 - Fix hipconfig on Windows 
Before setting the HIP_RUNTIME and HIP_COMPILER variables, first check the environment if these are set. We should prioritize the environment settings. For windows, it will be set, and also explicitly call perl when invoking hipconfig.

Change-Id: I89ad267285239e6d8a897dc681c4af5906e7b9d8
 2020-05-08 13:27:36 +00:00
agodavar 89415b66f0 SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall 
Change-Id: Ideb76b73916881469e39b7a0a4d68d7ec098b4a8
Signed-off-by: agodavar <Anusha.GodavarthySurya@amd.com>
 2020-05-08 07:36:28 -04:00
Chauncey Hui 06ee6f209a SWDEV-2 - Change OpenCL version number from 3138 to 3139 2020-05-08 03:00:03 -04:00
Sarbojit Sarkar 94699a7a6f Enabling hipGetDeviceFlags required in [SWDEV-229170] 
Change-Id: I998d37e5847f9651345554bada86df6fce86d1eb
 2020-05-08 01:37:23 -04:00
Vlad Sytchenko 10bf21829c Merge branch 'amd-master-next' into amd-npi-next 
Change-Id: Id97c6b8c875731250049a5b9dc8062311ae291ad
 2020-05-07 17:17:21 -04:00
Matt Arsenault 5e28b28044 Fix generated hip_prof_str.h install again 
Change-Id: I92ea4bedbcdc92974998c00ca7f0c00098791cb5
 2020-05-07 12:40:39 -04:00
Aaron En Ye Shi dc795978b5 Merge "Fix missed VDI names in hip-on-rocclr" into amd-master-next 2020-05-07 12:30:51 -04:00
agodavar 8f204466e9 Fix hip-config.cmake build error in rocBLAS 
Change-Id: I097f0dac0f67bfc22e9991350bf63bc7bfa8b269
 2020-05-07 12:24:20 -04:00
Michael LIAO 12fcfee41d Fix build failure. 
- Also fix `-Wreorder` warning. NFC.

Change-Id: I766fdc622c9107f901a55498bdc8fef3d821d1b7
 2020-05-07 10:39:10 -04:00
Michael LIAO 503ef06555 Clear executable permission. 
Change-Id: Ia0d363b1ba89d7947e5b5a55cb67edba86f0515e
 2020-05-07 10:38:58 -04:00
Aaron Enye Shi 88ce9d5a10 Fix missed VDI names in hip-on-rocclr 
Change-Id: I830feb37a043656136648e92a0c6f1eaae8402d7
 2020-05-07 08:37:28 -04:00
Tao Sang 94bc7375af Merge "Support performance tests" into amd-master-next 2020-05-07 07:15:09 -04:00
Chauncey Hui 3c7f376ec0 SWDEV-2 - Change OpenCL version number from 3137 to 3138 2020-05-07 03:00:03 -04:00
Rahul Garg 8644e77b9f Merge "Remove HIP_MARKER left overs due to HIP PR 2032" into amd-master-next 2020-05-07 01:36:57 -04:00