Commit Graph

4937 Commits

Author SHA1 Message Date
foreman 68c1629fe2 P4 to Git Change 1984760 by kjayapra@4_HIPWS_RCCM_ROCM on 2019/08/16 18:33:19
SWDEV-188177 - Fixing parameters passed to ihipBindTexture in case of 1D image.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#16 edit
2019-08-16 18:38:15 -04:00
foreman d4c996988e P4 to Git Change 1984568 by kjayapra@4_HIPWS_RCCM_ROCM on 2019/08/16 13:19:53
SWDEV-144570 - Code changes to support Texture header changes.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#15 edit
2019-08-16 13:27:47 -04:00
mhbliao 282f06014e [hip] Allow from/to half conversion on host side. (#1334) 2019-08-16 02:13:59 +00:00
Rahul Garg a0cc627c42 Fix build issues seen with hip-clang path (#1331) 2019-08-16 02:13:45 +00:00
Yaxun (Sam) Liu c4655d167e Fix assert for windows. (#1329)
MSVC assert.h has no guard for include once. The macro assert overrides
device assert definition. Do not include it for device compilation.
2019-08-16 02:13:33 +00:00
Rahul Garg fbc9f7e20a Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check
2019-08-16 02:13:16 +00:00
Rahul Garg c741ad3c80 [dtests] refactor windows specific changes (#1313)
* [dtests] refactor windows specific changes

* Refactor hipMemoryAllocateCoherentDriver - PR- 1309

* Fix missing z in _putenv_s

* Revert "Fix missing z in _putenv_s"

This reverts commit 099a1b20a5c75c5f122d57c0ad2bca01745cdc9c.

* Refactor changes from PR 1299

* Update hipEnvVarDriver.cpp
2019-08-16 02:13:00 +00:00
Rahul Garg 7f9de881cb Fix undefined identifier issue for hipExtModuleLaunchKernel 2019-08-14 16:46:32 -04:00
Maneesh Gupta 3634695737 [hit] Add support for specifying dependencies in HIT syntax (#1323) 2019-08-14 11:30:42 +00:00
Sarbojit2019 c4618f2c3b [HIP] Fix for hipArray_t failure on nvcc path
Fixes SWDEV-148407
2019-08-14 11:30:06 +00:00
Rahul Garg d90c66f5bf [docs] Attribute details for launch kernel greater than 256 (#1319)
* Add attribute detail for kernel launch group > 256

* Add example
2019-08-14 11:29:04 +00:00
eshcherb 91c9f29cd1 parser support for spaces after func name (#1294)
* parser support for spaces after func name

* removing reference
2019-08-14 11:28:42 +00:00
Evgeny Mankov 9166b1554e [HIPIFY] Add cudaMallocManaged -> hipMallocManaged
+ Add mapping for corresponding data types
+ Add a test
+ Update docs
2019-08-13 17:56:06 +03:00
Evgeny Mankov 79de17dc84 [HIPIFY][Driver API] Add support for hipFuncGetAttribute() and enum hipFunction_attribute 2019-08-13 16:48:07 +03:00
Evgeny Mankov b9deceab05 [HIPIFY] Add cuMemcpy2DAsync -> hipMemcpyParam2DAsync mapping 2019-08-13 16:31:19 +03:00
foreman 602da8e12d P4 to Git Change 1982056 by kjayapra@3_HIPWS_TXT_ROCM on 2019/08/12 21:16:51
SWDEV-199635 - Setting VarInfoCallBack before all program builds.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#33 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#58 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#97 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#106 edit
2019-08-12 21:22:47 -04:00
foreman 1ce84c8b6e P4 to Git Change 1982034 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/12 19:08:13
SWDEV-199606 - [HIP] hipStreamQuery issue
	Don't test against CL_COMMAND_MARKER but 0 instead (user visible=false)

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#22 edit
2019-08-12 19:16:30 -04:00
Evgeny Mankov af557aaaf6 [HIPIFY] Cooperative groups support 2019-08-12 19:20:13 +03:00
foreman e51298aee1 P4 to Git Change 1981324 by kjayapra@3_HIPWS_TXT_ROCM on 2019/08/11 18:44:40
SWDEV-188177 - Texture API implementation and support for extern variables.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#35 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#340 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#57 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#608 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.hpp#172 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#250 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#79 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#152 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#41 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#96 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#133 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#105 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#48 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#102 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#46 edit
2019-08-11 18:53:11 -04:00
foreman 3494344c4d P4 to Git Change 1981152 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/09 20:33:32
SWDEV-193430 - [HIP] Delay creating HostQueue till commands are enqueued.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#21 edit
2019-08-09 20:41:13 -04:00
foreman 7bbbdabfb0 P4 to Git Change 1981065 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/09 16:31:44
SWDEV-198556 - [HIP] Use src/dstMemory->getContext instead of host_context.
	Also relax the check for P2P copies in case of hipMemcpy(hostMalloced, hipMalloced(dev1), dev0)

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#67 edit
2019-08-09 16:34:38 -04:00
Evgeny Mankov 2ee0ecde06 [HIPIFY][cuRAND][#1257] Fix
+ Update CURAND_API_supported_by_HIP.md and test accordingly
2019-08-09 21:27:16 +03:00
Nick Curtis 343d1f5715 Fix HIP Platform defines
Remove extra trailing `_` in platform defines
2019-08-09 09:25:31 -05:00
Maneesh Gupta 1884359940 Bump HIP version (#1311)
- Match HIP version with upcoming ROCm version
- Add githash to version string
2019-08-09 12:13:29 +00:00
amd-lthakur 19ad365834 [dtests] Fix build issues with hipMemoryAllocateCoherentDriver.cpp on windows (#1309)
Compilation error being observed due to popen(), pclose() and setenv() linux calls on windows. Replaced with appropriate calls on windows.
2019-08-09 11:53:16 +00:00
amd-lthakur 93f5940ef8 [dtests] Fix build issue with hipMemcpy_simple.cpp on windows (#1306)
Compilation error being observed on windows due to aligned_alloc() call. Mapped the call to _aligned_malloc() for windows.
2019-08-09 11:52:46 +00:00
ansurya fc60f3a95b [dtests[ Fix build issues with hipEnvVar*.cpp on windows (#1299)
* replace getopt with clara based command line options

* Removed header getopt.h
2019-08-09 11:52:10 +00:00
Rahul Garg 569f35a258 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis
2019-08-09 11:50:37 +00:00
amd-lthakur 36977dc276 [dtests] Fix build issues with hipLaunchParm.cpp on windows (#1293)
* Removed unwanted #include sys/time.h , gettimeofday() and timeval variables and this also helps avavoid compilation error in windows due to gettimeofday() call equivalent of which is not available in windows

* Changed the Macro name from GPU_PRINT_TIME to MY_LAUNCH_MACRO
2019-08-09 11:50:10 +00:00
amd-lthakur c212c484af [dtests] Fixed build issues with hipAsynchronousStreams.cpp on windows (#1292)
Changed the third arg of the functions __hip_as_write_block and __ockl_as_write_block from ulong to uint64_t so as to fix the compilation error in windows
2019-08-09 11:49:31 +00:00
foreman ab33c14089 P4 to Git Change 1980493 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/08 18:57:21
SWDEV-198556 - [HIP] Override queue if src/dst's device doesn't match the queue's device.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#66 edit
2019-08-08 19:03:46 -04:00
Evgeny Mankov 90c4dbe84a Merge pull request #1300 from amd-lthakur/windows-Single-Double-Precision-Math-Host-fixes
Fixed compilation errors being observed on windows
2019-08-09 00:15:48 +03:00
Rene van Oostrum 3e5fd98fc3 Add missing hipHostRegister flags to hipify-perl for flags that are defined and supported in hip_runtime_api.h 2019-08-08 10:46:45 -05:00
Siu Chi Chan 3cf2d7d385 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back
2019-08-08 08:33:04 +00:00
Maneesh Gupta 268d82aefd Merge pull request #1305 from ROCm-Developer-Tools/fix-hip-vdi-include-clang
Fix HIP-VDI using incorrect include files
2019-08-08 08:28:20 +00:00
Maneesh Gupta 520f97b920 Merge pull request #1302 from davidrohr/master
Treat .cxx files like .cpp files
2019-08-08 08:28:01 +00:00
Rahul Garg 8b6317d041 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error
2019-08-08 08:27:41 +00:00
Evgeny Mankov 19a929f070 Merge pull request #1290 from emankov/master
[HIP][doc] Populate README.md with the supported CUDA APIs links
2019-08-08 11:17:50 +03:00
lthakur 80acd13ba7 Resubmitting the fix so as to address the changed format in the last submission 2019-08-08 11:26:26 +05:30
Aaron Enye Shi 3750b2cf42 Fix HIP-VDI using incorrect include files
When HIP-VDI depends on an llvm-amdgpu package, the include clang directory is not properly assessed.
2019-08-07 16:59:17 -04:00
David Rohr a22119d381 Treat .cxx files like .cpp files 2019-08-07 19:11:35 +02:00
foreman 24e2e8a6b2 P4 to Git Change 1979518 by kjayapra@3_HIPWS_TXHDR_ROCM on 2019/08/07 12:40:50
SWDEV-198194 - Adding lock in Unregistervar.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#36 edit
2019-08-07 12:45:50 -04:00
foreman bf395ba54a P4 to Git Change 1979482 by zukhan@zukhan-ocl-win10 on 2019/08/07 11:30:33
SWDEV-196326 - [hipclang-vdi-rocm]: [FBA-80]: Runtime error when all GPUs are hidden by ROCR_VISIBLE_DEVICES
	 - Adjusted hipGetDeviceCount to return "hipErrorNoDevice".
	 - This was done to match the same behaviour as HIP-HCC, and API spec for when no devices are found. Rather then return "count = 0" as it did.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17789/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#22 edit
2019-08-07 11:44:31 -04:00
foreman 2f761998c3 P4 to Git Change 1979479 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/07 11:25:59
SWDEV-198424 - [HIP] Implemented missing fields for hipGetDeviceAttribute.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#17 edit
2019-08-07 11:30:59 -04:00
foreman 534fcf8222 P4 to Git Change 1979460 by kjayapra@3_HIPWS_TXHDR_ROCM on 2019/08/07 11:05:27
SWDEV-145570 - Code changes after header update.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#13 edit
2019-08-07 11:07:16 -04:00
lthakur c4f6d58354 Fixed compilation errors being observed on windows 2019-08-07 15:54:46 +05:30
Rahul Garg 971a64c6b9 Enable temporarily disabled device properties on HIP/VDI 2019-08-06 22:03:19 -04:00
foreman 1ee23f0f43 P4 to Git Change 1979123 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/06 17:15:10
SWDEV-198556 - [HIP] Gnarly bug due to macros:
	HIP_RETURN(ret) duplicates ret twice first by setting the last error
	then via LogDebugInfo. So if HIP_RETURN has a function as a parameter,
	the function would get called twice. So ihipMalloc and ihipMemcpy were
	being called twice (and perhaps more functions).
	Also logging the pointer returned by ihipMalloc so we can track memory
	in logs more easily.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#33 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#65 edit
2019-08-06 17:19:28 -04:00
Evgeny Mankov 5bcff6f081 [HIP][doc] Populate README.md with the supported CUDA APIs links 2019-08-05 16:05:39 +03:00
Evgeny Mankov 00ac238921 [HIPIFY][doc] Update README.md
+ cuDNN, Python, and VS supported versions update;
+ testing output update.
2019-08-05 14:49:01 +03:00