Galantsev, Dmitrii
8eb9f892d3
Fix out-of-bounds array access for --showvc
...
get_od_clk_volt_info assumed the size of the file instead of checking
the length. This caused out-of-bounds array element access.
Change-Id: Ibda8f0c3a6d1623d48964641ae5ef610d2072e94
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-26 13:59:37 -05:00
Maisam Arif
b452c8e2a3
Merge amd-dev into amd-master 20230925
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ib028fd7749f8c38bcf64b11682468c464ca567c7
2023-09-25 20:18:36 -05:00
Maisam Arif
5131e61ce4
Removed comma from vendor_name for output formatting
...
Change-Id: Ief4b9c2b68cbf16cb994d78bc3ae3f4fe702fd70
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-25 14:57:44 -05:00
Maisam Arif
535f93c1cf
Merge amd-dev into amd-master 20230925
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ib60e35c5b8e40229d6da61af2b748f90d8d54417
2023-09-25 11:32:29 -05:00
Galantsev, Dmitrii
21dcf6d66c
SWDEV-423796 - Resolve stack smashing issue
...
Inconsistency between struct fields caused stack smashing
Change-Id: Ib06d67723e062d4306420854ba7ab45fb252ffe3
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-25 11:24:55 -05:00
Galantsev, Dmitrii
31cc2eecfb
Merge remote-tracking branch 'rocmsmi/amd-staging' into HEAD
...
Change-Id: I0661926c10eef2bc32b83d9a63a3a6eb6991e781
2023-09-25 04:35:53 -05:00
Galantsev, Dmitrii
ac8bde5978
CMAKE - Fix --break-system-packages
...
Change-Id: I4a46859124018b6574d2b53e6ef9e72482784f39
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-25 02:03:27 -05:00
Maisam Arif
25b055014d
Updated tool & lib versions & README.md
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ic41a36bcfa988ce9c8304157593012752857e919
2023-09-25 02:02:22 -05:00
Maisam Arif
053c5d0c53
Fixed vram_type reference to vram_vendor
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I3519992f1cc59c411c2b045f0532be4de63090a2
2023-09-25 02:02:22 -05:00
Maisam Arif
5ab82ad4e6
Added N/A for mixed gpu values with --csv
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Iab730ae61d2c0fb08785e90f05f83bab755b5d94
2023-09-25 02:02:22 -05:00
Maisam Arif
b90dff83ea
Remove adding .json, .csv, & .txt file extensions
...
Change-Id: I35172115932a1363c23aedf877151e87b669bca4
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-25 02:02:22 -05:00
Maisam Arif
9c314dfd5c
Updated metric --xgmi_err to display string instead of object
...
Change-Id: I4f67384cdf65b5fa3cb04e1012ba79a53ae72cd7
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-25 02:02:22 -05:00
Maisam Arif
9281bfbbfa
Fixed log handling and exceptions
...
Updated exceptions
Added driver load exception
Fixed logging override by removing previous log handlers
Updated debug output to use gpu_id vs C-pointer
Removed AmdSmiRetcode class in favor of using the wrapper
directly
Added traceback limits for clean errors (Not in debug)
Change-Id: Ia02bb842b8f60d9ab4b68b7f8b1afda30b1c021c
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-25 01:49:35 -05:00
Galantsev, Dmitrii
db3e119f7d
Remove old gpuv-smi symlink
...
Change-Id: I39d9aa96eb8ed2dd6a4a222c3c4da9ff2b2de007
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-25 00:52:17 -05:00
Charis Poag
f078375350
Add Current (Instant) Socket Power
...
* Updates:
- rocm_smi_logger:
General cleanup &
Aligned to cpplint rules for usage
- rocm_smi_monitor:
Fixed MonitorTypes
from not displaying properly in logs
& Added socket power label + current
socket power MonitorTypes
- rocm_smi API:
Added rsmi_dev_current_socket_power_get API
- rocm_smi CLI:
General cleanup,
Concise info now displays device data
in variable width (see printLogSpacer's
new field),
printLogSpacer now as an adjustable
variable that overrides appWidth,
Added Socket Power to base rocm-smi +
--showpower CLI calls,
--showpower & base rocm-smi CLI defaults
to printing socket power (if not available,
displays average power)
- Cleaned up temp label references
- power_read gtests:
Added current socket power to testing
Change-Id: Ica57e6f98ad96e2584e7c7955e188f68d2dab89d
Signed-off-by: Charis Poag <Charis.Poag@amd.com >
2023-09-25 01:38:54 -04:00
Galantsev, Dmitrii
3d40c4bb2c
SWDEV-422836 - Add sleep frequency support
...
Change-Id: I0bde403b010bf036ce44ed0600cc7eb03742c6b6
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-25 01:38:27 -04:00
Ori Messinger
d44a6ef523
ROCm SMI LIB: Add Missing Firmware Blocks
...
The purpose of this patch is to add the following missing firmware
blocks to the SMI LIB:
-RSMI_FW_BLOCK_MES
-RSMI_FW_BLOCK_MES_KIQ
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com >
Change-Id: I5d4d37d883878dd02ef8533d4eb8891d54d70630
2023-09-25 01:37:38 -04:00
Bill(Shuzhou) Liu
2247c4b46c
Change the python tool id output label
...
Change the label from GPU to Device as we call rsmi_dev_id_get().
Change-Id: I8ffe3673d434e5291ebd5cc909afb7d18154ecb6
2023-09-25 01:31:04 -04:00
Bill(Shuzhou) Liu
85df5676d4
Handle the memory frequency with only one line
...
Change the code to handle the memory frequency if it is only one line.
Change-Id: I09e6ee78a2b9c12c861243dc89296e4e7862da49
2023-09-25 01:30:56 -04:00
Maisam Arif
842b290a44
Added energy counter in metric --energy
...
Change-Id: I8ea09af79a1a37f53038d06a89eeac0882c47a1d
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-24 22:32:52 -04:00
Hao Zhou
75e5e1bd58
Merge amd-staging into amd-master 20230925
...
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com >
Change-Id: I84b76024c6b88234f92add3453fe291805363cda
2023-09-25 09:36:45 +08:00
Maisam Arif
5c52f82328
Removed compatibility modes
...
Removed gpuv-smi and rocm-smi compatibility options
Updated py-interface README
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I1cad3e65e0928e7041727c6d5e7e7bdc39d667d0
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-24 21:17:43 -04:00
Maisam Arif
8a9f862dbf
Change uuid_info file read to uuid generation
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I77f2c6b44efd6faae3c2466989e1caeaad16669d
2023-09-24 21:17:34 -04:00
Maisam Arif
a28df4a242
Added all option to gpu selection
...
Change-Id: Ifcb49d66239c54fd3a214f4782321bbcc59e057a
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-24 18:13:38 -04:00
Maisam Arif
5ad17006b2
Updated Fan speed function calls
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ie4d6af3a05d6a408a94ce22268addd547ad5b688
2023-09-24 18:05:13 -04:00
Maisam Arif
ddc63694bc
Moved clock locked under applicable clock
...
Change-Id: Ie47b20d0d367a198d6978a5dc571811938cfd02f
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-24 03:15:20 -05:00
Maisam Arif
f82063d19f
Updated metric --usage labels & error handling
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ie376785deeae2df562962c18f4395db87025181b
2023-09-24 01:36:05 -04:00
Maisam Arif
e079032d0e
Added pcie bandwith to metric --pcie
...
Change-Id: I12d070ca8e4ad0606d5d2c843cdffdcd83007350
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-24 00:12:57 -04:00
Maisam Arif
901b9e8331
Moved replay count under metric --pcie
...
Change-Id: I86564af04526df9b1a8cdae14da39450d924805d
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-23 23:12:20 -05:00
Maisam Arif
6d0adab4fd
Added is_clock_locked placeholder
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ia8750b4233bf37c4eab81b7815fd9aaebe3f1ca3
2023-09-23 23:01:58 -05:00
Maisam Arif
7b28fdf9c5
Corrected voltage output to N/A in metric --power
...
Change-Id: I0e8da0821196602842d35841470e36b91ba31ce3
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-23 23:57:22 -04:00
Maisam Arif
4ce4b7fda1
Changed pcie_slot_type to slot_type
...
Change-Id: Iab63397b049bbed4e0e52357c3eff7c1bcfe9590
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-23 23:53:25 -04:00
Maisam Arif
93c5112cdf
Corrected mem_usage command
...
Dropped redundant fb_usage argument
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I85d72683085270415f735e9817e359baf6b36773
2023-09-23 23:53:05 -04:00
Maisam Arif
6dcfd4a815
Added vram info to static --vram
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I48f6875d5131440848ef6f5875c6d385fee871e3
2023-09-23 23:52:50 -04:00
Maisam Arif
79ccf1670b
Added vendor_name to static --asic
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I3d52a8769e1f721c20efdf78ffb9e6813de59e10
2023-09-23 23:51:24 -04:00
Bill(Shuzhou) Liu
9fc677a261
Standard format driver date
...
Normalize the driver date format.
Change-Id: I2f9623e99d28217b3cc1a9b6f91cbe77ed66fac9
2023-09-23 23:46:43 -04:00
Galantsev, Dmitrii
0c662611e9
SWDEV-423672 - Always compile and install gtest
...
This commit makes sure GTest is always compiled with rocm_smi_lib_tests.
GTest installation was inconsistent outside of AMD CI environment.
libgtest.so wouldn't get installed with rocm_smi_lib_tests if gtest
existed on the build machine. Which is undesirable when packaging.
Change-Id: I607df6c67c81480e3b6487b28f14924e8bf56ad4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-23 21:10:12 -04:00
Maisam Arif
5aaea7a514
Change mem_actvity_acc to mem_activity_acc
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: I55862d6d173fca201ad8830bf7f8961f3be9b65d
2023-09-23 14:22:33 -04:00
Galantsev, Dmitrii
1683245ecf
PY: Remove f-strings from rocm_smi.py
...
Change-Id: I0a422e8f66473af837460ecb2450e5be329163b0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-22 19:15:59 -05:00
Galantsev, Dmitrii
2589d677b0
actvity -> activity
...
Change-Id: Ie31d9faca2181cb2d47f7f4764b64ed8cc7f8007
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-22 11:45:21 -05:00
Galantsev, Dmitrii
5c41319c83
Merge remote-tracking branch 'rocmsmi/amd-staging' into HEAD
...
Change-Id: I65ed7f3a0d1b6e58bc8377932d7c39db21d1b422
2023-09-21 23:43:20 -05:00
Maisam Arif
def17accbe
Corrected voltage_read call in amdsmi_get_power_info
...
Change-Id: I4097b3ac5699360d4e91c8b8254431b6b6768c3e
Signed-off-by: Maisam Arif <maisarif@amd.com >
2023-09-21 23:41:38 -05:00
Maisam Arif
e4fac177c1
SWDEV-417124 - Implement Power Management
...
Signed-off-by: Maisam Arif <maisarif@amd.com >
Change-Id: Ib0d37038e49cec61d5415076a46a5666d95dcea2
2023-09-21 14:23:26 -05:00
Oliveira, Daniel
e0483f2ee2
rocm_smi_lib: Fix [linux BM] [AMDSMI] Memory Bandwidth
...
Implements APIs for 'gpu_metrics_v1_3' utilization averages
Code changes related to the following:
* rsmi_dev_activity_metric_get()
* rsmi_dev_activity_avg_mm_get()
* CLI shows "Avg.Memory Bandwidth" under "--showmemuse"
Change-Id: I8e4600f350a7c18499abf022534db2b875f09d5f
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com >
2023-09-21 11:00:29 -04:00
Hao Zhou
3686032f35
Merge amd-staging into amd-master 20230921
...
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com >
Change-Id: I85a307afa6cfa024f4fd486456cea865d4da93c7
2023-09-21 13:50:28 +08:00
Galantsev, Dmitrii
a6af1769b9
Update amdsmi_wrapper.py
...
Change-Id: Ia523ba6ac629c02b6d6ba3db6d57507f2003f817
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-20 15:05:09 -04:00
Galantsev, Dmitrii
b99867eb80
PACKAGE - Fix packaging
...
Allow for configureLogrotate to fail without failing configure
In previous commit I forgot to invert the check when switching
"IS_SYSTEMD" and "!IS_SYSTEMD" if-else statements.
Change-Id: I8eb8e7981c6353a2e60064eb3a6e35821ea2a0d0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-20 10:37:35 -05:00
Galantsev, Dmitrii
431a7071a0
PACKAGE - Cleanup packaging
...
- Clean-up packaging scripts. More consistent with RDC.
- Remove all 'sudo' calls. all these scripts are to be ran by root.
- Reduce scope of variables.
- Remove unnecessary functions
Change-Id: Ib90f8e66ef4eae24f73e940fff44f515e12233f5
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2023-09-20 01:07:51 -04:00
Maisam Arif
8b873f6262
Merge "Added debug logging for amdsmi library calls" into amd-dev
2023-09-19 16:47:51 -04:00
Maisam Arif
11bd6a0319
Merge "Changed discovery to list" into amd-dev
2023-09-19 16:47:46 -04:00