AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
54,851 Commits 3 Branches 0 Tags
a2cedb7fe5ccb4c0bbd911a661672e7d581e95e4
Commit Graph

54851 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alex Voicu 41045dd24d This corrects some interesting choices that were present in the HIP 
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.


[ROCm/clr commit: 58a18eaf0c]
 2017-11-01 22:51:22 +00:00
Alex Voicu 58a18eaf0c This corrects some interesting choices that were present in the HIP 
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.
 2017-11-01 22:51:22 +00:00
Alex Voicu a619ac6f92 This corrects some interesting choices that were present in the HIP 
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.
 2017-11-01 22:51:22 +00:00
Alex Voicu 840895525a Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n). 
[ROCm/clr commit: 4693c5e56c]
 2017-11-01 22:33:13 +00:00
Alex Voicu 4693c5e56c Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n). 2017-11-01 22:33:13 +00:00
Alex Voicu 2cacda91bb Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n). 2017-11-01 22:33:13 +00:00
foreman 80e0bed02b P4 to Git Change 1477581 by wchau@wchau_WIN_OCL_HSA on 2017/11/01 16:33:34 
SWDEV-136305 - [OCL 2.1 Plat] API calls for all drivers

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_command.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#87 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.hpp#27 edit


[ROCm/clr commit: ab934181fa]
 2017-11-01 16:53:27 -04:00
foreman ab934181fa P4 to Git Change 1477581 by wchau@wchau_WIN_OCL_HSA on 2017/11/01 16:33:34 
SWDEV-136305 - [OCL 2.1 Plat] API calls for all drivers

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_command.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#87 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.hpp#27 edit
 2017-11-01 16:53:27 -04:00
foreman d1584c846c P4 to Git Change 1477581 by wchau@wchau_WIN_OCL_HSA on 2017/11/01 16:33:34 
SWDEV-136305 - [OCL 2.1 Plat] API calls for all drivers

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_command.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#87 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.hpp#27 edit


[ROCm/clr commit: bafc102e17]
 2017-11-01 16:53:27 -04:00
foreman bafc102e17 P4 to Git Change 1477581 by wchau@wchau_WIN_OCL_HSA on 2017/11/01 16:33:34 
SWDEV-136305 - [OCL 2.1 Plat] API calls for all drivers

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_command.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#87 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.hpp#27 edit
 2017-11-01 16:53:27 -04:00
Ben Sander 725f46aa94 Merge pull request #237 from bensander/use_ctxptr_for_p2p 
Use ctxptr for p2p

[ROCm/clr commit: fe32685fbc]
 2017-11-01 18:55:25 +01:00
Ben Sander fe32685fbc Merge pull request #237 from bensander/use_ctxptr_for_p2p 
Use ctxptr for p2p
 2017-11-01 18:55:25 +01:00
Ben Sander 09d866a639 Merge pull request #237 from bensander/use_ctxptr_for_p2p 
Use ctxptr for p2p
 2017-11-01 18:55:25 +01:00
Ben Sander 6e82cc25df Add HIP_DB=warn + message if sync on dangerous event. 
[ROCm/clr commit: 172b9f96e6]
 2017-11-01 10:44:34 -07:00
Ben Sander 172b9f96e6 Add HIP_DB=warn + message if sync on dangerous event. 2017-11-01 10:44:34 -07:00
Ben Sander 70c25bdf8e Add HIP_DB=warn + message if sync on dangerous event. 2017-11-01 10:44:34 -07:00
Ben Sander 19935275ea Merge pull request #245 from scchan/centos_fixes 
various fixes for centos/rhel

[ROCm/clr commit: 5a80c4108e]
 2017-11-01 18:10:29 +01:00
Ben Sander 5a80c4108e Merge pull request #245 from scchan/centos_fixes 
various fixes for centos/rhel
 2017-11-01 18:10:29 +01:00
Ben Sander 86f62accfd Merge pull request #245 from scchan/centos_fixes 
various fixes for centos/rhel
 2017-11-01 18:10:29 +01:00
foreman 7fa1b2c5b1 P4 to Git Change 1477431 by kzhuravl@kzhuravl-fiji-ocllc on 2017/11/01 12:56:46 
SWDEV-102733 - Update cmake for CL 1455364

	Testing: open source build, also here http://git.amd.com:8080/#/c/113674/

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#7 edit


[ROCm/clr commit: 6293fd1825]
 2017-11-01 13:01:29 -04:00
foreman 6293fd1825 P4 to Git Change 1477431 by kzhuravl@kzhuravl-fiji-ocllc on 2017/11/01 12:56:46 
SWDEV-102733 - Update cmake for CL 1455364

	Testing: open source build, also here http://git.amd.com:8080/#/c/113674/

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#7 edit
 2017-11-01 13:01:29 -04:00
foreman fa72a9a820 P4 to Git Change 1477431 by kzhuravl@kzhuravl-fiji-ocllc on 2017/11/01 12:56:46 
SWDEV-102733 - Update cmake for CL 1455364

	Testing: open source build, also here http://git.amd.com:8080/#/c/113674/

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#7 edit


[ROCm/clr commit: 6afeb11d56]
 2017-11-01 13:01:29 -04:00
foreman 6afeb11d56 P4 to Git Change 1477431 by kzhuravl@kzhuravl-fiji-ocllc on 2017/11/01 12:56:46 
SWDEV-102733 - Update cmake for CL 1455364

	Testing: open source build, also here http://git.amd.com:8080/#/c/113674/

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#7 edit
 2017-11-01 13:01:29 -04:00
Alex Voicu b738633bcb This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own. 
[ROCm/clr commit: 28f87f7d2e]
 2017-11-01 15:09:59 +00:00
Alex Voicu 28f87f7d2e This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own. 2017-11-01 15:09:59 +00:00
Alex Voicu c2482d1255 This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own. 2017-11-01 15:09:59 +00:00
Jenkins 6f25720c66 Merge 'master' into 'amd-master' 
Change-Id: Ic61bd45a4904ddb1645e90b9e8fb42ffeab4825a


[ROCm/clr commit: 4401c8c390]
 2017-11-01 04:42:40 -05:00
Jenkins 4401c8c390 Merge 'master' into 'amd-master' 
Change-Id: Ic61bd45a4904ddb1645e90b9e8fb42ffeab4825a
 2017-11-01 04:42:40 -05:00
Jenkins 7d55fc385b Merge 'master' into 'amd-master' 
Change-Id: Ic61bd45a4904ddb1645e90b9e8fb42ffeab4825a
 2017-11-01 04:42:40 -05:00
foreman f1764ece0c P4 to Git Change 1477155 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/01 03:00:04 
SWDEV-2 - Change OpenCL version number from 2531 to 2532.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2279 edit


[ROCm/clr commit: b3181d4b6c]
 2017-11-01 03:05:32 -04:00
foreman b3181d4b6c P4 to Git Change 1477155 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/01 03:00:04 
SWDEV-2 - Change OpenCL version number from 2531 to 2532.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2279 edit
 2017-11-01 03:05:32 -04:00
foreman f7ea0599f8 P4 to Git Change 1476932 by kzhuravl@kzhuravl-fiji-ocllc on 2017/10/31 16:10:43 
SWDEV-102733 - Bring CMakeLists.txt in sync with open source

	 - Remove extra empty lines
	 - Add new lines at the end of files

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#17 edit
... //depot/stg/opencl/drivers/opencl/tools/clinfo/CMakeLists.txt#4 edit


[ROCm/clr commit: 5c24331d20]
 2017-10-31 16:19:51 -04:00
foreman 5c24331d20 P4 to Git Change 1476932 by kzhuravl@kzhuravl-fiji-ocllc on 2017/10/31 16:10:43 
SWDEV-102733 - Bring CMakeLists.txt in sync with open source

	 - Remove extra empty lines
	 - Add new lines at the end of files

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#17 edit
... //depot/stg/opencl/drivers/opencl/tools/clinfo/CMakeLists.txt#4 edit
 2017-10-31 16:19:51 -04:00
foreman 3698a97a23 P4 to Git Change 1476932 by kzhuravl@kzhuravl-fiji-ocllc on 2017/10/31 16:10:43 
SWDEV-102733 - Bring CMakeLists.txt in sync with open source

	 - Remove extra empty lines
	 - Add new lines at the end of files

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#17 edit
... //depot/stg/opencl/drivers/opencl/tools/clinfo/CMakeLists.txt#4 edit


[ROCm/clr commit: d52e0bf530]
 2017-10-31 16:19:51 -04:00
foreman d52e0bf530 P4 to Git Change 1476932 by kzhuravl@kzhuravl-fiji-ocllc on 2017/10/31 16:10:43 
SWDEV-102733 - Bring CMakeLists.txt in sync with open source

	 - Remove extra empty lines
	 - Add new lines at the end of files

Affected files ...

... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#17 edit
... //depot/stg/opencl/drivers/opencl/tools/clinfo/CMakeLists.txt#4 edit
 2017-10-31 16:19:51 -04:00
Shaoyun Liu 55fc06dac3 Add asic id for gfx906 on emulator 
On thunk level, gfx906 works same as gfx900 chip

Change-Id: I727bd904284616f3b1b9b911e41ad0f19318b3ee
Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>
 2017-10-31 14:58:09 -04:00
Shaoyun Liu a068301408 Add asic id for gfx906 on emulator 
On thunk level, gfx906 works same as gfx900 chip

Change-Id: I727bd904284616f3b1b9b911e41ad0f19318b3ee
Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>


[ROCm/ROCR-Runtime commit: 55fc06dac3]
 2017-10-31 14:58:09 -04:00
Siu Chi Chan 2094b92a3e Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11 
[ROCm/clr commit: c1a4ff7b20]
 2017-10-31 18:16:12 +00:00
Siu Chi Chan c1a4ff7b20 Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11 2017-10-31 18:16:12 +00:00
Siu Chi Chan 99d32a195f Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11 2017-10-31 18:16:12 +00:00
Siu Chi Chan b04f17be8f use libc++ on centos 7 and rhel 7.4 
[ROCm/clr commit: cb454d5366]
 2017-10-31 18:14:07 +00:00
Siu Chi Chan cb454d5366 use libc++ on centos 7 and rhel 7.4 2017-10-31 18:14:07 +00:00
Siu Chi Chan cd6996614f use libc++ on centos 7 and rhel 7.4 2017-10-31 18:14:07 +00:00
Maneesh Gupta c1639486c6 Merge pull request #197 from bensander/update_coherency_tests 
Update coherency tests

[ROCm/clr commit: a6458616f5]
 2017-10-31 17:26:50 +05:30
Maneesh Gupta a6458616f5 Merge pull request #197 from bensander/update_coherency_tests 
Update coherency tests
 2017-10-31 17:26:50 +05:30
Maneesh Gupta f27c2c1715 Merge pull request #197 from bensander/update_coherency_tests 
Update coherency tests
 2017-10-31 17:26:50 +05:30
Maneesh Gupta 6b6d28479d Merge pull request #241 from ROCm-Developer-Tools/multi_host 
Inital codes to remove x86_64 dependency in HIP source build

[ROCm/clr commit: fc5a86d595]
 2017-10-31 16:35:12 +05:30
Maneesh Gupta fc5a86d595 Merge pull request #241 from ROCm-Developer-Tools/multi_host 
Inital codes to remove x86_64 dependency in HIP source build
 2017-10-31 16:35:12 +05:30
Maneesh Gupta 4d85b6ab29 Merge pull request #241 from ROCm-Developer-Tools/multi_host 
Inital codes to remove x86_64 dependency in HIP source build
 2017-10-31 16:35:12 +05:30
Maneesh Gupta 25389f4fcc Merge pull request #242 from bensander/time_hip_apis 
Add ns-level timer for HIP API routines

[ROCm/clr commit: 5e1a721a05]
 2017-10-31 16:33:46 +05:30