SWDEV-130722 - Channel order in an interop buffer from OpenCL to OpenGL is flipped on Vega
OCL calls glGetTexLevelParameteriv_ function to get the internal GL format but this format is the one chosen by app in OGL API such as glTexImage2D.
The issue is that OGL sometimes selects a different format than defined in the glTexImage2D and this causes some issues in cl_gl interop. One example is shown below
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA/**internal format**/, width, height, 0, GL_BGRA/**external format**/, GL_UNSIGNED_BYTES, NULL);
in this case GL_RGBA is selected by app as the internal format but OGL switches to BGRA8 internally and causes an issue later in cl_gl interop (i.e., R and B channels are swapped) because OCL gets GL_RGBA as the internal format in the glGetTexLevelParameteriv_ call.
To avoid this issue, OCL needs to query the real internal gl format in wglResourceAttachAMD and adjusts the CL format accordingly.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13408/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevicegl.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#35 edit
SWDEV-2 - Change OpenCL version number from 2492 to 2493.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2240 edit
[ROCm/clr commit: a90c0025a4]
SWDEV-2 - Change OpenCL version number from 2492 to 2493.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2240 edit
SWDEV-131497 - [CQE OCL][Vega10][OclTst][QR][DTB-Blocker] 'Spir' test of OCLTST is crashing randomly 3/10 times; Faulty CL# 1451293
- The test doesn't release command queues, which may cause a crash on the device destruction. Force the app's queue destruction if the app didn't release them.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#54 edit
[ROCm/clr commit: d3d97c5010]
SWDEV-131497 - [CQE OCL][Vega10][OclTst][QR][DTB-Blocker] 'Spir' test of OCLTST is crashing randomly 3/10 times; Faulty CL# 1451293
- The test doesn't release command queues, which may cause a crash on the device destruction. Force the app's queue destruction if the app didn't release them.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#54 edit
SWDEV-2 - Change OpenCL version number from 2491 to 2492.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2239 edit
[ROCm/clr commit: b71ee777ff]
SWDEV-2 - Change OpenCL version number from 2491 to 2492.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2239 edit
SWDEV-79278 - [OCL][PAL] refactoring PAL Null device create function to account for creating all the gfx9+ subtarget devices such as gfx901/gfx902/etc
ReviewboardURL = http://ocltc.amd.com/reviews/r/13378/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#53 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#18 edit
[ROCm/clr commit: 9772217dcb]
SWDEV-79278 - [OCL][PAL] refactoring PAL Null device create function to account for creating all the gfx9+ subtarget devices such as gfx901/gfx902/etc
ReviewboardURL = http://ocltc.amd.com/reviews/r/13378/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#53 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#18 edit
SWDEV-131493 - [CQE OCL][Vega10][QR][DTB-Blocker] Soft Hang is observed while running 'Mipmaps-clCopyImage' tests of WF Conformance due to Faulty CL# 1451293
Multiple runtime locks could conflict each other:
- Remove PAL lock from the resource creation/destruction. PAL should be thread safe for those operations.
- Avoid queue execution lock for a mipmap view destruction in submitUnmapMemory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#55 edit
[ROCm/clr commit: 6b103f1bf6]
SWDEV-131493 - [CQE OCL][Vega10][QR][DTB-Blocker] Soft Hang is observed while running 'Mipmaps-clCopyImage' tests of WF Conformance due to Faulty CL# 1451293
Multiple runtime locks could conflict each other:
- Remove PAL lock from the resource creation/destruction. PAL should be thread safe for those operations.
- Avoid queue execution lock for a mipmap view destruction in submitUnmapMemory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#55 edit
SWDEV-79278 - [OCL] Dont add gfx9+ devices into offline devices list in orca path as they will be added in pal.
ReviewboardURL = http://ocltc.amd.com/reviews/r/13396/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#569 edit
[ROCm/clr commit: 121ffcc6ec]
SWDEV-79278 - [OCL] Dont add gfx9+ devices into offline devices list in orca path as they will be added in pal.
ReviewboardURL = http://ocltc.amd.com/reviews/r/13396/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#569 edit
SWDEV-131312 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] Compubench test are not completing due to faulty CL#1451293
- Mark active vgpu only for pinned memory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#16 edit
[ROCm/clr commit: 57cfc57a45]
SWDEV-131312 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] Compubench test are not completing due to faulty CL#1451293
- Mark active vgpu only for pinned memory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#16 edit
SWDEV-131311 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] BasemarkCL test are not completing due to faulty CL#1451293
- After a view destruction the original object is no longer can be associated with a vgpu
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#33 edit
[ROCm/clr commit: ab82101b73]
SWDEV-131311 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] BasemarkCL test are not completing due to faulty CL#1451293
- After a view destruction the original object is no longer can be associated with a vgpu
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#33 edit
SWDEV-2 - Change OpenCL version number from 2490 to 2491.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2238 edit
[ROCm/clr commit: 38a9a7201e]
SWDEV-2 - Change OpenCL version number from 2490 to 2491.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2238 edit
Blocks inside of HsaCounterProperties structure is not a fixed size. It
varies with number of counters in the block -- size of Counters in
HsaCounterBlockProperties is different in every block. Current
implementation assumes fixed size and the next block will overwrite the
previous block's Counters. This patch change the array implementation to
using a pointer so it'll move the next block to the correction position.
Change-Id: I72800f4db5f2a68215fba477a61ca07ec99054bf
Signed-off-by: Amber Lin <Amber.Lin@amd.com>
Blocks inside of HsaCounterProperties structure is not a fixed size. It
varies with number of counters in the block -- size of Counters in
HsaCounterBlockProperties is different in every block. Current
implementation assumes fixed size and the next block will overwrite the
previous block's Counters. This patch change the array implementation to
using a pointer so it'll move the next block to the correction position.
Change-Id: I72800f4db5f2a68215fba477a61ca07ec99054bf
Signed-off-by: Amber Lin <Amber.Lin@amd.com>
[ROCm/ROCR-Runtime commit: 117fa5034b]
SWDEV-2 - Change OpenCL version number from 2489 to 2490.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2237 edit
[ROCm/clr commit: 86752f8861]
SWDEV-2 - Change OpenCL version number from 2489 to 2490.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2237 edit
SWDEV-86035 - Code clean-up
- Use TS check first to avoid LogError
- Reset VirtualGPU reference if resource was cached
- Lock active VirtualGPU on release, since a cached resource can have access to that queue from another thread
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#30 edit
[ROCm/clr commit: 38c1488dfd]
SWDEV-86035 - Code clean-up
- Use TS check first to avoid LogError
- Reset VirtualGPU reference if resource was cached
- Lock active VirtualGPU on release, since a cached resource can have access to that queue from another thread
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#30 edit
SWDEV-79278 - [OCL][NV10] adding Pal::GfxIpLevel::GfxIp10 into couple of places and fixing a typo in GfxIpDeviceInfo table (gfx801 should be 810)
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13369/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#28 edit
SWDEV-2 - Change OpenCL version number from 2488 to 2489.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2236 edit
[ROCm/clr commit: 06c254beb0]
SWDEV-2 - Change OpenCL version number from 2488 to 2489.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2236 edit
foreman
Rahul Garg
Amber Lin
Sean Keely
Laurent Morichetti
Jenkins
Ben Sander