Commit Graph

104 Commits

Author SHA1 Message Date
Oliveira, Daniel a2f04dd3bc fix: [rocm/amd_smi_lib] header cleanup Remove non-unified headers
Cleans up individual gpu metric APIs which will be implemented according to 'unified-headers' standards

Code changes related to the following:
  * '_get_gpu_metrics_' APIs
  * Functional tests

Change-Id: I2dd2ecde11c1d77e343e0ae0e10aeb9120ae9b99
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>


[ROCm/amdsmi commit: 55734d2d7a]
2024-01-26 10:38:48 -05:00
Charis Poag f357c180e7 Fix metric type error output + re-align with ROCm SMI metrics
Changes:
* [CLI] Provide fix for "/opt/rocm/bin/amd-smi metric
TypeError: '>' not supported between instances of 'str' and 'i"
--> Python API was updated, CLI needed to reflect these changes
* [API] Updated amdsmi.h's with ROCm SMI
--> Incorrectly added mem_bandwidth_acc & mem_max_bandwidth
--> Realigned wrapper with updates
* [Test] Added metrics not shown in gpu_metrics_read.cc

Change-Id: Ia3a172377fd5a582254dd5a46d81dbec7e763cd9
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 34bd26c68e]
2024-01-24 21:23:40 -06:00
Charis Poag 601a254f37 Fix GPU metric tests & cleanup test output
- CLI: Added average_power to display if current_power is empty
    - CLI: fixed PCIe current_speed not displaying GT/s
    - ROCm API: 1.3 & 1.4
                -> commented out setting avg clocks to current clock value
(leave as max uint value, not re-assign; these are not same values)
                    -> commented out setting current_socket_power = average_power
(leave as max uint value, not re-assign; these are not same values)
                    -> For all non-array clocks, placed value in first
                        array[0] to keep outputs consistent
                    (helps xcd calc)
      - ROCm API: rsmi_dev_metrics_curr_gfxclk_get fixed to count
        XCDs using backwards compatible rsmi_dev_gpu_metrics_info_get.
      - ^ Fixes XCD count overall + assigning clock[0] in 1.3 to curr
        freq
      - AMD SMI API: amdsmi_get_gpu_metrics_info() initialized all new
        1.5 metric values for all lower metric tables
      - AMD SMI API: wrapper -> fix is here + returns correct AMD SMI return
      - AMD SMI API: wrapper -> now displays amdsmi return status as
        string in logs
      - gpu_metrics_read.cc -> now has better overview of backwards
        compatible output
      - gpu_metrics_read.cc -> Cleaned up output, added units, and
        display all array output

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
Change-Id: Id5b60ded5b0ed2cdf0f96ca72c79e356f0410960


[ROCm/amdsmi commit: 5ff5af0b5a]
2023-12-19 14:18:15 -05:00
Maisam Arif ff96f50145 Refactor gpu_metrics usage in libraries
Signed-off-by: Maisam Arif <maisarif@amd.com>
Change-Id: I763638d4b546bf49b234e823df81028c357e8f49


[ROCm/amdsmi commit: d790ebc62b]
2023-11-22 03:32:15 -06:00
Maisam Arif 0a20cc33ab Updated License Dates
Signed-off-by: Maisam Arif <maisarif@amd.com>
Change-Id: Id6fd66b03c602232ecc1a063a534a15fe3a03f56


[ROCm/amdsmi commit: 5dba2f3120]
2023-11-07 03:57:08 -05:00
Galantsev, Dmitrii e5d0ba249d Merge rocmsmi/amd-staging into amd-dev 20231103
Change-Id: Ie70ab54a63b25649b6b9d30620c5546dc66cd766
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 513dd8a445]
2023-11-03 02:55:02 -05:00
Galantsev, Dmitrii 21fa9c0950 SWDEV-424983 - Fix supported metrics api checks
Change-Id: I5c95bb3057dd7546036cbd87bbf7025469d2b3d5
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 88d5e011e6]
2023-10-30 17:28:59 -04:00
Galantsev, Dmitrii 553a05efec Merge rocmsmi/amd-staging into amd-dev 20231016
Change-Id: I137171162a64af4960d82336cc517c1b34a870f3
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: df4f5e8bf8]
2023-10-16 14:31:13 -05:00
Galantsev, Dmitrii e3ee60fc5e Merge rocmsmi/amd-staging into amd-dev 20231010
Change-Id: I492562094a004eb78b2cc2b52d14d013d9f97112
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 6d72d65c48]
2023-10-11 18:58:12 -05:00
Galantsev, Dmitrii 1b4acb28f8 Merge remote-tracking branch 'rocmsmi/amd-staging' into amd-dev
Change-Id: I6037383a3efa777cc281a992fd9aa11d8e9ced28


[ROCm/amdsmi commit: 3d3759061a]
2023-10-04 19:11:59 -05:00
Galantsev, Dmitrii 49553cf896 Merge remote-tracking branch 'rocmsmi/amd-staging' into HEAD
Change-Id: I0661926c10eef2bc32b83d9a63a3a6eb6991e781


[ROCm/amdsmi commit: 31cc2eecfb]
2023-09-25 04:35:53 -05:00
Galantsev, Dmitrii 43591c22cf Merge remote-tracking branch 'rocmsmi/amd-staging' into HEAD
Change-Id: I65ed7f3a0d1b6e58bc8377932d7c39db21d1b422


[ROCm/amdsmi commit: 5c41319c83]
2023-09-21 23:43:20 -05:00
Maisam Arif 806adfa83c SWDEV-412847 - Changed junction to hotspot
Change-Id: I7f6c1a0a77e6a09d2a3e831463cf03e35266bf40
Signed-off-by: Maisam Arif <maisarif@amd.com>


[ROCm/amdsmi commit: d2ef113457]
2023-09-14 17:43:26 -05:00
Bill(Shuzhou) Liu 8a4aead84b Add API for the memory type
Get the memory type from libdrm and add a new API.

Change-Id: I89327bca2ef860f2e3f4f6ca20def2331eba66c0


[ROCm/amdsmi commit: b52034fed8]
2023-09-07 13:05:58 -05:00
Bill(Shuzhou) Liu 9869516963 Support PCIe vendor name
Add the support for PCIe vendor name.

Change-Id: Ibc1d289a08731e4c5a14f992f3b0d31b51482396


[ROCm/amdsmi commit: 9021ef96dc]
2023-08-28 16:46:43 -05:00
Galantsev, Dmitrii a464b0d202 Merge remote-tracking branch 'rocmsmi/amd-staging' into amd-dev
Change-Id: I7a35220a2283b92c5b4825ee99d6693401ef8e1e


[ROCm/amdsmi commit: 14190c5a94]
2023-08-28 16:01:19 -05:00
Galantsev, Dmitrii 413698396a Merge remote-tracking branch 'rocmsmi/amd-staging' into amd-dev
Change-Id: I9c38b4facd472b877d1ad133f3176a023c890955
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 936719eeb6]
2023-08-23 16:04:15 -05:00
Maisam Arif 9a98e0e317 Updated Versioning
corrected to amd-smi version from rocm-smi version
	Added newline characters in the gpu choices
	Updated cli versioning to 23.2.1.0 to match amd-smi

Signed-off-by: Maisam Arif <maisarif@amd.com>
Change-Id: Ia6db3a281e2349e05a09209bdcfdfa5ac48e3a86


[ROCm/amdsmi commit: ca59a60a9a]
2023-08-01 14:28:27 -04:00
Bill(Shuzhou) Liu fa6f0f5ea0 Fix unit test errors
Add unit test error handling for set freq and volt.

Change-Id: I5877f8300b942caac8f38e6efc03264bfc432def


[ROCm/amdsmi commit: 4307330cb0]
2023-07-12 09:39:39 -04:00
Bill(Shuzhou) Liu 262ef9dba1 Fix fan write unit test failure
Even if fan speed can be read, sometimes the set is not supported.

Change-Id: I8584e6fe170c34144800af78d76f04234def11c8


[ROCm/amdsmi commit: 9e2fcd0e40]
2023-06-29 07:58:23 -05:00
Maisam Arif a3ec450571 Cleaned up APIs
Change-Id: I93487e01d7126bdfa77439b571df927a6af3bb70
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 9cebc93cee]
2023-06-07 10:48:37 -04:00
Bill(Shuzhou) Liu 58962bb075 Clean up the APIs
Remove and rename APIs after review.

Change-Id: I5464f200eb605b366673f8abca95183c3837843b


[ROCm/amdsmi commit: 62ce965409]
2023-05-30 16:08:54 -04:00
Dalibor Stanisavljevic d95be94e51 SWDEV-384793 - Clean up API
Change-Id: I441b315d32df59a454e06d521e5ca8b2c229451a
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: 1bc1d431d8]
2023-05-19 16:40:26 +02:00
Bill(Shuzhou) Liu da3da06941 Return NOT_SUPPORT for set function in VM guest
Fix the unit tests which are fail in VM guest environment.

Change-Id: Id7c58887692bbdecba54f5d2d8463b292e19b4ad


[ROCm/amdsmi commit: dc4ba12e00]
2023-05-11 10:42:55 -05:00
Suma Hegde 90607682ef Renamed APIs
amdsmi_dev_open_supported_func_iterator -> amdsmi_open_supported_func_iterator
amdsmi_dev_open_supported_variant_iterator -> amdsmi_open_supported_variant_iterator
amdsmi_dev_close_supported_func_iterator -> amdsmi_close_supported_func_iterator

Change-Id: Ie9b2efa5aee7095c3c835b91de1951df6b065510


[ROCm/amdsmi commit: edd8f1ae23]
2023-05-11 11:01:37 -04:00
Suma Hegde 19262e1fd8 Renamed API amdsmi_dev_reset_xgmi_error
amdsmi_dev_reset_xgmi_error -> amdsmi_reset_gpu_xgmi_error

grep -rli 'amdsmi_dev_reset_xgmi_error' * | xargs -i@ sed -i
's/amdsmi_dev_reset_xgmi_error/amdsmi_reset_gpu_xgmi_error/g' @

Change-Id: Ic7e4c4b345fdf6187aed42d53fb7ae8536c2edea


[ROCm/amdsmi commit: 6256bf6f1a]
2023-05-11 11:01:25 -04:00
Suma Hegde 0be5a5fb82 Renamed APIs
amdsmi_dev_get_gpu_ecc_status -> amdsmi_get_gpu_ecc_status
amdsmi_dev_get_gpu_ecc_enabled -> amdsmi_get_gpu_ecc_enabled
amdsmi_dev_get_gpu_ecc_count -> amdsmi_get_gpu_ecc_count

Change-Id: I84e6489f82bae115e1a13c9e4fce8029888ca379


[ROCm/amdsmi commit: d9ba131f73]
2023-05-11 11:00:59 -04:00
Deepak Mewar e0d2d9b909 Renamed APIs
1) amdsmi_dev_set_overdrive_level to amdsmi_set_gpu_overdrive_level
2) amdsmi_dev_set_overdrive_level_v1 to amdsmi_set_gpu_overdrive_level_v1

grep -rli 'amdsmi_dev_set_overdrive_level' * | xargs -i@ sed -i
's/amdsmi_dev_set_overdrive_level/amdsmi_set_gpu_overdrive_level/g' @

Change-Id: Id6934e5b0962c9262cca041bdfdf02c60f69573b


[ROCm/amdsmi commit: e687a72235]
2023-05-11 11:00:45 -04:00
Deepak Mewar 9d23ac40c6 Renamed API amdsmi_dev_get_od_volt_curve_regions
to amdsmi_get_gpu_od_volt_curve_regions

grep -rli 'amdsmi_dev_get_od_volt_curve_regions' * | xargs -i@ sed -i
's/amdsmi_dev_get_od_volt_curve_regions/amdsmi_get_gpu_od_volt_curve_regions/g' @

Change-Id: I4b390c2d5173ca919c4ab5b1173a4fc40e2a0015


[ROCm/amdsmi commit: ced22230c4]
2023-05-11 11:00:33 -04:00
Deepak Mewar a970cea1b0 Renamed API amdsmi_dev_set_od_volt_info
to amdsmi_set_gpu_od_volt_info

grep -rli 'amdsmi_dev_set_od_volt_info' * | xargs -i@ sed -i
's/amdsmi_dev_set_od_volt_info/amdsmi_set_gpu_od_volt_info/g' @

Change-Id: I2364f9f555c010e1022e2c946a65b72fcf3d2233


[ROCm/amdsmi commit: 467f3e3bb7]
2023-05-11 10:59:51 -04:00
Deepak Mewar 19d30f71bd Renamed API amdsmi_dev_set_od_clk_info
to amdsmi_set_gpu_od_clk_info

grep -rli 'amdsmi_dev_set_od_clk_info' * | xargs -i@ sed -i
's/amdsmi_dev_set_od_clk_info/amdsmi_set_gpu_od_clk_info/g' @

Change-Id: I0f1fd5a80322a544f7d25e09146c9e52b82091f6


[ROCm/amdsmi commit: a72e1ec91d]
2023-05-11 10:59:25 -04:00
Deepak Mewar cd81fa970d Renamed API amdsmi_dev_get_od_volt_info
to amdsmi_get_gpu_od_volt_info

grep -rli 'amdsmi_dev_get_od_volt_info' * | xargs -i@ sed -i
's/amdsmi_dev_get_od_volt_info/amdsmi_get_gpu_od_volt_info/g' @

Change-Id: Icd8658509b28523b7c04f8d2c53efb82689e294b


[ROCm/amdsmi commit: 2bd94db02c]
2023-05-11 10:59:11 -04:00
Deepak Mewar 6229bac89b Renamed API amdsmi_dev_get_overdrive_level
to amdsmi_get_gpu_overdrive_level

grep -rli 'amdsmi_dev_get_overdrive_level' * | xargs -i@ sed -i
's/amdsmi_dev_get_overdrive_level/amdsmi_get_gpu_overdrive_level/g' @

Change-Id: Id33a4544a2f2fd9d77de601addcf4e45d09d65d1


[ROCm/amdsmi commit: 78ce4979e1]
2023-05-11 10:59:00 -04:00
Deepak Mewar f9e0851070 Renamed API amdsmi_dev_xgmi_error_status
to amdsmi_gpu_xgmi_error_status

grep -rli 'amdsmi_dev_xgmi_error_status' * | xargs -i@ sed -i
's/amdsmi_dev_xgmi_error_status/amdsmi_gpu_xgmi_error_status/g' @

Change-Id: I0d2338f0e924da5d69d280fdd988c2a6f9fe4ace


[ROCm/amdsmi commit: d83dc2b005]
2023-05-11 10:58:49 -04:00
Deepak Mewar 3be8f88cab Renamed API amdsmi_counter_get_available_counters
to amdsmi_get_gpu_available_counters

grep -rli 'amdsmi_counter_get_available_counters' * | xargs -i@ sed -i
's/amdsmi_counter_get_available_counters/amdsmi_get_gpu_available_counters/g' @

Change-Id: Ief60be6c95f2ea4d0f6f91b153263d95710e6942


[ROCm/amdsmi commit: 0cb9e157db]
2023-05-11 10:56:57 -04:00
Deepak Mewar 1894e4d345 Renamed API amdsmi_read_counter
to amdsmi_gpu_read_counter

grep -rli 'amdsmi_read_counter' * | xargs -i@ sed -i
's/amdsmi_read_counter/amdsmi_gpu_read_counter/g' @

Change-Id: Ie9fec914358dd901930db54ab94e05f2fe32fa5a


[ROCm/amdsmi commit: 7a6c26244e]
2023-05-11 10:55:52 -04:00
Deepak Mewar c70ff3cbed Renamed API amdsmi_control_counter
to amdsmi_gpu_control_counter

grep -rli 'amdsmi_control_counter' * | xargs -i@ sed -i
's/amdsmi_control_counter/amdsmi_gpu_control_counter/g' @

Change-Id: Ibdcd32327ebd2646375fb5c3b913cb528ac8aa97


[ROCm/amdsmi commit: 6e1a72d2c1]
2023-05-11 10:55:36 -04:00
Deepak Mewar ca4b919b16 Renamed API amdsmi_dev_destroy_counter
to amdsmi_gpu_destroy_counter

grep -rli 'amdsmi_dev_destroy_counter' * | xargs -i@ sed -i
's/amdsmi_dev_destroy_counter/amdsmi_gpu_destroy_counter/g' @

Change-Id: I328f65f5a2a86108ee5b217f95ed0f4f03745286


[ROCm/amdsmi commit: e6dd8d49ba]
2023-05-11 10:55:22 -04:00
Deepak Mewar 69267f01c1 Renamed API amdsmi_dev_create_counter
to amdsmi_gpu_create_counter

grep -rli 'amdsmi_dev_create_counter' * | xargs -i@ sed -i
's/amdsmi_dev_create_counter/amdsmi_gpu_create_counter/g' @

Change-Id: Ic296057314f98547dd6a01b1c7d51668cfe5bc9a


[ROCm/amdsmi commit: 0c435b81c2]
2023-05-11 10:55:06 -04:00
Deepak Mewar 22ad287cbf Renamed API amdsmi_dev_counter_group_supported
to amdsmi_gpu_counter_group_supported

grep -rli 'amdsmi_dev_counter_group_supported' * | xargs -i@ sed -i
's/amdsmi_dev_counter_group_supported/amdsmi_gpu_counter_group_supported/g' @

Change-Id: I69a5534f779dc0013bbe75b3d9b2c6074b2f378b


[ROCm/amdsmi commit: fb419ab655]
2023-05-11 10:54:57 -04:00
Deepak Mewar 370168e42c Renamed API amdsmi_init_event_notification
to amdsmi_init_gpu_event_notification

grep -rli 'amdsmi_init_event_notification' * | xargs -i@ sed -i
's/amdsmi_init_event_notification/amdsmi_init_gpu_event_notification/g' @

Change-Id: I6a45d38836f9d4221e3e5159370d4b6791fecca5


[ROCm/amdsmi commit: 2ad8b91e0e]
2023-05-11 10:54:41 -04:00
Deepak Mewar b3dac649d9 Renamed API amdsmi_set_event_notification_mask
to amdsmi_set_gpu_event_notification_mask

grep -rli 'amdsmi_set_event_notification_mask' * | xargs -i@ sed -i
's/amdsmi_set_event_notification_mask/amdsmi_set_gpu_event_notification_mask/g' @

Change-Id: Id4b9b6bc31f438b6d4d584142c8814f091b4b553


[ROCm/amdsmi commit: 828908424d]
2023-05-11 10:54:30 -04:00
Deepak Mewar 3dd6db2044 Renamed API amdsmi_stop_event_notification
to amdsmi_stop_gpu_event_notification

grep -rli 'amdsmi_stop_event_notification' * | xargs -i@ sed -i
's/amdsmi_stop_event_notification/amdsmi_stop_gpu_event_notification/g' @

Change-Id: If6b7ca238a911cef37306c0b623e219f7ee43225


[ROCm/amdsmi commit: 0bfc2a37aa]
2023-05-11 10:54:22 -04:00
Deepak Mewar 19eefc2c69 Renamed API amdsmi_get_event_notification
to amdsmi_get_gpu_event_notification

grep -rli 'amdsmi_get_event_notification' * | xargs -i@ sed -i
's/amdsmi_get_event_notification/amdsmi_get_gpu_event_notification/g' @

Change-Id: I587f1fa785fabbd5347dca886636a81e3c2d1003


[ROCm/amdsmi commit: 6d6d8ce819]
2023-05-11 10:54:07 -04:00
Deepak Mewar 8bc7c2acc9 Renamed API amdsmi_get_compute_process_gpus
to amdsmi_get_gpu_compute_process_gpus

grep -rli 'amdsmi_get_compute_process_gpus' * | xargs -i@ sed -i
's/amdsmi_get_compute_process_gpus/amdsmi_get_gpu_compute_process_gpus/g' @

Change-Id: I230bbf85e96983f9e0d2e3c61464c2bf4b353a95


[ROCm/amdsmi commit: 26f8190cb4]
2023-05-11 10:53:48 -04:00
Deepak Mewar 48aa5df6ef Renamed APIs
1) amdsmi_get_compute_process_info to
   amdsmi_get_gpu_compute_process_info
2) amdsmi_get_compute_process_info_by_pid to
   amdsmi_get_gpu_compute_process_info_by_pid

grep -rli 'amdsmi_get_compute_process_info' * | xargs -i@ sed -i
's/amdsmi_get_compute_process_info/amdsmi_get_gpu_compute_process_info/g' @

Change-Id: Ia5c9c22d1466ecea27d3ae3025b3b87db75853e2


[ROCm/amdsmi commit: f3854b3d5f]
2023-05-11 10:53:41 -04:00
Deepak Mewar 2e060f2934 Renamed API amdsmi_dev_get_ecc_status
to amdsmi_dev_get_gpu_ecc_status

grep -rli 'amdsmi_dev_get_ecc_status' * | xargs -i@ sed -i
's/amdsmi_dev_get_ecc_status/amdsmi_dev_get_gpu_ecc_status/g' @

Change-Id: I11f9b818e251684d688f266e8721ff7a9277f6bd


[ROCm/amdsmi commit: 7232a79e18]
2023-05-11 10:52:32 -04:00
Deepak Mewar 6d927b285c Renamed API amdsmi_dev_get_ecc_enabled
to amdsmi_dev_get_gpu_ecc_enabled

grep -rli 'amdsmi_dev_get_ecc_enabled' * | xargs -i@ sed -i
's/amdsmi_dev_get_ecc_enabled/amdsmi_dev_get_gpu_ecc_enabled/g' @

Change-Id: I8cb31a2fc4128758a3545e1d17f743a6eff152a0


[ROCm/amdsmi commit: 4347ad6a0c]
2023-05-11 10:51:57 -04:00
Deepak Mewar 60e0a30dfe Renamed API amdsmi_dev_get_ecc_count
to amdsmi_dev_get_gpu_ecc_count

grep -rli 'amdsmi_dev_get_ecc_count' * | xargs -i@ sed -i
's/amdsmi_dev_get_ecc_count/amdsmi_dev_get_gpu_ecc_count/g' @

Change-Id: I851aeec18de1e2151f74f39a149c6ddd53eee695


[ROCm/amdsmi commit: 8c76a96cfb]
2023-05-11 10:50:46 -04:00
Deepak Mewar 971ff06772 Renamed API amdsmi_dev_get_power_profile_presets
to amdsmi_get_gpu_power_profile_presets

grep -rli 'amdsmi_dev_get_power_profile_presets' * | xargs -i@ sed -i
's/amdsmi_dev_get_power_profile_presets/amdsmi_get_gpu_power_profile_presets/g' @

Change-Id: Iff3d22517a4c5ece5efe4738618f74946cf600bd


[ROCm/amdsmi commit: 64e8d81af4]
2023-05-11 10:49:30 -04:00