The following snippets has different behaviour based on platform.
printf("%p", 0x123abc);
Linux -> 0x123abc
Windows -> 123ABC
printf("%p", nullptr);
Linux -> (nil)
Windows -> 0000000000000000
%p specifier according to C spec is implementation defined, so we need
to adjust the reference string to be correct on Windows.
Change-Id: I7059fa0f6cde611718bd76655637670fcbccf43c
[ROCm/clr commit: 4dd4d8c05f]
The current implementation in ROCclr for callback is
based on OCL specification. If in HIP the same command
could get multiple callbacks, then ROCclr will process them in
a reverse order. Unique Markers for each callback will make
sure it won't happen.
Add a dependency wait for callbacks, since HSA signal callback
doesn't guarantee the order.
Change-Id: I9d514734e258312fe9a74d48132361eb17c52d67
[ROCm/clr commit: e48111bfce]
With direct dispatch enqueue occurs before callback update and
it can't be tracked in the device backend
Change-Id: Ie8793e3ddb68cc5bb36348f7a8dcdbdc87a2487c
[ROCm/clr commit: b0402a95bf]
Some upstream will load hip multiple times thus Rocclr static lib will
be linked to hip::amdhip64 many times. This will bring some unexpected
issues such as in hipBLAS. The patch prevents his happening.
Change-Id: I6bb27659f74371dae6e59c59fd6bb2022cc062ff
[ROCm/clr commit: f65348cfbe]
Flags of NVCC_OPTIONS need be sent to linker. Because compiler and
linker flager are mixed in NVCC_OPTIONS.
Change-Id: I3db37b962808566ea145e3cbdefa66d373e2d360
[ROCm/clr commit: f727a048d3]
which can cause segmentation faults. Hence checking for its sanity
Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7
[ROCm/clr commit: b9c0065e4f]
This reverts commit be82aa43fb.
Hold wall time related updates till direct dispatch is ready.
Change-Id: I53b232f6f51bc2fc71b6b639fe0081e2907e9707
[ROCm/clr commit: 62c278c39d]
[dtest] Tests for hipEvent related APIs
Added Negative scenarios for hipEvent related APIs
1. Verifying all hipEvent related APIs by passing nullptr.
2. Pass illegal/unknown flag to hipEventCreateWithFlags API
Change-Id: Ia0a24065d16fe0f5ee28a88e280c25c1be0c3590
[ROCm/clr commit: 2a0593258c]
If MT is enabled, then a new callback can be received before the previous
command is processed, causing a conflict of 2 callbacks.
Change-Id: I5ff8f231208e8d62824d590d3c8e791e8e36affb
[ROCm/clr commit: fe7501a64b]
runtimeApi/event/hipEventElapsedTime will report invalid resource error
on cuda due to wrong calling sequence. The fix will arrange the calling
in right sequence.
Change-Id: I3db28a962888566ea135e3cbdefa68d373e2d369
[ROCm/clr commit: b9cf12e920]
memory/hipMalloc_MultiThreaded_MultiGpu costs too much time to finish.
1 GPU: about 1000s, 2 GPUs: about 2200s
But Jenkin build need quick return and ctest will kill test that last
1500+s. So we need shorten the test time.
Change-Id: I3db27a962808566ea135e3cbdefa66d373e2d369
[ROCm/clr commit: 657a515e60]
Exclude gcc/LaunchKernel from static lib as
it's shared lib test case only
Change-Id: I3db17a962808565ea135e3cbcefa66d373e2d364
[ROCm/clr commit: f055582473]
1. Added 1 scenario to validate value of deviceProp.arch.has* with
value of __HIP_ARCH_HAS_* device flag.
SWDEV-238517 - Enhancing hip unit tests
Change-Id: Idb237a76b75180ce77808853a5351f19077a0d33
[ROCm/clr commit: a28c367ed0]
Added a test to generate a code object for multiple target
architectures (including for the current device),
load and execute the kernel.
SWDEV-238517 for enhancing hip unit tests
Change-Id: I509d01124abdc0495cfc770ab5508738f108c91c
[ROCm/clr commit: 05409f05d0]
This reverts commit 10af608c66.
Reverting since this is dependent on a device libs change which is not yet in mainline.
Change-Id: I094781b868f39995d1eecb41488c1a1a0147b787
[ROCm/clr commit: 18234e1d24]