AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
857 Commits 3 Branches 0 Tags
a8dcdec00ff1e3453c1a86589f3897c8544682c8
Commit Graph

482 Commits

Author SHA1 Message Date
Karl W Schulz a8dcdec00f tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the 
loglevel name in output, but without color

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 69de978d35]
 2024-03-15 09:31:22 -05:00
Karl W Schulz ba4bccbe0f tighten up [analyze] help to be consistent with [profile] help 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 357d225716]
 2024-03-15 09:31:22 -05:00
Karl W Schulz 3a77ecadd3 bug fix for df tracing output - add more function demarcation 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: c29f28e25e]
 2024-03-15 09:31:22 -05:00
Karl W Schulz 624606771f enable more function demarcation for analyze tracing 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 76121f20a9]
 2024-03-15 09:31:22 -05:00
Karl W Schulz 3dbe61f462 logger update: assign color for TRACE level 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 3438bc9d0f]
 2024-03-14 17:37:30 -05:00
Karl W Schulz 8d6a8e3b06 update logging formatter handling for consistent behavior with error messsages 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 69af2ffc83]
 2024-03-14 17:37:30 -05:00
Nick Curtis c5408fb22b fixup MI300 MFMA rate disagreement between SOL and pipeline (#315) 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>

[ROCm/rocprofiler-compute commit: b610e1c27b]
 2024-03-14 10:41:35 -05:00
colramos-amd 0b4ee818ba Update doc samples for new logging output 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: bfef420099]
 2024-03-12 20:17:46 -05:00
colramos-amd b2c4c8a8cc Found a bug in kernel filtering and fixed 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2acc8e98c1]
 2024-03-12 18:21:35 -05:00
colramos-amd 63d52b2e4c Python format 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: cac4b1aff5]
 2024-03-12 16:47:18 -05:00
colramos-amd 1a27707a4d Throw error if user analyzes two of same path (#260, #67) 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: fa7c82de75]
 2024-03-12 16:46:36 -05:00
colramos-amd ff7751724b Fix missing argv in console_warning() 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e7cc326d5a]
 2024-03-12 16:44:02 -05:00
JoseSantosAMD bd4bc51cd4 change stubbed values to hbm bw (#302) 
* change stubbed values to hbm bw

Signed-off-by: Jose Santos <josantos@amd.com>

* Reformat

Signed-off-by: Jose Santos <josantos@amd.com>

* Update analysis_webui.py

remove print statements

Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>

[ROCm/rocprofiler-compute commit: efb8f131ec]
 2024-03-12 16:08:30 -05:00
JoseSantosAMD 513ba356ae Kernel no overwrite (#303) 
* Removing kernel name shortener from profile

-  Kernel name shortener now in analyze
-  db import uses pymongo to import

Signed-off-by: Jose Santos <josantos@amd.com>

* collections now added using pymongo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* kernel_name_shortener shortens dataframes and not a workload

-  argparser: --kernel-verbose to connection group
-  analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
-  db_import: demangle kernel_name dfs

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix db name in pymongo command

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* reformat

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix typo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* remove checker for verbose in profiler_base

Signed-off-by: Jose Santos <josantos@amd.com>

* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc

Signed-off-by: Jose Santos <josantos@amd.com>

* add kernel_verbose to analysis_webui, remove stubbed values

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* Update src/utils/kernel_name_shortener.py

keep console_debug

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/utils/kernel_name_shortener.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 4424f320ad]
 2024-03-12 15:54:52 -05:00
colramos-amd 4fb2f6e2b4 Update DB module for new sysinfo keys 
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 706d3bb9f0]
 2024-03-12 12:24:49 -05:00
Karl W Schulz 69d3de2549 apply formatting 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 458087b425]
 2024-03-12 09:09:46 -05:00
Cole Ramos c9b6cb8f40 Throw error when we cannot read gfx942 details (#310) 
* Throw error when we cannot read gfx942 details

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing my stupid typo

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 267f0842ec]
 2024-03-11 15:26:26 -05:00
Karl W Schulz 28f027c7bf move set_locale_encoding() to occur after logging is setup - allows 
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e85037fdfb]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 6b0a36cb27 Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 5e21dc35fd]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz d4015bd76b Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: ebc9108da0]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz f7fa0b6038 Update src/omniperf_profile/profiler_rocscope.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: e8ca48dc83]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 65c1e2cb9c Update src/omniperf_profile/profiler_base.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 8856480808]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz ed8d923155 Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 523639a7fd]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz eade3386b1 Update src/omniperf_profile/profiler_rocscope.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: af3f006a7e]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz f287aa0fc8 Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 8e45cc897f]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 17565f7752 Update src/omniperf_profile/profiler_base.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: f6d996b085]
 2024-03-11 14:19:01 -05:00
Karl W. Schulz c822d910be Update src/omniperf_base.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: a3b68c7042]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 35a983b85a allow color formatter via env variable OMNIPERF_COLOR=1 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 34070394eb]
 2024-03-11 14:19:01 -05:00
Karl W Schulz fbf3711eb2 apply formatting 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: b27a2b2c10]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 9d7dde19b0 refactor setting of local encoding; remove from top-level omniperf 
wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 27a57bdafb]
 2024-03-11 14:19:01 -05:00
Karl W Schulz aada8d8e92 remove duplicate line after conflict cleanup due to rebase 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: dbba0d418a]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 4aa463a4e6 update log summary at begin of profiling mode 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 594875a974]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 1c3eec3f91 enable file-logger in profiling workflow; turn some info messages into debug 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: f4483e3c4e]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 2d84322ea1 update print_status() to use console logger; convert some info logs to debug logs 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 15c86ba424]
 2024-03-11 14:19:01 -05:00
Karl W Schulz fdbc5565f3 rework of logger.py setup to introduce another setup_file_handler() - 
this function enables file-based logger output for use with profile
mode

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 505e263279]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 4969416e5f use cached loglevel var in arguments to decide on status bar presence 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: a3a0eac80a]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 917b784ead refactor logging initialization into two steps: 
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e24e6c35a5]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 2381bba1cf apply formatter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: df4f881ed3]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 9e06bcb624 adding --quiet and --verbose options to top-level help info; pass 
quiet arg to setup_logging function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2dd72f7366]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 975c2dad8b add quietmode option to setup_logging function 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: abd3d20cb2]
 2024-03-11 14:19:01 -05:00
Karl W Schulz a9cda2ad33 add a exit keyword to console_error function; allows multiple error 
lines prior to code exit

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2b24375e8d]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 7756a5b00b updates for run_prof() routine: 
* add a profileMode keyword option, used to indent profiling output

* update logic if forked process is not successful, output is
  displayed directly with INFO logging or lower; also dispaly output
  in ERROR mode if the process fails

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 377c642ac2]
 2024-03-11 14:19:01 -05:00
Karl W Schulz ab3ce5ecb8 remove duplicate process output within run_prof() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: dcdef37c34]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 89bc098c59 include ERROR delimiter directly for console_error() messsages 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 61267ee262]
 2024-03-11 14:19:01 -05:00
Karl W Schulz a5e23e17fe add a profileMode option to capture_subprocess_output() - includes 
indented output with profiler selection when enabled

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: cc7a725ae8]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 587d55cd9d minor refactor of print_status() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 6bb4210d94]
 2024-03-11 14:19:01 -05:00
Karl W Schulz b948aa6ebf add indent support to console_log() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 63129e4247]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 890154db8e include loglevel function argument to "run_prof" routine 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 34694f86c2]
 2024-03-11 14:19:01 -05:00
Karl W Schulz efc9f72f7a assign loglevel attribute in omniperf base class 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 48de8ae490]
 2024-03-11 14:19:01 -05:00
Karl W Schulz 16f580b992 update setup_logging function to return loglevel; disable inclusion of 
loglevel delimiter in output

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: bdfc536ade]
 2024-03-11 14:19:01 -05:00