Grafico dei commit

164 Commit

Autore SHA1 Messaggio Data
Matt Arsenault 36432be962 Don't directly link pthreads
This was already searching for the right threads library, but ignoring
the result.

Change-Id: I10d898245696135c1ef928c7715efce8ec6b939f
2020-05-01 08:28:36 -04:00
Matt Arsenault b618939e2e Don't emit generated hip_prof_str.h to source directory
The build should never touch the source directory, and only write
generated files to the output directory.

Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.

Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
2020-05-01 08:24:56 -04:00
Matt Arsenault bd4ec781f2 Find python to generate prof API headers.
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.

The top level CMakeLists also repeats exactly this, which should be
fixed.

Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
2020-04-30 18:21:03 -04:00
Michael Hong Bin Liao 977efb14c6 Merge "[vdi] Skip null texture object in hipDestroyTextureObject." into amd-master-next 2020-04-30 16:07:58 -04:00
Payam Ghafari aa950adc73 Merge "renaming vdi to rocclr, part 1" into amd-master-next 2020-04-29 19:42:20 -04:00
Laurent Morichetti 4591b7469e Don't make a copy of the embedded device binaries
Embedded device binaries should not be cloned if we want the ROCR's
code object URI for this binary to point to the container (host
executable or shared library) instead of a memory location.

Depends-On: I7973bb0243f5a2d1b639b8a88445cfe6af919dd7
Change-Id: Id3afc981e027e5371114d011f2caaa6414f5fc58
2020-04-29 18:40:18 -04:00
Payam cb7d3227e8 renaming vdi to rocclr, part 1
Change-Id: Idec9be2b6174217abcebaa1776e59168670740b1
2020-04-29 17:54:37 -04:00
Saleel Kudchadker f52b2d4504 Fix error code when hipEventRecord is not called
Change-Id: I6672d4320280fd87fd2786bc54214d40944da845
2020-04-29 13:13:52 -04:00
Michael LIAO db4bcda1bf [vdi] Skip null texture object in hipDestroyTextureObject.
- To match both CUDA and HCC runtime behavior.

Change-Id: I072b006dd554e17f8341f391d33bf6224a125a7e
2020-04-29 12:20:42 -04:00
German Andryeyev bc65ca64fc Clean-up the list of blocking streams
- Insert the stream into the list on the host queue creation,
instead of stream creation

Change-Id: Ib25053019f7df97e5bc786922a6587b9514852d3
2020-04-29 11:37:43 -04:00
Vlad Sytchenko 89b9befe42 Fix order initialization warning
Change-Id: I77ddf1dbec2d11c273163efae6526d3deca92dbf
2020-04-28 20:07:51 -04:00
Vlad Sytchenko 518be44661 Handle copy cases where the uses pases a bad ptr
Change-Id: I4490b8519e4d0dde25b845f9ca7e81c1d80d4f28
2020-04-28 11:04:29 -04:00
Freddy Paul 2a271dc418 hip-on-vdi: Enable RUNPATH and versioning
1. Enable versioning for HIP libraries
2. Enable RUNPATH on HIP libraries to find ROCm dependencies
3. Control HIP package install using CPACK_INSTALL_PREFIX

Change-Id: I9096da56592e9c78cdba329011f6e1bae99adaa2
2020-04-27 19:48:44 -04:00
kjayapra-amd 19c654e794 SWDEV-232008 - Handle cases where Memcpy size is less than Symbol Size.
Change-Id: I046bc70445dfd4f6fdfd06415f53d1fc06f425b4
2020-04-27 10:47:28 -04:00
root b5031f39b1 Merge master into amd-master-next
Change-Id: I3fc1dc0c860d627053537581e75561e8a7efe327
2020-04-26 22:19:37 +00:00
Michael LIAO f8062c6fbd [vdi] Revise the symbol management.
- As different modules may have symbols with the same name, each symbol
  needs identifying with a pair of the module handle and the symbol
  name.

Change-Id: I85650a787d9a424545154cc40ebd59e706fa358f
2020-04-24 22:28:31 -04:00
German Andryeyev 5a7c094729 SWDEV-232918
hipEventRecord is much slower in hipclang/vdi

- Make sure default streams don't sync each other.
- Add null stream into the list of default streams.
- Code clean-up to simplify queue look-up.

Change-Id: I36e1fc8d86a600e3dce806694d95d146ed8afd03
2020-04-24 14:40:43 -04:00
Michael Hong Bin Liao 2e61683b33 Merge "[vdi] Fix hang due to recursive locking." into amd-master-next 2020-04-24 10:30:26 -04:00
Michael LIAO c56a3ca63e [vdi] Fix hang due to recursive locking.
- Declare recursive lock for global function map.

Change-Id: I3e792e21688c980343c4fd1c61dcad97f7a890cd
2020-04-23 23:32:56 -04:00
kjayapra-amd 92c63384cb SWDEV - 231874 - Do Dword aligned memset if the total size aligns.
Change-Id: Id05db4cfd9c43b2cffa3cec8b02f1cd07f340dd6
2020-04-23 21:08:50 -04:00
Maneesh Gupta f2e1118d7a Merge in the rocclr based hip runtime (#2032)
* Merge master-next changes in master (include vdi development in master branch)
2020-04-23 09:12:06 -07:00
Evgeny Shcherbakov e8d64b509e Merge "cleanup" into amd-master-next 2020-04-22 23:28:22 -04:00
Tao Sang 85abd8f028 Fix hip_get_devices failure in lammps
Support hipDeviceAttributeIntegrated in hipDeviceGetAttribute() with hip-vdi rt

Change-Id: Ie5ba81222af3554a843c184ae75af7f369a3c24b
2020-04-22 15:16:59 -04:00
Evgeny b05e54bf84 cleanup
Change-Id: Ia0ee0e4cab2ee8eaa9931024681d0db5b2802594
2020-04-22 13:42:45 -05:00
Michael LIAO 441284841d [vdi] Refactor texture/surface reference support.
Change-Id: I8014d82aae7139ef5f95e4b50c4fc6da200dbc9d
2020-04-21 11:56:48 -04:00
German Andryeyev 21840ac6a0 SWDEV-231579 - [hipclang-vdi-rocm][perf]
- HIPPerfDispatchSpeed disparity between HIP/HCC vs HIP/VDI
Insert a wait marker command in the default stream only when
HIP has pending operations on other async streams

Change-Id: I68660a54867fab7571ba57eb1df5feb1bca1c61a
2020-04-21 10:05:26 -04:00
kjayapra-amd b3308f7674 SWDEV-229480 - Improve error messages in HIP Layer.
Change-Id: I054b979d3aa6cf6ed4ca14a9393bdcba757772ff
2020-04-20 21:23:52 -04:00
Tao Sang 32130f8ec3 Solve issues with hip-vdi runtime static lib
1.Combine libamdhip64_static_base.a and libamdvdi_static.a into libamdhip64_static.a.
2.Let hipcc use -use-staticlib to link libamdhip64_static.a.
3.Add some samples for static lib.
4.Fix compiling failure of code object.

Change-Id: Ic8c95228eb139058da8b5d66ba8439486154ca6f
2020-04-20 15:37:02 -04:00
Tao Sang a6c6f51926 Revert "Solve issues with hip-vdi runtime static lib"
This reverts commit 5210ee6ca5.

Reason for revert: It is causing dkms-no-npi-hipclang broken.
It is top priority to maintain dkms-no-npi-hipclang build, otherwise we lose track of regression analysis.
So revert the change for now and recommit it after fixing it.

 

Change-Id: Ia5136e888baecb6148c6c18eedbf37066fcb1eaa
2020-04-17 10:13:08 -05:00
Tao Sang 5210ee6ca5 Solve issues with hip-vdi runtime static lib
1.Combine libamdhip64_static_base.a and libamdvdi_static.a into libamdhip64_static.a.
2.Let hipcc use -use-staticlib to link libamdhip64_static.a.
3.Add some samples for static lib.
4.Fix compiling failure of code object.
Change-Id: Ia2333622a8d05639b90974c4c5d3d85654ba0138
2020-04-15 13:46:36 -04:00
Karthik Jayaprakash d7d49eb8e9 Merge "SWDEV-227602 - Adding support for hipFuncGetAttribute" into amd-master-next 2020-04-15 12:18:32 -04:00
Vlad Sytchenko 4d6e394c73 Correctly calculate size of the copy region
Since we adjust we adjust the start of the region, amd::BufferRect::end_ is no longer the size, just the offset as to where the region ends.

The actual size of the region is (amd::BufferRect::end_ - amd::BufferRect::start_).

Change-Id: I8425d8bdfb20f485740863813e762e8923d9ee94
2020-04-14 12:25:17 -04:00
Yaxun (Sam) Liu 4e1d05c4be Fix MIOpen build failure
This is charrypick of 9ead991784
and https://github.com/ROCm-Developer-Tools/HIP/pull/2009

Fix cmake config file

Removed cmake target files under packaging directory.

Merged cmake config .in files for HIP-Clang and HCC as one.

Use cmake generated target files in both install and packaging.

This makes cmake config file consistent for make install and
make package.

Let device side malloc/free return nullptr and trap

Change-Id: I448f3ea2d4934648089bad371debc203f895cba6
2020-04-13 23:01:31 -04:00
kjayapra-amd fc720c6287 SWDEV-227602 - Adding support for hipFuncGetAttribute
Change-Id: I16511274653c8c5521447eb2ed0fc5331dae8cba
2020-04-13 21:23:04 -04:00
Vlad Sytchenko a9513154c7 Default stream needs to be initialized
Change-Id: I5cbf9076bffb51c0e99601393645f443c1658e13
2020-04-13 15:32:35 -04:00
Evgeny Shcherbakov 76363d90b8 Merge "fxing C compatibility (amd-master-next)" into amd-master-next 2020-04-10 13:41:47 -04:00
Evgeny 8e2138b23b fxing C compatibility (amd-master-next)
Change-Id: Ib95b953bb49e0edbe044789b6ff81aaccb87f85f
2020-04-10 00:08:09 -05:00
Vladislav Sytchenko 28da0b89ea Correctly check max 1D image buffer size
VDI reports the limits in pixels, but user provides the size in bytes.

Make sure both values are in pixels before doing comparisons.

Change-Id: I082c7175c9fa4383e0b0ee38ff8c047c26ff20b4
2020-04-09 21:37:43 -04:00
Vladislav Sytchenko 73751496e1 Fix Windows build
Change-Id: I8e219f8200875e3c46c1f54348317ba7ad8ae8ba
2020-04-09 20:00:29 -04:00
Christophe Paquot 396e6a87ba Merge "Remove a map lookup whenever we were getting the default stream" into amd-master-next 2020-04-09 18:35:46 -04:00
Vladislav Sytchenko 524a81fcf5 Fix warnings when compiling with clang
The following warnings are addressed:

comparison of different enumeration types in switch statement

Change-Id: I6cb3948aeab7287851c57ecc1d4b3a439ab14ec6
2020-04-09 17:07:48 -04:00
Christophe Paquot 137150f694 Remove a map lookup whenever we were getting the default stream
Change-Id: I64b6d1deea41d81e94a58a83de287e78923656b3
2020-04-09 12:44:21 -07:00
Evgeny cc60da5da1 enabling hipPrintString (to master-next)
Change-Id: I28859f3dbe5b867a858ca1d76c93e6fab6a68d1f
2020-04-09 09:57:27 -05:00
Saleel Kudchadker f3e31ad00e Merge "Revert "Wake up commandQueue before returning"" into amd-master-next 2020-04-06 18:52:29 -04:00
Saleel Kudchadker 1b46f2622b Revert "Wake up commandQueue before returning"
This reverts commit e2def55164.

Reason for revert: German advised againt this change.

Change-Id: Ia1b1b9db60c965b2d9c006bd7d20012a9d7697e1
2020-04-06 16:46:50 -05:00
Payam 14010cb705 updated LOG_LEVEL prints to print pid and tid
Change-Id: I8a9212b26bb7e312408a222823efcfd00344094b
2020-04-06 16:58:25 -04:00
German Andryeyev 8be723e199 SWDEV-184710
Support hipLaunchCooperativeKernelMultiDevice()

- Add validation logic for MGPU launches to pass a cuda test

Change-Id: Iccca7fde43493fc3bc6685512d39202271ae3e92
2020-04-06 16:38:27 -04:00
German Andryeyev 9e93116097 Merge "(SWDEV-228488)" into amd-master-next 2020-04-06 16:30:37 -04:00
German Andryeyev 74e98ea447 SWDEV-184710
Support hipLaunchCooperativeKernelMultiDevice()

- Add hipCooperativeLaunchMultiDeviceNoPreSync and
hipCooperativeLaunchMultiDeviceNoPostSync support to pass a cuda test

Change-Id: If518f11ef2636a2235e5df9e77f879d8ced68102
2020-04-06 15:29:03 -04:00
Vladislav Sytchenko a3613cc6da (SWDEV-228488)
These fixes address regressions caused by http://gerrit-git.amd.com/c/compute/ec/hip/+/337601

Currently we're converting a 1D offset into a 3D offset, which doesn't make much sense once you consider the fact that this offset is relative to a different origin than our current 3D offset.

I traced through our blit kernels in VDI - the copy buffer rect path is able to handle immediate offsets in the 3D buffer via the amd::BufferRect::start_ parameter.

Instead of adjusting the offset, simply adjust the start of the region.

Change-Id: Ic8797a2c8ac0ad106f246f61ff06ca1ca03d3058
2020-04-06 14:17:11 -04:00