Commit Graph

6428 Commits

Author SHA1 Message Date
cjatin a12163b4e5 SWDEV-268531 - Fixing shadow varible warning seen with hip vector usage
Change-Id: I9e20a41e74e473b328cc173f2c27b06352128c88
2021-02-09 13:33:12 -05:00
agodavar c149c88fa1 SWDEV-271096 - Handle depth zero in hipMalloc3D
Change-Id: I0ef0cc825e20b3480e9e5476e09dde5f73cdd3ea
2021-02-09 08:39:44 -05:00
Jatin Chaudhary 1770e8a160 SWDEV-271274 - Remove hip init call from hipUnregisterBinary, this call ends up initializing rocclr and hsa even when there is no hip call in the entire file
Change-Id: I20c1d3079c6032d79c5b892d5616921f7aeb4fe2
2021-02-09 07:59:32 -05:00
Satyanvesh Dittakavi 4f062fa1fb SWDEV-269439 - Fix dtests build failure on HIP CUDA
Change-Id: Ibdba5d364df1bcd3b9e158e22a602dd993044d7a
2021-02-08 17:09:49 -05:00
Tao Sang 9996ebb641 SWDEV-271406 - Remove unecessary hip_ext.h
tests/src/runtimeApi/module/hipModuleLaunchKernel.cpp doesn't
need hip_ext.h which will fail cuda building. So remove it

Change-Id: Icf5763449ccec839d9efda90ffe3a86fb53bdb85
2021-02-08 14:33:04 -05:00
Julia Jiang 090b2829b9 SWDEV-271416 - Remove HIP_DYNAMIC_SHARED macro in hip
Change-Id: I12f39ea8438eb7ce76d8ffb2151b4faa93689048
2021-02-08 13:17:46 -05:00
Tao Sang 76d8ad1bf9 SWDEV-271363 - Fix undefined HIP_VERSION_GITDATE
HIP_VERSION_GITDATE won't be defined when git isn't
installed. This will lead to building failure of
deviceLib.hipVersion. When git isn't installed, set
HIP_VERSION_GITDATE as 0 by default.

Change-Id: Icf5763449ccec833d9efda90ffe3a86fb53bdb82
2021-02-03 21:31:26 -05:00
Aaron En Ye Shi af6cc3c45f SWDEV-263964 - Fix hipcc --hip-device-lib-path
On Windows, there may be spaces in the directory
location. Therefore, must add quotes when adding
this path with a location in C:/Program Files/.

Change-Id: I63642093092e25a2f6ed73b55a7afd16835ac736
2021-02-03 19:41:35 +00:00
Satyanvesh Dittakavi e2551bd15c SWDEV-269440 - Fix build error in HIP-CUDA path
Change-Id: Icf5763449ccec333d9efda90ffe3a86fb53bdb81
2021-02-02 05:40:31 -05:00
agodavar e236ae7ea5 SWDEV-269085 - Add support for build with ADDRESS_SANITIZER
Change-Id: I102cbe197727ec059d3dc9fae3a41bb559b0dff1
2021-01-29 01:54:43 -05:00
Sarbojit Sarkar 09b1eb8c9f SWDEV-265469 - added constexpr constructor for dim3
Change-Id: I2e23a403f272d1ff0ade24fec11190d2f3244e5f
2021-01-28 13:23:51 -05:00
Vladislav Sytchenko ff4b9ab9bc SWDEV-1 - Fix Windows build
Change-Id: I20c727a8718941694da6dc024efdfd1eb6af828b
2021-01-28 10:22:25 -05:00
kjayapra-amd f78522c226 SWDEV-270007 - Fixing the hipMemoryAllocateCoherent test binary path for hipMemoryAllocateCoherentDriver test path.
Change-Id: Iae5363685d10fce32ff80ac5d6bfba460dc2b574
2021-01-28 09:47:01 -05:00
Satyanvesh Dittakavi 25cccbb60d SWDEV-269784 - managed memory support for HIP CUDA
Change-Id: I01f9fc64573f402031eceab24395e5cbd93007f9
2021-01-28 07:51:52 -05:00
agodavar 464cad2751 SWDEV-269400 - handle nullptr in hipFuncGetAttributes and blockSizeLimit<0 in hipModuleOccupancyMaxPotentialBlockSize
Change-Id: Ia1c6e5713f40876b4a9c7a1c56b7b3a589c4497a
2021-01-27 23:41:31 -05:00
agodavar 83482253ec SWDEV-270198 - hip-hcc cleanup remove lpl_ca
Change-Id: I6cae9435397e9070efb4a953c7ba8bd3dcd98c0e
2021-01-27 23:40:58 -05:00
agodavar aac12d1bd9 SWDEV-268552 - HIP sample segfaults during hipModuleLoad, fix mmap bug
Change-Id: I51c6061e7ac6b2524586d96fdd69b9f084b1906a
2021-01-27 23:39:50 -05:00
Rahul Garg 2314fe2e3a SWDEV-270166 - Remove Linux specific includes
Change-Id: I929285941f28941cb41718f9fb8f618d11f1a69b
2021-01-27 12:10:37 -05:00
agodavar 8610e93f39 SWDEV-267154 - Add checks for grid and block dimensions 0
Change-Id: I54799c0a4a42a91f6226f94a1e3ff7bc79046a98
2021-01-27 00:32:31 -05:00
Vladislav Sytchenko 33d019a800 SWDEV-1 - Fix Windows build
Change-Id: I144142b2b31785fe7b1d319fb7e88eb2b41099ac
2021-01-26 15:51:57 -05:00
Aaron En Ye Shi 9e47efe0e6 SWDEV-263964 - Fix hipconfig to work on Windows
Modify hipconfig and hipcc to properly run Windows compiler
executables. Support Windows Environmental Variables and
AMD Display Adapter info. Update flags to include quotes for
paths that have spaces, such as Program Files.

Change-Id: Ib721b318bd88be7dfa1247a30ce78c7ed6a334e8
2021-01-25 12:53:03 -05:00
Aaron En Ye Shi d88c50439a SWDEV-263964 - Add Windows CMake find_package(hip)
Modify hip-config.cmake to support building on Windows
using CMake's find_package(hip). Windows CMake will work
with Ninja Generator and inheritEnvironments clang_cl_x64.

Change-Id: I03d76b5f8d695ce50ecaacb449e4eb1c1ca49700
2021-01-25 12:52:46 -05:00
Joseph Greathouse b52392f6ee SWDEV-269756 - Add missing Cooperative Groups error string
Change-Id: I1833f8bb4b48b19bb3d6cac57dda429231cf3562
2021-01-22 15:48:18 -06:00
Tao Sang 30820b131e SWDEV-268757 - Disable deprecation warning
Disable it as it will fail rocgdb test

Change-Id: Ibf34c780d5bd4278adcedba1d6e057639c258483
2021-01-21 15:35:32 -05:00
Tao Sang 26d04e9af8 SWDEV-257056 - Fix cyclic dependence of hip/rocclr libs
Solve upstream building failure due to the cyclic dependence.

Change-Id: Ibf34c789d5bd4278adcedba1d6e057639c258488
2021-01-21 13:00:22 -05:00
jujiang 6084d0da2d SWDEV-265003 - update HIP document
Change-Id: I1e8ec3ad380330b48d164a2ca60b0a70f7e54ae6
2021-01-20 16:24:20 -05:00
Satyanvesh Dittakavi ecdbaf73cf SWDEV-268989 - Modify atomicAdd double to use clang builtin
Change-Id: If9d40046df2f3f5af7cc1bd6c935fbe7d686e7d8
2021-01-20 02:39:15 -05:00
agodavar 2e2f5a3824 SWDEV-267298 - update install script to build hip-rocclr
Change-Id: Ia8d72ebc41184d2fc58aa4e99966ef9b71a7fc26
2021-01-19 11:50:42 -05:00
agodavar 70f2b4031b SWDEV-268552 - HIP sample hipDispatchEnqueueRateMT segfaults, updated to use hipModuleLoadData
Change-Id: Ibf34c780d5bd4278adcedba1d6e057637c258485
2021-01-19 09:32:14 -05:00
Tony Tye 040bc455d4 SWDEV-268864 - Use new isa class to access isa related information (part 2)
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f
2021-01-19 03:36:22 +00:00
Tony Tye c45b74c9de SWDEV-268864 - Use new isa class to access isa related information
Change-Id: I2122bf85155997d802ca54e456c2dae66b801825
2021-01-18 22:31:01 +00:00
Sameer Sahasrabuddhe 96be8a7b73 Implement assert() using the new fprintf_stderr facility
The device library now provides functions to specify the host stderr
stream in a hostcall printf message. This change implements an
assert() macro which can construct such a message. The end result is
that assertions on the device are now correctly printed on the host
stderr instead of stdout.

Change-Id: I85ab8f7848bcf28303cb8dbb8a798bc6aece7d75
2021-01-17 23:54:46 -05:00
David Salinas 5f96929cf6 remove extractkernel
Change-Id: I46a380059fa336aa7553669629a21e8aa7717e7b
2021-01-15 11:34:32 -08:00
Satyanvesh Dittakavi aaa15a7455 device property __HIP_ARCH_HAS_SHARED_INT64_ATOMICS__ set to 1 as it has compiler support
Change-Id: Ic91c4955d4f2d52d844471f81e6f0d19418018f5
2021-01-15 11:40:09 -05:00
DURGESH KROTTAPALLI 0b871a24f6 [dtest] Kernel Execution time fix for hipExtLaunchKernelGGL and hipExtModuleLaunchKernel API's
Fix for kernel execution time using clock rate

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id06df31387ecab96f219e0c1fbcdda1609f75605
2021-01-15 01:58:22 -05:00
David Salinas cb859b7263 add new code object tooling: roc-obj-ls and roc-obj-extract
SWDEV-229776

Change-Id: Icb11c4552515d3eff3bcf303c4a470ab90d1dd58
2021-01-14 14:45:46 -05:00
Tao Sang 59ef7dc9e2 Fix building mathlibs failure
Add back
__HIP_PLATFORM_HCC__
__HIP_PLATFORM_NVCC__

Change-Id: I1ae48678eafd849d6c25bcb204c1724b026be22f
2021-01-14 14:03:15 -05:00
Tony Tye 28e60ec942 Use ROCclr Info.targetId_
Use Info.targetId_ instead of Info.name_ so it will work on Windows
PAL driver and ROCm.

Change-Id: I20537899c36c0ee330a4c09136a52e53d9f35e0d
2021-01-14 05:17:20 +00:00
jujiang e3ec98f6e2 SWDEV-265003-Update HIP documents
Change-Id: I3aea36f9a817ff0d2a379fc902b1ba7794f9736e
2021-01-13 17:55:16 -05:00
Rahul Garg 89491c6015 Update dispatch latency with wall time measurements
Change-Id: I73bfed129171d6909b4638f714b694111b31ef56
2021-01-12 22:52:33 +00:00
Tao Sang ef8110da22 Workarround for rocThrust building failure
Define the following for workarround of rocThrust building failure,
HIP_INCLUDE_HIP_HCC_DETAIL_DRIVER_TYPES_H
HIP_INCLUDE_HIP_HCC_DETAIL_HOST_DEFINES_H

Change-Id: I1ae48677eafd749d6c25bca204c1724b026be22f
2021-01-12 11:31:06 -05:00
Tao Sang 636f7600bd Fix failure for g++/hipMalloc test
Fix hardcoded /opt/rocm

Change-Id: I1ae48567eafd749d6c25bca204c1724b026be21f
2021-01-11 11:46:17 -05:00
Michael LIAO 094ff5431e Remove checking on double.
- All conversions among floating point types should be allowed.

Change-Id: I6223bece51f5b2a535ab3369c5c4380f18acc74d
2021-01-11 11:33:33 -05:00
Sameer Sahasrabuddhe 05cc647684 Identifiers with a double underscore "anywhere" are reserved
This particular cleanup is limited to just two functions defined in
the HIP headers.

Change-Id: Ib529685265f2fda90e009b24e7e756e0cf363012
2021-01-11 15:09:53 +05:30
Icarus Sparry 24c8e5a348 Allow for /usr/bin/hipcc to be a symlink
SWDEV-267206

If /usr/bin/hipcc is a symlink then resolve it first, and then find
the resulting directory rather than resolving /usr/bin.

Change-Id: I380728ffa05ed813cc793a1d6488aaae81ddbda8
2021-01-11 00:50:20 -05:00
Saleel Kudchadker f24b2e075a Update documentation for hipEventCreateWithFlags
Change-Id: I2658bd95df0d3a802cce4ffcb8dfd40e7055b0f7
2021-01-08 16:32:57 -05:00
Rahul Garg c307baf3da Add IPC Events support
Change-Id: Iac2bf3d5e1d9a993bebbb066c20d300d6f05558b
2021-01-08 20:09:26 +00:00
Tao Sang b34dd95124 Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
2021-01-08 10:53:34 -05:00
DURGESH KROTTAPALLI d1c921ffca [dtest] Tests for hipExtLaunchKernelGGL APIs
Added test scenarios for hipExtLaunchKernelGGL
1. verify kernel execution time using events
   passed through argument
2. Verify the API by disabling time flag in
   event creation.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I755adc34a25c58b68041fc927bbffd2a9e6eafde
2021-01-08 00:16:54 -05:00
DURGESH KROTTAPALLI ba3fff4fcd [dtest] Tests for hipExtModuleLaunchKernel APIs
Added test scenarios for hipExtModuleLaunchKernel/hipModuleLaunchKernel APIs

 1. Negative Test Scenarios for hipExtModuleLaunchKernel API
 2. Negative Test Scenarios for hipModuleLaunchKernel API
 3. hipExtModuleLaunchKernel API Concurrency Verification
    using global variable
 4. hipExtModuleLaunchKernel API Concurrency Verification
    using total time taken by kernels.
 5. hipExtModuleLaunchKernel API verifying the kernel execution time
    of a particular kernel
 6. hipExtModuleLaunchKernel API verifying by disabling the
    time flag during event creation

SWDEV-238517 for enhancing hip unit tests

Change-Id: I33bbab152d47beba62065c461a07cbcacdc01d97
2021-01-08 00:05:57 -05:00