Commit Graph

293 Commits

Author SHA1 Message Date
Divya Shikre a95af9b70d Add fix for out of range temperature value for HBM.
Driver mem fills in 0xFF for all for the metrices not supported for that ASIC.
So if 0xFF is detected, return RSMI_STATUS_NOT_SUPPORTED

Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Iacb6474486e3732f2aa824ff447c17f8243b65cd


[ROCm/rocm_smi_lib commit: f61cb1b41d]
2021-11-23 15:37:41 -05:00
Sreekant Somasekharan 70be1fab11 Modify bool variable to true in if condition of src=dst
Change-Id: Ie2024b3a6ad68e48384bb3472fe8785bcd643665


[ROCm/rocm_smi_lib commit: 3f27dcc1ac]
2021-11-17 12:53:40 -05:00
Ori Messinger 4883fa50c4 ROCm SMI CLI: Fix printErrLog Arguments
This patch removes every erroneous occurance of a third argument
when calling printErrLog(device, err), since it takes two arguments.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I5971cc68b69c86f37c69f44e4785dabfc82c7955


[ROCm/rocm_smi_lib commit: 40eed25a3b]
2021-11-08 12:54:00 -05:00
Elena Sakhnovitch 8a5effb2e1 [ROCm-SMI] add --showNodesBw
Display min and max bandwidth between gpu nodes

Signed-off-by: Elena Sakhnovitch
Change-Id: I7289fb83f80e2f899996b7d7560ece670cc5f31f


[ROCm/rocm_smi_lib commit: 13cde8429d]
2021-10-29 12:49:35 -04:00
Elena Sakhnovitch f0a86d3d29 [rocm_smi.py] remove repetitive footnote
Printing "Primary die (usually one above or below the secondary) shows
total (primary + secondary) socket power information" footnote only one time, not
for every secondary die.

Signed-off-by: Elena Sakhnovitch
Change-Id: Iae9c5c94945ec38ecdb128a576a4eacafc30a044


[ROCm/rocm_smi_lib commit: 15e4fe80e1]
2021-10-29 08:32:06 -04:00
Sreekant Somasekharan 01cb5a2b61 Add test case for rsmi_is_P2P_accessible API.
Change-Id: Iccfede42925c98d96454b5f25cc0ed6fc9258911


[ROCm/rocm_smi_lib commit: ce46fd237a]
2021-10-28 17:06:07 -04:00
Elena Sakhnovitch 71fe1f8bce [ROCm SMI LIB]: Add rsmi_minmax_bandwidth_get()
API provides min/max bandwidth values between nodes.
(Current implementation only supports directly (1 hop)
connected XGMI devices.

Signed-off-by: Elena Sakhnovitch
Change-Id: Ifc95da13845fbe7903c5386d320183ffd58c5b53


[ROCm/rocm_smi_lib commit: 50ea68e694]
2021-10-28 17:00:41 -04:00
Divya Shikre 68a7ef02b5 Add failing rsmi tests to exclude file to enable blacklisting
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Ibdad4d54ffe87391b13379c63e005fd04c6abaf5


[ROCm/rocm_smi_lib commit: e96d6ab77e]
2021-10-26 17:57:05 -04:00
Ori Messinger b1720b42cd ROCm SMI CLI: Add --showtopoaccess Functionality
The purpose of this patch is to implement --showtopoaccess
functionality in the CLI, which shows True or False if P2P is
possible between two given GPUs.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I07d70d80ae7b484136b31d5d22780c4990029391


[ROCm/rocm_smi_lib commit: e2d9a37e5f]
2021-10-14 11:06:05 -04:00
Ori Messinger a9993fb509 ROCm SMI LIB: Add rsmi_is_P2P_accessible() API
Implements rsmi_is_p2p_accessible API.
The function returns True if P2P is possible between two nodes.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: Ic7316eebcec4480175c7ad04c21a42b2e1a4c454


[ROCm/rocm_smi_lib commit: ff02042c64]
2021-10-13 22:01:33 -04:00
Bill(Shuzhou) Liu 6601ab509b Add cmake target for rocm_smi
rocm_smi will provide cmake files exporting the INCLUDE/LIBRARY targets.

Change-Id: I1943a3142bdc0abd8f03ff62e12e947aac835401


[ROCm/rocm_smi_lib commit: 088fe48d12]
2021-10-04 11:08:23 -04:00
Elena Sakhnovitch 683df7e44c [rocm_smi.py]: fix fan 255% error
signed-off-by: Elena Sakhnovitch
Change-Id: I265ba32bc3777db5f04f1924547fe432ba78c3d0


[ROCm/rocm_smi_lib commit: 2f84906cc2]
2021-09-29 21:11:06 -04:00
Elena Sakhnovitch bc5030e721 [rocm_smi.py]: pep8 formatting
signed-off-by: Elena Sakhnovitch
Change-Id: If12b3371cd6acac16d9f6b3adf5f5cc8df28992f


[ROCm/rocm_smi_lib commit: 80140c3b02]
2021-08-26 10:23:58 -04:00
Elena Sakhnovitch 64a2e50a43 rocm_smi_lib: fix gpu_metrics_v1_3 support
Signed-off-by: Elena Sakhnovitch
Change-Id: Ia7a6b17eb0f317465613ba92ae7548a221c46ee3


[ROCm/rocm_smi_lib commit: 5e1bfcadd7]
2021-08-13 11:59:50 -04:00
Elena Sakhnovitch 0bd439006a rocm_smi_lib: add gpu_metrics_v1_3 support
Signed-off-by: Elena Sakhnovitch
Change-Id: I4a9dedc80b8fce60e12c5baf8651d54d16a6a41c


[ROCm/rocm_smi_lib commit: fee82af1fe]
2021-08-13 09:23:35 -04:00
Harish Kasiviswanathan 131a0d1705 Fall back to pci-ids if FRU product_name is empty
rocm-smi --showproductname will not show "Card series" in its output if
product_name exported by Kernel is empty string. This has been raised a
regression by customer.

BUG: SWDEV-297228

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I9aae24778e2d3a30aa661d8f338278c1666590fb


[ROCm/rocm_smi_lib commit: 7a8c3f3629]
2021-08-04 10:53:55 -04:00
Bill(Shuzhou) Liu 3e74c1a903 support rocm_smi_lib version in the header file
Package the rocm_smi64Config.h into deb/rpm.

Change-Id: Ic4ba90646a0dbeb8bc2dd4edf455004b1a7ea859


[ROCm/rocm_smi_lib commit: 26874d2a10]
2021-08-04 10:19:44 -04:00
Bill(Shuzhou) Liu 1f9cb25055 Add -g compiler option for ADDRESS_SANITIZER
Add -g compiler option for Address Sanitizer

Change-Id: I958fefa6c4b5871c29734ab1d4ec238c9e073192


[ROCm/rocm_smi_lib commit: 42d39d3e34]
2021-08-03 13:54:19 -04:00
Elena Sakhnovitch 578d20c037 [rocm_smi.py] --showpower error bugfix
Fix error message in -P for secondary die

Signed-off-by: Elena Sakhnovitch
Change-Id: Ica3c0a83b565d2231fad23389b9378056a0f56b3


[ROCm/rocm_smi_lib commit: 2db7e2a312]
2021-07-30 00:08:14 -04:00
Elena Sakhnovitch ebba123919 [rocm_smi.py] add secondary die check.
Signed-off-by: Elena Sakhnovitch <Elena.Sakhnovitch@amd.com>
Change-Id: I46618002c1967ec115db88becbaba9e7c0a08af1


[ROCm/rocm_smi_lib commit: b59e752122]
2021-07-29 17:46:12 -04:00
Harish Kasiviswanathan 3da3df8905 rocm_smi.py: Remove extraneous line during process termination
During the tail end when process is terminating, subprocess module fails
to find the process. This results in extraneous printing of a line with
char 'b'. Fix this.

BUG: SWDEV-296409

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I39aacf8ae948a5acec0aa93296cc0e0aec88b3ef


[ROCm/rocm_smi_lib commit: a03acf2c07]
2021-07-27 16:26:49 -04:00
Icarus Sparry 8a61dda627 Add dependency on rocm-core
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
Change-Id: Ie2a5b08747129a1313edf2a834f2e0e8638372c2
(cherry picked from commit c0ad8375c7)


[ROCm/rocm_smi_lib commit: de025ca5f6]
2021-07-27 09:42:30 -04:00
Ori Messinger 8e3d715d10 ROCm SMI Python CLI: Fix printLog Collisions
Python's default 'print' implementation is not thread safe, causing
empty lines to be printed during multithreaded code execution.

This fixes the --showevents output for multi-GPU systems.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I72f7341cdf4401f1fed4cd8f7d7a4a90bf9a3a4c


[ROCm/rocm_smi_lib commit: 95348f37cc]
2021-07-21 23:58:07 -04:00
Ori Messinger b8324162e0 ROCm SMI Python CLI: Add Zero Padding to Device Model
Use zero padding for the hexadecimal value 'device_model' inside
showProductName with a padding length of 4.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I962b94d414c6ba050d951486ad9e7559123f8850


[ROCm/rocm_smi_lib commit: 03ae187a35]
2021-07-17 04:29:52 -04:00
Bill(Shuzhou) Liu a4dba3ba7e AddressSanitizer report stack-use-after-scope
Fix the stack-use-after-scope error reported by the AddressSanitizer.

Bug: SWDEV-291913
Change-Id: I0ffd71af8679b8bff6c363096fafe75dffcf329e


[ROCm/rocm_smi_lib commit: 8c60dbebaa]
2021-06-25 13:33:38 -04:00
Divya Shikre 9abb288ace Add fix to ignore error returned when perf determinism is not supported.
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: I89b6a0a3dbba6fbd4b12ff2e20670eff9f32ed7f


[ROCm/rocm_smi_lib commit: 6edea7a92e]
2021-06-14 12:18:22 -04:00
Divya Shikre 47d033876c Add fix to show usage of setperfdeterminism functionality in --help command
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Ife93c887eea2a9aae69f2923dba45c7cde4838d3


[ROCm/rocm_smi_lib commit: 686e6ac654]
2021-05-12 17:29:37 -04:00
Divya Shikre f3c90aa582 Return an error when user tries to set out of range clock values for setsrange functionality
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Ibe1075c1d2b6c009332a52b81f4b41f7e93d0756


[ROCm/rocm_smi_lib commit: 462d4adc24]
2021-05-11 12:32:19 -04:00
Harish Kasiviswanathan deac3a055c Add timestamp resolution info in comments
Specify that timestamp resolution is in ns in header file.

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I4db00a07c0b5c43ae23c98213f2fbbcf93110234


[ROCm/rocm_smi_lib commit: 14201290a2]
2021-05-05 12:32:58 -04:00
Harish Kasiviswanathan 1f7954113f Add support to read gpu_metrics version 1.2
gpu_metrics version 1.2 provides atomic timestamp. Use this timestamp.

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I7a1a675f53b93718f34b1f2979173e9064e0ef93


[ROCm/rocm_smi_lib commit: 6b10a7761b]
2021-05-05 12:31:10 -04:00
Harish Kasiviswanathan 1aac6e61d4 Change #define RSMI_GPU_METRICS_API_CONTENT_VER
Chnage to RSMI_GPU_METRICS_API_CONTENT_VER_1. In preparation for
supporting additional formats

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I4367a2622a0fa41e6b05bc4436ecd24b8c4e30e2


[ROCm/rocm_smi_lib commit: e83cf605c6]
2021-05-04 20:51:10 -04:00
Harish Kasiviswanathan debafec88c Move gpu_metrics functions to different file
No logic change. Only structural change

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Id5e1a678c0888f04081ee06db4521c72b5eb9b16


[ROCm/rocm_smi_lib commit: c416726054]
2021-05-04 20:49:51 -04:00
Ori Messinger ecaf3c52ff ROCm SMI LIB: Add Default Power Cap To rsmitst
Implement default GPU power cap functionality in rsmitst.
It is available in the "rsmitstReadOnly.TestPowerRead" test, and
is displayed as: "Default Power Cap: #uW" (where uW is microwatts).

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I564ea3785f1a93dfd30587634057516549fa762c


[ROCm/rocm_smi_lib commit: 5b42cdf780]
2021-04-28 12:42:34 -04:00
Kent Russell 22485bf114 rocm_smi.py: Fix gpu reset error
Since device is a list, we need to pass a single item to the isAmdGpu
function.

Fixes: 17bdc065a1 "rocm_smi.py: Don't try to reset non-AMD GPUs"

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: I19a74377636ff4589f11d092f41e1d35c1acb307


[ROCm/rocm_smi_lib commit: 242d94a668]
2021-04-28 07:44:55 -04:00
Kent Russell 2ba625e569 rocm_smi.py: Don't try to print absent clock files
Instead of throwing "Unsupported clock" errors for ASICs that don't
support a certain clock type (e.g. dcefclk on MI-series), just dump the
warning to logging.debug and don't try to read the clock

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: If3cb9a472b03aa535a76fc24bcd9f77122090634


[ROCm/rocm_smi_lib commit: b931380f02]
2021-04-23 10:19:04 -04:00
Ori Messinger 563db7514b rocm_smi.py: Show 'Out of Spec' warning only if required
Use default power cap exposed via sysfs to determine when to
show 'Out of Spec" warning.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I0fa3612b50e230856b0d5a390f876b35268d9587


[ROCm/rocm_smi_lib commit: b71e07b3fb]
2021-04-22 14:44:05 -04:00
Ori Messinger 9a23204e22 ROCm SMI LIB: Add Default GPU Power Cap
Implement default GPU power cap functionality in the LIB.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: Ia6b3420beb0e4df5559c3e6d11d0667972590b53


[ROCm/rocm_smi_lib commit: 83cd2fe4f1]
2021-04-22 10:49:55 -04:00
Harish Kasiviswanathan 108cf12a97 Add energy counter resolution to rsmi_dev_energy_count_get
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I03b70968257db7a45e21d7ba62542cdedd18eb85


[ROCm/rocm_smi_lib commit: 844acbc0d8]
2021-04-22 10:25:06 -04:00
Ori Messinger 6b4889a3a4 ROCm SMI Python CLI: Add showevent Functionality
Implement showevent functionality in the ROCm SMI Python CLI.

It can be called using --showevents with any combination of:
VM_FAULT, THERMAL_THROTTLE, and/or GPU_RESET
For example:
./rocm-smi --showevents VM_FAULT, THERMAL_THROTTLE, GPU_RESET

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I905fd9c949e91423b79833a04ab89d6ba3760e62


[ROCm/rocm_smi_lib commit: a9e7e5a475]
2021-04-22 10:21:07 -04:00
Elena 6f751e3fd5 [rocm_smi.py] add energy counter
--showenergycounter

Signed-off-by: Elena Sakhnovitch
Change-Id: Iede0f2b06523f7cb2719489a883e9c49722f8d93


[ROCm/rocm_smi_lib commit: c80fc54500]
2021-04-21 18:40:19 -04:00
Elena 8ee1e50e75 [rocm_smi.py] Coarse Grain Utilization Counters
--showuse
--showmemuse

====================================
========= % time GPU is busy =======
GPU[0]          : GPU use (%): 0
GPU[0]          : GFX Activity: 0
====================================

Change-Id: I9db115ad78b394469206b22d195781a430b2f1d8


[ROCm/rocm_smi_lib commit: 771b4af95c]
2021-04-21 17:23:21 -04:00
Harish Kasiviswanathan 7717cc9d88 Suppress warning message in getFanSpeed function
Many data center cards are fanless. Don't show warning if unable to get
fan speed. The fan speed will be reported as 0

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I53efe67ac88fb0824cf4820430b46c18bc7692df


[ROCm/rocm_smi_lib commit: 1c9e384c8f]
2021-04-21 15:29:44 -04:00
Harish Kasiviswanathan 5e9519a066 Add time profile for set_power_cap function
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Id728cb5fe85b3558e52b4517508211dca499e801


[ROCm/rocm_smi_lib commit: 92cf7ff28a]
2021-04-21 15:29:44 -04:00
Divya Shikre 7b99a4e180 Update setrange functionality in CLI
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Ic942bd76297c50caf189bfc0972d30dc42d91f32


[ROCm/rocm_smi_lib commit: 56c132873b]
2021-04-20 15:39:05 -04:00
Divya Shikre 275094d6c5 Add support for mi200 clocks being continuous.
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Ifb7570054572239b9f48eaefe51e879fb3569031


[ROCm/rocm_smi_lib commit: dc431506f5]
2021-04-20 13:12:27 -04:00
Divya Shikre 58fe0fb6db Add new setrange function in C++ lib
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: I670aaeb93827bf4b2cc08eb36d0f9756f00e4e4e


[ROCm/rocm_smi_lib commit: 9f9a7aaf65]
2021-04-19 22:38:59 -04:00
Divya Shikre f17e6de490 Fix for cli errors - extra args in perf_determinism, undefined variable in setClocks
Signed-off-by: Divya Shikre <DivyaUday.Shikre@amd.com>
Change-Id: Id138cfcbea4384f520537cc045d358024177b1ac


[ROCm/rocm_smi_lib commit: d9f7bd0ff4]
2021-04-19 17:32:07 -04:00
Elena e813049fd7 [rocm-smi-lib] add HBM temperature conversion factor
Change-Id: I45339c87c3d2a40670baf1b76ada60dceb650dc0


[ROCm/rocm_smi_lib commit: a383dd23aa]
2021-04-19 16:41:48 -04:00
Elena 134bb5d820 Adding 4 new HBM temperature sensors.
Signed-off-by: Elena Sakhnovitch
Change-Id: Iaea04c38e8c2353e85d8aa2b871fdb82727157de


[ROCm/rocm_smi_lib commit: 81c066350f]
2021-04-17 23:58:49 -04:00
Bill(Shuzhou) Liu db8d076b35 Unit test for energy accumulator counter
Add a few unit tests for energy accumulator counter.

Change-Id: Ib78a67e29465de9c14e6e934c5d62ec64de66d8a


[ROCm/rocm_smi_lib commit: 392d13e318]
2021-04-14 16:04:46 -04:00