c124899669
Merge pull request #282 from gargrahul/texture_driver_3d_support
...
Added support for 3D texture driver apis
2017-12-18 15:39:26 +05:30
574797cdff
Merge pull request #286 from gargrahul/fix_hipDeviceGetAttribute_nvcc
...
Fix hipGetDeviceAttribute dtest for HIP/NVCC
2017-12-12 12:49:23 +05:30
c4192eec7d
Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
...
Fix ilogb/ilogbf functions to return int
2017-12-12 10:47:33 +05:30
a62ef42c09
Fix hipGetDeviceAttribute dtest for HIP/NVCC
2017-12-06 15:49:06 +05:30
b439b45641
Fix ilogb/ilogbf functions to return int
...
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.
2017-12-05 23:14:10 +00:00
105df94cd0
Added support for
...
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array
2017-12-05 14:11:13 +05:30
e186bd9533
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
2017-12-03 23:09:06 +00:00
33bb425013
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
2e39534377
Add missing space (the final frontier).
2017-11-29 21:50:43 +00:00
4966518846
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit 4792475
2017-11-29 21:49:10 +00:00
92e80f0943
Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used.
2017-11-29 21:47:04 +00:00
4792475d01
Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions.
2017-11-29 21:01:28 +00:00
93e595c267
Fix compiler version check.
2017-11-29 03:05:53 +00:00
37c1811b2a
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
c6ab6f292b
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
d5c8de3f41
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
6a0efb7ed2
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
d37a5a6008
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
e93a24bdbe
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
dfa532db98
Remove leftover comment.
2017-11-22 19:37:03 +00:00
38029f2849
Fixed review comments
2017-11-21 21:19:06 +05:30
24307fe5c4
Changed function hipMemcpy_2D to hipMemcpyParam2D
2017-11-21 12:36:24 +05:30
f8c1c1b38e
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
2017-11-21 02:40:34 +00:00
27bc487635
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
2017-11-20 16:33:52 +00:00
30d90dab38
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
76f174b536
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
0cc921f103
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
edbfeeb141
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
e536eb038d
Texture code reorganized
2017-11-14 11:09:35 +05:30
1851c153f6
Texture driver APIs support
2017-11-09 22:10:55 +05:30
0ad1308efd
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
28f87f7d2e
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
7e8b39fc96
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
cf98d0e37d
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-27 01:18:28 -04:00
36c2795dd4
add a printf device function
2017-10-23 18:30:08 -04:00
ed85b15c3e
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
2017-10-20 15:52:13 +00:00
939fa02ade
Add [[nodiscard]] attribute to hipError_t in C++17 mode
...
This will yield a compiler warning any time you discard an error
return value from an API call.
2017-10-19 13:34:02 +01:00
132316fecf
Merge pull request #194 from bensander/fix_genco_math_path
...
Fix math ordering for --genco mode.
2017-10-03 16:17:34 +05:30
2e9b78c274
Fix math ordering for --genco mode.
2017-10-02 21:52:16 +00:00
71a5a0cb42
Fixed review comment
2017-10-02 17:29:08 +05:30
79a943e654
Fixed review comments
2017-10-02 10:57:25 +05:30
d92cfa44d2
Fixed build issue
2017-10-02 10:40:01 +05:30
e6725e2b7a
Fix texture support on HIP/NVCC path
2017-10-02 10:40:01 +05:30
bf6a3f4294
ensure the condition is evaluated before applying the negation operator
2017-09-20 01:38:28 -04:00
01163d327b
Merge pull request #155 from wsttiger/master
...
Modify hip headers such that they are more compatible with strict C compiler
2017-09-15 10:49:55 +05:30
846b0555b9
Fix typo in nvcc_detail/hip_runtime_api.h
2017-09-14 16:19:57 +05:30
096caca840
Merge pull request #175 from gargrahul/assert_support
...
Device side assert support
2017-09-14 16:08:00 +05:30
f6fda276ce
Add hipDevice[Get/Set]SharedMemConfig API on nvcc details
2017-09-14 16:03:19 +05:30
9dcf2ad751
Device side assert support
2017-09-07 20:45:27 +05:30
a6d1778fff
Update docs.
...
- Review unsupported comments and refresh.
- Review experimental tag in API.
2017-08-28 15:44:38 -05:00
Maneesh Gupta
Rahul Garg
Aaron En Ye Shi
Alex Voicu
Ben Sander
Siu Chi Chan
Chris Kitching
sriharikarnam