SWDEV-77584 - HSA HLC: refactoring of min/max processing and folding
1. Fixed correctness bug: if a source contains code like (x > y) ? x : y, HLC was folding
this and similar patterns to min and max instructions. The problem is with NaN handling.
Such a pattern may return NaN if one of two arguments is a NaN. All our instructions return
a number in this case, except for gcn instruction returning a qNaN if input is sNaN.
For a qNaN a number is retuned in any way. Therefor such folding is only correct if NaN handling
is disabled. Patterns are predicated to work with -cl-finite-math-only or -cl-fast-relaxed-math
which includes the former option.
NB: Performance regressions are expected in programs which do not use either of these options.
2. Compiler lib did hot handle -cl-finite-math-only. Also added handling of -cl-no-signed-zeros,
even though it does not affect code generation because there is no llvm counterpart for it.
3. Patterns for NaN agnostic comparison codes are added. We are getting these in case if finite
only math is requested.
4. Removed patterns for __hsail_min_f* and __hsail_max_f*. Instead these intrinsics are lowered
to fminnum and fmaxnum llvm operations with the same semantics. This allows to decrease the number
of patterns and simplify handling.
5. For f32 we were only producing gcn versions min and max with source patterns if gcn is enabled.
Added similar lowering to standard min/max HSAIL operations if gcn is disabled.
6. Added lowering of fmaxnum/fminnum to more efficient gcn operations if gcn is enabled.
Neither OpenCL nor LLVM IR semantics are violated by this.
7. Moved GCN media intrinsics definitions into the GCN directory.
8. Added folding of gcn f32 instructions min(max), min(min), max(max) into corresponding gcn
instructions med3, min3 and max3. This should have been helpful for color clamping.
Performance testing showed these are slow, however. T-Rex test from compubench has slowed down
by 50 times for no obvious reason. Therefor folding is disabled by default. The option -enable-gcn-mm3
is added to enable the folding for testing purposes.
Testing: smoke, precheckin, luxmark, compubench, BasemarkCL,
conformance: commonfns, bruteforce -w, relationals, select
Reviewed by Brian Sumner
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/codegen.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/opt_level.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/options.cpp#35 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/GCN/HSAILArithmetic.td#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/GCN/HSAILFusion.td#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/GCN/HSAILIntrinsics.td#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILArithmetic.td#45 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILFusion.td#28 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILISelDAGToDAG.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILISelLowering.cpp#113 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILInstrInfo.td#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILIntrinsics.td#70 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/llc/opt/minmax/minmaxf3pat.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/llc_opt.tlst#93 edit
[ROCm/clr commit: efa52f77ef]
SWDEV-2 - Change OpenCL version number from 2108 to 2109.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1855 edit
[ROCm/clr commit: c12399b2e6]
SWDEV-2 - Change OpenCL version number from 2107 to 2108.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1854 edit
[ROCm/clr commit: 23266526c9]
SWDEV-2 - Change OpenCL version number from 2106 to 2107.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1853 edit
[ROCm/clr commit: 889bcdcf8a]
SWDEV-2 - Change OpenCL version number from 2105 to 2106.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1852 edit
[ROCm/clr commit: 829e3d0f6e]
SWDEV-92625 - x86 RT: fix division by zero in cpumapping::HCtoDCmap
In many cases default alignment passed as 0. At the same time minimal possible alignment is 1,
while cpumappings uses this value as a divisor. Set it to max(passed alignment, 1).
Testing: smoke, precheckin, conformance really quick on cpu
Reviewed by German Andreev
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpumapping.cpp#5 edit
[ROCm/clr commit: 62a98d8da8]
SWDEV-90482 - [Afterswitch] Interop from OpenGL to OpenCL is broken in one driver and crashes in another
- Make sure SRD resource is reported to OS if program contains static samplers
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#314 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#67 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#4 edit
[ROCm/clr commit: c484ae9061]
SWDEV-2 - Change OpenCL version number from 2104 to 2105.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1851 edit
[ROCm/clr commit: 9775dd2ba0]
SWDEV-2 - Change OpenCL version number from 2103 to 2104.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1850 edit
[ROCm/clr commit: ee51c7b281]
SWDEV-2 - Change OpenCL version number from 2102 to 2103.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1849 edit
[ROCm/clr commit: 40e4f4f88c]
Ben Sander
Maneesh Gupta
foreman
Aditya Atluri
bwicakso
Jack Chung
bwicakso