Commit Graph

186 Commits

Author SHA1 Message Date
Sarbojit Sarkar 1ef88375c2 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
Tao Sang a7aa84f73a Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd
2020-12-11 13:32:15 -05:00
Rahul Garg 584771e7a2 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
2020-12-09 19:09:43 -05:00
Saleel Kudchadker 08a65054ea Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394
2020-12-09 15:10:18 -05:00
Jatin Chaudhary 24b997119f Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157
2020-12-09 01:22:08 -05:00
Jatin Chaudhary dfe6f1ef27 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725
2020-12-07 03:17:14 -05:00
Saleel Kudchadker db7ed1a78c Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8
2020-12-03 13:45:39 -05:00
agodavar 273e83ff6c SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar a08ddb4b53 SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840
2020-12-03 05:50:42 -05:00
agodavar ef415ec610 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33
2020-12-02 00:01:54 -05:00
Tony 8493142a22 Add additional targets
Add support for loading the following targets:

- gfx705
- gfx805
- gfx90c
- gfx1031
- gfx1032
- gfx1033

Change-Id: Ib7f61c33662619757409e95fb0b50068f9e11065
2020-11-23 20:31:45 +00:00
Aryan Salmanpour 00268eaeed Add support for hipExtStreamGetCUMask API
Change-Id: I0fa67ad581dd75556f17c7410af2c1d5cb6ae99a
2020-11-20 13:41:38 -05:00
Satyanvesh Dittakavi 60ec2a3e46 SWDEV-255614: Fix Caffe2 Test Failure
Change-Id: I043caa89b2a43dace7f18c739f30d2a7bfa644ca
Fixes the issue when memcpy DtoH is performed on device 0 where the device buffer 
is allocated on device1 and the destination pinned buffer is allocated from device 0.
2020-11-20 10:24:50 -05:00
Vladislav Sytchenko 63167e4b70 Report maxTexture1DLinear property
Change-Id: If562bbee80d8b98712806cb8258b5a7482d33bf6
2020-11-20 10:18:20 -05:00
Rahul Garg 236352a64d Fix async flag in hipMemset3DAsync
Change-Id: I3dc717c14bdd1d46873e03c687bdf57f9202663e
2020-11-18 20:32:18 -05:00
Yaxun (Sam) Liu cdc7f3f49e Fix embedding PCH
Change-Id: Ibaf043c9e331f15965185cd4195da98d9441cba3
2020-11-18 00:56:42 -05:00
Rahul Garg d11027c522 Fix hipDeviceGetByPCIBusId
SWDEV-260845

Change-Id: I2d6db15906d794c9ebfa85b745a2c1bbb6f3e731
2020-11-16 23:28:52 +00:00
Tao Sang 10f4918d97 Remove unnecessary stuff from hip cmakefile
Remove the following from hip cmakefile,
1.find_package cmds of hsa-runtime64 and amd_comgr;
2.macros of USE_COMGR_LIBRARY and COMGR_DYN_DLL
because they have already been used in Rocclr cmakefile.
cmake mechanism will make hip cmakefile inherite them.

Change-Id: I03b527fc4135c79bb35cbbfe419211ec363cb067
2020-11-13 15:01:32 -05:00
agodavar 9ef681a618 SWDEV-249870: Generate Pre-Compiled Headers from includes in source repo for Online Compilation
Change-Id: I663f510603e983927f80f7944df4d039ba7bc0b0
2020-11-12 10:50:33 -05:00
German Andryeyev d4e642203c Add an early exit if it's a null stream wait
Change-Id: I577f5da2f928bff172d64d511a60e08eda28c81d
2020-11-11 13:20:04 -05:00
Konstantin Zhuravlyov 73fb01cb3a SWDEV-198415 - Implement Target ID Proposal
Changes from Jatin Chaudhary, Tony Tye

Change-Id: I14904920ad2356ae2098cf827b83613089d33962
2020-11-10 13:31:43 -05:00
Tao Sang 6db4976759 Make directed_test support static libs
1.Make directed_test apps linked against static libs
    of hip, rocclr, rocr, roct and amd_comgr.
    2.Remove custom_target amdhip64_static_combiner.
    3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
    4.Simplify argument list parsing.
    5.Install rocclr when rocm is installed.
    6.Fix some original small bugs.

Revert "Revert "Make directed_test support static libs""
This reverts commit 0d1cf31eb1.

Change-Id: I918eeae94487e5e2ff5bfde083667ac65fb6e702
2020-10-26 12:39:58 -04:00
Sourabh Betigeri b65314d168 SWDEV-251091: Added null checks and empty file check in hip_module and hip_platform
Change-Id: Iad99f996dcf90ffb86f62e79bf4cbd53b35b7e3b
2020-10-20 19:55:01 -04:00
kjayapra-amd c18a791c80 SWDEV-250005 - Fixing error code propagation to HIP outer layer.
Change-Id: I0c0e87dbace0b1182f24411200abdfd9cab3f865
2020-10-20 09:43:57 -04:00
Sarbojit Sarkar a73d1a1fe0 SWDEV-256325 : Fix for hipMemset2D crash
Change-Id: I1f434602fecd4fb935d2bc72f2c72d6a2d4c45fe
2020-10-20 02:54:29 -04:00
Rahul Garg 4b7c8f5fc1 Fix PCI bus domain ID query
SWDEV-256338

Change-Id: I5db361bd2899a5bf761ecf05ecd4635f9e3dce1d
2020-10-19 12:02:50 -04:00
Rahul Garg cc1101f97a Fix maxTexture1D query
Needed by SWDEV-254068

Change-Id: Ib43a3e5e96d3882af354208063e5502673c0f35a
2020-10-14 17:32:04 -04:00
agodavar 4018464960 SWDEV-249870: Short-Term solution for Pre-Compiled Headers for Online Compilation - Fix static build
Change-Id: Ib608e73dbffa2d803599cba5ba842cd5a2a2ba9d
2020-10-14 00:37:46 -04:00
German Andryeyev 15ba5611ba Report managed memory capabilities
Change-Id: I241a42e26ee49fb47dcb3ba87c4bd8fb691dffdf
2020-10-13 16:09:43 -04:00
Aryan Salmanpour 89964dbbd4 Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247
2020-10-13 11:14:41 -04:00
Julia Jiang c144b57d54 SWDEV-249487-remove two HCC related APIs
Change-Id: Icf90ece0808643e0c5f0cc00b6644d5171b553d8
2020-10-13 11:08:37 -04:00
agodavar 7d67573a4f SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ia19e6806a476d3c6ecd3e9a89c3ed72953a4900c
2020-10-12 06:04:14 -04:00
Tao Sang 0d1cf31eb1 Revert "Make directed_test support static libs"
This reverts commit 36c5679efc.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ib2d1084ea21461f70f96f95c6025a08f88288357
2020-10-12 00:01:13 -04:00
Tao Sang 36c5679efc Make directed_test support static libs
1.Make directed_test apps linked against static libs
of hip, rocclr, rocr, roct and amd_comgr.
2.Remove custom_target amdhip64_static_combiner.
3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
4.Simplify argument list parsing.
5.Fix hip_pch.o missing issue in samples' build.
6.Fix some original small bugs.

Change-Id: I30f5e65367613152ce86b80b13e1c9f2a28da803
2020-10-08 22:46:58 -04:00
Sarbojit Sarkar a3b44b5f75 [perf]hipMalloc perf optimization
Change-Id: I9cd1d29205cb0c9938d26bb8e336fc9fe8a262ed
2020-10-06 12:22:57 -04:00
Vladislav Sytchenko 8034467ec3 Change __HIP_ENABLE_PCH to be an option
Currently all the logic checks if __HIP_ENABLE_PCH is set, so setting it
to OFF will still enable PCH.

Switching __HIP_ENABLE_PCH to be a CMake option will enable correct
build behaviour.

Change-Id: I77a663589ffb5f2595c6ad3d144eb9466adcf250
2020-10-06 11:17:47 -04:00
kjayapra-amd 40322a9f1c SWDEV-254363 - Checks to make sure kernel is launched on the same device as it was launched.
Change-Id: I2f273a70b1a5fc0e9fc9c6144eabd32466ff4e59
2020-10-06 08:38:09 -04:00
Rahul Garg 2a5d39cd3b Remove libhip_hcc references
These were added in commit 2cce9170c3.

Change-Id: I5815c90bb83ac74730f6bce114eb353f54b86670
2020-10-06 04:29:35 -04:00
Vladislav Sytchenko d5aa0f607d Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
This reverts commit 9142674ef0.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko 9142674ef0 Revert "Merge branch 'amd-master-next' into amd-npi-next"
This reverts commit d7c02619d6.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721
2020-10-05 13:02:39 -04:00
German Andryeyev ef5d9bd562 Fix error codes in HMM interfaces
Change-Id: I16490c575f2840b1116a4135431a611cf812f3a4
2020-10-05 12:54:16 -04:00
Jatin Chaudhary c9d996a0a8 Use availableRegistersPerCU_ to populate number of registers
Change-Id: I58f2323bf454f910d22ab31f05aa3024a3d1106f
2020-10-05 00:33:27 -04:00
Aryan Salmanpour 4817ec4778 fix a bug for calculating the prev_sum of MGSyncInfo struct used in multi-gpu cooperative launch
SWDEV-251619

Change-Id: I6566bfc9384bb4677562085991a7a01d3cea3935
2020-10-01 14:05:22 -04:00
Sarbojit Sarkar d4fa2e8c80 SWDEV-253654 : Added invalid parameter checks
Change-Id: I8a2ae1ee6898f111aac1c68663a653cca410daec
2020-09-29 13:20:27 -04:00
Julia Jiang 3d59e050db SWDEV-247518-fix HPC multi gpu test performance drop
Change-Id: I2f07d9ba183cf88b3845d8d61607a8a0462d015f
2020-09-29 12:04:40 -04:00
Aryan Salmanpour a680b514b3 fix a pagefault when wrong argument (extent) passed in hipMemset3D API
Change-Id: I779fc14ccd7c942d1ae0a938ebfd3c2e728ff761
2020-09-25 10:57:37 -04:00
kjayapra-amd 19acb0bfe5 SWDEV-241896 - Remove extern support in ROCclr/HIP since compiler added Texture reference support.
Change-Id: I1b0a7377b803b4e2b94ffef6ffd91e376fdb2b2f
2020-09-24 14:28:16 -04:00
Rahul Garg 2f3d60fc4a Return hipMemoryTypeHost as memory type for hipHostRegistered pointer
Fixes SWDEV-253741
Change-Id: I42c2c9df00862157314d5767b6f175a0d2f28b47
2020-09-24 12:27:32 -04:00
agodavar 3c9bbc335a SWDEV-249870 - Short-Term solution for Pre-Compiled Headers for Online Compilation
Change-Id: Iec989787e546ff2eb68c4b146dc540655698b569
2020-09-24 12:18:06 -04:00
Jatin 2cce9170c3 CMake changes to now write to test folder
Change-Id: Ia898b31a09f3c59ef8e7d64253f28ae93c501277
2020-09-21 00:37:15 -04:00