İşleme Grafiği

1006 İşleme

Yazar SHA1 Mesaj Tarih
Siu Chi Chan b2dff85550 fix compilation error when host compiler is clang (#1147)
* fix compilation error when host compiler is clang

* use a macro specifically for hcc && hip-clang


[ROCm/hip commit: 72e51f3ad0]
2019-05-29 12:34:48 +05:30
Maneesh Gupta d5e847f2a3 Header changes for cooperative groups
Change-Id: I5f3acca94275d74adc97adcb168aed9f74951189


[ROCm/hip commit: 21a9e05867]
2019-05-28 16:58:55 +05:30
Maneesh Gupta 77010ad8e8 Merge pull request #1128 from aaronenyeshi/fix-smid-func
Fix bug in __smid not setting correct size

[ROCm/hip commit: 68ae4a0a3e]
2019-05-24 14:16:12 +05:30
Aaron Enye Shi b08cbff718 Fix bug in __smid not setting correct size
The SZ field should minus by 1 since SIZE range is 1..32. Also add comments that results may vary.


[ROCm/hip commit: ff74babedf]
2019-05-22 19:20:09 +00:00
Evgeny Mankov c24d90afb3 [HIP] fix typo in #1127
[ROCm/hip commit: eede980a39]
2019-05-22 20:48:18 +03:00
Evgeny Mankov 9ebc775254 [HIP] fix nvcc path break in #1127
[ROCm/hip commit: 47bbb9c605]
2019-05-22 20:04:45 +03:00
Evgeny Mankov cd309b6638 [HIP][HIPIFY] Make hipMemcpyParam2D coherent with cuMemcpy2D
+ Makes hip_Memcpy2D struct compatible with CUDA_MEMCPY2D struct
+ Add hipMemcpyParam2D support in nvcc fallback path
+ Update hipify-clang, tests and docs accordingly


[ROCm/hip commit: 8f059b0ee9]
2019-05-22 18:31:39 +03:00
Alex Voicu d5a3acfd69 Add HIPRTC, glorious ersatz for NVRTC (#1097)
* Add ersatz for NVRTC.

* Fix extraneous paren and use correct namespace.

* Use lowerCamelCase (yuck, yuck) consistently.

* Link against FS when building hiprtc lib.

* Correctly mark Manipulators. Fix dual compile.

* Add unit tests. Extend HIT to accept linker options.

* Make sure the HIPRTC library is installed.

* Better logging. Try to auto-detect the target.

* Stop specifying the target explicitly.

* Add missing flavour of `hipModuleLaunchKernel`.

* Program was already destroyed.

* Don't use `--genco`. Fix mangled name trimming.

* Fix HIPRTC breakage due to upstream noise.

* [dtests] Replace RUN -> TEST in hiprtc tests

Change-Id: Ie499e92dfe4e5c94634b1c2b76cf52d241bcfea3

* [hit] Set HIP_PATH to HIP_ROOT_DIR for all tests

Change-Id: Ib0ad1f99bc71c03e363e055dd508a7a4a210680a


[ROCm/hip commit: ccfb764a59]
2019-05-16 18:28:54 +05:30
Wen-Heng (Jack) Chung 3264991e58 Revert "HACK for SWDEV-173477" (#1004)
* Revert "HACK for SWDEV-173477"

This reverts commit 3eb009913c.

[ROCm/hip commit: 9b9257f9b0]
2019-05-13 14:42:05 +05:30
Rahul Garg c4567ad01a Add fine grained host memory lock support (#1095)
* Add fine grained host memory lock support

* Fix default flag check


[ROCm/hip commit: aeeab1b23f]
2019-05-13 11:48:26 +05:30
Siu Chi Chan d0252dfa79 migrate program_state logic from header into shared library (phase I) (#1077)
* Revert "Revert "Use COMgr to read Kernel Args Metadata (#1006)""

This reverts commit 62e96cb4cf.

* Revert "Use COMgr to read Kernel Args Metadata (#1006)"

This reverts commit 882006555b.

* Revert "improve program state commentary"

This reverts commit fb2beb0c88.

* Revert "load program state once per agent"

This reverts commit 21f5e142f5.

* start moving function_names() into the hip shared lib

* start moving code_object_blobs to a new "state" object

* Consolidate various program state related static objects into a
single program_state object

* minor clean up

* move more stuffs from functional_grid_launch into program_state

* debug make_kernarg

* moving lookup for kernargs size_align into program_state

* clean up old code for kernarg size and alignment

* update hip_module to use newer api in program_state

* Create public member functions for program_state

* move most program state functions into shared library

* Pass the data buffer size to load_executable
Otherwise, it can't figure what the data size is
just from the char* (since the data is not really a string)

* turning free functions in program state into members of program_state_impl

* change the free function globals() into a member of program_state_impl

* replace the static mutex used for populating globals

* moving associate_code_object_symbols_with_host_allocation into
program_state_impl

* move load_code_object_and_freeze_executable into program_state_impl

* moving executables and functions_names into program_state_impl

* moving kernels() into program_state_impl

* moving functions() into program_state_impl

* move get_kernargs into program_state_impl

* moving kernel_descriptor into program_state_impl

* moving kernargs_size_align calculation into program_state_impl

* Changing the handle to program_state_impl to a pointer

* moving program_state_impl into a separate inline source file

* fixing/cleaning up some header file includes

* moving member function for kernargs_size_align into program_state.cpp

* moving Kernel_descriptor into program_state.inl

* add a new class to manage agent globals

* moving all agent globals processing functions into agent_globals_impl

* load program state once per agent

re-merging PR991 against other program state changes

* fix per-agent program state member initialization

* cache executables based on elf name, isa, and agent.

This avoids program state reloading executables after a shared library is dlopened.

re-merging PR1057 against other program state changes

* protect executables cache by a global mutex

* return ref to executables cache

* adapt PR#981 Make hipModuleGetGlobal be in HIP runtime


[ROCm/hip commit: f5eb91d53d]
2019-05-12 19:24:03 +05:30
Maneesh Gupta 1f94348f2e Merge pull request #1084 from mhbliao/hliao/master/api_ext
[hip] Add API `hipExtModuleLaunchKernel` in HIP runtime

[ROCm/hip commit: 5b607e14a6]
2019-05-09 18:26:31 +05:30
Maneesh Gupta 049c0d84bb Merge pull request #1082 from gargrahul/fix_hipmemcpy_symbol_nvcc
Fix symbol address issue on NVCC path

[ROCm/hip commit: 7264f6b64e]
2019-05-07 16:17:01 +05:30
Maneesh Gupta 36d37296d5 Merge pull request #1081 from mangupta/swdev-181624
Implement hipExtGetLinkTypeAndHopCount for ROCm devices

[ROCm/hip commit: d5abe65668]
2019-05-07 16:15:41 +05:30
Maneesh Gupta 0527ac9038 Merge pull request #1068 from mhbliao/hliao/master/dev_vec_func
[devfunc] Add necessary `__device__` and `__host__` attributes.

[ROCm/hip commit: d82d6b499e]
2019-05-07 16:01:48 +05:30
Michael LIAO 0c41f2298d [hip] Add API hipExtModuleLaunchKernel in HIP runtime
[ROCm/hip commit: 5150f1297a]
2019-05-06 21:20:28 -04:00
Rahul Garg d700f67b79 Fix symbol address issue on NVCC path
[ROCm/hip commit: e906bd69ce]
2019-05-07 03:59:43 +05:30
Maneesh Gupta f7eaff474b Implement hipExtGetLinkTypeAndHopCount for ROCm devices
Change-Id: Ie5bb4f640ac6d189c7fceeab22627a7494fd10bd


[ROCm/hip commit: 035ef04e1f]
2019-05-06 15:54:31 +05:30
Maneesh Gupta f49a4c6d89 Merge pull request #1062 from mhbliao/hliao/master/icmp
[hip] Re-implement ballot using AMDGCN builtins

[ROCm/hip commit: 117bdd8774]
2019-05-03 17:48:19 +05:30
Michael LIAO 2c2b897902 [devfunc] Add necessary __device__ and __host__ attributes.
- Minor clean up to keep consistent function declaration.


[ROCm/hip commit: 44692978fe]
2019-05-01 22:26:35 -04:00
Michael LIAO e637e72364 [Device Function] Fix implementation of __bitinsert_u64
- It's a common mistake by assuming 1 << shamt would be promoted to
  64-bit, if shamt is a 64-bit integer. That's not the case. Replace
  that left shift to a 64-bit one to ensure it won't fall into undefined
  behavior.
- Fix the host-side implementation as well for device function testing.


[ROCm/hip commit: 9bd2d5746d]
2019-04-30 08:59:13 -04:00
Michael LIAO cc4de2bc28 [devfunc] Re-implement ballot using AMDGCN builtins
- As the signature of `amdgcn.icmp` is changed for next-gen chip, using
  clang builtins is portable way to hide that details.


[ROCm/hip commit: a64637da2c]
2019-04-29 17:21:25 -04:00
Aaron Enye Shi 62e96cb4cf Revert "Use COMgr to read Kernel Args Metadata (#1006)"
This reverts commit 882006555b.


[ROCm/hip commit: a3d118eaa8]
2019-04-26 16:04:56 -04:00
Maneesh Gupta c36aa3a056 Merge pull request #1043 from mhbliao/hliao/master/fp16
[hip] Fix including of hip_fp16.h

[ROCm/hip commit: ffe9f86fe8]
2019-04-24 16:50:46 +05:30
Maneesh Gupta 7938012378 Merge pull request #1042 from mhbliao/hliao/master/ldg
[hip] Fix use of `__HIP_CLANG_ONLY__` in `hip_ldg.h`.

[ROCm/hip commit: de6c680767]
2019-04-24 16:50:37 +05:30
Maneesh Gupta 7b5ed45968 Merge pull request #1040 from eshcherb/roctracer-hip-frontend-190422
hip_prof_api.h include under __cplusplus

[ROCm/hip commit: e489f7579a]
2019-04-24 16:50:27 +05:30
Maneesh Gupta 5235da375e Merge pull request #1039 from gargrahul/fix_ptrgetattr_nvcc
Fix hipPointerGetAttributes for NVCC

[ROCm/hip commit: 2975221560]
2019-04-24 16:50:18 +05:30
Rahul Garg c01236f679 Add hipMallocManaged default functional support (#1036)
* Add hipMallocManaged default functional support

* Fix build error

* Add dtest


[ROCm/hip commit: 2bc2c46d4d]
2019-04-24 16:50:03 +05:30
Michael LIAO 6eec9d4ac8 [hip] Fix including of hip_fp16.h
- Separate the definition of `__HCC_OR_HIP_CLANG__`, `__HCC_ONLY__`, and
  `__HIP_CLANG_ONLY__` into hip_common.h so that it could be included in
  hip_fp16.h, which may be included separately in app.


[ROCm/hip commit: dc0d7bd5ce]
2019-04-23 09:16:00 -04:00
Michael LIAO 27aed8c172 [hip] Fix use of __HIP_CLANG_ONLY__ in hip_ldg.h.
- Check its value instead of whether it's defined or not.


[ROCm/hip commit: 6fb07acc8c]
2019-04-22 23:22:32 -04:00
Evgeny 17474d2b58 hip_prof_api.h include under __cplusplus
[ROCm/hip commit: af3f3ccb2b]
2019-04-22 21:14:18 -05:00
Rahul Garg be49602b29 Fix hipPointerGetAttributes for NVCC
[ROCm/hip commit: 69a3d6b72a]
2019-04-23 03:22:25 +05:30
Konstantin Pyzhov 2e0c67bbd3 Fix for __popcll() device function implementation.
[ROCm/hip commit: beadaab661]
2019-04-19 08:53:22 -04:00
Konstantin Pyzhov 53b232fb2a Fix for __ffsll() device functions.
[ROCm/hip commit: b7bd29924a]
2019-04-18 13:07:24 -04:00
David Salinas d4c72ad357 Revert "append the ELF flags for sram-ecc and xnack to the target triple per code object"
This reverts commit ee887dd6a2.


[ROCm/hip commit: 5843530a06]
2019-04-18 11:49:40 -04:00
Maneesh Gupta f529a6af13 Merge pull request #995 from david-salinas/add_sram-ecc_and_xnack_flags_to_triple
Append the ELF flags for sram-ecc and xnack to the target triple per code object

[ROCm/hip commit: 8309632e2d]
2019-04-16 09:10:04 +05:30
Maneesh Gupta 8b7cd90f0c Merge pull request #1019 from scchan/lazy_binding
minor workaround for lazy binding

[ROCm/hip commit: d789aef46e]
2019-04-16 08:36:10 +05:30
Mr-LiuSw ba23b5c5db add little changes in hip_runtime_api.h to work with c language (#1017)
* Update hip_runtime_api.h

when i try to use mpicc or gcc to compile a c language code which call some hip runtime api , error occured as
> /path/to/hcc_detail/hip_runtime_api.h:2268:33: error: unknown type name ‘hipFuncAttributes’; 
> hipFuncGetAttributes(hipFuncAttributes* attr, const void* func);
 
add ' struct ' for the first parameter of hipFuncGetAttributes will get ride of this problem.


[ROCm/hip commit: dc07b1b06c]
2019-04-16 08:35:36 +05:30
Aaron Enye Shi 882006555b Use COMgr to read Kernel Args Metadata (#1006)
* Add CMAKE dep to amd_comgr

* Use COMGR for read_kernarg_metadata in COV2

* Do not assume kernargs exist

* Add proper metadata destroy cleanup

* Use a process function for easier destroy

* Remove old read_kernarg_metadata

* Clean up HCC, prints, names

* Use COMGR in CMAKE by default

* Move metadata lookup for keyword values into helper

* Remove C string usage for lookup_keyword_value

* Guard COMGR for non-NVCC path

* Add hip_hcc dependency on comgr package

* Add lifetime to metadata nodes

* Find COMGR config file for amd_comgr target

* Move set_active data earlier


[ROCm/hip commit: 8a548bf40b]
2019-04-16 08:34:39 +05:30
Yaxun (Sam) Liu 9899d0523e hip-clang: Add __align__
CUDA has __align__. Define eqivalent for hip-clang.


[ROCm/hip commit: b9f8f977fb]
2019-04-10 14:17:18 -04:00
David Salinas ee887dd6a2 append the ELF flags for sram-ecc and xnack to the target triple per code object
[ROCm/hip commit: c61f265657]
2019-04-05 13:17:11 -04:00
Siu Chi Chan 23df3b5879 minor workaround for lazy binding
[ROCm/hip commit: e126f7254c]
2019-04-02 17:28:06 -04:00
Wen-Heng (Jack) Chung 1cc94f9369 Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime (#981)
* Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime

In HIP PR #929, quite a few HIP public APIs were made as inline functions with
hidden visibility. It was necessary to support applications with shared
libraries with GPU kernels launched via hipLaunchKernelGGL(), after HIP runtime
is initialized.

In empirical tests, the implementation has been proved to be a bit too
excessive, especially for hipModuleGetGlobal(). The function is used by another
type of client applications which relies on the existence of this function
within HIP runtime so global symbols from HSA code objects loaded dynamically
at runtime can be retrieved programmtically.

This commit moves hipModuleGetGlobal() back to src/hip_module.cpp, and makes it
visible and not inline, to fulfill requirements for applications
aforementioned. It does not change the behavior of applications depending on
hipLaunchKernelGGL().

* Add HIP_INIT_API into the implementation of hipModuleGetGlobal

Address review comments.

* Fix failing HIP unit tests


[ROCm/hip commit: 4b7177ac42]
2019-03-29 03:45:04 +00:00
Jeff Daily fb2beb0c88 improve program state commentary
Disambiguate calling many varibles "agent".
More detail in exception message.
Create and discard map placeholders; no need to call std::vector::clear() on map value.


[ROCm/hip commit: 7aada87cbd]
2019-03-27 21:40:27 +00:00
Jeff Daily 21f5e142f5 load program state once per agent
[ROCm/hip commit: c9117de8eb]
2019-03-27 18:19:10 +00:00
Maneesh Gupta 464c023bb5 Merge pull request #990 from mhbliao/hliao/master/sw
SWDEV-184380 Fix hcc compilation

[ROCm/hip commit: e66dfa6ea3]
2019-03-27 05:23:26 +00:00
Michael LIAO a9a397bc4b SWDEV-184380 Fix hcc compilation
- `hcc` has no builtin. Need to invoke LLVM intrinsic directly.


[ROCm/hip commit: 939d153c1a]
2019-03-26 15:20:17 -04:00
Michael LIAO 94b7856a1a [hip] Fix typo in macro hipLaunchKernel
[ROCm/hip commit: b3497824ec]
2019-03-25 12:06:46 -04:00
Maneesh Gupta 82fd86e63f Merge pull request #970 from mangupta/swdev-172995
hipExtMallocWithFlags implementation

[ROCm/hip commit: 30b5c02ec4]
2019-03-25 07:46:53 +00:00
Maneesh Gupta bfb73dd148 Merge pull request #982 from ROCm-Developer-Tools/hack_swdev-173477
HACK for SWDEV-173477

[ROCm/hip commit: a75f375788]
2019-03-22 09:14:38 +00:00