Alex Voicu
1c815170da
Ensure that static structures are populated
2019-01-09 17:21:53 +00:00
Wen-Heng (Jack) Chung
6e68d44220
Introduce hash key to HIP module implementation
...
A hash calculated via FNV-1a algorithm is introduced in ihipModule_t, the
internal of hipModule_t. The hash is used by HIP module APIs such as
- read_agent_global_from_module
to determine whether the agent-scope globals for a module have been iterated.
This commit fixes one issue that applications which load / unload modules
frequently would occasionally fail. After deep investigation of the issue it
turns out the old implementation in read_agent_global_from_module uses
hipModule_t as the key, which is not robust enough, as hipModule_t instances
are allocated dynamically so there are cases that one memory address may be
used by multiple hipModule_t instances. The real solution is to introduce a
uniquely identifiable hash for the code object associated with the HIP module.
And that's the rationale behind this commit.
2019-01-08 17:33:40 +00:00
Alex Voicu
3470692998
Hook into the creaky lazy-reinit machinery. Try to minimise race-risk.
2019-01-01 11:01:16 +05:30
Alex Voicu
b2f76123b1
More blobs, more problems.
2019-01-01 11:01:07 +05:30
Alex Voicu
3e8f198b58
Start re-working 731 for 2.0.
2019-01-01 11:00:57 +05:30
Maneesh Gupta
a778f7cdf7
Merge pull request #797 from gargrahul/fixhipPointerGetAttributes
...
Fixed hipPointerGetAttributes for hostmalloced ptr
2018-12-12 10:16:07 +05:30
Maneesh Gupta
6ce99b066c
Merge pull request #608 from gargrahul/add_pinned_2d_sdma_copy
...
Added support for pinned 2D SDMA copy
2018-12-12 07:44:16 +05:30
Rahul Garg
77fd517e09
Fixed hipPointerGetAttributes for hostmalloced ptr
2018-12-08 01:42:08 +05:30
Siu Chi Chan
4251a70bc0
Revert "Rely on code object metadat for kernarg arguments alignof and sizeof."
...
This reverts commit 299b9d1382 .
2018-11-29 11:38:37 -05:00
Siu Chi Chan
a41bce5163
Revert "Handle the very confusing dual encoding of the symbol name."
...
This reverts commit 1fe33b4738 .
2018-11-29 11:38:36 -05:00
Siu Chi Chan
dc36c49212
Revert "If we've already seen a __global__ function we do not need to re-parse"
...
This reverts commit 1621deee71 .
2018-11-29 11:38:35 -05:00
Siu Chi Chan
c5df445d1f
Revert "Missing handling nullary __global__ functions for mixed arity cases."
...
This reverts commit 1e64813716 .
2018-11-29 11:38:31 -05:00
Siu Chi Chan
adbf0c444b
Revert "Fix issue in kernarg metadata parsing due to early finalization"
...
This reverts commit ba2b5ff9da .
2018-11-29 11:35:00 -05:00
Yaxun Sam Liu
988dcd1e4a
Let hip-clang support --genco
2018-11-27 15:55:50 -05:00
Maneesh Gupta
3a41a8b1f1
Merge pull request #772 from scchan/kernarg_metadata_early_finalize
...
Fix issue in kernarg metadata parsing due to early finalization
2018-11-26 08:55:19 +05:30
Maneesh Gupta
5bfde06bcc
Merge pull request #773 from fronteer/master
...
Support of printing process ID for HIP tracing
2018-11-23 11:16:22 +05:30
Maneesh Gupta
99bb89b756
Merge pull request #760 from eshcherb/roctracer-hip-frontend-181113
...
Roctracer hip frontend 181113
2018-11-23 11:08:25 +05:30
Qianfeng Zhang
4f85e98384
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP
2018-11-22 19:11:49 +08:00
Qianfeng Zhang
b88c8769ea
Add support of printing process ID for HIP Tracing
2018-11-22 18:58:06 +08:00
Siu Chi Chan
ba2b5ff9da
Fix issue in kernarg metadata parsing due to early finalization
...
The logic to parse the kernel metadata is unaware that enabling
of early finalization could result in multiple code blobs in a
single .kernel section. This teaches the HIP runtime to handle
that.
Change-Id: I1581b42f0da8b30233d7898014f7468728c1d489
2018-11-21 12:09:46 -05:00
Maneesh Gupta
40d3184dd1
Merge pull request #748 from mkuron/getsymboladdress
...
Implement hipGetSymbolAddress and hipGetSymbolSize
2018-11-21 10:32:01 +05:30
Michael Kuron
e9b88711e2
Merge branch 'master' into getsymboladdress
2018-11-20 12:03:22 +01:00
Rahul Garg
aae87e21d2
Fix hipHostRegister
2018-11-17 05:38:35 +05:30
Maneesh Gupta
f769320b5c
Merge pull request #755 from gargrahul/fix_memcpy_symb_nonzerodev
...
Fixed hipMemcpyToSymbol doesn't work on GPU other than device 0
2018-11-14 13:22:22 +05:30
root
0774b275c8
rebase to master, tracer related changes
2018-11-13 15:50:34 +00:00
Evgeny
e362688adf
renaming HIP_INIT_CB_API to HIP_INIT_API
2018-11-13 15:33:26 +00:00
Evgeny
8c88932f30
hip_prof_(api/str).h moving under hcc_detail dir
2018-11-13 15:33:26 +00:00
Evgeny
a13e035fd9
adding lost i the merge change
2018-11-13 15:33:26 +00:00
Evgeny
084a68be63
adding activity prof layer
2018-11-13 15:33:26 +00:00
Rahul Garg
70bb04cc61
Fixed symbol tracking device index
2018-11-13 07:01:17 +05:30
Rahul Garg
ac32566d9b
Fixed hipMemcpyToSymbol doesn't work on GPU other than device 0 SWDEV-166881
2018-11-13 00:49:20 +05:30
Alex Voicu
1e64813716
Missing handling nullary __global__ functions for mixed arity cases.
2018-11-12 01:51:59 +00:00
Alex Voicu
01ec23538e
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_get_alignment_and_size_from_metadata
2018-11-11 22:37:09 +00:00
Yaxun Sam Liu
80b382a37a
Add more checks for fatbin
2018-11-08 16:46:01 -05:00
Alex Voicu
392e2ba1ba
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_get_alignment_and_size_from_metadata
2018-11-08 06:53:06 -08:00
Maneesh Gupta
e510be9395
Merge pull request #730 from yxsamliu/dbg-fatbin
...
Add more checks and debug outputs for fat binary
2018-11-08 11:44:27 +05:30
Maneesh Gupta
0bafc38135
Merge pull request #721 from fronteer/my-fix
...
Make correct checking of the returned hipDeviceptr_t from read_global…
2018-11-08 11:42:08 +05:30
Maneesh Gupta
8b1544c911
Merge pull request #742 from gargrahul/fix_module_global_tracking
...
Fixes global symbols tracking in hip_module
2018-11-08 11:41:35 +05:30
Michael Kuron
357dc8be11
Use correct trace macro in hipGetSymbolAddress/hipGetSymbolSize
2018-11-06 20:46:30 +01:00
Michael Kuron
4da2d92281
Introduce ihipModuleGetGlobal
2018-11-06 09:54:34 +01:00
Michael Kuron
0b6f5791f8
Implement hipGetSymbolAddress and hipGetSymbolSize
2018-11-04 10:39:34 +01:00
Alex Voicu
1c525d7222
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_get_alignment_and_size_from_metadata
2018-11-01 23:17:27 +00:00
Siu Chi Chan
cdd0109e70
Move the global arrays for hip malloc/free
...
from a header into a source file such that
there's only an unique copy in an executable
and prevent wasting static memory on the host
Change-Id: Id5b62766f77809c8d7b47892cb7149c490dcbdb9
2018-11-01 16:20:35 -04:00
Maneesh Gupta
a75d4c0ecc
Merge pull request #733 from ex-rzr/fix_array_alloc_size
...
Fix allocation size of arrays with multiple and/or non-32-bit channels
2018-10-31 14:08:58 +05:30
Maneesh Gupta
c7f2198c6e
Merge pull request #714 from aaronenyeshi/remove-static-hip-device
...
Remove libhip_device.a static library
2018-10-31 14:08:29 +05:30
Maneesh Gupta
8f667984af
Merge pull request #713 from scchan/master-hcc_early_finalize_support
...
Support more than one device code blobs in a single .kernel section
2018-10-31 14:04:06 +05:30
Alex Voicu
1621deee71
If we've already seen a __global__ function we do not need to re-parse
2018-10-30 23:34:27 +00:00
Rahul Garg
592efa017f
Fixes global symbols tracking in hip_module
2018-10-31 03:22:38 +05:30
Alex Voicu
1fe33b4738
Handle the very confusing dual encoding of the symbol name.
2018-10-30 01:55:09 +00:00
Anton Gorenko
6e6297f3cd
Fix allocation size of arrays with multiple and/or non-32-bit channels
...
hipMallocArray and hipMalloc3DArray must use sum of bits
of all components.
2018-10-29 18:12:00 +06:00