Commit Graph

1263 Commits

Author SHA1 Message Date
Dalibor Stanisavljevic 77728c48f3 SWDEV-397054 - Added ecc info (accummulated number of ECC errors)
Change-Id: I75f6fc402d8c62046c4ccd581347360343aea0e4
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: 6cce103fba]
2023-05-09 10:48:02 +02:00
Ranjith Ramakrishnan d248adcf16 SWDEV-383221 - Set the default value of ROCM_HEADER_WRAPPER_WERROR to OFF
Using wrapper header files will result in #warning message by default

Change-Id: I8941a96bdc1b921a7646ccb353130cb283957ff8


[ROCm/amdsmi commit: daffcdb930]
2023-05-08 16:56:52 -07:00
Dalibor Stanisavljevic dbd6fe5768 SWDEV-397055 - Remove mm_ip_list from caps
Change-Id: Ia4f337d24744fc545e8336705fe7a2b2d9b5f8db
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: b36f040bf9]
2023-04-28 03:54:24 -04:00
Galantsev, Dmitrii 135971e3bf CMake: Install amdsmitst.exclude
Change-Id: I166cbd265cf9074e17cad39fddac77988e2fd686
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 3d00ae1240]
2023-04-27 11:58:03 -04:00
Dalibor Stanisavljevic c9f3e7683b SWDEV-392029 - Added support for guest
If one API fail, tool will work properly for all other arguments

Change-Id: I7b996e6da87873efb9d3210398971ea22203ac44
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: f8e7d93a69]
2023-04-25 10:17:13 -04:00
Maisam Arif 0c84413614 SWDEV-392033 - Topology gpu index fix
Fixed Topology csv output
	Added README.md for amd-smi

Change-Id: I05819b883af01c19383ee4f220923798fc7453e2
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 515adfb61f]
2023-04-25 09:16:17 -05:00
Marko Oblak bdc4abb376 SWDEV-393084 - [AMDSMI] [Linux] [Guest] Added checking of return values of subfunctions in function amdsmi_get_power_cap_info and added handling errors
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: I3bfcc6003d018add683d30efc9d038bdb6af072c


[ROCm/amdsmi commit: 9b476baf8e]
2023-04-25 09:20:40 -04:00
Dalibor Stanisavljevic 9ea55651b9 SWDEV-392029 - Implemented platform detection
Change-Id: Ieefccf65c35f17ffa17761139a0ae56ef5438341
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: cd15cf1cf4]
2023-04-24 14:57:42 +02:00
Maisam Arif d5a6159233 SWDEV-392033: Added Topology Command
Change-Id: Ib1d007aee9937e3062d0e9c9898ca9198a585132
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 39da929fe4]
2023-04-21 15:33:18 -05:00
Maisam Arif 582cab11ff SWDEV-380722 - Watch Modifier
Updated CSV & Watch output
Change-Id: If88b9375482dbb9afa4e24b1847397b65d73d050
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 543c573cc7]
2023-04-21 15:09:53 -05:00
Maisam Arif 1de2329c18 SWDEV-380688 - Added CSV Format
Change-Id: I609bc9837132fd674bf54480a3220c911b2909d2
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 8ad410f6af]
2023-04-20 00:06:20 -05:00
Bill(Shuzhou) Liu a1c2a246b1 Crash if no hwmon sysfs
Return NOT_SUPPORTED if no hwmon sysfs.

Change-Id: I8f4bea0d74619150aee7dfc21fe62d24018e2994


[ROCm/amdsmi commit: b39a56fc52]
2023-04-19 05:46:02 -04:00
Marko Oblak 29a981ecab SWDEV-394359 - [AMDSMI] [Linux] [Guest] Resolved issue: status string and socket info API failing
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: I6fe3beafbf2cd3d2701dd5f78dac2bcf2d9b3aa9


[ROCm/amdsmi commit: 5e168c8f6a]
2023-04-19 05:43:25 -04:00
Maisam Arif d048ee8e14 SWDEV-381302 - Added Error handling for Set & Metric
Bug Fixes for Set and Fan
Updated lib_amdsmi.so directory access
Backwards compatability fixes for gpuv-smi

Change-Id: I3b7977859c750c1c3d6f41eaa761c81d8b9e5184
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 0830e983d8]
2023-04-18 10:27:50 -05:00
Dalibor Stanisavljevic d13f16e2c9 SWDEV-381302 - Added error handling
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>
Change-Id: Ia69c8aebdaa23e212c0ce2522201092bab54e732


[ROCm/amdsmi commit: 06f12c4700]
2023-04-18 14:00:11 +02:00
Charis Poag fc18ccd37a [SWDEV-392571] Fix concise info when missing VRAM info
Updates:
    * [rocm-smi] Added larger app width size, which helps
      display missing device info
    * [rocm-smi] Added better context when rsmi_ret_ok
      does not return with RSMI_STATUS_SUCCESS
    * [rocm-smi] Removed all references to an
      undefined function (printLogNoDev())
    * [rocm-smi] Fixed not detecting non-int
      values when setting the voltage curve
    * [rocm-smi] Added better context on missing
      sysfs file when setting clock overdrive
      values
    * [rocm-smi] Fixed getMemInfo() calls not
      referencing tuple values (making it easier
      to read)
    * [rocm-smi] Silenced concise info spitting
      out errors for missing VRAM files, instead
      display which metric is "unsupported" if
      the files are missing
    * [rocm-smi] Updated function descriptions for
      rsmi_ret_ok & getMemInfo
    * [rocm-smi] Updated getMemInfo to provide a
      quiet call, to silence for concise info calls.
      This provides a way to keep the output clean.
    * [rocm-smi-lib] Added when using debug sysfs
      files, to state, which enums are enabled
      for debug

Change-Id: I0e9e0c97ccf71467ced0e1a1f71803327a8be2b7
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 6be92b9e26]
2023-04-13 15:11:35 -04:00
Bill(Shuzhou) Liu 759d14709d Validate the clock frequency when set it
Add the check of the clock frequency when set it.

Change-Id: I707291bfb5007bb69100c780af50a4b0f697bb37


[ROCm/amdsmi commit: b6789891b0]
2023-04-06 11:54:38 -04:00
Charis Poag a3c5120159 [SWDEV-391036 + SWDEV-392933] Fixes for VoltRead and ComputePart.
Updates:
    * VoltRead - needed to properly send out RSMI_STATUS_NOT_SUPPORTED
      when device does not have voltage hwmon files
    * ComputePart. - test failure was likely caused due to EvtNotif
      causing conflicts (unknown exactly why). Test passes when
      moving it ahead of the event notifier. Both API calls may have
      a system resource issue, TBD.
    * rocm_smi_example - now indicates when an API call
      returns RSMI_STATUS_NOT_SUPPORTED or
      RSMI_STATUS_NOT_YET_IMPLEMENTED. Allows example to fully complete
      on systems which may not provide support for all API calls.

Change-Id: I520b8584e078d412414e8e5797c664220a7e823a
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 78a0812f7f]
2023-04-05 12:44:29 -05:00
Maisam Arif 5743058efb CI Build directory fix
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I7600c3c4c2fd45ca240ee8ec04de55dc29c26365


[ROCm/amdsmi commit: 452bffb6b4]
2023-03-30 11:38:58 -04:00
AravindanC 49ac5ae1e1 SWDEV-351540 - ASAN packaging for amd-smi added amdsmi_cli and py-interface under dev comp
Change-Id: Ifa7a2e5e280f2d0ef8868c63cd4ba94ca75a3468


[ROCm/amdsmi commit: 35b9c40c7d]
2023-03-30 08:10:17 -07:00
Maisam Arif 584d563ed9 AMDSMI CLI Version 0.0.2
Added Rocm Set Commands
Wrapped all amdsmi_interface calls with error handling

Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ic6b3648ef01ded8ee1fb7f0f14f3ca7bc069c567


[ROCm/amdsmi commit: 4cc7244fb6]
2023-03-30 01:25:11 -05:00
Bill(Shuzhou) Liu c71312a760 Increase the max BDF ID length
Increase the max length from 256 to 512.

Change-Id: I3114f7ce6852aafa9dfec0186f27c1121c939c69


[ROCm/amdsmi commit: 58c83eb379]
2023-03-29 10:04:28 -04:00
Bill(Shuzhou) Liu b875784232 Correct subsystem name by matching device id.
The rsmi_dev_subsystem_name_get() only matches subvendor id and
subdevice id for a vendor. The change will also match device id.

Change-Id: Ife3aedaf6fc7390ed7fa62edbde40c2340689b23


[ROCm/amdsmi commit: 0c82a9d577]
2023-03-28 15:48:31 -05:00
AravindanC e8a95d9028 SWDEV-351540 - ASAN packaging for amd-smi
Change-Id: I5f0bf5330727e11159db87c2814904a2832df385


[ROCm/amdsmi commit: 689d58d2c9]
2023-03-23 10:40:10 -07:00
Galantsev, Dmitrii bb2a7811a4 CLI: Remove python dependency
Python is no longer used for generating any CLI files

Change-Id: I70dff5d86df9a179f99b32630dada9e92391eaaa
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: e92afab18e]
2023-03-22 08:14:53 -05:00
Galantsev, Dmitrii 9aa803cfc0 CLI: Make compatible with python3.6
Wrapper generation is still only compatible with python3.7 and above

Change-Id: I33cdc3925cd3fab80c9ce5f4540e1a981a5cc1f0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: adceb8033d]
2023-03-21 17:09:55 -05:00
Galantsev, Dmitrii a94331f293 CMake: Replace .whl with libexec install
Generating .whl has proved to be difficult with AMD CI.
Switch to directly installing python projects instead.

Change-Id: I8a4c2fe22fc872865bba7da3a3386513efd5269a
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 87b9faf926]
2023-03-20 21:24:39 -05:00
AravindanC 7e2d0970e5 SWDEV-351540 - ASAN packaging for rocm_smi_lib
Change-Id: Iab354d02d261a0270a3d118b825835fc6f021c15


[ROCm/amdsmi commit: 778f3b7fdc]
2023-03-20 13:14:53 -07:00
Maisam Arif 24c96943d4 AMDSMI CLI Initial Packaging
- Added CMake packaging to the amdsmi_cli folder
- Updated Headings in the README.md to follow markdown standard
- Updated Compatibility to be based on the built package name in bin
- Added misc error handling and import corrections
- Updated py-interface amdsmi_exception imports to work by relative path
- Cleaned up py-interface cmake & generator code for finding libamd_smi.so
- Changed line endings in tools/generator.py file to unix

Change-Id: I91858ff3dd0cb57ed9b8cd61a0ada27b6af9c51c
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 235c8db949]
2023-03-20 10:50:21 -05:00
Maisam Arif b8f463cda5 AMDSMI_CLI version 0.0.1
Change-Id: I0b02ddf1cc22753635062475cccadcc235e3a603
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: aa70b77ec5]
2023-03-20 08:51:35 -05:00
Charis Poag e543fc1e0c [SWDEV-387906] Fix rocm-smi initialize crash
Fix was needed due to hwmon updates.
Several voltage sensors (ex. vddgfx/vddnb)
are unsupported or not applicable
to upcoming hardware. This was not the case
for previous hardware sensors, resulting in
the rocm-smi crash observed.

Change-Id: Ib8593e10811638def26fc7a1eda29309e328db09
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: f44d1ea8bc]
2023-03-17 15:04:34 -05:00
Galantsev, Dmitrii 446f1d1c15 Improve python wrapper generation
- Add "BUILD_PACKAGE" option that is OFF by default (CI issues)

- Optionally package wrapper if python3.7 or above is present (hack for CI)
- Optionally build wrapper if clang is present (hack for CI)
- Improve dependency resolution for wrapper
- Use python venv
- Use pyproject.toml instead of setup.py
- Use CMake install path to search for libamd_smi.so
- Move python-specific CMakeLists into py-interface
- Search for libamd_smi.so more aggressively

Change-Id: Ie7dad676b0d4a5f58ad2b887db7fecf5b1297e3b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 74479187d0]
2023-03-16 09:13:56 -05:00
Dalibor Stanisavljevic feffb7dd00 SWDEV-387561 - Fixed market name
In case there is no device id to map to the corresponding market_name,
the rsmi_dev_brand_get function is used to retrieve the market_name

Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>
Change-Id: I565089d34b2b7e5f714e0dd41062ac8d52095835


[ROCm/amdsmi commit: 3af2687f17]
2023-03-15 12:54:14 +01:00
Bill(Shuzhou) Liu 6d5a10d914 Fix cppcheck static analysis report warning
Fix some warning from static anaysis tool.

Change-Id: I7e8c2f5d6f79aff5fdcad81b1fd832900f213c47


[ROCm/amdsmi commit: 1b7eb4e1f4]
2023-03-13 09:27:19 -05:00
Ranjith Ramakrishnan ea950b8778 SWDEV-366831 - Compile time flag to switch between #warning and #error message
Using backward compatibility paths will provide an #error message. Compile time option added to enable/disable the #error message.
Disabling the same will provide a #warning message

Change-Id: Ib49633501aa6eb6d97158b1ecfc47de6f18fba85


[ROCm/amdsmi commit: 14b86107a7]
2023-03-10 08:56:45 -08:00
Bill(Shuzhou) Liu e18c56efd8 amdsmitst crash when read ECC counter
If the amdsmi is fail to read ECC counter from sysfs file, it
still assumes the data is read into vector, which causes crash.

Add the check to make sure the data is read into the vector.

Change-Id: Ia24331ee6e75408120248b0ed7bc58581a2f23ad


[ROCm/amdsmi commit: ad3b7d9f0d]
2023-03-08 09:13:04 -05:00
Bill(Shuzhou) Liu 41349aa57b Filter out the GPUs not assigned to a container in showpid
The process ids of other container are still visible in the sysfs file,
filter it out to prevent crash.

Change-Id: I665912cd09c606804186aff8cba5c24f5e58ded7


[ROCm/amdsmi commit: 710649ab66]
2023-03-06 11:05:02 -06:00
Marko Oblak c5054f75f4 SWDEV-379772 - [Navi32] [SMI-LIB] [Linux] [BM] [Guest] Wrong market name
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: I12d3e650851a3aa474ccbf62628b60d4c385e68c


[ROCm/amdsmi commit: d1325fcf40]
2023-03-06 17:08:33 +01:00
Charis Poag d2497bb2d3 [SWDEV-335697 + SWDEV-342812] Fix NPS & Compute tests
Updates:
    * Fixed rsmi_dev_compute_partition_get
      & rsmi_dev_nps_mode_get to properly check
      for invalid arguments
    * Updated compute partition & NPS mode tests
      - Now properly confirms the invalid
        argument is seen
      - Spacing for multiple devices is added
        to better see distinction between
        separate device's tests (for verbose output)
      - Changed expect to assert calls, so errors
        are observed faster for test failures
      - Fixed multiple device testing where a
        variable should have been unset, but
        having multiple devices caused it to
        set
      - Updated multiple device testing to iterate
        accross all devices (previously returned,
        instead of continuing checking support
        after RSMI_STATUS_NOT_SUPPORTED detected)
      - Fixed a few spelling errors & verbose output

Change-Id: Ieba9e5b46763c6cd880fbf27fcdf58be8ecbc683
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: c252ecccd1]
2023-03-02 13:24:38 -06:00
Marko Oblak f59498bb9d SWDEV-371210 - [AMDSMI][LinuxBM] SMILIB returns wrong pcie speed value
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: Ie3ca6997f11d18505df799fef9cd9d53716d53f9


[ROCm/amdsmi commit: 8429df989c]
2023-02-28 11:49:20 +01:00
Bill(Shuzhou) Liu f3b32d05df mem_use_pct uninitialized error
Initialize mem_use_pct if the memory info is not available.

Change-Id: Id8e285050149c51077356826c8f99719b473060d


[ROCm/amdsmi commit: fcb6afa289]
2023-02-27 16:47:45 -06:00
Charis Poag ff26973e15 [SWDEV-335697] Add RSMI_STATUS_SETTING_UNAVAILABLE for dynamic partition
Updates:
    * Added RSMI_STATUS_SETTING_UNAVAILABLE for
      rsmi_dev_compute_partition_set - gives users
      better error output when attempting to set
      compute partition to values not listed in
      available_compute_partition SYSFS
    * Updated python --setcomputepartition to
      provide better output when receiving
      RSMI_STATUS_SETTING_UNAVAILABLE
    * Updated all test & example files to check for
      RSMI_STATUS_SETTING_UNAVAILABLE when doing
      rsmi_dev_compute_partition_set

Change-Id: Ida5d54880d9b9b6e4a0468cdb962fdc0c18d6257
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 0d3558945b]
2023-02-27 11:17:44 -06:00
Bill(Shuzhou) Liu c4d64a56d8 Memory usage division by zero
The showAllConcise with division by zero error.

Change-Id: I469f1b9f268842cd51662be6f9036f555a8949b2


[ROCm/amdsmi commit: 55bc2e2072]
2023-02-24 10:12:36 -06:00
Dalibor Stanisavljevic 08e3cdccf4 SWDEV-380736 - Adjusted ouput for amdsmi_get_vram_usage
Change-Id: I6a2cd2353a0c3fafc3a3690098a1e279ecd30378
Signed-off-by: Dalibor Stanisavljevic <Dalibor.Stanisavljevic@amd.com>


[ROCm/amdsmi commit: 7b176fc2df]
2023-02-24 14:47:07 +01:00
Marko Oblak 839c93fa14 SWDEV-384518 - [AMDSMI] [Navi32] [Linux] [BM] [Guest] Fixed RAS enabled Python interface
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: Iacdb57ddc63ea3e7ce5c19506577487ab18c0c89


[ROCm/amdsmi commit: b43b6e71c2]
2023-02-23 15:51:45 +01:00
Marko Oblak f0e658c03e SWDEV-384678 - Resolve issue with amdsmi build failure
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: I073113814d2f6740c9eaea1b298d8aff9ea58c72


[ROCm/amdsmi commit: 7eea4e596b]
2023-02-22 11:00:57 +01:00
Bill(Shuzhou) Liu 5c43dc8160 Use Unified Changelog Template
The CHANGELOG.md is added to track changes.

Change-Id: I33547cb7f1596b4b8abf206aebdd664649d4d19f


[ROCm/amdsmi commit: b40933b895]
2023-02-21 14:27:55 -06:00
Marko Oblak 9c6b1f56d5 SWDEV-373291 - Added implementation of versioning solution
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: Ifd0be3f81902466339b6c098ce16d5e49740056c


[ROCm/amdsmi commit: 0aadf7eab2]
2023-02-21 17:37:54 +01:00
Marko Oblak c9b2dc036f SWDEV-381227 - [AMDSMI][Linux][BM] SMILIB returns wrong temperature value
Signed-off-by: Marko Oblak <Marko.Oblak@amd.com>
Change-Id: Idc9929d1cfd882bb33abf040378587f68d22b31a


[ROCm/amdsmi commit: db9d8793be]
2023-02-21 17:21:15 +01:00
Charis Poag 02ca598e70 [SWDEV-381630] Add reset partition functionality
Updates:
    * Added rsmi_dev_compute_partition_reset & rsmi_dev_nps_mode_reset
    * Added --resetcomputepartition and --resetnpsmode python smi calls
    * Added temp data files rocmsmi_boot_compute_partition_<device num>
      & rocmsmi_boot_nps_mode_partition_<device num>, writes UNKNOWN
      if data cannot be read or device does not support
    * Cleaned up NPS & compute API documentation
    * Added creation and reading of API temp files (used in reset
      functionality)
    * Cleaned up output of rocm_smi_example
    * Updated rocm_smi_example to check if running with sudo permission
      before executing write API calls (cleans up erroneous output)
    * Added template specialization for storing temp data, requires
      specific rsmi_type_t enums (restrics what data can be stored)
    * Added storage of temp data, if temp files do not exist
    * Updated google tests for NPS & compute to include reset API calls

Change-Id: I69895a466b97107617e6dbb355737b84499a76c9
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 77c950a4bf]
2023-02-17 12:55:08 -06:00