Commit Graph

382 Commits

Author SHA1 Message Date
sdashmiz 4dd4970313 SWDEV-408586 - set device active when malloc is called
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ib930d997b7d544d8b6fb42d2fea01fa8a4418e98


[ROCm/clr commit: 173de06658]
2023-07-13 11:39:58 -04:00
taosang2 828c7714e0 SWDEV-408687 - Prevent updating dstXInBytes/srcXInBytes twice
Update pCopy->srcMemoryType and pCopy->dstMemoryType so
 that ihipGetMemcpyParam3DCommand() won't redetect memory
 type. This will prevent dstXInBytes and srcXInBytes getting
 updated twice with offset in hipMemoryTypeUnified type.

Change-Id: Ief4ea81941e25d22bcafd213b3b84a65eb23cf94


[ROCm/clr commit: 56daa6c489]
2023-07-05 09:22:49 -04:00
sdashmiz f07e8cbc95 SWDEV-403382 - param sanity check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibddb2be7d0543676ed9aed71ebb3f5877662c9ae


[ROCm/clr commit: 5f93a59798]
2023-06-27 19:03:34 -04:00
taosang2 9aa3a87b66 SWDEV-368553 – Add missing mipmap Apis
Add missing mipmap Apis’ implementation.
Fix some bugs of mimpmap apis.
Use hipmipmappedArray to differentiate cuda
and driver apis on Nvidia.
Change-Id: I6079d9f3b2ddf4e42b9a6f7f3902322cfca02cfd


[ROCm/clr commit: f03c11491b]
2023-06-22 17:24:21 -04:00
Saleel Kudchadker 60b9dc4a45 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203


[ROCm/clr commit: b2240bcda5]
2023-06-20 14:26:44 -04:00
Jaydeep Patel cb3642e26e SWDEV-398047 - Disable arena for XNACK.
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f


[ROCm/clr commit: ffa1deef27]
2023-05-10 23:28:05 -04:00
Ajay 858a32a24a SWDEV-374386 - hipGraphAddMemcpyNode negative cases
validate 3d memcpy params -
pitch, extend - height/width/depth, src/dst offsets and total size

Change-Id: I629fc242264ebbc3e9dbfd9233da8d3a127500b4


[ROCm/clr commit: 22eae6ac9e]
2023-04-28 12:11:24 -04:00
German Andryeyev b2525dfb82 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d


[ROCm/clr commit: 3e5803c4c0]
2023-04-26 15:25:01 -04:00
Sourabh Betigeri 898340aaa9 SWDEV-392367 - Fixes hipMemGetAddressRange returning device buffer size as 0
Change-Id: I6b5640b544390b2dfc53fad271acc7f30240e274


[ROCm/clr commit: 7aba1cf4cd]
2023-04-25 13:46:52 -04:00
pghafari 0ddd82a5f7 SWDEV-367145 - adding support for timeline semaphore
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492


[ROCm/clr commit: afa15ddb89]
2023-04-25 10:02:43 -04:00
Jaydeep Patel 3bab75e327 SWDEV-389477 - Check D2D is intra device.
Change-Id: Ibef2a6de82a18357ef35bcd70298478de6b0e380


[ROCm/clr commit: 415fb15c76]
2023-04-19 01:01:12 -04:00
pghafari 82219d2fb1 SWDEV-366992 - adding handle type for vk interop
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97


[ROCm/clr commit: 78de2ae692]
2023-04-18 16:59:25 -04:00
taosang2 769f1e166e SWDEV-390626 - Support surface Apis
Change-Id: I1691b82d597bfd722d562778f919ebf8ca530e90


[ROCm/clr commit: 53742adc08]
2023-04-05 16:38:04 +00:00
German 56dedad98b SWDEV-380703 - sync all streams individually
Avoid syncing blocking streams with the default stream,
since that introduces extra command dependencies and
doesn't allow to destroy memory after last submission

Change-Id: I618e9bd2091c4cf9157125612d8c4759030c5a80


[ROCm/clr commit: 1e88d2c52f]
2023-04-05 16:37:49 +00:00
Satyanvesh Dittakavi dded7831c1 SWDEV-374363 - hipImportExternalMemory/Semaphore should return error
when the Memory/Semaphore handle desc type is invalid

Change-Id: If122b05d87cc65974a797da69c134e2ac264d1db


[ROCm/clr commit: 1ed823a477]
2023-04-05 10:56:41 +00:00
Ioannis Assiouras 517e142aeb SWDEV-388661 - Fixed regression in hipMemCpyParam3D when offset is applied
Change-Id: I31273d643aac05f394f505235734c7f098497051


[ROCm/clr commit: 9c04e21b68]
2023-04-05 10:54:34 +00:00
Saleel Kudchadker ce8215feb4 SWDEV-384658 - Optimize D2D memcpy
- Intra device memcpy does not need to perform host side synchronization
- Check alloc flags when determining memory type

Change-Id: Ieff28bd8d62756ffe82905354c4a91e9717e6bd4


[ROCm/clr commit: dfefc97178]
2023-03-09 04:47:11 -05:00
Saleel Kudchadker 71a3807e6f SWDEV-345213 - Use the right accessor
- Use correct accessor to fetch memory objects. This checks the svm map
and arena maps

Change-Id: I84515330bb530cfe2b39abf30e1e659938f06806


[ROCm/clr commit: 8028d327e9]
2023-03-06 19:35:40 -05:00
Anusha GodavarthySurya 2d9f92288c SWDEV-368521 - Return hipErrorNotSupported when Mipmap array create support is not available
Change-Id: I47acfa82ff3f58427b1f5fbb0d2f4aabfff0d6ec


[ROCm/clr commit: 705c56ed31]
2023-03-02 03:05:43 -05:00
Jaydeep Patel 37769589f3 SWDEV-383056 - Don't sync with dst device for hipMemcpyAsync.
Change-Id: I28530e6bd870d617507592576295fc9e7eed1475


[ROCm/clr commit: 57fa5938fe]
2023-02-28 23:21:01 -05:00
Ioannis Assiouras 2633e62801 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8


[ROCm/clr commit: e3633dc8f4]
2023-02-21 18:12:03 -05:00
Rakesh Roy 9c51780b13 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983


[ROCm/clr commit: 287d07ccd4]
2023-02-16 23:04:29 -05:00
Ioannis Assiouras 5007a5f15d SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef


[ROCm/clr commit: 8b87ccb8cc]
2023-02-16 17:49:12 -05:00
kjayapra-amd 9c479ada12 SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303


[ROCm/clr commit: 193c5e387e]
2023-02-16 14:05:54 -05:00
Jaydeep Patel 4b3f70a6b4 SWDEV-380405 - Make hipMemcpyPeer async w.r.t. host and let dst device wait till copy finishes by src device.
Change-Id: Idbe25404d0c31b93436e190b548f12f327f47a04


[ROCm/clr commit: 5f231c55e3]
2023-02-07 00:34:45 -05:00
pghafari 5fa035dbd4 SWDEV-369551 - invalid stream check in hipMemcpy
Change-Id: I6762af93cd566a38f7d04994b87a76e744b19043


[ROCm/clr commit: 76b0b4d635]
2023-01-18 20:02:28 -05:00
pghafari 5959057299 SWDEV-374361, SWDEV-374362, SWDEV-374364, SWDEV-374365 - error checking
Change-Id: I0b729976ed794239fa54e1ad2965133b319d2f5d


[ROCm/clr commit: a9cbff0a49]
2023-01-17 23:10:22 -05:00
German Andryeyev 36d240ff89 SWDEV-355281 - Use offset from FindMemObj
Change-Id: I53ce2c1ef2e3a580b8b12312b693c2476f0885d2


[ROCm/clr commit: 39db0ec297]
2023-01-17 10:01:49 -05:00
Jaydeep Patel d74f646173 SWDEV-374360 - Handle free for external memory.
Change-Id: Ibfaf30eef371499a3c1f931a73cce76c83d8f7f3


[ROCm/clr commit: 7eecbdd9db]
2023-01-16 13:07:01 -05:00
Jaydeep Patel ffcff763d2 SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl.
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea


[ROCm/clr commit: fdecc1b351]
2023-01-16 11:37:57 -05:00
German Andryeyev 9c811dc241 SWDEV-353281 - Initial support of memalloc in graph
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b


[ROCm/clr commit: eef47ca24a]
2023-01-13 13:06:59 -05:00
Ajay 433f99686b SWDEV-369556 - Unit_hipMemGetAddressRange_Negative cases
- return value for invalid device ptr
- offset greater than size

Change-Id: I8bcf878c3c1c0a29836ea664bfb9048e1114b74e


[ROCm/clr commit: c6a7ce66bb]
2023-01-10 06:57:54 -05:00
kjayapra-amd 5057429e7a SWDEV-361374 - Adding support for hipPointerSetAttributes
Change-Id: I56710b808854acefca07b3b5898deebee38063e9


[ROCm/clr commit: 0c8c08cf51]
2023-01-09 12:36:57 -05:00
Jaydeep Patel f6a5cd9e33 SWDEV-374373 - Occupied size should be within range.
Change-Id: I20e24c628c51154c2f8f36dca0a6fa4ead1ee6d0


[ROCm/clr commit: 67792dd858]
2023-01-05 08:02:20 -05:00
Satyanvesh Dittakavi 47167d7e7a SWDEV-374371 - hipGraphAddMemsetNode should return error if width is 0
Change-Id: I1cd4be271f65c9cade8dddb6d00191e1b74c96bc


[ROCm/clr commit: 409f23d905]
2023-01-03 10:29:16 -05:00
Jaydeep Patel 2d25a60c1a SWDEV-374370 - Propogate element size to blit kernel.
Change-Id: I8a3355c62947265be34e6a2befd26f86b3dc6cd2


[ROCm/clr commit: f2b0542442]
2023-01-01 23:54:09 -05:00
Rakesh Roy 981137d2af SWDEV-374789 - Validate HostQueue before accessing it
- hip::getQueue will return nullptr when comgr fails to load blit kernels.

Change-Id: I3bea1f5c13301d4a35e40ab7c6faa73f9c6aecf4


[ROCm/clr commit: 95b2441cbc]
2022-12-28 01:04:10 -05:00
Ioannis Assiouras 49a3b0c6ba SWDEV-374393, SWDEV-373631 - Added input checks for hipMemcpy2D/3D
Change-Id: I5ae57326c35b599d9ecec05e2a22bc6086027322


[ROCm/clr commit: 1278cf555e]
2022-12-22 11:21:55 -05:00
Ioannis Assiouras 65f79be5f7 SWDEV-374355, SWDEV-374356, SWDEV-374357, SWDEV-374358, SWDEV-374359 - Added input sanity checks to hipExternalMemoryGetMappedBuffer
Change-Id: I61e43dece3fb9bd961e92db8e015f08170327538


[ROCm/clr commit: 99d2d016c1]
2022-12-22 10:46:10 +00:00
Jaydeep Patel 376f515547 SWDEV-374398 - Pitch should not be less than width for both src and dst.
Change-Id: Ib8fa8e3bd0c655f3de213b3798d369ba866b2f01


[ROCm/clr commit: c4003ef62a]
2022-12-21 23:08:55 -05:00
Ioannis Assiouras 0019cfdf7c SWDEV-374392 - Make hipMemCpy2/3DAsync synchronous for any HostToHost and DeviceToPageableHost
Change-Id: Iaa411681a49427a9e9b3a06e90abb0b32f5a6851


[ROCm/clr commit: d29a2e545d]
2022-12-21 14:59:39 -05:00
Jaydeep Patel e5a9c5b85b SWDEV-374394 - Correct hip error for invalid stream.
Change-Id: I96949c58e050cb3149ab8434aebe0f1a97a6e857


[ROCm/clr commit: 148f67a36d]
2022-12-20 21:27:56 -05:00
Jaydeep Patel bd59bad586 SWDEV-374395 - Correct rhs.
Change-Id: I433d60344a6d23bc48f4db58d5501af89bc1989c


[ROCm/clr commit: 027f71ccfb]
2022-12-20 11:38:11 +00:00
Ioannis Assiouras f3c412b183 SWDEV-369548 - Disallow opening an ipc mem handle in the originating process.
Change-Id: Icce5e41a220566141bd7d92b7199d477f60bed8e


[ROCm/clr commit: 30e740023b]
2022-12-14 04:52:21 -05:00
kjayapra-amd c3c4eb85d3 SWDEV-371904 - Adding pseudo fine grain flag to hsa memory allocation for device fine grained memory.
Change-Id: I8c605d6bc3ac905bfffc6de3a56911151ef0e663


[ROCm/clr commit: f7c194edf7]
2022-12-12 11:40:00 -05:00
Ioannis Assiouras e609c247ec SWDEV-369581 - Convey copy API metadata to ROCclr
Change-Id: I6fcd2c2dbec887199de538326a7826bd29a25ca0


[ROCm/clr commit: 337976febf]
2022-12-09 00:27:35 -05:00
Jaydeep Patel 2411eeba32 SWDEV-366086 - Validations for negative scinerios.
Change-Id: Icca87de775bf7f8c4d18f911f7bee21fafdcff55


[ROCm/clr commit: e2279b3869]
2022-12-06 21:27:37 -05:00
Rakesh Roy ff8d9d3c77 SWDEV-348820 - Fix hipPointerAttribute_t incompatibility
- Use hipPointerAttribute_t.type instead of hipPointerAttribute_t.memoryType

Change-Id: I3bf1c0758bdae987213ba7de62247dd420ef4cc9


[ROCm/clr commit: cbc3a0a652]
2022-11-29 00:53:24 -05:00
Maneesh Gupta 6594768a22 Revert "SWDEV-363069 - Disable sync force for MT"
This reverts commit e3f6a5fa0d.

Reason for revert: SWDEV-365075, SWDEV-367163, SWDEV-367164, SWDEV-367173

Change-Id: Id2924c60e46e9879038ded358f777c71cd95b2c1


[ROCm/clr commit: 1c45f257b9]
2022-11-17 01:04:44 -05:00
German Andryeyev 670266f94f SWDEV-364457 - Don't attempt adding duplicates into the memory map
KMD can enable hipHostRegister optimization  with HMM path.
That will make CPU and GPU pointers matching.

Change-Id: Iad96ceada5cfa3bada20452b906f744f9dbaebbe


[ROCm/clr commit: 55d085ca8c]
2022-11-03 10:04:12 -04:00