Revīziju grafs

5443 Revīzijas

Autors SHA1 Ziņojums Datums
Mark Searles 7c101b2e20 Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)


[ROCm/hip commit: aa7ce2ef44]
2018-08-31 11:10:58 -07:00
Saleel Kudchadker f47cdceb42 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into skudchad-hip
[ROCm/hip commit: cd926a44b7]
2018-08-31 10:38:41 -07:00
Mark Searles ff4df50cd5 Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)


[ROCm/hip commit: f0183dfaac]
2018-08-31 10:36:05 -07:00
foreman f83a7c1054 P4 to Git Change 1600056 by skudchad@skudchad_test2_win_opencl on 2018/08/30 12:04:10
SWDEV-145570 - [HIP] Fix elapsed time calc for hipEvent

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15717/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#6 edit


[ROCm/hip commit: 0d2b874266]
2018-08-30 12:17:57 -04:00
Maneesh Gupta 62a1c2f8f9 Merge pull request #564 from phani544/hipClangClass8B
Adding class size>8bytes tests

[ROCm/hip commit: 5ab1d757e4]
2018-08-30 10:33:47 +05:30
Maneesh Gupta 57d67f90b8 Merge pull request #647 from tdd11235813/fix-cmake-build-name
Fixes build-name bug due to reversed string() arguments in cmake.

[ROCm/hip commit: 2da880620d]
2018-08-30 10:32:39 +05:30
Aaron Enye Shi 8a602184bb __forceinline__ needs inline and always_inline
Related to SWDEV-163084


[ROCm/hip commit: e7352a1f4a]
2018-08-29 18:33:35 +00:00
Aaron Enye Shi 1a34cbc1c4 Remove testing bitinsert/extract on nvcc path
[ROCm/hip commit: bbcb3fa0c0]
2018-08-29 15:29:53 +00:00
Yaxun Sam Liu c1ab349fc7 Add clock() and clock64()
[ROCm/hip commit: 1f74a66bea]
2018-08-29 10:51:00 -04:00
fpadmin 65a48ce72e Adding class size>8bytes tests
[ROCm/hip commit: 0022f53a10]
2018-08-29 15:16:43 +05:30
Aaron Enye Shi 31a34f6804 Add tests for bitextract and bitinsert
[ROCm/hip commit: 5893bbc1f4]
2018-08-28 20:01:54 +00:00
Aaron Enye Shi 9619457b1f Add bitinsert64 to device functions
[ROCm/hip commit: ba9fc6f355]
2018-08-28 20:01:14 +00:00
Aaron Enye Shi eb2e7e0671 Clean up and add meaningful variables to bit funcs
[ROCm/hip commit: b939a3c6ed]
2018-08-28 18:19:48 +00:00
Yaxun (Sam) Liu 6798169f4d Fix documentation about hip-clang macros
[ROCm/hip commit: 8c0860df88]
2018-08-28 09:55:18 -04:00
Yaxun (Sam) Liu d9a5cc2560 Fix documentation about hip-clang macros
[ROCm/hip commit: f991117288]
2018-08-28 09:48:38 -04:00
Yaxun (Sam) Liu fb55365af2 Documents hip-clang predefined macros
[ROCm/hip commit: d107b460b2]
2018-08-28 09:43:38 -04:00
Maneesh Gupta c4574981af [ci] New CI flow
- Removed hcc integration logic for now
- No longer publish docker images to artifactory or docker hub
- Switch to new docker images and new test node

Change-Id: Idb06bf0a52658d1869367cb38bb03ef4f1649103


[ROCm/hip commit: e4c540d7dc]
2018-08-28 12:36:54 +05:30
foreman 36ba22ea01 P4 to Git Change 1598666 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/27 18:36:44
SWDEV-145570 - [HIP] - Multithreading issues
	Add a lock per function so kernel parameters don't get overwritten
	Make execStack_ thread local and remove global lock use for it:
	The compiler uses the same thread to set it up and launch the function

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#19 edit


[ROCm/hip commit: 938481928a]
2018-08-27 18:46:34 -04:00
Matthias Werner ab8e3c2504 Fixes build-name bug due to reversed string() arguments in cmake.
[ROCm/hip commit: bbfda64813]
2018-08-27 17:51:12 +02:00
foreman 75bc7ef195 P4 to Git Change 1597160 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/22 18:31:15
SWDEV-145570 - [HIP] Implemented hipSurfaceCreate/Destroy APIs.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#4 edit


[ROCm/hip commit: e52fbca4a1]
2018-08-22 18:42:22 -04:00
foreman 41bd605d15 P4 to Git Change 1596634 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/21 18:07:55
SWDEV-145570 - [HIP] Implmented hipSurfaceCreate/Destroy APIs

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#3 edit


[ROCm/hip commit: 28ce8a8a89]
2018-08-21 18:29:16 -04:00
foreman 3995cddd87 P4 to Git Change 1596023 by skudchad@skudchad_test2_win_opencl on 2018/08/20 18:40:38
SWDEV-145570 - [HIP] Fixes to HIP env var logic

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15653/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#225 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#311 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#105 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#96 edit


[ROCm/hip commit: 095572b7d5]
2018-08-20 18:48:00 -04:00
Aaron Enye Shi 1d29819850 Add bitextract and bitinsert functions
[ROCm/hip commit: b445e45007]
2018-08-20 16:46:12 +00:00
Saleel Kudchadker 0d410147cf Check for hipEnvVar at the same level if directed_tests location fails
[ROCm/hip commit: 8e0e373f69]
2018-08-17 12:14:42 -07:00
foreman bac72feb76 P4 to Git Change 1595124 by skudchad@skudchad_test2_win_opencl on 2018/08/17 14:05:25
SWDEV-145570 - [HIP] Implement environment variables and subsequent changes for HIP. This gets hipEnvVar passing

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15641/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#224 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#310 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#104 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#95 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#297 edit


[ROCm/hip commit: 7f80b1c6bc]
2018-08-17 14:28:54 -04:00
Yaxun Sam Liu 86b18a66ef Add HIP_DB=fatbin for debugging fat binary issues
[ROCm/hip commit: 1299b65e15]
2018-08-17 11:53:45 -04:00
Aaron Enye Shi d5b8f89565 Remove few hcc specific cmake for hip-clang
[ROCm/hip commit: dbcede2ab8]
2018-08-15 21:53:20 +00:00
foreman cd7d8c49c5 P4 to Git Change 1594075 by skudchad@skudchad-lnx on 2018/08/15 14:00:33
SWDEV-145570 - [HIP] Fix some test failures

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#14 edit


[ROCm/hip commit: c998b3c3e2]
2018-08-15 14:13:08 -04:00
foreman 3c4e2d4529 P4 to Git Change 1593706 by skudchad@skudchad_test2_win_opencl on 2018/08/14 18:44:29
SWDEV-145570 - [HIP] Implement hipError*

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15619/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#9 edit


[ROCm/hip commit: 21559762b8]
2018-08-14 18:54:13 -04:00
Maneesh Gupta b5569a7be9 [hipcc] Remove libhsakmt from linker flags
Change-Id: I6dc769d09d8c7546fbc594c1eb65f9edf0f0ff58


[ROCm/hip commit: e658b68c14]
2018-08-14 15:31:04 +05:30
foreman 4a16441933 P4 to Git Change 1592348 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 17:00:39
SWDEV-145570 - [HIP] Do not multiply block and dims for Hcc/Ext kernel module launch

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#16 edit


[ROCm/hip commit: a38de7d73d]
2018-08-10 17:16:53 -04:00
foreman 867efccf75 P4 to Git Change 1592228 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:55:25
SWDEV-145570 - [HIP] Report maxGridSize as INT32_MAX, not UINT32_MAX

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#13 edit


[ROCm/hip commit: 327e62e31a]
2018-08-10 14:10:19 -04:00
foreman 57e500b670 P4 to Git Change 1592225 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:52:21
SWDEV-145570 - [HIP] Report memoryClockRate in kilohertz too.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#12 edit


[ROCm/hip commit: 903f8a551b]
2018-08-10 14:09:04 -04:00
foreman 95764032f1 P4 to Git Change 1592223 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:50:47
SWDEV-145570 - [HIP] Report clockRate in kilohertz.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#11 edit


[ROCm/hip commit: c4e3d90ba9]
2018-08-10 14:04:43 -04:00
Yaxun Sam Liu f6374ced16 Add HIP directed test hipTestGlobalVariable.cpp
[ROCm/hip commit: a6c7aeed72]
2018-08-10 08:15:36 -04:00
Maneesh Gupta b5940c7969 Merge pull request #621 from ROCm-Developer-Tools/disable_startup_loader
Disable startup loader by default and guard with env var

[ROCm/hip commit: 4cf851f416]
2018-08-10 10:18:25 +05:30
Maneesh Gupta 236c7002b4 Merge pull request #623 from ROCm-Developer-Tools/tf18
Fix declaration conflict when hip/math_functions.h is included first

[ROCm/hip commit: d8d45a906c]
2018-08-10 09:36:27 +05:30
Maneesh Gupta 83db29605b Merge pull request #616 from ROCm-Developer-Tools/hip-clang-static-lib
Let hipcc handle static library for hip-clang

[ROCm/hip commit: 04dd1a8daf]
2018-08-10 09:35:22 +05:30
Maneesh Gupta be85f53160 Merge pull request #615 from aaronenyeshi/enable-hip-compiler
Enable HIP_COMPILER to choose HIP-Clang lib links

[ROCm/hip commit: 04a34aa46a]
2018-08-10 09:34:51 +05:30
Maneesh Gupta 28739aa597 Merge pull request #613 from ROCm-Developer-Tools/hcc-compat
Add HCC compatibility mode for hip-clang

[ROCm/hip commit: 11cccaa5d0]
2018-08-10 09:32:31 +05:30
Maneesh Gupta 1027f112b9 Merge pull request #617 from gargrahul/genco_remove_adipose_extn
Remove adipose extension from genco output

[ROCm/hip commit: b5f2ad0715]
2018-08-10 09:31:44 +05:30
Maneesh Gupta 5b8e25b541 Merge pull request #619 from ROCm-Developer-Tools/revert-pr457
Revert pr457

[ROCm/hip commit: d358ce75db]
2018-08-10 09:25:57 +05:30
sunway513 cfe96a2db0 resolve a segfault bug when env var not set; remove startup_kernel_loader class
[ROCm/hip commit: 17f38937e0]
2018-08-09 16:40:26 +00:00
Rahul Garg 3bae902cae Clean up module api samples
[ROCm/hip commit: 8f0d684988]
2018-08-08 22:28:13 +05:30
Evgeny Mankov 37d047b454 [HIPIFY][Complex] Add cuComplex support
+ Add API_COMPLEX support (data types and functions)
+ Add cuComplex_API_supported_by_HIP.md
+ Add cuComplex_Julia.cu test
+ Update README.md


[ROCm/hip commit: 368977f75b]
2018-08-08 18:34:57 +03:00
Yaxun Sam Liu 9c2a33b5c9 Fix __HIP_ARCH_* not defined after including math_functions.h
hcc_detail/math_functions.h used to include hcc_detail/hip_runtime.h.

Removing it has caused regression in TensorFlow 1.8.

Put it back for backward compatibiliity.


[ROCm/hip commit: b8a0c14171]
2018-08-08 08:55:28 -04:00
Yaxun Sam Liu 735e7ac097 Fix __HIP_DEVICE_COMPILE__ not defined when hip/math_functions.h is included
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/hip commit: 450ea49df0]
2018-08-07 17:14:39 -04:00
Yaxun Sam Liu fd1b704358 Fix declaration conflict when hip/math_functions.h is included first
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/hip commit: dacb18414e]
2018-08-07 15:44:59 -04:00
foreman 2e2d950893 P4 to Git Change 1590010 by skudchad@skudchad_test2_win_opencl on 2018/08/06 21:18:48
SWDEV-145570 - [HIP] - Fix some issues in hip runtime
	- Set stream for event
	- Free mem needs to be reported in bytes but runtime backends reports in Kb

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15586/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#15 edit


[ROCm/hip commit: c708d8b16b]
2018-08-06 21:24:14 -04:00
sunway513 09a4ad1dcf Add more check to ensure the startup loader only be enabled with the env var set to 1
[ROCm/hip commit: 30dfa6f129]
2018-08-04 01:52:27 +00:00