Commit Graph

991 Commits

Author SHA1 Message Date
Tao Sang b9cf12e920 SWDEV-272088 - Fix runtimeApi/event/hipEventElapsedTime issue
runtimeApi/event/hipEventElapsedTime will report invalid resource error
on cuda due to wrong calling sequence. The fix will arrange the calling
in right sequence.

Change-Id: I3db28a962888566ea135e3cbdefa68d373e2d369
2021-02-23 12:36:40 -05:00
Tao Sang 657a515e60 SWDEV-272089 - Shorten memory test time
memory/hipMalloc_MultiThreaded_MultiGpu costs too much time to finish.
    1 GPU: about 1000s, 2 GPUs: about 2200s
But Jenkin build need quick return and ctest will kill test that last
1500+s. So we need shorten the test time.

Change-Id: I3db27a962808566ea135e3cbdefa66d373e2d369
2021-02-22 18:01:00 -05:00
Tao Sang f055582473 SWDEV-273484 - Fix static lib build failure
Exclude gcc/LaunchKernel from static lib as
it's shared lib test case only

Change-Id: I3db17a962808565ea135e3cbcefa66d373e2d364
2021-02-19 17:11:26 -05:00
agodavar d5b4762d96 SWDEV-255979 - Added support of __managed__ static variable
Change-Id: I9d5cbbecc8c19ec38a95c94ab4130465ba76c102
2021-02-17 13:01:29 -05:00
Rupam Chetia a28c367ed0 SWDEV-238517 - [dtest] Adding new test case to validate hipDeviceProp_t arch values
1. Added 1 scenario to validate value of deviceProp.arch.has* with
value of __HIP_ARCH_HAS_* device flag.

SWDEV-238517 - Enhancing hip unit tests

Change-Id: Idb237a76b75180ce77808853a5351f19077a0d33
2021-02-17 03:23:42 -05:00
Sarbojit Sarkar ed7f4560cf SWDEV-272769 - Enabled gcc based hip test
Change-Id: I48bc850df00848bf11de71e3f614273111d31b47
2021-02-16 21:20:00 -05:00
Tao Sang 5039649dd4 SWDEV-272089 - Fix concurrent memory test failure on CUDA
Change-Id: Ibf35c789d6bd4279bdcedba1a6e057639c258489
2021-02-16 10:00:23 -05:00
Rupam Chetia 05409f05d0 SWDEV-238517 - [dtest] Test for Multiple Target Architecture Code Object
Added a test to generate a code object for multiple target
architectures (including for the current device),
load and execute the kernel.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I509d01124abdc0495cfc770ab5508738f108c91c
2021-02-15 06:41:24 -05:00
cjatin caf9b2b108 SWDEV-252745 - Adding rtc options transformer
Change-Id: Ib250689906a35f81255398e53da979774361dbfa
2021-02-09 13:35:30 -05:00
cjatin d9496c149b SWDEV-269879 - Adding function that recommends optimal thread count
Change-Id: I42eb94a058c1b7f9253182e16ff1c3389a836d61
2021-02-09 13:34:08 -05:00
Satyanvesh Dittakavi 45e5d6aa67 SWDEV-269439 - Fix dtests build failure on HIP CUDA
Change-Id: Ibdba5d364df1bcd3b9e158e22a602dd993044d7a
2021-02-08 17:09:49 -05:00
Tao Sang a6176099cf SWDEV-271406 - Remove unecessary hip_ext.h
tests/src/runtimeApi/module/hipModuleLaunchKernel.cpp doesn't
need hip_ext.h which will fail cuda building. So remove it

Change-Id: Icf5763449ccec839d9efda90ffe3a86fb53bdb85
2021-02-08 14:33:04 -05:00
Julia Jiang e4fdbfcf5b SWDEV-271416 - Remove HIP_DYNAMIC_SHARED macro in hip
Change-Id: I12f39ea8438eb7ce76d8ffb2151b4faa93689048
2021-02-08 13:17:46 -05:00
kjayapra-amd d13124d90f SWDEV-270007 - Fixing the hipMemoryAllocateCoherent test binary path for hipMemoryAllocateCoherentDriver test path.
Change-Id: Iae5363685d10fce32ff80ac5d6bfba460dc2b574
2021-01-28 09:47:01 -05:00
agodavar 2d2f127b8a SWDEV-268552 - HIP sample segfaults during hipModuleLoad, fix mmap bug
Change-Id: I51c6061e7ac6b2524586d96fdd69b9f084b1906a
2021-01-27 23:39:50 -05:00
DURGESH KROTTAPALLI d27db0f038 [dtest] Kernel Execution time fix for hipExtLaunchKernelGGL and hipExtModuleLaunchKernel API's
Fix for kernel execution time using clock rate

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id06df31387ecab96f219e0c1fbcdda1609f75605
2021-01-15 01:58:22 -05:00
Tao Sang 12c976ef63 Fix failure for g++/hipMalloc test
Fix hardcoded /opt/rocm

Change-Id: I1ae48567eafd749d6c25bca204c1724b026be21f
2021-01-11 11:46:17 -05:00
Rahul Garg 3829645039 Add IPC Events support
Change-Id: Iac2bf3d5e1d9a993bebbb066c20d300d6f05558b
2021-01-08 20:09:26 +00:00
Tao Sang d504a761ad Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
2021-01-08 10:53:34 -05:00
DURGESH KROTTAPALLI ec794ae051 [dtest] Tests for hipExtLaunchKernelGGL APIs
Added test scenarios for hipExtLaunchKernelGGL
1. verify kernel execution time using events
   passed through argument
2. Verify the API by disabling time flag in
   event creation.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I755adc34a25c58b68041fc927bbffd2a9e6eafde
2021-01-08 00:16:54 -05:00
DURGESH KROTTAPALLI a57968fba9 [dtest] Tests for hipExtModuleLaunchKernel APIs
Added test scenarios for hipExtModuleLaunchKernel/hipModuleLaunchKernel APIs

 1. Negative Test Scenarios for hipExtModuleLaunchKernel API
 2. Negative Test Scenarios for hipModuleLaunchKernel API
 3. hipExtModuleLaunchKernel API Concurrency Verification
    using global variable
 4. hipExtModuleLaunchKernel API Concurrency Verification
    using total time taken by kernels.
 5. hipExtModuleLaunchKernel API verifying the kernel execution time
    of a particular kernel
 6. hipExtModuleLaunchKernel API verifying by disabling the
    time flag during event creation

SWDEV-238517 for enhancing hip unit tests

Change-Id: I33bbab152d47beba62065c461a07cbcacdc01d97
2021-01-08 00:05:57 -05:00
Rupam Chetia 5ba7259ffc [dtest] Enabling all negative tests for hipModule* APIs
Enabling all negative test cases for amd as they are functional now
SWDEV-238517 for enhancing hip unit tests

Change-Id: I0bdbf8c192ef94588403c8f027c0399dd5480a00
2021-01-07 23:50:56 -05:00
Rupam Chetia 328f8ab0ff [dtest] Additional tests for hipDevice APIs
APIs: hipDeviceGetAttribute(), hipGetDeviceProperties(),
      hipDeviceGetByPCIBusId() and hipDeviceGetPCIBusId()
1. New negative test cases for each API.
2. Additional attributes for testing with hipDeviceGetAttribute()

SWDEV-238517  Enhancing hip unit tests

Change-Id: I3c24462426ffaf3a9317b7de9cd33f7c65791a4b
2021-01-07 23:29:14 -05:00
DURGESH KROTTAPALLI b2a93adb82 [dtest] Enhanced tests for hipGetDeviceCount hipSetDevice and hipGetDevice
Added following functional and negative scenario tests for
HIP_VISIBLE_DEVICES (HVD), ROCR_VISIBLE_DEVICES (RVD)
CUDA_VISIBLE_DEVICES(CVD)
1. Verifying HVD and RVD - invalid number in sequence
2. Verifying HVD and RVD - dupliates in the beginning of sequence
3. Verifying HVD and RVD - all the duplicates
4. Device count with RVD(max devices and HVD(min devices)
5. Device count with RVD(min devices and HVD(max devices)
6. Device count - RVD(set), HVD(unset), CVD(set)

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ia83e9e9068cbf8cc61cff17311cda1d1f8a38fee
2021-01-07 23:23:51 -05:00
Rupam Chetia 656a2cb556 [dtest] Tests added for V3 and V4 Code Objects with Static Lds
- Added test for V3 Static Lds code object with sramecc/xnack settings.
- Added test for V4 Static Lds code object.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibc4f7e12033dec231d6834ccdd983e3b9e001d60
2021-01-07 23:19:02 -05:00
DURGESH KROTTAPALLI 7e6d748f26 [dtest] Tests for hipMemcpy2D and hipMemcpy2DAsync APIs
Added following functional and negative scenario tests
for hipMemcpy2D and hipMemcpy2DAsync APIs
 1. Verifying D2H and H2D functionality
 2. Verifying D2D on same device and peer device
 3. Verifying using pinned host memory on same and peer GPU
 4. Negative test scenarios
 5. Verifying hipMemcpy2DAsync API along with kernel launch

SWDEV-238517  Enhancing hip unit tests

Change-Id: I8f447bc7f6bf13cb895f1809f5a2b501baa8782c
2021-01-05 23:23:09 -05:00
Tao Sang 8a2b0b7424 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
2021-01-05 10:39:31 -05:00
sumanthtg 2624a5654c [dtest] Tests for hipMemset3D/hipMemset3DAsync APIs
Negative, Functional and Regression scenarios for
 - hipMemset3D
 - hipMemset3DAsync

SWDEV-238517 for enhancing hip unit tests

Change-Id: Idc5604f728ca1a96ec13876e006120f7a3d69acf
2021-01-05 07:00:48 -05:00
Sarbojit Sarkar 872d8b7fc6 SWDEV-265344: fix for dtest build issue
Change-Id: I561546cb792fc0b33c03b17ba2ccf62802f05656
2020-12-20 23:26:20 -05:00
Satyanvesh Dittakavi f06393c75f SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 40733e1fff Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8
2020-12-15 01:40:24 -05:00
Sarbojit Sarkar 1ef88375c2 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
Aaron En Ye Shi d432615faa Fix hipTestFMA to support older compiler
The older compiler does not promote integral
arguments to double, instead it uses float.
This patch tries to support the old compiler
headers, and also the newer one.

Change-Id: I01e0b96a82ecddc6230cb5baf2573a318b25445b
2020-12-10 14:27:42 -05:00
Aaron En Ye Shi 9c041b1984 Fix hipTestFMA to align with libcxx
The HIP-Clang math headers upstream have been updated
to perform type promotion on math function overloads.
If any argument has integral type, it will be cast to
double.

Change-Id: I38d9e6240c40c4092b946851469498b2ae6500ae
2020-12-08 10:48:29 -08:00
Sudheer Kumar da6de84535 compiler argument update for nvcc
Change-Id: If40caf20543cc29301482deddfb03d6fccb6f3c9
2020-12-06 23:21:14 -05:00
sumanthtg 8ad39c41d8 [dtest] hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags() - Additional test
Additional test for flag

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ieca443678c122e291b9d4cd16f7198505cd5d6c3
2020-12-06 23:19:23 -05:00
Michael LIAO f3b63c004a Fix hostcall test build.
- As `long`/`ulong` on Windows has different bit sizes from Linux
  platforms, even compiled in 64-bit mode. Need to use portable data
  type `int64_t`/`uint64_t` as possible or use `long long` ones to
  match the prototype in LLVM IR.

Change-Id: I62fe16a2e53aa0f2f2b4069b8a1596b8db7050c9
2020-11-30 16:47:16 -05:00
Rupam Chetia 4b16d3896d [dtest] Tests for hipExtGetLinkTypeAndHopCount() API
1. Negative Test Cases
2. API functionality tests for hopcount and linktype using rocm-smi library.
3. API functionality test for hopcount when devices are reversed.
4. Disabling test case 7.
5. Implemented External Review Comments.
6. Created a new header file hipP2pLinkTypeAndHopFunc.h.
7. Removed test case 0x7 from directed test.
8. Put testMaskedDevice() under __linux__, placed TODO in line 404 (comments) and replaced '&=' with '='.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I1ae256ecfd637d6c25bca293c1724b026be20eca
2020-11-26 09:30:38 -05:00
Sudheer Kumar 50524ae60c [dtest] Additional tests for d2d transfer
- Test d2d transfer after doing copy from pinned host buffer
- Test d2d transfer after doing copy from unpinned host buffer

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ib262185ce2692036e11c0f95ccb850eb3bce1c81
2020-11-26 08:22:55 -05:00
Rupam Chetia 4f039d1bf5 [dtest] Tests for hipModuleGetTexRef() API
1. Negative Test Cases
2. API functionality test using multiple streams.
3. API functionality validation using multiple GPUs.
4. Setting hipTexRefSetFlags() with HIP_TRSF_READ_AS_INTEGER flag instead of 0 as suggested in SWDEV-256096.
5. Enabling test cases 0x03 (short) and 0x04 (char).
6. Implemented external code review comments.

SWDEV-238517 for enhancing hip unit tests

Change-Id: If42796047ec1cf2e3695dc2b7f40a2d9dd50f5bd
2020-11-26 06:51:49 -05:00
Aryan Salmanpour e086f2bbff [dtest] add a test case for hipExtStreamGetCUMask API
Change-Id: I2b03f06fc96c4af0c3dcf4efc0b83126971aab46
2020-11-20 14:08:02 -05:00
Michael LIAO 28e1fb0cf7 Fix cooperative group tests.
- `gm` should be a global variable instead of auto local variable.

Change-Id: Ibde1e54ee83fa5725f21820b4b792a97bf7df6ad
2020-11-17 14:09:16 -05:00
Sarbojit Sarkar 25c8b41cb5 [SWDEV-259216] Minor test bug
Change-Id: Ib2ece421af88c99ded41514b6a2dc432b78be682
2020-11-13 02:23:45 -05:00
Sarbojit Sarkar c68a36fe14 [SWDEV-257048] fix for softhang in dtest
Change-Id: Ic77f5d9c13852c4e3da7afb41b1db7d43c5cbf75
2020-11-13 02:21:00 -05:00
Tao Sang 272f89a966 Make hipMemset*Async* tests pass in static lib
3 hipMemset*Async* direct tests will crash in static lib because
some hsa objects are not initialized when hip apis call them.
The fix will make the hip apis called in main() so that hsa objects
have been initialized at that stage.

Change-Id: I41eb29b8c2588acac0cd3ae6d96b14fb1abd235a
2020-11-03 09:54:30 -05:00
Tao Sang 6db4976759 Make directed_test support static libs
1.Make directed_test apps linked against static libs
    of hip, rocclr, rocr, roct and amd_comgr.
    2.Remove custom_target amdhip64_static_combiner.
    3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
    4.Simplify argument list parsing.
    5.Install rocclr when rocm is installed.
    6.Fix some original small bugs.

Revert "Revert "Make directed_test support static libs""
This reverts commit 0d1cf31eb1.

Change-Id: I918eeae94487e5e2ff5bfde083667ac65fb6e702
2020-10-26 12:39:58 -04:00
agodavar 8717a78bf7 cmake hip-rocclr as default build,change HIP_PLATFORM to amd|nvidia
Change-Id: I59d2e15b297b6ca2d5eee1a6dee642bdb01a3839
2020-10-21 07:26:14 -04:00
Sudheer Kumar f9d3e5a7be [dtest] Tests for loading hip apis dynamically
SWDEV-238517 for enhancing hip unit tests

Change-Id: I9b6ef41db2f02ee3679360d0fae709a404a0ea4f
2020-10-21 02:49:49 -04:00
Yaxun (Sam) Liu 4c4fff6b51 Fix test hipDynamicShared
This test does not work if block size is greater than wave size
since it relies on lock-step execution of the kernel in the block.
If there are more than waves in the block, the threads in the block
miss synchronization since one wave may finish before another wave.

Due to this bug, the test fails on GFX10 wave32 mode.

This patch fixes that so that it works for block size greater than
wave size.

Change-Id: Ie0097066081df36cb6fe025a71d0ee5a83ec00a2
2020-10-14 10:15:44 -04:00
Lakhan singh Thakur 04b773471b [dtest] Adding Test case for hipFuncSetSharedMemConfig() and hipFuncSetAttribute()
SWDEV-251504 - QA task for validation

Change-Id: I11ed98f648352cb32161c41290516c77231236bc
2020-10-13 11:11:00 -04:00