Commit Graph

5458 Commits

Author SHA1 Message Date
Nico Trost 725486fb11 fixed loss of accuracy in hipCfma() 2019-03-21 10:30:10 +01:00
eshcherb 045c6afa2c adding hip_prof_gen verbose log (#977)
* adding hip_prof_gen verbose log

* adding stderr fatal error

* adding no error exit by default

* adding hip_prof_str regeneration dependencies

* adding more informative messages

* fixing error mesage
2019-03-21 05:28:18 +00:00
foreman 9682f81a75 P4 to Git Change 1759248 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/20 18:32:19
SWDEV-183452 - [HIP] Typo of | instead of &

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#47 edit
2019-03-20 19:18:10 -04:00
foreman a63b38c304 P4 to Git Change 1759224 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/20 17:47:43
SWDEV-183452 - [HIP] PyTorch test_pin_memory fails
	hipPointerGetAttributes should return hipMemoryTypeHost for hipHostMalloc memories.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#46 edit
2019-03-20 18:43:07 -04:00
foreman 7d3439719d P4 to Git Change 1758971 by yaxunl@yaxunl-lc10 on 2019/03/20 12:00:49
SWDEV-145570 - Fix build failure due to type mismatch of amd::Event::CallBackFunction

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#16 edit
2019-03-20 12:24:45 -04:00
Maneesh Gupta ce72890dcf Merge pull request #972 from yxsamliu/global
Add declaration of symbol related API for VDI
2019-03-20 05:12:21 +00:00
Maneesh Gupta 54091b5273 Merge pull request #973 from mhbliao/hliao/master/build
[Device Function] Fix typos.
2019-03-20 05:12:14 +00:00
Maneesh Gupta 48d790e205 Merge pull request #974 from yxsamliu/name2
Change HIP dll name to amdhip64.dll on Windows
2019-03-20 05:11:58 +00:00
eshcherb 1229750546 adding prof primitives generator (#967)
* adding prof primitives generator

* minor change, renaming

* minor cosmetic changes, comments correcting and dead code removing

* minor changes and renaming

* minor chane, fixing comments
2019-03-20 05:11:40 +00:00
Siu Chi Chan fa9495841b reimplement HIP_INIT as hip_impl::hip_init(), add hip_init() to some of the inlined API (#966)
* reimplement HIP_INIT as a function, expose it as hip_impl::hip_init()
so that it could be called from hipLaunchKernelGGL and other inlined
HIP functions

* Don't call hip_init from ihipPreLaunchKernel
2019-03-20 05:11:15 +00:00
Yaxun Sam Liu 55f4c416a0 Change HIP dll name to amdhip64.dll on Windows 2019-03-19 16:27:18 -04:00
Michael LIAO f42e84cef7 [Device Function] Fix typos. 2019-03-19 15:32:19 -04:00
foreman 4ef60db63b P4 to Git Change 1758323 by yaxunl@yaxunl-lc10 on 2019/03/19 11:22:17
SWDEV-145570 - Forward declare hipModuleGetGlobal to fix build failure.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#23 edit
2019-03-19 11:31:24 -04:00
Yaxun Sam Liu fb3241a000 Add declaration of symbol related API for VDI 2019-03-19 11:11:49 -04:00
Maneesh Gupta 6ced14e71c Merge pull request #969 from nicholasmalaya/patch-1
Update hip_faq.md
2019-03-19 18:42:05 +05:30
Maneesh Gupta e7453483e2 Merge pull request #965 from mhbliao/hliao/master/immarg
[Device Function] Support immediate argument.
2019-03-19 18:41:31 +05:30
Maneesh Gupta 1500eec5f7 Merge pull request #954 from mhbliao/master
[hip] Re-implement hipLaunchKernelGGL as macros.
2019-03-19 18:39:27 +05:30
Maneesh Gupta e44de376f7 hipExtMallocWithFlags implementation
Change-Id: Iee9e119796472200b2933d5e23be60813f33bc75
2019-03-19 11:59:22 +05:30
foreman e432cfb2e9 P4 to Git Change 1757948 by kjayapra@1_HIPWS_SL_IPC on 2019/03/18 18:29:24
SWDEV-144570 - Implementation of
	               hipMemcpyToSymbol, hipMemcpyFromSymbol,
	               hipMemcpyToSymbolAsync, hipMemcpyFromSymbolAsync,
	               hipGetSymbolAddress, hipModuleGetGlobal

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#101 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#45 edit
2019-03-18 18:44:55 -04:00
Nicholas Malaya b1ec4e0b5f Update hip_faq.md
Making more clear what this list details. In particular, this list is intended to indicate what items for each CUDA release is supported, and which are not.
2019-03-18 14:51:18 -05:00
Jenkins 4f32124b90 Merge 'master' into 'amd-master'
Change-Id: I7fd7b61a4a78eeb26600bfe18593c0fd67a008b8
2019-03-16 16:37:02 -04:00
Michael LIAO b74b4500c4 [Device Function] Support immediate argument.
- `immarg`, immediate argument, is enabled on all AMDGPU intrinsics.
  Revise device functions using these intrinsics with immediate
  arguments.
2019-03-15 12:38:04 -04:00
Maneesh Gupta 41bbd24185 Merge pull request #964 from eshcherb/roctracer-hip-frontend-190314
tracing callback layer update
2019-03-15 16:24:46 +05:30
Evgeny 2aa88a4505 tracing callback layer update 2019-03-14 22:43:52 -05:00
Maneesh Gupta e3726bbf90 Merge pull request #963 from gargrahul/add_module_get_global_test
Test hipModuleGetGlobal
2019-03-15 06:17:50 +05:30
Maneesh Gupta 23170f6af8 Merge pull request #958 from aaronenyeshi/cxxabi-mismatch-workaround
CXX11 ABI Mismatch Workaround
2019-03-15 06:15:46 +05:30
Rahul Garg 46346343af Test hipModuleGetGlobal 2019-03-15 04:08:03 +05:30
Rahul Garg af72cde0a1 Add 2D fallback to use copy kernel 2019-03-14 13:03:06 +05:30
Siu Chi Chan 739d43c5d8 remove visibility hidden attribute 2019-03-13 11:58:32 -04:00
Jenkins 581dbbad71 Merge 'master' into 'amd-master'
Change-Id: Iacbb173bd73fe861c4ca67dbf6fd8480981f5010
2019-03-13 04:09:50 -05:00
Maneesh Gupta f14c695edb Merge pull request #957 from eshcherb/roctracer-hip-frontend-190311
adding memset32d
2019-03-12 10:58:56 +05:30
Evgeny 0586924ae6 adding memset32d 2019-03-11 21:28:27 -05:00
Siu Chi Chan 5044c9ba49 minor cleanup 2019-03-11 19:51:57 +00:00
Siu Chi Chan f54da9358b remove old style triple name 2019-03-11 19:51:51 +00:00
Siu Chi Chan 30053f6443 move triple_to_hsa_isa into the header 2019-03-11 19:51:44 +00:00
Siu Chi Chan fa564a5345 Fix memory leak introduced by previous change to Agent_global.
Make Agent_global manage the lifetime of the name string
2019-03-11 19:51:32 +00:00
Aaron Enye Shi fcde9fe3df Fix Agent_global variables failing hipTestDeviceSymbol
Issue: Header uses std::vector<Agent_global> agent_globals which is created by hip_module.cpp
  - Move iterator fails to copy Agent_global from library source into header version
  - Due to different versions of std::string name in struct Agent_global
Fix: Change Agent_global to use char* name instead of std::string name
2019-03-11 19:51:25 +00:00
Aaron Enye Shi f8aca3159c Fix hash_for undefined reference in hipTestConstant test
Issue: mismatch undefined symbols in different user env
  - Binary expects modified return value std::string&
  - Fails to match libhip_hcc.so: return value is std::string& but doesn't match modified C++ env
Fix: Change return value to char*, create new key std::string in header from char*
2019-03-11 19:51:18 +00:00
Michael Liao f46d6cf249 [hip] Re-implement hipLaunchKernelGGL as macros. 2019-03-08 09:10:51 -05:00
Jenkins fd368c7554 Merge 'master' into 'amd-master'
Change-Id: I8491766916813e6f344bdc8aa65cda30bf9f3f63
2019-03-08 04:09:55 -06:00
Maneesh Gupta 44309ee879 Merge pull request #951 from tycho/nvcc-hipDeviceSetCacheConfig
nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
2019-03-08 09:22:25 +05:30
Maneesh Gupta 8bc97d6859 Merge pull request #953 from yxsamliu/vdi
Fix HIP/VDI build failure due to dlopen change
2019-03-08 06:02:47 +05:30
foreman f9942770e0 P4 to Git Change 1753099 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/07 16:43:54
SWDEV-145570 - [HIP] Change IS_HIP into a dynamic variable set by HIP layer

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#127 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#303 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/macros.hpp#11 edit
2019-03-07 17:24:23 -05:00
foreman 1f45d27b9f P4 to Git Change 1752994 by kjayapra@2_HIPWS_SL_D32 on 2019/03/07 14:06:54
SWDEV-145570 - Implementation of ihipMemsetD32 and ihipMemsetD32Async
	       HIP-HCC Info: https://github.com/ROCm-Developer-Tools/HIP/pull/933

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#44 edit
2019-03-07 14:58:49 -05:00
Yaxun Sam Liu 2dc87b6019 Fix HIP/VDI build failure due to dlopen change 2019-03-07 14:45:45 -05:00
Evgeny Mankov 6b664dcf77 Merge pull request #950 from emankov/master
[HIPIFY][tests] Update lit testing infrastructure
2019-03-07 15:19:15 +03:00
Jenkins f659fea4b8 Merge 'master' into 'amd-master'
Change-Id: I36a294a054f029038c3ae5a9376695e8790897ff
2019-03-07 04:09:48 -06:00
Steven Noonan 27d6755552 nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
Signed-off-by: Steven Noonan <steven@uplinklabs.net>
2019-03-06 11:21:36 -08:00
Evgeny Mankov f138f89bc8 [HIPIFY][tests] Update lit testing infrastructure
+ Set -D__LP64__ in case of 64-bit hipify-clang binary
  [partial workaround for clang's bug https://bugs.llvm.org/show_bug.cgi?id=38811]

  C:/GIT/LLVM/trunk/llvm-64-release-vs2017/dist/lib/clang/9.0.0\include\__clang_cuda_device_functions.h(1609,45): error GEF7559A7: no matching function for call to 'roundf'
  __DEVICE__ long lroundf(float __a) { return roundf(__a); }

  #if defined(__LP64__)
  __DEVICE__ long lround(double __a) { return llround(__a); }
  __DEVICE__ long lroundf(float __a) { return llroundf(__a); } // ok: llroundf should be used when 64-bit
  #else
  __DEVICE__ long lround(double __a) { return round(__a); }
  __DEVICE__ long lroundf(float __a) { return roundf(__a); } // error
  #endif

+ Print more system info while testing in the following form:
  ========================================
  CUDA 9.0 - will be used for testing
  LLVM 9.0.0svn - will be used for testing
  AMD64 - Platform architecture
  Windows 10 - Platform OS
  64 - hipify-clang binary bitness
  32 - python 3.7.2 binary bitness
  ========================================
2019-03-06 19:26:05 +03:00
eshcherb 7c3499198c roctracer-proto header find_path (#884) 2019-03-06 17:36:34 +05:30