Commit Graph

1317 Commits

Author SHA1 Message Date
vedithal-amd 5f12d9b789 Fix instructions to build standalone binary (#1116) 2025-09-24 16:31:08 -04:00
vedithal-amd bd7a1de879 Remove rocprofv1/v2 in favour of rocprofiler-sdk (#673)
* Set default rocprof interface as rocprofiler-sdk

* Remove rocrprofv1 and rocprofv2 interfaces

* Remove deprecation notice for rocprof v1/v2/v3 interfaces
  * Make rocprofiler-sdk the default interface and make rocprofv3 interface opt-in using ROCPROF=rocprofv3

* Add deprecation notice for rocprofv3
2025-09-24 10:37:01 -04:00
vedithal-amd 7df02745eb [rocprofiler-compute] Update gfx12 counter definitions (#1003)
* Update gfx12 counter definitions

* Add counter defintions for Navi 4

* Made changes per https://github.com/ROCm/rocm-systems/pull/238 and
  doubled checked register specification

* bugfix
2025-09-24 10:32:21 -04:00
vedithal-amd f5505b5989 Use ROCM_PATH for sdk library path (#1097) 2025-09-24 10:31:20 -04:00
jamessiddeley-amd 05315c5bb2 fixed function argument dir in apply_filters (#1100) 2025-09-24 09:50:58 -04:00
vedithal-amd 4962f237c2 Fix workload path (#1096) 2025-09-23 17:47:31 -04:00
xuchen-amd c3054c00b1 [rocprofiler-compute] Type annotation patch for analysis_db.py (#981) 2025-09-23 17:05:37 -04:00
systems-assistant[bot] 872f0aed0c Live attach/detach and its unit tests (#53) 2025-09-23 13:17:08 -04:00
xuchen-amd 68cd123b0f [rocprofiler-compute][TUI] improve for cross-platform uses (#1007) 2025-09-23 10:59:29 -04:00
cfallows-amd 9819e1cbfc Refactor roofline binary detection (#933)
* Simplify the roofline binary pickup process by determining which base distribution the system OS is based off of, and select the correct binary.
* Add more OS distribution support to roofline by modifying the detection parameters and adding an AZL binary
* Update changelog to include roofline support additions

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-09-22 12:04:20 -04:00
vedithal-amd fa31650298 [rocprofiler-compute] make pmc files deterministic (#1066)
* make pmc files deterministic
2025-09-22 10:48:35 -04:00
abchoudh-amd a927f246f6 Fix test failures (#1059)
* Test fix

* Added path not exists check
2025-09-22 18:07:13 +05:30
ywang103-amd 775ac73d25 change interval for host_trap in unit test to adapt to single kernel (#1064) 2025-09-19 17:21:02 -04:00
jamessiddeley-amd 18b4b84a9f update TCC_EA0_RDREQ_sum def (#1039) 2025-09-19 11:21:45 -04:00
Jason Bonnell eebf5ead8c Replace cmake-format with gersemi in rocprofiler-compute-formatting.yml (#1053)
* Replace cmake-format with gersemi in rocprofiler-compute-formatting.yml

* Run gersemi formatting on CMakeLists.txt files

* Remove .cmake-format.yaml, add .gersemirc file

* Add more options to .gersemirc

* Add new line to .gersemirc

* Add new line to CMakeLists.txt

* Run gersemi again with new options
2025-09-19 08:42:40 -04:00
xuchen-amd d41e115916 [rocprofiler-compute][webui] bug fix (#1047) 2025-09-18 10:48:01 -04:00
xuchen-amd 288bca17ea [rocprofiler-compute] refactor bug fixes (#994) 2025-09-16 14:20:33 -04:00
systems-assistant[bot] 3b5467b746 [DOC] single pass counter collection (#95) 2025-09-16 11:00:11 -04:00
ywang103-amd 97f8b7b1ec change to single-kernel workload for pc_sampling tests (#955) 2025-09-16 10:17:23 -04:00
xuchen-amd a442766d26 [rocprofiler-compute] improve profile options (#999) 2025-09-15 18:21:45 -04:00
xuchen-amd eb46160a8f update proj toml (#974) 2025-09-12 16:24:44 -04:00
xuchen-amd 7ed6000e32 [rocprofiler-compute] Refactor to add type annotation and misc (#787) 2025-09-12 13:53:24 -04:00
abchoudh-amd 7d847dde3f Split tests (#952) 2025-09-12 12:29:48 +05:30
jamessiddeley-amd 62843ed900 [rocprof-compute] Wrap negative values in L2 - Fabric interface detailed metrics (#833)
* update gfx942 soc_config 1700

* add MAX wrapper for Write and Atomic (32B)

* removed trailing whitespace and EA* fix

* added to CHANGELOG.md

* edited changelog
2025-09-11 14:51:58 -04:00
Ammar ELWazir 2a9700fcd7 [ROCProfiler-Register/Systems/Compute] Fixing License file name usage (#927)
ROCProfiler-Register/Systems/Compute: The license file name in the CMake install module and other locations was originally LICENSE, but it was recently changed to LICENSE.md, requiring an update to the CMake install module and all other relevant locations.
2025-09-10 15:46:39 -04:00
Joseph Macaranas 696881ae82 LICENSE clean up (#919)
- Clean up and standardization of MIT licenses after discussion with legal team.
- Update README.md with blurb for top-level files.
- MIT License explicitly mentioned for relevant projects.
- Removal of years.
- Copyright attribution should be to `Advanced Micro Devices, Inc.` and not `AMD ROCm(TM) Software`
- Removal of `All rights reserved.`
- Reduce line width of the text for readability.
- Add clear visual separators for additional licenses.
- Convert text files to markdown format for aforementioned separators.
- Update build scripts to point to renamed files.
- Fixed SMI doc references

Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
2025-09-10 12:06:14 -04:00
ywang103-amd 4c614d3d21 remove test_scientific_notation_trigger_above_upper_bound for its (#913) 2025-09-10 10:18:42 -04:00
vedithal-amd 85a557673d Handle mutually exclusive report section filters (#710)
* Make --roof-only, --block and --set mutually exclusive from each other

* Update help output and documentation
  * Add sanitize function for checking profiler options

* Update filter blocks arguments when --set or --roof-only is provided

* Update filter_blocks in profiling_config.yaml based on --set option
  * Log Filtered Sections instead of Report Sections and Set Selection

* Move soc class function calls from rocprof compute base class to profiler base class

* Fix bug in panel level filtering using --filter-block option

* Remove roofline specific pmc files

* Move microbenchmark entry point from gfx specific soc class to base soc class

* Run microbenchmarks only if block 4 is selected or roof only is selected; skip for mi100
2025-09-09 17:48:20 -04:00
vedithal-amd 4238ddb185 Add unsupported counters for rocprofv1 (#889) 2025-09-09 09:42:08 -04:00
ggottipa-amd f6b5c45723 Enclosing copyright headers in /**/ (#894) 2025-09-09 18:56:57 +05:30
ggottipa-amd 5288d47275 Including copyright headers. (#879) 2025-09-09 11:02:47 +05:30
systems-assistant[bot] d58adf96da [DOC] TUI kernel selection (#94) 2025-09-08 13:52:39 -04:00
abchoudh-amd 682ae2d014 Streamline --list-metrics command line option in rocprof-compute (#310)
* Remove L2 channels from --list-metrics

--list-metrics moved to general options

List metrics for the current architecture

Filter blocks for metrics

Removed test for --list-metrics in profile mode

Test the options don't throw error

Fixed --config-dir error

Test stdout for command line options

Provide path list for loading panel configs

Show L2 Cache (per) channel metrics

Changed command line option names

Can show two levels only

Removed filtering blocks

Moved blocks to original position

Removed filter block tests

Removed filtering

Formaating fix

Readability enhancement

Test formatting

Filter L2 channels without sysinfo

Show avilable metrics for current arch

Intermediate commit

Fixed tests

Added argument sanitization

Added list_metrics to ctest

merge iconflict resolution

Updated test marker

Updated changelog

Fixed formatting

* Updated docs
2025-09-08 20:21:46 +05:30
ywang103-amd c9b1ad72a5 scientific notion of memchart(CLI, TUI and GUI) (#764) 2025-09-08 01:30:30 -04:00
cfallows-amd 2e750763e7 Fix file naming for roofline PDF outputs when using --kernel (#803)
Move check for kernel filtering to add to roofline pdfs- was originally only labelling pdfs with the filtered kernel names from --kernel when --kernel-names was called, we want it at all times when kernels are filtered. 

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-09-06 02:34:51 -04:00
jamessiddeley-amd fa860c5272 [rocprof-compute] Fixed CDash compute code coverage upload (#863)
* Test CDash upload fixes

* Test CDash upload fixes + rename

* fix run-ci.py script

* fix run-ci.py script

* fix run-ci.py script

* fix run-ci.py script

* fixed workflow

* renamed coverage file

* fixed run-ci.py script

* edited workflow file

* edited script desc

* Update Coverage.xml
2025-09-05 11:55:08 -04:00
vedithal-amd 77ed80f457 Fix Performance (GFLOPs) metric (#843) 2025-09-04 14:30:22 -04:00
jamessiddeley-amd 5a85df8f31 [rocprof-compute] update coverage to 81.1% (#826)
* update coverage to 81.1%

* Update coverage to latest develop
2025-09-04 14:21:03 -04:00
jamessiddeley-amd 04c6cfec8c [rocprof-compute] updated test_utils mock to be compatible with python3.11 (#839)
* updated test_utils mock to work with python3.11

* fixed python formatting
2025-09-04 10:44:04 -04:00
vedithal-amd 181bdf9ca1 [rocprofiler-compute] Fix MI100 tests (#832)
* Fix MI100 tests

* Handle missing roofline in db_analysis.py
2025-09-03 11:09:12 -04:00
jamessiddeley-amd f3a2bb07a4 [rocprofiler-compute] added ctest coverage and cdash submission (#366)
* added cdash automatic CI upload

* added cdash automatic CI upload

* tweaked wording

* changed nightly to continuous

* removed unnecessary dry-run arg

* updated README.md

* edited workflow description

* update coverage

* formatted cmakelists.txt

* ruff formatting and update coverage
2025-09-02 11:21:40 -04:00
jonatluu 6bc1ea966f fix lintian warning (#696)
* fix lintian warning

* fix lintian warning
2025-08-27 13:53:54 -04:00
cfallows-amd c68ba44e72 Add single kernel filtering to roofline plots (#757)
* Add single kernel filtering for roofline
* Add --kernel to documentation
* Add kernel labels to roofline pdfs

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Add test cases

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Add autodetect for mode (profile or analyze) during roof validate and filter
Prevent --kernel from affecting roofline in gui mode- although this may be broken in develop branch anyways

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Add note about roof-only usage checking for existing profiling files in the dir. If roof-only is not provided, rocprof-compute currently assumes it has to profile in full regardless. Will look into this another day.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Update CHANGELOG.md

Add line in resolved issues section to highlight that kernel filtering is now working for roofline plots

* Apply changes suggested by docs team

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Update projects/rocprofiler-compute/CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-08-27 13:41:07 -04:00
jamessiddeley-amd f0955f5a83 [rocprof-compute] added f4f6 description and VALU FLOPS split for empirical peaks (#739)
* added f4f6 description and VALU FLOPS split

* changed peak ammolite vars to local

* reverted to dict peak initialization

* ruff check format

* updated VALU descriptions

* updated VALU descriptions

* Update parser.py

* Update parser.py

Added gracefull NameError handling
Moved globals() update to init_metric_evaluation with ammolite__ vars and raw pmc_df

* update formatting
2025-08-27 12:46:41 -04:00
Pratik Basyal cfd3fee0e2 ROCm Compute Profiler changelog for 7.0 updated (#740)
* ROCm Compute Profiler changelog for 7.0 updated

* Roofline limited support for MI350 removed

* Update CHANGELOG.md
2025-08-27 11:24:49 -04:00
vedithal-amd 323d06c79c [rocprofiler-compute] Add database output format to analyze mode (#748)
Analysis data dump

* Add `--output-format` and `--output-name` option to analyze mode

* Remove `--output` and `-save-dfs` option to analyze mode

* Add documentation on `rocpd` output format and analysis database file

* Create sqlite3 database using object relation mapping (ORM) provided
  by sqlalchemy library

* Fix metrics config to remove metrics marked as `null`, fix `Unit` header, add
  missing `title`

* Add test cases to ensure analysis data dump work
2025-08-26 14:15:05 -04:00
xuchen-amd e8081bd91a Update mi350 output files for unit tests. (#744) 2025-08-25 21:27:10 -04:00
xuchen-amd 5c8b34ddf5 [rocprofiler-compute][TUI] Add interactive metric description (#718) 2025-08-25 15:53:55 -04:00
vedithal-amd 9a02dae75f [rocprofiler-compute] [Bugfix] Fix analysis not working with rocpd (#704)
* fix rocpd roofline

* Improve rocpd test by using dynamic workload folder

* bugfix

* fix ruff format
2025-08-25 11:46:55 -04:00
vedithal-amd 748c9b74d9 Update standalone binary to use python 3.9 (#725)
* Update standalone docker to python 3.9

* Add TUI files

* Fix docker files to work with monorepo

* Update standalone binary documentation
2025-08-25 07:57:08 -04:00