EPR #010002 - Change OpenCL version number from 1725 to 1726.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1472 edit
[ROCm/clr commit: ef33fcfcff]
EPR #010002 - Change OpenCL version number from 1725 to 1726.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1472 edit
EPR #010002 - Change OpenCL version number from 1724 to 1725.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1471 edit
[ROCm/clr commit: 2a531ac0ea]
EPR #010002 - Change OpenCL version number from 1724 to 1725.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1471 edit
EPR #410989 - Set globalScratchBuf_ to NULL after it is deleted.
The issue is that scratch buffer will be destroyed again when the transfer queue is destroyed.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#492 edit
[ROCm/clr commit: 6ea7225039]
EPR #410989 - Set globalScratchBuf_ to NULL after it is deleted.
The issue is that scratch buffer will be destroyed again when the transfer queue is destroyed.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#492 edit
ECR #333753 - Compiler Lib/ORCA RT/Performance: BRIG in BIF is not needed anymore for finalizing & executing ISA (except cases with program scope global variables).
[Description] The feature is intended to minimize the binary size for execution.
This is half-hearted solution: If -fno-bin-cg is set, then after ISA finalization all BRIG sections are removed from the binary, but if there are program scope global variables in code, the option is ignored and all BRIG sections retain in binary for further globals allocation & initialization. The complete solution awaits Code Objects implementation.
+ Additionally change fixes Bug 10478.
+ Recompilation steps determination is changed in RT.
+ symBRIGLoaderMap is added to bif_section_labels.
+ RT_CONTAINS_LOADER_MAP is added for aclQueryInfo in order to check symBRIGLoaderMap existance in binary.
+ complib tests are added on -fbin-cg/-fno-bin-cg.
+ ocltst -t complib -M CLEnumCheck is updated.
[Side effects] performance improvement, memory consumption reduction
[TODO] Do the same on .hsa bits.
[Testing] pre check-in, make smoke, complib, ocltst: complib, compiler, runtime, binary
[Reviewer] German Andryeyev
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#59 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/brig_loader.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.hpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/scwrapper/scClientAPI.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclEnums.h#16 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/bif_section_labels.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/compiler/loader/libloader/loader.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#188 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#5 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/CLEnumCheck.cpp#40 edit
[ROCm/clr commit: 84508bb5a4]
ECR #333753 - Compiler Lib/ORCA RT/Performance: BRIG in BIF is not needed anymore for finalizing & executing ISA (except cases with program scope global variables).
[Description] The feature is intended to minimize the binary size for execution.
This is half-hearted solution: If -fno-bin-cg is set, then after ISA finalization all BRIG sections are removed from the binary, but if there are program scope global variables in code, the option is ignored and all BRIG sections retain in binary for further globals allocation & initialization. The complete solution awaits Code Objects implementation.
+ Additionally change fixes Bug 10478.
+ Recompilation steps determination is changed in RT.
+ symBRIGLoaderMap is added to bif_section_labels.
+ RT_CONTAINS_LOADER_MAP is added for aclQueryInfo in order to check symBRIGLoaderMap existance in binary.
+ complib tests are added on -fbin-cg/-fno-bin-cg.
+ ocltst -t complib -M CLEnumCheck is updated.
[Side effects] performance improvement, memory consumption reduction
[TODO] Do the same on .hsa bits.
[Testing] pre check-in, make smoke, complib, ocltst: complib, compiler, runtime, binary
[Reviewer] German Andryeyev
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#59 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/brig_loader.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.hpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/scwrapper/scClientAPI.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclEnums.h#16 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/bif_section_labels.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/compiler/loader/libloader/loader.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#188 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#5 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/CLEnumCheck.cpp#40 edit
EPR #010002 - Change OpenCL version number from 1723 to 1724.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1470 edit
[ROCm/clr commit: 9276e5b992]
EPR #010002 - Change OpenCL version number from 1723 to 1724.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1470 edit
EPR #010002 - Change OpenCL version number from 1722 to 1723.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1469 edit
[ROCm/clr commit: 08f0e15bca]
EPR #010002 - Change OpenCL version number from 1722 to 1723.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1469 edit
EPR #010002 - Change OpenCL version number from 1721 to 1722.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1468 edit
[ROCm/clr commit: c51f296496]
EPR #010002 - Change OpenCL version number from 1721 to 1722.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1468 edit
EPR #010002 - Change OpenCL version number from 1720 to 1721.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1467 edit
[ROCm/clr commit: 3eb6dee213]
EPR #010002 - Change OpenCL version number from 1720 to 1721.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1467 edit
EPR #010002 - Change OpenCL version number from 1719 to 1720.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1466 edit
[ROCm/clr commit: cc54e51cfb]
EPR #010002 - Change OpenCL version number from 1719 to 1720.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1466 edit
EPR #411675 - Disable the code of writing 0 for the buffer paging by VidMM if asic is apu.
On Kaveri, benchmark "photo editing" of PCMarks takes longer time
Not sure how PCMarks measures it.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#202 edit
[ROCm/clr commit: fe8a3fc53e]
EPR #411675 - Disable the code of writing 0 for the buffer paging by VidMM if asic is apu.
On Kaveri, benchmark "photo editing" of PCMarks takes longer time
Not sure how PCMarks measures it.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#202 edit
ECR #333753 - Partial fix for Bug 10478 "Fix -fno-bin-llvmir/-fno-bin-hsail options"
If option -fno-bin-llvmi is set, .llvmir section is deleted from BIF on CG phase instead of FE. Both HSA & AMDIL are affected.
[Fixed] -fno-bin-llvm option causes clBuildProgram fail with error -11.
Took place only if compiled from OpenCL
[TODO] If possible -fno-bin-hsail should avoid putting HSAIL binary (BRIG) into BIF.
[Tests] pre check-in, make smoke, complib
[Reviewers] Brian Sumner, Nikolay Haustov
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/frontend.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/frontend_clang.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#58 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#63 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-llvmir/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-llvmir/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#3 edit
[ROCm/clr commit: 770a084e70]
ECR #333753 - Partial fix for Bug 10478 "Fix -fno-bin-llvmir/-fno-bin-hsail options"
If option -fno-bin-llvmi is set, .llvmir section is deleted from BIF on CG phase instead of FE. Both HSA & AMDIL are affected.
[Fixed] -fno-bin-llvm option causes clBuildProgram fail with error -11.
Took place only if compiled from OpenCL
[TODO] If possible -fno-bin-hsail should avoid putting HSAIL binary (BRIG) into BIF.
[Tests] pre check-in, make smoke, complib
[Reviewers] Brian Sumner, Nikolay Haustov
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/frontend.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/frontend_clang.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#58 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#63 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-llvmir/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-llvmir/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#3 edit
EPR #010002 - Change OpenCL version number from 1718 to 1719.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1465 edit
[ROCm/clr commit: c2128824a2]
EPR #010002 - Change OpenCL version number from 1718 to 1719.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1465 edit
foreman
Ben Goz
Oded Gabbay