Commit-Graf

64512 Incheckningar

Upphovsman SHA1 Meddelande Datum
Giovanni LB fe00badc6e Adding late-replace envvar filenames to ATT
Change-Id: I5df51934ffa25358503013e1a230adb894d6ff94
2024-02-22 10:02:32 -05:00
Giovanni LB fe83593ccc Adding late-replace envvar filenames to ATT
Change-Id: I5df51934ffa25358503013e1a230adb894d6ff94


[ROCm/rocprofiler commit: fe00badc6e]
2024-02-22 10:02:32 -05:00
Shweta Khatri 24633c7a85 Avoid releasing scratch for blit queues
At hsa_shutdown(), scratch_lock_ may be gone. Blit queues don't need it.

Change-Id: Ic132ac8a6be31fb2f0623137115608b0b222f077
2024-02-22 14:12:05 +00:00
Shweta Khatri 7b3dbd6d9e Avoid releasing scratch for blit queues
At hsa_shutdown(), scratch_lock_ may be gone. Blit queues don't need it.

Change-Id: Ic132ac8a6be31fb2f0623137115608b0b222f077


[ROCm/ROCR-Runtime commit: 24633c7a85]
2024-02-22 14:12:05 +00:00
Jonathan Kim 1f63ea3476 Fix export-close race during IPC attach request
If two attach requests to the same piece of shared memory occur,
a double export or premature dmabuf fd close can occur since the export
and close on demand calls are not atomic.

Use a reference counter on shared memory dmabuf FDs that have
already been opened to avoid this problem.

Change-Id: I14a59209c0385e32582af42a57b33b1c6838a9b1
2024-02-22 14:12:05 +00:00
Jonathan Kim 18d556cba7 Fix export-close race during IPC attach request
If two attach requests to the same piece of shared memory occur,
a double export or premature dmabuf fd close can occur since the export
and close on demand calls are not atomic.

Use a reference counter on shared memory dmabuf FDs that have
already been opened to avoid this problem.

Change-Id: I14a59209c0385e32582af42a57b33b1c6838a9b1


[ROCm/ROCR-Runtime commit: 1f63ea3476]
2024-02-22 14:12:05 +00:00
David Yat Sin b77ade9c64 rocrtst: Add non-contiguous VMM map tests
Add rocrtst to test mapping non-contiguous memory to a
single VA range

Change-Id: Id2e57f83512f8b482456b2b1925586951ada7400
2024-02-22 14:12:05 +00:00
David Yat Sin 5288e97de6 rocrtst: Add non-contiguous VMM map tests
Add rocrtst to test mapping non-contiguous memory to a
single VA range

Change-Id: Id2e57f83512f8b482456b2b1925586951ada7400


[ROCm/ROCR-Runtime commit: b77ade9c64]
2024-02-22 14:12:05 +00:00
David Yat Sin 99e31e43aa rocrtst: Add test for GPU access to memory
Add test to verify whether GPU shaders can read memory created using VMM
APIs.
Split VMM rocrtst to two separate groups: Basic and Access tests

Change-Id: Iead8d46125580c71ccd582e967c8e2e891e75c5e
2024-02-22 14:12:05 +00:00
David Yat Sin a4003bb849 rocrtst: Add test for GPU access to memory
Add test to verify whether GPU shaders can read memory created using VMM
APIs.
Split VMM rocrtst to two separate groups: Basic and Access tests

Change-Id: Iead8d46125580c71ccd582e967c8e2e891e75c5e


[ROCm/ROCR-Runtime commit: 99e31e43aa]
2024-02-22 14:12:05 +00:00
David Yat Sin 1f50219634 Fix compile error when using clang
Change-Id: Ibacf094934a9b489c052a18eeb6b26639aba3032
2024-02-22 14:12:05 +00:00
David Yat Sin 1e44ddc349 Fix compile error when using clang
Change-Id: Ibacf094934a9b489c052a18eeb6b26639aba3032


[ROCm/ROCR-Runtime commit: 1f50219634]
2024-02-22 14:12:05 +00:00
Rahul Garg bb17583545 SWDEV-443760 - Disable HIP_FORCE_DEV_KERNARG by default
Change-Id: I8c3d8e65aa954bd28499eebefbc532d1177445dc


[ROCm/clr commit: b954d0d6e0]
2024-02-22 04:37:51 -05:00
Rahul Garg b954d0d6e0 SWDEV-443760 - Disable HIP_FORCE_DEV_KERNARG by default
Change-Id: I8c3d8e65aa954bd28499eebefbc532d1177445dc
2024-02-22 04:37:51 -05:00
Gopesh Bhardwaj a651f1e215 Fixing opensuse compilation (#521)
* Fixing opensuse compilation

* source formatting (clang-format v11) (#526)

Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>

* Update tests/tools/CMakeLists.txt

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 2d71520953]
2024-02-22 01:10:23 -06:00
Gopesh Bhardwaj 2d71520953 Fixing opensuse compilation (#521)
* Fixing opensuse compilation

* source formatting (clang-format v11) (#526)

Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>

* Update tests/tools/CMakeLists.txt

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
2024-02-22 01:10:23 -06:00
Jonathan R. Madsen f760a3ceaa Updates/fixes for CI, docs, tests, samples, and common library (#528)
- .github/workflows/continuous_integration.yml
  - apt-get update before apt-get install
  - remove libgtest-dev
  - actions-comment-pull-request: v2.4.3 -> v2.5.0
- .github/workflows/formatting.yml
  - create-pull-request: v5 -> v6
- cmake/rocprofiler_options.cmake
  - remove unused ROCPROFILER_DEBUG_TRACE and ROCPROFILER_LD_AQLPROFILE options
- samples/counter_collection/callback_client.cpp
  - corr_id field renamed to correlation_id
- samples/counter_collection/client.cpp
  - corr_id field renamed to correlation_id
- include/rocprofiler-sdk/fwd.h
  - In rocprofiler_record_counter_t: rename corr_id field to correlation_id
  - doxygen fixes
- lib/common/utility.*
  - remove get_accurate_clock_id_impl
  - timestamp_ns() defaults to CLOCK_BOOTTIME
- lib/rocprofiler-sdk/counters/core.cpp
  - fix spelling mistake: extrenal -> external
  - corr_id field renamed to correlation_id
- lib/rocprofiler-sdk-tool/tool.cpp
  - fix destruction of static tool::output_file before finalization
- scripts/update-docs.sh
  - define PROJECT_NAME
- tests/async-copy-tracing/validate.py
  - init_time and fini_time checks
  - hip_api_traces, marker_api_tracing
- tests/common/serialization.hpp
  - fix save function for rocprofiler_record_counter_t following rename of corr_id to correlation_id
- tests/kernel-tracing/validate.py
  - init_time and fini_time checks
  - relax test_total_runtime range
- tests/rocprofv3/tracing/CMakeLists.txt
  - remove -M from rocprofv3-test-systrace-execute
  - exclude test_hsa_api_trace in rocprofv3-test-systrace-validate due to HIP API tracing
- tests/rocprofv3/tracing/validate.py
  - update test_kernel_trace to accept mangled or demangled
- tests/tools/json-tool.cpp
  - remove use of GLOG
  - include init_time and fini_time
  - write_json(...) function

[ROCm/rocprofiler-sdk commit: 0d939edbba]
2024-02-22 00:16:43 -06:00
Jonathan R. Madsen 0d939edbba Updates/fixes for CI, docs, tests, samples, and common library (#528)
- .github/workflows/continuous_integration.yml
  - apt-get update before apt-get install
  - remove libgtest-dev
  - actions-comment-pull-request: v2.4.3 -> v2.5.0
- .github/workflows/formatting.yml
  - create-pull-request: v5 -> v6
- cmake/rocprofiler_options.cmake
  - remove unused ROCPROFILER_DEBUG_TRACE and ROCPROFILER_LD_AQLPROFILE options
- samples/counter_collection/callback_client.cpp
  - corr_id field renamed to correlation_id
- samples/counter_collection/client.cpp
  - corr_id field renamed to correlation_id
- include/rocprofiler-sdk/fwd.h
  - In rocprofiler_record_counter_t: rename corr_id field to correlation_id
  - doxygen fixes
- lib/common/utility.*
  - remove get_accurate_clock_id_impl
  - timestamp_ns() defaults to CLOCK_BOOTTIME
- lib/rocprofiler-sdk/counters/core.cpp
  - fix spelling mistake: extrenal -> external
  - corr_id field renamed to correlation_id
- lib/rocprofiler-sdk-tool/tool.cpp
  - fix destruction of static tool::output_file before finalization
- scripts/update-docs.sh
  - define PROJECT_NAME
- tests/async-copy-tracing/validate.py
  - init_time and fini_time checks
  - hip_api_traces, marker_api_tracing
- tests/common/serialization.hpp
  - fix save function for rocprofiler_record_counter_t following rename of corr_id to correlation_id
- tests/kernel-tracing/validate.py
  - init_time and fini_time checks
  - relax test_total_runtime range
- tests/rocprofv3/tracing/CMakeLists.txt
  - remove -M from rocprofv3-test-systrace-execute
  - exclude test_hsa_api_trace in rocprofv3-test-systrace-validate due to HIP API tracing
- tests/rocprofv3/tracing/validate.py
  - update test_kernel_trace to accept mangled or demangled
- tests/tools/json-tool.cpp
  - remove use of GLOG
  - include init_time and fini_time
  - write_json(...) function
2024-02-22 00:16:43 -06:00
Jatin Chaudhary 4b6fb4fff4 SWDEV-446760 - check image support before running array tests
Change-Id: I1eca9bdbfb20567137c7c17ab649555938fc6e60


[ROCm/hip-tests commit: ec11b79b12]
2024-02-22 00:58:32 -05:00
Jatin Chaudhary ec11b79b12 SWDEV-446760 - check image support before running array tests
Change-Id: I1eca9bdbfb20567137c7c17ab649555938fc6e60
2024-02-22 00:58:32 -05:00
jujiang 7c9a68343c SWDEV-444835 - Update hip FAQ
Change-Id: I8858982feb0407be96b4f428e665524ed60ea3dd


[ROCm/hip commit: 62dd171ef0]
2024-02-21 19:42:48 -05:00
jujiang 62dd171ef0 SWDEV-444835 - Update hip FAQ
Change-Id: I8858982feb0407be96b4f428e665524ed60ea3dd
2024-02-21 19:42:48 -05:00
jujiang c9991341dc SWDEV-444390 - Update link in Github for hip-tests
Change-Id: I8e49f88f8f6d9f6d430774bd72f8fdcc522553f6


[ROCm/hip-tests commit: 4c0bf68dd9]
2024-02-21 11:40:09 -05:00
jujiang 4c0bf68dd9 SWDEV-444390 - Update link in Github for hip-tests
Change-Id: I8e49f88f8f6d9f6d430774bd72f8fdcc522553f6
2024-02-21 11:40:09 -05:00
Satyanvesh Dittakavi 0595e7c41f SWDEV-426272 - hipPointerGetAttribute shouldn't segfault when host ptr is passed
Check the pointer if its present in the arrayset before trying to dereference
it as it can cause access violation if the pointer is allocated using malloc

Change-Id: Ida72b9015dc22269fc1fbe0728e66e3de29fda3d


[ROCm/clr commit: 821ae6a103]
2024-02-21 16:37:21 +00:00
Satyanvesh Dittakavi 821ae6a103 SWDEV-426272 - hipPointerGetAttribute shouldn't segfault when host ptr is passed
Check the pointer if its present in the arrayset before trying to dereference
it as it can cause access violation if the pointer is allocated using malloc

Change-Id: Ida72b9015dc22269fc1fbe0728e66e3de29fda3d
2024-02-21 16:37:21 +00:00
jujiang f120b0b805 SWDEV-446296 - Update README for the repos link change
Change-Id: I13f73e3c9a066c5e92f630bcd06f777790087e5e


[ROCm/clr commit: 4c28f4aefd]
2024-02-20 18:53:07 -05:00
jujiang 4c28f4aefd SWDEV-446296 - Update README for the repos link change
Change-Id: I13f73e3c9a066c5e92f630bcd06f777790087e5e
2024-02-20 18:53:07 -05:00
Ioannis Assiouras 80ddb8e4eb SWDEV-446399 - Fixed segfault in hipMemSetAccess
Change-Id: Ia1200d9bee03e8abade211287505f081e635ceec


[ROCm/clr commit: 1f6d416684]
2024-02-20 18:51:05 -05:00
Ioannis Assiouras 1f6d416684 SWDEV-446399 - Fixed segfault in hipMemSetAccess
Change-Id: Ia1200d9bee03e8abade211287505f081e635ceec
2024-02-20 18:51:05 -05:00
Todd tiantuo Li a4f180aea9 SWDEV-333557 - Enable PAL_HIP_IPC_FLAG by default
Change-Id: Ibb2ca0b9521aff4eca190e4817dcc5f8d697b172


[ROCm/clr commit: 7bfee3481b]
2024-02-20 18:45:25 -05:00
Todd tiantuo Li 7bfee3481b SWDEV-333557 - Enable PAL_HIP_IPC_FLAG by default
Change-Id: Ibb2ca0b9521aff4eca190e4817dcc5f8d697b172
2024-02-20 18:45:25 -05:00
Giovanni LB a1999fa366 SWDEV-446854: Fixing ATT crash on rocblas_sgemm
Change-Id: I932b92c4e188655500b1b150d9594ec663dd25c7
2024-02-20 14:55:27 -05:00
Giovanni LB 5d19da5db4 SWDEV-446854: Fixing ATT crash on rocblas_sgemm
Change-Id: I932b92c4e188655500b1b150d9594ec663dd25c7


[ROCm/rocprofiler commit: a1999fa366]
2024-02-20 14:55:27 -05:00
German Andryeyev 7e1d48625c SWDEV-311270 - Fix HIP tests for mempool IPC
Change-Id: Ib5065a259e66fd53c3ffd6bc038dd65be00a3a3d


[ROCm/hip-tests commit: 228748a9d8]
2024-02-20 11:35:44 -05:00
German Andryeyev 228748a9d8 SWDEV-311270 - Fix HIP tests for mempool IPC
Change-Id: Ib5065a259e66fd53c3ffd6bc038dd65be00a3a3d
2024-02-20 11:35:44 -05:00
Saleel Kudchadker ec59b1bc3e SWDEV-443760 - Enable device kern args
- Implement workaround to ensure HDP writes are done by writing and
reading the HDP MMIO register.
- Implement the same workaround for graphs, we no longer need sentinel
write/readback

Change-Id: I0d3027b46a1f61131ec62e3c8c669ff5184fa6b2


[ROCm/clr commit: f138e0d113]
2024-02-20 02:03:14 -05:00
Saleel Kudchadker f138e0d113 SWDEV-443760 - Enable device kern args
- Implement workaround to ensure HDP writes are done by writing and
reading the HDP MMIO register.
- Implement the same workaround for graphs, we no longer need sentinel
write/readback

Change-Id: I0d3027b46a1f61131ec62e3c8c669ff5184fa6b2
2024-02-20 02:03:14 -05:00
Galantsev, Dmitrii 6d5d9971c2 CMAKE - Find hsa-runtime64
Change-Id: Id877eb9cfcc61d81993a6a43703ef2e5f72e1e8f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-02-19 23:49:38 -05:00
Galantsev, Dmitrii dd257bfcac CMAKE - Find hsa-runtime64
Change-Id: Id877eb9cfcc61d81993a6a43703ef2e5f72e1e8f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 6d5d9971c2]
2024-02-19 23:49:38 -05:00
Benjamin Welton 2d9779ad96 Add rocprofiler_query_counter_info function (#452)
* Add rocprofiler_query_counter_info function

Replaces rocprofiler_query_counter_name. Allows for
querying other types of info from counters (such as
description) and gives us some flexibility to add
return data in the near future (if we have to).

* source formatting (clang-format v11) (#453)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Updated version fetching

* source formatting (clang-format v11) (#509)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Merged

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 7adffd5b22]
2024-02-19 16:05:38 -08:00
Benjamin Welton 7adffd5b22 Add rocprofiler_query_counter_info function (#452)
* Add rocprofiler_query_counter_info function

Replaces rocprofiler_query_counter_name. Allows for
querying other types of info from counters (such as
description) and gives us some flexibility to add
return data in the near future (if we have to).

* source formatting (clang-format v11) (#453)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Updated version fetching

* source formatting (clang-format v11) (#509)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Merged

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
2024-02-19 16:05:38 -08:00
Benjamin Welton cb6e12ab3a Callback based handler for counter collection (#506)
* Callback based handler for counter collection

* source formatting (clang-format v11) (#507)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* cmake formatting (cmake-format) (#508)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Doc fix

* Minor doc fix

* More doc fixes

* More doc fixes

* More doc fixes

* Update CI

* Changes to the API per comments

* Mutex exception for HSA

* source formatting (clang-format v11) (#511)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Doc fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 3638351b4c]
2024-02-19 15:55:21 -08:00
Benjamin Welton 3638351b4c Callback based handler for counter collection (#506)
* Callback based handler for counter collection

* source formatting (clang-format v11) (#507)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* cmake formatting (cmake-format) (#508)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Doc fix

* Minor doc fix

* More doc fixes

* More doc fixes

* More doc fixes

* Update CI

* Changes to the API per comments

* Mutex exception for HSA

* source formatting (clang-format v11) (#511)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Doc fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
2024-02-19 15:55:21 -08:00
Mirza Halilčević d1bebf302f EXSWHTEC-249 - Implement Performance Tests for Memcpy APIs #119
Change-Id: Ib04fe4dd3efce92d7c7bfc8f0c75abd8e9dfe7be


[ROCm/hip-tests commit: e3bac85a3c]
2024-02-19 23:36:51 +05:30
Mirza Halilčević e3bac85a3c EXSWHTEC-249 - Implement Performance Tests for Memcpy APIs #119
Change-Id: Ib04fe4dd3efce92d7c7bfc8f0c75abd8e9dfe7be
2024-02-19 23:36:51 +05:30
Nives Vukovic 48c932afad EXSWHTEC-259 - Implement new and extend existing tests for thread_block #151
Change-Id: I4d85af8e5f805a1c8ff7b7efd3b3400f38343ea9


[ROCm/hip-tests commit: 4fa177dd2b]
2024-02-19 23:36:30 +05:30
Nives Vukovic 4fa177dd2b EXSWHTEC-259 - Implement new and extend existing tests for thread_block #151
Change-Id: I4d85af8e5f805a1c8ff7b7efd3b3400f38343ea9
2024-02-19 23:36:30 +05:30
Mirza Halilčević 20ee07a6d7 EXSWHTEC-107 - Implement tests for Execution Control setter APIs #57
Change-Id: I5d7e6471237b4a5726e09e4de06dafe2aa78cd28


[ROCm/hip-tests commit: 4507ee6531]
2024-02-19 23:35:21 +05:30
Mirza Halilčević 4507ee6531 EXSWHTEC-107 - Implement tests for Execution Control setter APIs #57
Change-Id: I5d7e6471237b4a5726e09e4de06dafe2aa78cd28
2024-02-19 23:35:21 +05:30