Граф коммитов

64512 Коммитов

Автор SHA1 Сообщение Дата
Oliveira, Daniel ea66076ea9 fix: [rocm/rocm_smi_lib] header cleanup Remove non-unified headers
Cleans up individual gpu metric APIs which will be implemented according to 'unified-headers' standards

Code changes related to the following:
  * 'rsmi_dev_metrics_' APIs
  * Functional tests
  * Examples

Change-Id: I7d562a95889361ee6f8f7588f8a790f42c8eb262
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>


[ROCm/rocm_smi_lib commit: ce36198cb1]
2024-02-14 17:50:26 -06:00
Oliveira, Daniel ce36198cb1 fix: [rocm/rocm_smi_lib] header cleanup Remove non-unified headers
Cleans up individual gpu metric APIs which will be implemented according to 'unified-headers' standards

Code changes related to the following:
  * 'rsmi_dev_metrics_' APIs
  * Functional tests
  * Examples

Change-Id: I7d562a95889361ee6f8f7588f8a790f42c8eb262
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
2024-02-14 17:50:26 -06:00
Manjunath-Jakaraddi 8d705f8b96 SWDEV-445654: Adding metrics to MI300
Change-Id: I7c3d78d8739ad219fc05bd99d7fc11d1f023aadc
2024-02-14 13:17:15 -05:00
Manjunath-Jakaraddi afae19671e SWDEV-445654: Adding metrics to MI300
Change-Id: I7c3d78d8739ad219fc05bd99d7fc11d1f023aadc


[ROCm/rocprofiler commit: 8d705f8b96]
2024-02-14 13:17:15 -05:00
Giovanni LB 95b49ca593 Adding bank conflict and other MI300 missing metrics to rocprofv2
Change-Id: Ibb7fb6163aa3bd7742f199a03600c737720e3c61
2024-02-14 13:15:54 -05:00
Giovanni LB 825227ee6a Adding bank conflict and other MI300 missing metrics to rocprofv2
Change-Id: Ibb7fb6163aa3bd7742f199a03600c737720e3c61


[ROCm/rocprofiler commit: 95b49ca593]
2024-02-14 13:15:54 -05:00
Anusha GodavarthySurya 80887e8559 SWDEV-444767 - Fix graph tests for context change between Inst & launch with DEBUG_CLR_GRAPH_PACKET_CAPTURE
When graph is Instantiate on device 0 graph and launch on device1 switch to command creation and enqueue during launch.

Change-Id: Ied34dc99b2a776130d1354ed3830c6ccab9068e4


[ROCm/clr commit: 7d09e1abed]
2024-02-14 17:02:36 +00:00
Anusha GodavarthySurya 7d09e1abed SWDEV-444767 - Fix graph tests for context change between Inst & launch with DEBUG_CLR_GRAPH_PACKET_CAPTURE
When graph is Instantiate on device 0 graph and launch on device1 switch to command creation and enqueue during launch.

Change-Id: Ied34dc99b2a776130d1354ed3830c6ccab9068e4
2024-02-14 17:02:36 +00:00
Jaydeep Patel f6e34b2cec SWDEV-439298 - Correct odd/even logic.
Change-Id: Iafe1b3915b513207a5ef24cf145ac1e8e39a1672


[ROCm/hip-tests commit: 3da249e472]
2024-02-14 10:12:10 -05:00
Jaydeep Patel 3da249e472 SWDEV-439298 - Correct odd/even logic.
Change-Id: Iafe1b3915b513207a5ef24cf145ac1e8e39a1672
2024-02-14 10:12:10 -05:00
Jaydeep Patel c252216c70 SWDEV-441208 - MI300 does not support image.
Change-Id: Ifde2d01bef629d2c2f6c40466c3d843955083368


[ROCm/hip-tests commit: 00bb4595f7]
2024-02-14 10:11:32 -05:00
Jaydeep Patel 00bb4595f7 SWDEV-441208 - MI300 does not support image.
Change-Id: Ifde2d01bef629d2c2f6c40466c3d843955083368
2024-02-14 10:11:32 -05:00
Jaydeep Patel 5c43230f79 SWDEV-401781 - Enhance test case.
Change-Id: I47074cc972512ac1b699ed4fc9386d470fae1c61


[ROCm/hip-tests commit: 8993dd87ef]
2024-02-14 06:22:09 -05:00
Jaydeep Patel 8993dd87ef SWDEV-401781 - Enhance test case.
Change-Id: I47074cc972512ac1b699ed4fc9386d470fae1c61
2024-02-14 06:22:09 -05:00
Jaydeep Patel 97ad1412ea SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667

Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664


[ROCm/clr commit: d1b75659f2]
2024-02-14 00:05:41 -05:00
Jaydeep Patel d1b75659f2 SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667

Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664
2024-02-14 00:05:41 -05:00
David Galiffi d4ea13cb6c SWDEV-437230 - Add CODEOWNERS file
Add @gargrahul, @rakesroy, and @mangupta as CODEOWNERS.
This is for GitHub upstream.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I563a7cf860cca56ae5fb5e05dcfaf1751b3692e4


[ROCm/clr commit: 3a5e8bac40]
2024-02-13 23:53:44 -05:00
David Galiffi 3a5e8bac40 SWDEV-437230 - Add CODEOWNERS file
Add @gargrahul, @rakesroy, and @mangupta as CODEOWNERS.
This is for GitHub upstream.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I563a7cf860cca56ae5fb5e05dcfaf1751b3692e4
2024-02-13 23:53:44 -05:00
Nick Curtis fba2e174fb Fix clocks (#246)
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>

[ROCm/rocprofiler-compute commit: 852cc13f2a]
2024-02-13 20:22:11 -06:00
Nick Curtis 852cc13f2a Fix clocks (#246)
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
2024-02-13 20:22:11 -06:00
Nick Curtis 0dcd6e35dd Fix hbmBW calculation, (#243)
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Fix for earlier smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>

[ROCm/rocprofiler-compute commit: c60f031558]
2024-02-13 20:19:56 -06:00
Nick Curtis c60f031558 Fix hbmBW calculation, (#243)
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Fix for earlier smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
2024-02-13 20:19:56 -06:00
colramos-amd a5b1082836 Modify yaml configs to reflect new combined Top Stats
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: b7d5d3b64b]
2024-02-13 19:56:46 -06:00
colramos-amd b7d5d3b64b Modify yaml configs to reflect new combined Top Stats
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-13 19:56:46 -06:00
colramos-amd 96786667ad Enable the revamped Top Stats section in standalone GUI
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: bd83f68412]
2024-02-13 19:18:31 -06:00
colramos-amd bd83f68412 Enable the revamped Top Stats section in standalone GUI
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-13 19:18:31 -06:00
colramos-amd 85c4cec42e Combine kernel and dispatch stats in the Top Stats section of analysis
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2526e14802]
2024-02-13 19:17:41 -06:00
colramos-amd 2526e14802 Combine kernel and dispatch stats in the Top Stats section of analysis
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-13 19:17:41 -06:00
Charis Poag 059fd6260e [SWDEV-423481/SWDEV-423393] Align all device identifier details
Updated:
 * [CLI] Fixed vram % - printf style formatting causes many data errors
   This fix updates to the recommended way of outputting formatted data.
   https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
 * [API/CLI] Added gpu_id / GUID from kfd (rsmi_dev_guid_get)
       -> CLI name: "GUID"
       -> ROCm SMI calls: no arg, -i, --showhw, --showproduct
 * [API/CLI] Added node_id from kfd (rsmi_dev_node_get)
       -> CLI name: "Node"
       -> ROCm SMI calls: no arg, --showhw, --showproduct
 * [CLI] Added target gfx version from kfd
       -> CLI name: "GFX Version" or "GFX VER"
       -> ROCm SMI calls: --showhw, --showproduct
 * [CLI] Base ROCm CLI
       -> Removed - stacked id formatting:
	   This is to simplify identifiers helpful to users.
	   More identifiers can be found on -i --showhw, --showproduct
 * [CLI] Update -i, --showhw, --showproduct, w/out arg
      -> Card ID/DID/Model/SKU/VBIOS:
            All unsupported values now display "N/A" instead
            of "unknown" or "unsupported"
 * [CLI] Showhw now expands data based on content

Change-Id: Ifb8586f9f545892b8a5aa7903608273cdd77e075
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/rocm_smi_lib commit: 4b5ccb57f0]
2024-02-13 19:52:29 -05:00
Charis Poag 4b5ccb57f0 [SWDEV-423481/SWDEV-423393] Align all device identifier details
Updated:
 * [CLI] Fixed vram % - printf style formatting causes many data errors
   This fix updates to the recommended way of outputting formatted data.
   https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
 * [API/CLI] Added gpu_id / GUID from kfd (rsmi_dev_guid_get)
       -> CLI name: "GUID"
       -> ROCm SMI calls: no arg, -i, --showhw, --showproduct
 * [API/CLI] Added node_id from kfd (rsmi_dev_node_get)
       -> CLI name: "Node"
       -> ROCm SMI calls: no arg, --showhw, --showproduct
 * [CLI] Added target gfx version from kfd
       -> CLI name: "GFX Version" or "GFX VER"
       -> ROCm SMI calls: --showhw, --showproduct
 * [CLI] Base ROCm CLI
       -> Removed - stacked id formatting:
	   This is to simplify identifiers helpful to users.
	   More identifiers can be found on -i --showhw, --showproduct
 * [CLI] Update -i, --showhw, --showproduct, w/out arg
      -> Card ID/DID/Model/SKU/VBIOS:
            All unsupported values now display "N/A" instead
            of "unknown" or "unsupported"
 * [CLI] Showhw now expands data based on content

Change-Id: Ifb8586f9f545892b8a5aa7903608273cdd77e075
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-02-13 19:52:29 -05:00
Ilya Panfilov 34cfbb5751 SWDEV-438299 - Remove unused variables
Change-Id: Id2908fe851d566ec2515161090f1e21b60cf6447


[ROCm/clr commit: 243555959f]
2024-02-13 19:39:11 -05:00
Ilya Panfilov 243555959f SWDEV-438299 - Remove unused variables
Change-Id: Id2908fe851d566ec2515161090f1e21b60cf6447
2024-02-13 19:39:11 -05:00
Vladimir Stempen dc98babe34 Fix [Not supported] status for get_compute_process_info_by_pid
On some systems [rocm-smi --showpids] reports
get_compute_process_info_by_pid, Not supported on the given system
[PID] [PROCESS NAME] 1 UNKNOWN UNKNOWN UNKNOWN

get_compute_process_info_by_pid fails because cu_occupancy debugfs method
is not provided on some graphics cards and GFX revisions by design

Proposing a change to return success status when only cu_occupancy debugfs method
is not found and provide cu_occupancy invalidation value to mark only
this parameter as UNKNOWN

Change-Id: Iae37070d9bd19483b4e6c8ee24c7d9a4c92f00d7
Signed-off-by: Vladimir Stempen <Vladimir.Stempen@amd.com>
Reviewed-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 677433b367]
2024-02-13 18:17:47 -05:00
Vladimir Stempen 677433b367 Fix [Not supported] status for get_compute_process_info_by_pid
On some systems [rocm-smi --showpids] reports
get_compute_process_info_by_pid, Not supported on the given system
[PID] [PROCESS NAME] 1 UNKNOWN UNKNOWN UNKNOWN

get_compute_process_info_by_pid fails because cu_occupancy debugfs method
is not provided on some graphics cards and GFX revisions by design

Proposing a change to return success status when only cu_occupancy debugfs method
is not found and provide cu_occupancy invalidation value to mark only
this parameter as UNKNOWN

Change-Id: Iae37070d9bd19483b4e6c8ee24c7d9a4c92f00d7
Signed-off-by: Vladimir Stempen <Vladimir.Stempen@amd.com>
Reviewed-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-02-13 18:17:47 -05:00
Galantsev, Dmitrii 32806681ca SWDEV-444700 - CMAKE - Fix RUNPATH
These RUNPATH changes make it so libraries can be found without setting
LD_LIBRARY_PATH.

Mostly tested on installed RDC binaries and libraries. The
build binaries should also work.

Change-Id: Ifd908a5b61d24dfcbb1d08d21b4ee830156d8643
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-02-13 16:56:28 -06:00
Galantsev, Dmitrii 3c18db8861 SWDEV-444700 - CMAKE - Fix RUNPATH
These RUNPATH changes make it so libraries can be found without setting
LD_LIBRARY_PATH.

Mostly tested on installed RDC binaries and libraries. The
build binaries should also work.

Change-Id: Ifd908a5b61d24dfcbb1d08d21b4ee830156d8643
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 32806681ca]
2024-02-13 16:56:28 -06:00
German Andryeyev c9bace9b71 SWDEV-311271 - Fix Windows mempool management
Windows path still uses multi threading implementation. Hence, in graphs
all nodes are executed in a queue thread and that requires to manage
mempool in the queue thread. However, the spec allows to destory memory,
allocated in a graph, outside of the graph's execution. That may cause
mempool management to go out of sync.

Change-Id: I0ffb2244b3cb720455ed44d1b3e2487fa8959a77


[ROCm/clr commit: 4f6b0da028]
2024-02-13 17:16:06 -05:00
German Andryeyev 4f6b0da028 SWDEV-311271 - Fix Windows mempool management
Windows path still uses multi threading implementation. Hence, in graphs
all nodes are executed in a queue thread and that requires to manage
mempool in the queue thread. However, the spec allows to destory memory,
allocated in a graph, outside of the graph's execution. That may cause
mempool management to go out of sync.

Change-Id: I0ffb2244b3cb720455ed44d1b3e2487fa8959a77
2024-02-13 17:16:06 -05:00
David Yat Sin 5b28a1bc17 Fix compile error on certain gcc versions
Change-Id: I8a4fab76d1dcc576eb7706ab45fc786c0cab274a
2024-02-13 15:25:34 -05:00
David Yat Sin 7a6c962b36 Fix compile error on certain gcc versions
Change-Id: I8a4fab76d1dcc576eb7706ab45fc786c0cab274a


[ROCm/ROCR-Runtime commit: 5b28a1bc17]
2024-02-13 15:25:34 -05:00
David Yat Sin 5257adde87 Add query for memory properties
Change-Id: I07c084c56b15c499ec564860b2a514e909ab7ca4


[ROCm/rocminfo commit: 7e159e6d76]
2024-02-13 14:28:30 -05:00
David Yat Sin 7e159e6d76 Add query for memory properties
Change-Id: I07c084c56b15c499ec564860b2a514e909ab7ca4
2024-02-13 14:28:30 -05:00
David Yat Sin ae16b3e14e Use sysconf pagesize for system pagesize
Provided by user huanggyizhi on github
https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/124

Change-Id: Ia03c45f7a869ae2c804accf8163f8ae36c20dd5a
2024-02-13 14:28:10 -05:00
David Yat Sin 65497f8f2c Use sysconf pagesize for system pagesize
Provided by user huanggyizhi on github
https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/124

Change-Id: Ia03c45f7a869ae2c804accf8163f8ae36c20dd5a


[ROCm/ROCR-Runtime commit: ae16b3e14e]
2024-02-13 14:28:10 -05:00
Gopesh Bhardwaj 4bee0ece8b Adding test for demangling (#467)
* Adding test for demangling

* moving -M option to existing one

* minor typo in script and test correction

[ROCm/rocprofiler-sdk commit: 2b1c11a4f3]
2024-02-13 11:09:27 -06:00
Gopesh Bhardwaj 2b1c11a4f3 Adding test for demangling (#467)
* Adding test for demangling

* moving -M option to existing one

* minor typo in script and test correction
2024-02-13 11:09:27 -06:00
David Galiffi 42b79166bf SWDEV-437287 - Add CODEOWNERS file
Add @gargrahul, @mangupta, and @rakesroy as CODEOWNERS.
This is for GitHub upstream.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I24224d460a259acc6159ff0509667c861a4865e0


[ROCm/hip commit: 16b8ca7e49]
2024-02-13 10:36:01 -05:00
David Galiffi 16b8ca7e49 SWDEV-437287 - Add CODEOWNERS file
Add @gargrahul, @mangupta, and @rakesroy as CODEOWNERS.
This is for GitHub upstream.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I24224d460a259acc6159ff0509667c861a4865e0
2024-02-13 10:36:01 -05:00
David Galiffi 7a265ee254 SWDEV-437287 - Add CODEOWNERS file
Add @gargrahul, @rakesroy, and @mangupta as CODEOWNERS.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I353d56a37cf088a9c8c3a6deebad0eb3de1d99b9


[ROCm/hip-tests commit: aefccff870]
2024-02-13 10:35:51 -05:00
David Galiffi aefccff870 SWDEV-437287 - Add CODEOWNERS file
Add @gargrahul, @rakesroy, and @mangupta as CODEOWNERS.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Change-Id: I353d56a37cf088a9c8c3a6deebad0eb3de1d99b9
2024-02-13 10:35:51 -05:00