Граф коммитов

64512 Коммитов

Автор SHA1 Сообщение Дата
David Yat Sin 6333fdecf3 Use pthread_setaffinity_np
On some systems, pthread_addr_setaffinity_np does not exist, so we need
to use pthread_setaffinity_np on thread after pthread_create

Provided by Julian Samaroo on github

https: //github.com/RadeonOpenCompute/ROCR-Runtime/pull/143
Change-Id: I4649f94333f2d7b0a5993b370a4bfc48d92acecb
2023-12-18 17:41:49 -05:00
David Yat Sin dcd5f16de0 Use pthread_setaffinity_np
On some systems, pthread_addr_setaffinity_np does not exist, so we need
to use pthread_setaffinity_np on thread after pthread_create

Provided by Julian Samaroo on github

https: //github.com/RadeonOpenCompute/ROCR-Runtime/pull/143
Change-Id: I4649f94333f2d7b0a5993b370a4bfc48d92acecb


[ROCm/ROCR-Runtime commit: 6333fdecf3]
2023-12-18 17:41:49 -05:00
Cole Ramos c73bd2bf91 Enabling Standalone GUI on 2.x (#214)
* Initial overhaul of Analyze mode. Basic CLI is enabled.

Signed-off-by: colramos-amd <colramos@amd.com>

* Merge branch '2.x' of github.com:AMDResearch/omniperf into 2.x-dev

Signed-off-by: colramos-amd <colramos@amd.com>

* fix comment typo

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>

* Move error logging to util.py

Signed-off-by: colramos-amd <colramos@amd.com>

* Move perfmon_configs dir into omniperf_soc dir. Rename config dirs for clarity

Signed-off-by: colramos-amd <colramos@amd.com>

* Add a supported_archs property to Omniperf base class

Signed-off-by: colramos-amd <colramos@amd.com>

* Add css assets for GUI styling

Signed-off-by: colramos-amd <colramos@amd.com>

* Re-organize roofline class. Improved useability

Signed-off-by: colramos-amd <colramos@amd.com>

* Enable standalone GUI

Signed-off-by: colramos-amd <colramos@amd.com>

* Remove outdated metric_configs. This was moved to omniperf_soc dir

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix small bug in GUI to enable Mi100 visualization

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Cole Ramos <colramos@amd.com>
Co-authored-by: Karl W Schulz <karl.schulz@amd.com>

[ROCm/rocprofiler-compute commit: 7d93a086c2]
2023-12-18 14:37:01 -08:00
Cole Ramos 7d93a086c2 Enabling Standalone GUI on 2.x (#214)
* Initial overhaul of Analyze mode. Basic CLI is enabled.

Signed-off-by: colramos-amd <colramos@amd.com>

* Merge branch '2.x' of github.com:AMDResearch/omniperf into 2.x-dev

Signed-off-by: colramos-amd <colramos@amd.com>

* fix comment typo

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>

* Move error logging to util.py

Signed-off-by: colramos-amd <colramos@amd.com>

* Move perfmon_configs dir into omniperf_soc dir. Rename config dirs for clarity

Signed-off-by: colramos-amd <colramos@amd.com>

* Add a supported_archs property to Omniperf base class

Signed-off-by: colramos-amd <colramos@amd.com>

* Add css assets for GUI styling

Signed-off-by: colramos-amd <colramos@amd.com>

* Re-organize roofline class. Improved useability

Signed-off-by: colramos-amd <colramos@amd.com>

* Enable standalone GUI

Signed-off-by: colramos-amd <colramos@amd.com>

* Remove outdated metric_configs. This was moved to omniperf_soc dir

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix small bug in GUI to enable Mi100 visualization

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Cole Ramos <colramos@amd.com>
Co-authored-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-18 14:37:01 -08:00
Rakesh Roy cf3d4a1162 SWDEV-434211, SWDEV-437982 - Disable failing tests found in PSDB stress testing
- Disable tests that are failing on Linux during PSDB stress testing

Change-Id: I1711d2d67afd3d23a27f84684a06602236cece45


[ROCm/hip-tests commit: 24e2f429ca]
2023-12-18 20:49:43 +05:30
Rakesh Roy 24e2f429ca SWDEV-434211, SWDEV-437982 - Disable failing tests found in PSDB stress testing
- Disable tests that are failing on Linux during PSDB stress testing

Change-Id: I1711d2d67afd3d23a27f84684a06602236cece45
2023-12-18 20:49:43 +05:30
Giovanni Lenzi Baraldi 946407623f Fixed pcs doorbell_id so it matches the trap handler (#309)
* Fixed pcs doorbell_id so it matches the trap handler

* source formatting (clang-format v11) (#310)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Changed trap_handler correlation_id to a struct and added comments

* Fixed one of the comments

* source formatting (clang-format v11) (#312)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Changing correlation_in to please the linter

* source formatting (clang-format v11) (#313)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 5761b5fb60]
2023-12-18 11:50:06 -03:00
Giovanni Lenzi Baraldi 5761b5fb60 Fixed pcs doorbell_id so it matches the trap handler (#309)
* Fixed pcs doorbell_id so it matches the trap handler

* source formatting (clang-format v11) (#310)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Changed trap_handler correlation_id to a struct and added comments

* Fixed one of the comments

* source formatting (clang-format v11) (#312)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Changing correlation_in to please the linter

* source formatting (clang-format v11) (#313)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>
2023-12-18 11:50:06 -03:00
David Yat Sin 9b2ed66609 Fix README for invalid command
`-DCMAKE_INSTALL_PATH` is not valid,use `-DCMAKE_INSTALL_PREFIX` instead

https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/171/

Suggested-by: fjh1997 on github
Change-Id: Ibb85da7fe755b662fa9a836d6fbe3394d34a0337
2023-12-18 09:15:05 -05:00
David Yat Sin 9481b6290a Fix README for invalid command
`-DCMAKE_INSTALL_PATH` is not valid,use `-DCMAKE_INSTALL_PREFIX` instead

https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/171/

Suggested-by: fjh1997 on github
Change-Id: Ibb85da7fe755b662fa9a836d6fbe3394d34a0337


[ROCm/ROCR-Runtime commit: 9b2ed66609]
2023-12-18 09:15:05 -05:00
Ioannis Assiouras e1c6e3060b SWDEV-433745 - Changed hipExtModuleLaunchKernel declaration to extern C
Change-Id: I793471dfe3a0a580faa7a9b2672839db191fbe4f


[ROCm/hip commit: ef2b5f174a]
2023-12-18 12:48:19 +00:00
Ioannis Assiouras ef2b5f174a SWDEV-433745 - Changed hipExtModuleLaunchKernel declaration to extern C
Change-Id: I793471dfe3a0a580faa7a9b2672839db191fbe4f
2023-12-18 12:48:19 +00:00
Ioannis Assiouras e51c2f6097 SWDEV-437817 - Fix hipMemCpy2D case that erroneously fails with invalid argument error
When an offset is applied to the source or destination pointers plus the kind is set to
hipMemcpyDefault and the source or destination is allocated with hipMallocManaged
hipMemCpy2D erroneously fails with hipErrorInvalidValue.

Change-Id: I0db4c17514f743652d8f9a2691da6601a2abb2a1


[ROCm/clr commit: d3bfb55d7a]
2023-12-18 07:31:56 -05:00
Ioannis Assiouras d3bfb55d7a SWDEV-437817 - Fix hipMemCpy2D case that erroneously fails with invalid argument error
When an offset is applied to the source or destination pointers plus the kind is set to
hipMemcpyDefault and the source or destination is allocated with hipMallocManaged
hipMemCpy2D erroneously fails with hipErrorInvalidValue.

Change-Id: I0db4c17514f743652d8f9a2691da6601a2abb2a1
2023-12-18 07:31:56 -05:00
Giovanni LB 490ea4c37d SWDEV-432445: ATT - Adding fixes for symbolic stitch and source reference numbering
Change-Id: I31d63bd2500155697129c29d7e0bc857e48cad8e
2023-12-18 08:53:51 -03:00
Giovanni LB 0f5bec223e SWDEV-432445: ATT - Adding fixes for symbolic stitch and source reference numbering
Change-Id: I31d63bd2500155697129c29d7e0bc857e48cad8e


[ROCm/rocprofiler commit: 490ea4c37d]
2023-12-18 08:53:51 -03:00
Anusha GodavarthySurya 5355857116 SWDEV-436405 - Move hipChooseDevice out of hip namespace
Change-Id: I47a3cc5e5409f418b282d1a2e250128c769f4778


[ROCm/clr commit: 4a7291ded8]
2023-12-18 04:37:39 -05:00
Anusha GodavarthySurya 4a7291ded8 SWDEV-436405 - Move hipChooseDevice out of hip namespace
Change-Id: I47a3cc5e5409f418b282d1a2e250128c769f4778
2023-12-18 04:37:39 -05:00
Ranjith Ramakrishnan c3457852af Correct the permission of rocminfo and rocm_agent_enumerator
Both will have a permission of 755

Change-Id: I428c6419358a578595969b4bf0918e6384180dbc


[ROCm/rocminfo commit: c9905a8ba1]
2023-12-17 20:55:42 -08:00
Ranjith Ramakrishnan c9905a8ba1 Correct the permission of rocminfo and rocm_agent_enumerator
Both will have a permission of 755

Change-Id: I428c6419358a578595969b4bf0918e6384180dbc
2023-12-17 20:55:42 -08:00
gobhardw 6f033b4295 Allowed rocporf v1 for MI300
Change-Id: I5e4999fc2d27b68afa0bf70b65e2d97cd7f2b01d
2023-12-18 04:21:12 +00:00
gobhardw 51057d115b Allowed rocporf v1 for MI300
Change-Id: I5e4999fc2d27b68afa0bf70b65e2d97cd7f2b01d


[ROCm/rocprofiler commit: 6f033b4295]
2023-12-18 04:21:12 +00:00
Rupam Chetia 9b9c1cd34c SWDEV-322620 - [catch2][dtest] Adding test for VMM APIs
Change-Id: Ia4dea28601b3c2f0163012a7a2ceb14d3a0c369b


[ROCm/hip-tests commit: de348d8b35]
2023-12-16 07:28:16 -05:00
Rupam Chetia de348d8b35 SWDEV-322620 - [catch2][dtest] Adding test for VMM APIs
Change-Id: Ia4dea28601b3c2f0163012a7a2ceb14d3a0c369b
2023-12-16 07:28:16 -05:00
taosang2 75b68c4989 SWDEV-435296 - Fix sporatic segment fault
Fix sporatic segment fault in texture test
via retaining image in texture object which
references the image.
The image will be released when the texture
object is destroyed.

Change-Id: Ic3fefa2d5dda6afebd1acd4d41ad310b138af6dd


[ROCm/clr commit: d6d235a111]
2023-12-15 21:06:20 -05:00
taosang2 d6d235a111 SWDEV-435296 - Fix sporatic segment fault
Fix sporatic segment fault in texture test
via retaining image in texture object which
references the image.
The image will be released when the texture
object is destroyed.

Change-Id: Ic3fefa2d5dda6afebd1acd4d41ad310b138af6dd
2023-12-15 21:06:20 -05:00
Ioannis Assiouras d45267dd2a SWDEV-433745 - Added demangled symbol for hipExtModuleLaunchKernel
Change-Id: Ib8051fcbdf0c8c99e97c845b777d6562220701a0


[ROCm/clr commit: fe739047e5]
2023-12-15 16:59:40 -05:00
Ioannis Assiouras fe739047e5 SWDEV-433745 - Added demangled symbol for hipExtModuleLaunchKernel
Change-Id: Ib8051fcbdf0c8c99e97c845b777d6562220701a0
2023-12-15 16:59:40 -05:00
German Andryeyev 67597f4901 SWDEV-436869 - Destroy host memory
Recent changes disabled system memory allocation
in the abstraciton layer. That requires memory
allocation/destruction in ROCR. Add destruction logic.

Change-Id: I68fe6b0a620ca743fe5850052ea0efa8bb7931c2


[ROCm/clr commit: a6d480e098]
2023-12-15 16:39:41 -05:00
German Andryeyev a6d480e098 SWDEV-436869 - Destroy host memory
Recent changes disabled system memory allocation
in the abstraciton layer. That requires memory
allocation/destruction in ROCR. Add destruction logic.

Change-Id: I68fe6b0a620ca743fe5850052ea0efa8bb7931c2
2023-12-15 16:39:41 -05:00
Jonathan R. Madsen 309a8e069b Update packaging (#306)
* Restructured tests

- support standalone compilation
- move tests/kernel-tracing/serialization.hpp to tests/common/serialization.hpp
- created tests/common library
- handle cloning of cereal library in standalone build

* Update install and packaging

* Update cmake/rocprofiler_config_packaging.cmake

- condense core, samples, development, and tools install components into single rocprofiler-sdk package
- keep tests install component in separate rocprofiler-sdk-tests package

* Update CI workflow to test install and packaging

* Update CI workflow

- install newer cmake for packaging checks

* Update cmake/rocprofiler_config_packaging.cmake

- disable auto-generation of shared-lib deps and provides for tests package

* Update CI workflow

- add sbin to PATH for dpkg install

* Update CI workflow

- remove using github.workspace when installing packages

* Update CI workflow

- hack to fix ordering of dpkg install

* Update CI workflow

- whitespace cleanup

[ROCm/rocprofiler-sdk commit: 8ed68ce4f3]
2023-12-15 14:39:13 -06:00
Jonathan R. Madsen 8ed68ce4f3 Update packaging (#306)
* Restructured tests

- support standalone compilation
- move tests/kernel-tracing/serialization.hpp to tests/common/serialization.hpp
- created tests/common library
- handle cloning of cereal library in standalone build

* Update install and packaging

* Update cmake/rocprofiler_config_packaging.cmake

- condense core, samples, development, and tools install components into single rocprofiler-sdk package
- keep tests install component in separate rocprofiler-sdk-tests package

* Update CI workflow to test install and packaging

* Update CI workflow

- install newer cmake for packaging checks

* Update cmake/rocprofiler_config_packaging.cmake

- disable auto-generation of shared-lib deps and provides for tests package

* Update CI workflow

- add sbin to PATH for dpkg install

* Update CI workflow

- remove using github.workspace when installing packages

* Update CI workflow

- hack to fix ordering of dpkg install

* Update CI workflow

- whitespace cleanup
2023-12-15 14:39:13 -06:00
Xiaogang Chen 1a7162731e kfdtest: use svm range granularity in KFDSVMEvictTest.QueueTest/1
When xnack is on shadder code in this test triggers gpu page fault that migrate
data from system ram to vram. Use svm range granularity to move all data from
system buffer to vram to reduce system ram pressure to avoid system ram oom for
systems that has less system ram.

Signed-off-by: Xiaogang Chen <Xiaogang.Chen@amd.com>
Change-Id: I219472210756be319491f7827f7209fe32726f81
2023-12-15 13:27:22 -06:00
Xiaogang Chen 2a1b821740 kfdtest: use svm range granularity in KFDSVMEvictTest.QueueTest/1
When xnack is on shadder code in this test triggers gpu page fault that migrate
data from system ram to vram. Use svm range granularity to move all data from
system buffer to vram to reduce system ram pressure to avoid system ram oom for
systems that has less system ram.

Signed-off-by: Xiaogang Chen <Xiaogang.Chen@amd.com>
Change-Id: I219472210756be319491f7827f7209fe32726f81


[ROCm/ROCR-Runtime commit: 1a7162731e]
2023-12-15 13:27:22 -06:00
Jonathan R. Madsen 633a80ec1b Fix rocprof and rocprofiler-sdk-tool (#304)
* Fix rocprof and rocprofiler-sdk-tool

- removed redundant options for rocprofv3
- fixed extension of CSV files
- fixed memory error (segfault) when tracing kernels
- fixed constructor of output_file
  - using string after move
- output_file writes csv header
- implemented tool_fini
  - flush buffer and stop context

* Minor updates to rocprofv3

* Update source/bin/CMakeLists.txt

- fix rocprof configure output location

[ROCm/rocprofiler-sdk commit: 7d117870d8]
2023-12-15 12:44:50 -06:00
Jonathan R. Madsen 7d117870d8 Fix rocprof and rocprofiler-sdk-tool (#304)
* Fix rocprof and rocprofiler-sdk-tool

- removed redundant options for rocprofv3
- fixed extension of CSV files
- fixed memory error (segfault) when tracing kernels
- fixed constructor of output_file
  - using string after move
- output_file writes csv header
- implemented tool_fini
  - flush buffer and stop context

* Minor updates to rocprofv3

* Update source/bin/CMakeLists.txt

- fix rocprof configure output location
2023-12-15 12:44:50 -06:00
kjayapra-amd 6a36bf3b30 SWDEV-413997 - Alignment should be a multiple of device granularity.
Change-Id: Ie9c636385bbe3139c2dc24c16f31c9d5e2d56b95


[ROCm/clr commit: f9fd5f4049]
2023-12-15 13:27:23 -05:00
kjayapra-amd f9fd5f4049 SWDEV-413997 - Alignment should be a multiple of device granularity.
Change-Id: Ie9c636385bbe3139c2dc24c16f31c9d5e2d56b95
2023-12-15 13:27:23 -05:00
German cba839f38d SWDEV-436796 - Enable device memory for kernel arguments
Extra CPU read back will be performed before every submission to make sure
previous writes over PCIE reached GPU. HDP flush is done by CP.

Change-Id: I402d28ca26c8cee4a3920feb3599af8c285d0889


[ROCm/clr commit: cfc07c88ee]
2023-12-15 13:11:50 -05:00
German cfc07c88ee SWDEV-436796 - Enable device memory for kernel arguments
Extra CPU read back will be performed before every submission to make sure
previous writes over PCIE reached GPU. HDP flush is done by CP.

Change-Id: I402d28ca26c8cee4a3920feb3599af8c285d0889
2023-12-15 13:11:50 -05:00
Jonathan R. Madsen b50cf816a1 Update lib/rocprofiler-sdk/hsa/types.hpp (#305)
- remove static asserts on the HSA table step versions
- ifdef/else the amd_ext size based on HSA_AMD_EXT_API_TABLE_STEP_VERSION

[ROCm/rocprofiler-sdk commit: f96ab90067]
2023-12-15 11:01:55 -06:00
Jonathan R. Madsen f96ab90067 Update lib/rocprofiler-sdk/hsa/types.hpp (#305)
- remove static asserts on the HSA table step versions
- ifdef/else the amd_ext size based on HSA_AMD_EXT_API_TABLE_STEP_VERSION
2023-12-15 11:01:55 -06:00
German fa8e88b108 SWDEV-432575 - Disable direct map for persistent memory
Persistent memory should use direct access for write map and
indirect for read map.

Change-Id: I9fc84836d60088b24012ed25f7ef8c16e33796a3


[ROCm/clr commit: c8b3253a24]
2023-12-15 10:59:01 -05:00
German c8b3253a24 SWDEV-432575 - Disable direct map for persistent memory
Persistent memory should use direct access for write map and
indirect for read map.

Change-Id: I9fc84836d60088b24012ed25f7ef8c16e33796a3
2023-12-15 10:59:01 -05:00
Rahul Manocha 2d432c1ca6 SWDEV-431345 - CMake build flow for hip samples 16,17
Change-Id: I7bfc8600511c78d8c73aa526f9846cd268651279


[ROCm/hip-tests commit: f0b5b20466]
2023-12-15 09:02:23 -05:00
Rahul Manocha f0b5b20466 SWDEV-431345 - CMake build flow for hip samples 16,17
Change-Id: I7bfc8600511c78d8c73aa526f9846cd268651279
2023-12-15 09:02:23 -05:00
Rahul Garg a7971d31f9 SWDEV-422771 - Update links of ROCm projects
Change-Id: I211308814adce86549ce327ed0a823f799b3de03


[ROCm/clr commit: 35ce9f81d8]
2023-12-15 08:09:21 -05:00
Rahul Garg 35ce9f81d8 SWDEV-422771 - Update links of ROCm projects
Change-Id: I211308814adce86549ce327ed0a823f799b3de03
2023-12-15 08:09:21 -05:00
Anusha GodavarthySurya 01c89b94cd SWDEV-436405 - Add hipGetDevicePropertiesR0000 and hipChooseDeviceR0000 to hip dispatch table
Change-Id: I5b373ac030502eb88477d20a1d216bc48369b51d


[ROCm/clr commit: 3e72b8d1e1]
2023-12-15 06:26:52 -05:00
Anusha GodavarthySurya 3e72b8d1e1 SWDEV-436405 - Add hipGetDevicePropertiesR0000 and hipChooseDeviceR0000 to hip dispatch table
Change-Id: I5b373ac030502eb88477d20a1d216bc48369b51d
2023-12-15 06:26:52 -05:00