Граф коммитов

64512 Коммитов

Автор SHA1 Сообщение Дата
Galantsev, Dmitrii 8f9a6796f1 Upgrade to CXX-17 gtest-1.14
Change-Id: I1c7316f151128cbc9318b226dac14950e399d2c7
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-09-28 12:54:49 -05:00
Galantsev, Dmitrii d4440d392e Upgrade to CXX-17 gtest-1.14
Change-Id: I1c7316f151128cbc9318b226dac14950e399d2c7
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 8f9a6796f1]
2023-09-28 12:54:49 -05:00
Galantsev, Dmitrii f60b02916b Upgrade to CXX-17 gtest-1.14 and cmake-3.14
Also change the TARGET from amd_smi_libraries to rocm_smi_libraries
This helps reduce confusion between rocm-smi and amd-smi

Change-Id: Ie54cedd831ba24bd9afc341ad15b7e8e20732059
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: cf6bcbbb27]
2023-09-28 12:44:51 -05:00
Galantsev, Dmitrii cf6bcbbb27 Upgrade to CXX-17 gtest-1.14 and cmake-3.14
Also change the TARGET from amd_smi_libraries to rocm_smi_libraries
This helps reduce confusion between rocm-smi and amd-smi

Change-Id: Ie54cedd831ba24bd9afc341ad15b7e8e20732059
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-09-28 12:44:51 -05:00
taosang2 de3d24df97 SWDEV-415029 - [ABI Break] Remove hcc symbols
Change-Id: Ic0082d3960aadbb7bc559141b6e84bd29a75b5cf


[ROCm/hip-tests commit: 403afae98f]
2023-09-28 12:36:05 -04:00
taosang2 403afae98f SWDEV-415029 - [ABI Break] Remove hcc symbols
Change-Id: Ic0082d3960aadbb7bc559141b6e84bd29a75b5cf
2023-09-28 12:36:05 -04:00
kjayapra-amd 4937fa6b5d SWDEV-424569 - Fixing a merge error, which removed amd::Program->release().
Change-Id: Ib43dfc528ce217cb23d5eb38a0f87c241ae274a6


[ROCm/clr commit: c3a39ef32a]
2023-09-28 11:41:04 -04:00
kjayapra-amd c3a39ef32a SWDEV-424569 - Fixing a merge error, which removed amd::Program->release().
Change-Id: Ib43dfc528ce217cb23d5eb38a0f87c241ae274a6
2023-09-28 11:41:04 -04:00
Julia Jiang 31cab29779 SWDEV-422771 - Update some documents
Change-Id: I7a4032af44b66b6936e845ecce59e189f5c03664


[ROCm/hip commit: a4066ec239]
2023-09-28 11:31:35 -04:00
Julia Jiang a4066ec239 SWDEV-422771 - Update some documents
Change-Id: I7a4032af44b66b6936e845ecce59e189f5c03664
2023-09-28 11:31:35 -04:00
Giovanni LB 675e1b9d38 SWDEV-423898: Fixing issues with parallel kernels
Change-Id: I6726f3003af6036ba041c2b4bc5227dd08691090
2023-09-28 00:11:23 -03:00
Giovanni LB 2124bb6b38 SWDEV-423898: Fixing issues with parallel kernels
Change-Id: I6726f3003af6036ba041c2b4bc5227dd08691090


[ROCm/rocprofiler commit: 675e1b9d38]
2023-09-28 00:11:23 -03:00
Ajay a9e57c70b5 SWDEV-1 - fix build errors for file descriptor
Change-Id: I38b3962744f20ce758c32077f2c725013c666a35


[ROCm/clr commit: 3337f6912d]
2023-09-27 20:00:05 -04:00
Ajay 3337f6912d SWDEV-1 - fix build errors for file descriptor
Change-Id: I38b3962744f20ce758c32077f2c725013c666a35
2023-09-27 20:00:05 -04:00
Jonathan R. Madsen 1502968c67 Fix roctracer data race (#309)
- roctracer_type_mutex was per-thread, causing lack of sync b/t callback and activity

[ROCm/rocprofiler-systems commit: 227980f32b]
2023-09-27 18:06:16 -05:00
Jonathan R. Madsen 227980f32b Fix roctracer data race (#309)
- roctracer_type_mutex was per-thread, causing lack of sync b/t callback and activity
2023-09-27 18:06:16 -05:00
Jonathan R. Madsen 77ab79e3e2 Fix set_tests_properties on some unittests (#90)
* Fix set_tests_properties on some unittests

- misspelled variable in two places

* Update samples/api_buffered_tracing/client.cpp

- output to file by default

* Update samples/api_callback_tracing/client.cpp

- output to file by default

* Update lib/rocprofiler/registration.cpp

- improve guards around initialize and finalize

* Update lib/rocprofiler/tests/registration.cpp

- test rocprofiler_iterate_callback_tracing_kind_names
- validate number of kind names and number of HSA operation names

* Update CI workflow and run-ci.py

- change --coverage flag to support all/unittests/samples
  - samples mode excludes lib/common
  - samples mode appends -L samples
  - unittests mode appends -L unittests

* Update samples/api_buffered_tracing/client.cpp

- header include location fix

[ROCm/rocprofiler-sdk commit: 2d533ad91e]
2023-09-27 15:44:46 -05:00
Jonathan R. Madsen 2d533ad91e Fix set_tests_properties on some unittests (#90)
* Fix set_tests_properties on some unittests

- misspelled variable in two places

* Update samples/api_buffered_tracing/client.cpp

- output to file by default

* Update samples/api_callback_tracing/client.cpp

- output to file by default

* Update lib/rocprofiler/registration.cpp

- improve guards around initialize and finalize

* Update lib/rocprofiler/tests/registration.cpp

- test rocprofiler_iterate_callback_tracing_kind_names
- validate number of kind names and number of HSA operation names

* Update CI workflow and run-ci.py

- change --coverage flag to support all/unittests/samples
  - samples mode excludes lib/common
  - samples mode appends -L samples
  - unittests mode appends -L unittests

* Update samples/api_buffered_tracing/client.cpp

- header include location fix
2023-09-27 15:44:46 -05:00
Julia Jiang 284a1fc1cf SWDEV-400025 - Update FAQ for the differences between C and C++ HIP programs
Change-Id: Idc743453fc5f22669031bb49646f49cc68fd01da


[ROCm/hip commit: 2e8e205552]
2023-09-27 16:03:44 -04:00
Julia Jiang 2e8e205552 SWDEV-400025 - Update FAQ for the differences between C and C++ HIP programs
Change-Id: Idc743453fc5f22669031bb49646f49cc68fd01da
2023-09-27 16:03:44 -04:00
Fei Zheng 587bd81d29 A few fixes for the document (#302)
a few doc fixes

[ROCm/rocprofiler-systems commit: f88614dbcd]
2023-09-27 14:43:06 -05:00
Fei Zheng f88614dbcd A few fixes for the document (#302)
a few doc fixes
2023-09-27 14:43:06 -05:00
kjayapra-amd feaa0bbe43 SWDEV-420149 - Fixing unsafe atomics change for targets other than gfx90a.
Change-Id: Ifa26fd1c51505c5e86e121233c8352e3bde846ea


[ROCm/hip-tests commit: a363fa2833]
2023-09-27 12:20:05 -04:00
kjayapra-amd a363fa2833 SWDEV-420149 - Fixing unsafe atomics change for targets other than gfx90a.
Change-Id: Ifa26fd1c51505c5e86e121233c8352e3bde846ea
2023-09-27 12:20:05 -04:00
Bill(Shuzhou) Liu 20975db2be Do not print the library name if in default folder
The rocm-smi python tool will not print the library name on default
folder.

Change-Id: I203a872ebe2fc994766a2628049ca50c8bfa7120


[ROCm/rocm_smi_lib commit: 016dbf8aa3]
2023-09-27 12:14:33 -04:00
Bill(Shuzhou) Liu 016dbf8aa3 Do not print the library name if in default folder
The rocm-smi python tool will not print the library name on default
folder.

Change-Id: I203a872ebe2fc994766a2628049ca50c8bfa7120
2023-09-27 12:14:33 -04:00
Julia Jiang d1028926ef SWDEV-393746 - Fix for HIP-sample tests failure
Change-Id: Ifb2dc03cfa82bb96f5f0d21b3848a5cda0baf9bc


[ROCm/hip-tests commit: 547de9c274]
2023-09-27 11:55:17 -04:00
Julia Jiang 547de9c274 SWDEV-393746 - Fix for HIP-sample tests failure
Change-Id: Ifb2dc03cfa82bb96f5f0d21b3848a5cda0baf9bc
2023-09-27 11:55:17 -04:00
Jatin Chaudhary 16d3e732b6 SWDEV-412457 - Add <cassert> header in file that uses assert
Change-Id: I2f9401d3890cc3c5116dba21ee959f1bf4f0b48e


[ROCm/roctracer commit: 4ff80750b3]
2023-09-27 14:29:17 +01:00
Jatin Chaudhary 4ff80750b3 SWDEV-412457 - Add <cassert> header in file that uses assert
Change-Id: I2f9401d3890cc3c5116dba21ee959f1bf4f0b48e
2023-09-27 14:29:17 +01:00
Jonathan R. Madsen cfcfd280d0 rocprofiler library unit tests (#81)
* Update CI and linting workflows

- delete linting workflow
- compile default CI job with clang-tidy
- split out code coverage matrix entry to separate job
- code coverage job runs code coverage 3x
  - once for total code coverage
  - once for unittests code coverage
  - once for samples code coverage

* Update PTL submodule

- improves handling of when thread pool is destroyed in atexit handler

* Update lib/rocprofiler/buffer

- buffer::instance::get_internal_buffer()
- allocate_buffer invokes internal_threading::initialize() on first entry
- update flush routine
 - if wait is false, does not wait for task group to finish syncing
 - checks for callback pointer

* Update lib/rocprofiler/internal_threading

- modifications to handle destruction of statics before atexit handler is invoked

* Update lib/rocprofiler/registration.cpp

- reorder atexit call in initialize()
- protect finalize from executing more than once

* Add unittests for rocprofiler buffer

* Update CI workflow

- disable fail-fast for sanitizers
- move AddressSanitizer job to top of the list

* Update lib/rocprofiler/tests/buffer/CMakeLists.txt

- do not set memcheck LD_PRELOAD for rocprofiler-lib-buffer-tests

* Update lib/rocprofiler/registration.{hpp,cpp}

- only invoke client finalizers if initialized
- remove invoke_client_initializer
- move invoke_client functions to anonymous namespace (no declaration in header)
- set fini status in finalize

* Update scripts/thread-sanitizer-suppr.txt

- suppress false positive for double mutex lock in external/ptl/source/PTL/TaskGroup.hh

* Restructure lib/rocprofiler/tests

* Update lib/common

- add utility.cpp
- move read_command_line to utility.{hpp,cpp}
  - was formerly in config.cpp

* Update lib/rocprofiler

- checks for init status return configuration locked if status is not greater than -1
  - in other words, this prevents calling these functions directly (which was possible when check was for greater than 0

* Update lib/rocprofiler/context/context.{hpp,cpp}

- provide deactivate_client_contexts and deregister_client_contexts
  - these functions are used when the tool fails to configure

* Update lib/rocprofiler/registration.{hpp,cpp}

- internal "public" get_client_offet()
- client ids are offset by a random value to avoid default values behaving correctly

* Update lib/rocprofiler/tests

- fix rocprofiler_lib.registration_lambda_no_result

* Update lib/rocprofiler/tests

- fix rocprofiler_lib.registration_lambda_with_result

* Update lib/rocprofiler/tests

- remove deep bind from rocprofiler_lib.registration_lambda_with_result

* Update lib/rocprofiler/tests

- use RTLD_NOW when dlopen'ing in rocprofiler_lib.registration_lambda_with_result

* Update rocprofiler registration tests

- split registration tests into separate exe that links to shared library

* Formatting

* Update CI workflow

- always checkout submodules via actions/checkout

* Update lib/rocprofiler/buffer.{hpp,cpp}

- fix issue with buffer flushing not working when only called once

* Update rocprofiler lib registration test

- test for buffered callback

* Update include/rocprofiler/rocprofiler.h

- include internal_threading.h header

* Update rocprofiler lib registration test

- add in internal threading for buffered test

[ROCm/rocprofiler-sdk commit: a646c1546c]
2023-09-26 19:21:31 -05:00
Jonathan R. Madsen a646c1546c rocprofiler library unit tests (#81)
* Update CI and linting workflows

- delete linting workflow
- compile default CI job with clang-tidy
- split out code coverage matrix entry to separate job
- code coverage job runs code coverage 3x
  - once for total code coverage
  - once for unittests code coverage
  - once for samples code coverage

* Update PTL submodule

- improves handling of when thread pool is destroyed in atexit handler

* Update lib/rocprofiler/buffer

- buffer::instance::get_internal_buffer()
- allocate_buffer invokes internal_threading::initialize() on first entry
- update flush routine
 - if wait is false, does not wait for task group to finish syncing
 - checks for callback pointer

* Update lib/rocprofiler/internal_threading

- modifications to handle destruction of statics before atexit handler is invoked

* Update lib/rocprofiler/registration.cpp

- reorder atexit call in initialize()
- protect finalize from executing more than once

* Add unittests for rocprofiler buffer

* Update CI workflow

- disable fail-fast for sanitizers
- move AddressSanitizer job to top of the list

* Update lib/rocprofiler/tests/buffer/CMakeLists.txt

- do not set memcheck LD_PRELOAD for rocprofiler-lib-buffer-tests

* Update lib/rocprofiler/registration.{hpp,cpp}

- only invoke client finalizers if initialized
- remove invoke_client_initializer
- move invoke_client functions to anonymous namespace (no declaration in header)
- set fini status in finalize

* Update scripts/thread-sanitizer-suppr.txt

- suppress false positive for double mutex lock in external/ptl/source/PTL/TaskGroup.hh

* Restructure lib/rocprofiler/tests

* Update lib/common

- add utility.cpp
- move read_command_line to utility.{hpp,cpp}
  - was formerly in config.cpp

* Update lib/rocprofiler

- checks for init status return configuration locked if status is not greater than -1
  - in other words, this prevents calling these functions directly (which was possible when check was for greater than 0

* Update lib/rocprofiler/context/context.{hpp,cpp}

- provide deactivate_client_contexts and deregister_client_contexts
  - these functions are used when the tool fails to configure

* Update lib/rocprofiler/registration.{hpp,cpp}

- internal "public" get_client_offet()
- client ids are offset by a random value to avoid default values behaving correctly

* Update lib/rocprofiler/tests

- fix rocprofiler_lib.registration_lambda_no_result

* Update lib/rocprofiler/tests

- fix rocprofiler_lib.registration_lambda_with_result

* Update lib/rocprofiler/tests

- remove deep bind from rocprofiler_lib.registration_lambda_with_result

* Update lib/rocprofiler/tests

- use RTLD_NOW when dlopen'ing in rocprofiler_lib.registration_lambda_with_result

* Update rocprofiler registration tests

- split registration tests into separate exe that links to shared library

* Formatting

* Update CI workflow

- always checkout submodules via actions/checkout

* Update lib/rocprofiler/buffer.{hpp,cpp}

- fix issue with buffer flushing not working when only called once

* Update rocprofiler lib registration test

- test for buffered callback

* Update include/rocprofiler/rocprofiler.h

- include internal_threading.h header

* Update rocprofiler lib registration test

- add in internal threading for buffered test
2023-09-26 19:21:31 -05:00
Jonathan R. Madsen 553fff7218 Clean package manager caches in CI (#305)
* Clean package manager caches in CI

* remove cpack docker prune

* Apply suggestions from code review

* Apply suggestions from code review

* Update .github/workflows/cpack.yml

- disable removing large packages and swap storage to see if that fixes the jobs losing communication with server

* Update ubuntu-focal workflow

- disable debug flags in code coverage run

[ROCm/rocprofiler-systems commit: 0d84a357e5]
2023-09-26 15:44:49 -05:00
Jonathan R. Madsen 0d84a357e5 Clean package manager caches in CI (#305)
* Clean package manager caches in CI

* remove cpack docker prune

* Apply suggestions from code review

* Apply suggestions from code review

* Update .github/workflows/cpack.yml

- disable removing large packages and swap storage to see if that fixes the jobs losing communication with server

* Update ubuntu-focal workflow

- disable debug flags in code coverage run
2023-09-26 15:44:49 -05:00
Galantsev, Dmitrii 9d07110891 Fix out-of-bounds array access for --showvc
get_od_clk_volt_info assumed the size of the file instead of checking
the length. This caused out-of-bounds array element access.

Change-Id: Ibda8f0c3a6d1623d48964641ae5ef610d2072e94
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 8eb9f892d3]
2023-09-26 13:59:37 -05:00
Galantsev, Dmitrii 8eb9f892d3 Fix out-of-bounds array access for --showvc
get_od_clk_volt_info assumed the size of the file instead of checking
the length. This caused out-of-bounds array element access.

Change-Id: Ibda8f0c3a6d1623d48964641ae5ef610d2072e94
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-09-26 13:59:37 -05:00
Benjamin Welton b66bcdd107 Migrate XML counter defs and reader from v1/v2 (#25)
* Migrate XML counter defs and reader from v1/v2

* working set

* more fixes

* Update CMakeLists.txt

* source formatting (clang-format v11) (#83)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Update source/lib/rocprofiler/counters/CMakeLists.txt

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 59cc2a382c]
2023-09-26 13:50:57 -05:00
Benjamin Welton 59cc2a382c Migrate XML counter defs and reader from v1/v2 (#25)
* Migrate XML counter defs and reader from v1/v2

* working set

* more fixes

* Update CMakeLists.txt

* source formatting (clang-format v11) (#83)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Update source/lib/rocprofiler/counters/CMakeLists.txt

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
2023-09-26 13:50:57 -05:00
Jonathan R. Madsen 9f2109381b Sync with rocprofiler updates (#26)
- Update rocprofiler_configure prototype
- add compile_commands.json to .gitignore

[ROCm/rocprofiler-register commit: 5a6ac895d1]
2023-09-26 13:50:23 -05:00
Jonathan R. Madsen 5a6ac895d1 Sync with rocprofiler updates (#26)
- Update rocprofiler_configure prototype
- add compile_commands.json to .gitignore
2023-09-26 13:50:23 -05:00
AravindanC c274b20863 SWDEV-421448 - add library link directory for dynamicLoading test
Change-Id: I64c90b7dd84990bec31e8aa26b1fffb6482c49ab


[ROCm/hip-tests commit: cdd59ef727]
2023-09-26 12:29:30 -04:00
AravindanC cdd59ef727 SWDEV-421448 - add library link directory for dynamicLoading test
Change-Id: I64c90b7dd84990bec31e8aa26b1fffb6482c49ab
2023-09-26 12:29:30 -04:00
Jatin Chaudhary 77ef46fb63 SWDEV-412457 - <thread> header needs to be included
Change-Id: Ia291e5e4cc28050e05e6d7e5d7904698db56dce5


[ROCm/roctracer commit: b2671813eb]
2023-09-26 14:52:25 +01:00
Jatin Chaudhary b2671813eb SWDEV-412457 - <thread> header needs to be included
Change-Id: Ia291e5e4cc28050e05e6d7e5d7904698db56dce5
2023-09-26 14:52:25 +01:00
Ioannis Assiouras 153d0f5886 SWDEV-396618,SWDEV-398655 - Re-enabled Unit_hipEventElapsedTime_NotReady_Negative on windows
Change-Id: I9b13136f78d40edaabf14bce13462397f119496e


[ROCm/hip-tests commit: ab544d4136]
2023-09-26 12:52:44 +01:00
Ioannis Assiouras ab544d4136 SWDEV-396618,SWDEV-398655 - Re-enabled Unit_hipEventElapsedTime_NotReady_Negative on windows
Change-Id: I9b13136f78d40edaabf14bce13462397f119496e
2023-09-26 12:52:44 +01:00
Jatin Chaudhary 63278e0877 SWDEV-412457 - use proper headers for functionality used in hip-tests
Change-Id: I2ca20c17b4732638bf05e66196c500c5d25de3b2


[ROCm/hip-tests commit: fe4891ad52]
2023-09-26 05:45:55 -04:00
Jatin Chaudhary fe4891ad52 SWDEV-412457 - use proper headers for functionality used in hip-tests
Change-Id: I2ca20c17b4732638bf05e66196c500c5d25de3b2
2023-09-26 05:45:55 -04:00
Jatin Chaudhary acf40cd6df SWDEV-306642 - remove gcnArch from tests
Change-Id: Ibc16aa1bc3507fb583ac9c68394b1ab9b2ba7af4


[ROCm/hip-tests commit: 2c17edbced]
2023-09-26 05:34:34 -04:00
Jatin Chaudhary 2c17edbced SWDEV-306642 - remove gcnArch from tests
Change-Id: Ibc16aa1bc3507fb583ac9c68394b1ab9b2ba7af4
2023-09-26 05:34:34 -04:00