Commit-Graf
64512 Incheckningar
Upphovsman SHA1 Meddelande Datum
Jonathan R. Madsen 8d85410b11 Fix RHEL docker containers (#282)
* Fix RHEL docker containers

- avoid `yum update` since that can update the distro minor version

[ROCm/rocprofiler-systems commit: ad51223960]
2023-06-14 13:18:43 -05:00
Jonathan R. Madsen ad51223960 Fix RHEL docker containers (#282)
* Fix RHEL docker containers

- avoid `yum update` since that can update the distro minor version
2023-06-14 13:18:43 -05:00
Jonathan R. Madsen b65f8e7605 CI timeout + line-info in releases (#279)
* Update perfetto args.gn.in

- remove enable_perfetto_tools_trace_to_text (unused)

* core timeout implementation

- requires OMNITRACE_CI=ON
- requires OMNITRACE_CI_TIMEOUT=<sec>
- adds pthread_self and std::this_thread::get_id to thread info
- pthread_create_gotcha stores native handles (pthread_self)

* Testing updates

- improve detection of segfault/failures with PASS_REGEX exists
- add OMNITRACE_CI_TIMEOUT env variable to all tests

* Line-info in releases

- e.g. -g1 + more options to minimize size of debug info

* Fix typo in config exit action message

* OMNITRACE_UNLIKELY around debug/verbose messages

* format fixes

* Overflow tests + capability check

* transpose example update

- link to threads library

* roctracer/rocprofiler update

- in ROCm 5.5.0, cannot include rocprofiler.h and roctracer.h in same file due to conflicting enum defs
- Moved HSA tracing setup/shutdown to component::roctracer

* roctracer update

- fix definition of roctracer::setup when disabled

* Update fork example

- detach threads on main PID
- flush io outputs when printing info

* Update overflow tests

- pass regular expressions
- overflow on PERF_COUNT_SW_CPU_CLOCK event

* fork gotcha update

- use getpid() instead of getppid()

* update fork example

- wait on threads calling fork

* timeout update

- wait on timeout thread to launch before proceeding

[ROCm/rocprofiler-systems commit: 3e2fa69a14]
2023-06-14 11:55:22 -05:00
Jonathan R. Madsen 3e2fa69a14 CI timeout + line-info in releases (#279)
* Update perfetto args.gn.in

- remove enable_perfetto_tools_trace_to_text (unused)

* core timeout implementation

- requires OMNITRACE_CI=ON
- requires OMNITRACE_CI_TIMEOUT=<sec>
- adds pthread_self and std::this_thread::get_id to thread info
- pthread_create_gotcha stores native handles (pthread_self)

* Testing updates

- improve detection of segfault/failures with PASS_REGEX exists
- add OMNITRACE_CI_TIMEOUT env variable to all tests

* Line-info in releases

- e.g. -g1 + more options to minimize size of debug info

* Fix typo in config exit action message

* OMNITRACE_UNLIKELY around debug/verbose messages

* format fixes

* Overflow tests + capability check

* transpose example update

- link to threads library

* roctracer/rocprofiler update

- in ROCm 5.5.0, cannot include rocprofiler.h and roctracer.h in same file due to conflicting enum defs
- Moved HSA tracing setup/shutdown to component::roctracer

* roctracer update

- fix definition of roctracer::setup when disabled

* Update fork example

- detach threads on main PID
- flush io outputs when printing info

* Update overflow tests

- pass regular expressions
- overflow on PERF_COUNT_SW_CPU_CLOCK event

* fork gotcha update

- use getpid() instead of getppid()

* update fork example

- wait on threads calling fork

* timeout update

- wait on timeout thread to launch before proceeding
2023-06-14 11:55:22 -05:00
Ruili Ji 9bf1cbe4ed kfdtest: Update COMPUTE_PGM_RSRC1 for software trap
If asics don't need software traps within GFX11 domain,
test with COMPUTE_PGM_RSRC1.PRIV = 1 will make system hang.

Change-Id: I00cf8eb6d6b07856885c77bd343ca3c41cc3cad5
Signed-off-by: Ruili Ji <ruiliji2@amd.com>
Signed-off-by: Aaron Liu <aaron.liu@amd.com>
2023-06-14 07:46:51 -04:00
Ruili Ji 0a8096b34a kfdtest: Update COMPUTE_PGM_RSRC1 for software trap
If asics don't need software traps within GFX11 domain,
test with COMPUTE_PGM_RSRC1.PRIV = 1 will make system hang.

Change-Id: I00cf8eb6d6b07856885c77bd343ca3c41cc3cad5
Signed-off-by: Ruili Ji <ruiliji2@amd.com>
Signed-off-by: Aaron Liu <aaron.liu@amd.com>


[ROCm/ROCR-Runtime commit: 9bf1cbe4ed]
2023-06-14 07:46:51 -04:00
Galantsev, Dmitrii 9f534b1c6b SWDEV-340919 - Package rsmitst
Similar to I879b21428e6642f19fda67092b365d8b78b7ba7b.

Main CMake improvements:

* Add rsmitst with -DBUILD_TESTS=ON
* Package tests into rocm-smi-lib-tests.deb and .rpm
* Note - this breaks build_rsmitst.sh

Misc improvements:

* Add .editorconfig to normalize code formatting
* Export compile_commands.json
* Remove gtest source and pull from github instead

Change-Id: Ib87ed4a5acd9f78badae6d028e5ff3d4f56dafc2
Depends-On: I8b26795471ad1432c805e45d8b58d7bb34abfcfc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 0478d53e23]
2023-06-13 22:52:10 -05:00
Galantsev, Dmitrii 0478d53e23 SWDEV-340919 - Package rsmitst
Similar to I879b21428e6642f19fda67092b365d8b78b7ba7b.

Main CMake improvements:

* Add rsmitst with -DBUILD_TESTS=ON
* Package tests into rocm-smi-lib-tests.deb and .rpm
* Note - this breaks build_rsmitst.sh

Misc improvements:

* Add .editorconfig to normalize code formatting
* Export compile_commands.json
* Remove gtest source and pull from github instead

Change-Id: Ib87ed4a5acd9f78badae6d028e5ff3d4f56dafc2
Depends-On: I8b26795471ad1432c805e45d8b58d7bb34abfcfc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-13 22:52:10 -05:00
Jenkins bcc74e6cbb SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: Ib8ce0e4247ab25374f02ac090f41ae45a7b2d052


[ROCm/hip commit: e621df4e0d]
2023-06-14 02:58:04 +00:00
Jenkins e621df4e0d SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: Ib8ce0e4247ab25374f02ac090f41ae45a7b2d052
2023-06-14 02:58:04 +00:00
Philip Yang 29b04c2534 kfdtest: Fix KFDSVMEvictTest.QueueTest OOM
Typo to calculate bufferSize from vramBufSizeInPages. The OOM shows up
only with HSA_XNACK=1 because HSA_XNACK=0 doesn't support VRAM
oversubscription. We changed to run SVM tests with both XNACK off and
on.

Change-Id: I3949959288fd92f4e7f4a87115a5f1547e225042
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
2023-06-13 21:15:31 -04:00
Philip Yang 6bf1babb51 kfdtest: Fix KFDSVMEvictTest.QueueTest OOM
Typo to calculate bufferSize from vramBufSizeInPages. The OOM shows up
only with HSA_XNACK=1 because HSA_XNACK=0 doesn't support VRAM
oversubscription. We changed to run SVM tests with both XNACK off and
on.

Change-Id: I3949959288fd92f4e7f4a87115a5f1547e225042
Signed-off-by: Philip Yang <Philip.Yang@amd.com>


[ROCm/ROCR-Runtime commit: 29b04c2534]
2023-06-13 21:15:31 -04:00
gobhardw 7da40d2d7b Decoupling HIP code with runFeatureTest target
Change-Id: I8cac692289c7c9393b76789b0fa67eb239df2079
2023-06-14 01:48:17 +05:30
gobhardw a550cde477 Decoupling HIP code with runFeatureTest target
Change-Id: I8cac692289c7c9393b76789b0fa67eb239df2079


[ROCm/rocprofiler commit: 7da40d2d7b]
2023-06-14 01:48:17 +05:30
gobhardw bbc7bc1ada Fixing Logging for profiler v2
Change-Id: I7e52236c828f441e78631c5125692959eac7260b
2023-06-13 15:58:05 -04:00
gobhardw 41be6ae55a Fixing Logging for profiler v2
Change-Id: I7e52236c828f441e78631c5125692959eac7260b


[ROCm/rocprofiler commit: bbc7bc1ada]
2023-06-13 15:58:05 -04:00
Jonathan Kim bfb94b3b6e Soften trap handler loading failure when exception handling not supported
GFX11 and up including some GFX9 devices will not support
old trap handling without the new exception handling.

Instead of a hard assert failure that runs into a core dump,
let ROCr initialization continue instead.

Change-Id: I309becdc72ef4fb2fafd118c1faf0801407e658e
2023-06-13 13:05:47 -04:00
Jonathan Kim 1772d866c9 Soften trap handler loading failure when exception handling not supported
GFX11 and up including some GFX9 devices will not support
old trap handling without the new exception handling.

Instead of a hard assert failure that runs into a core dump,
let ROCr initialization continue instead.

Change-Id: I309becdc72ef4fb2fafd118c1faf0801407e658e


[ROCm/ROCR-Runtime commit: bfb94b3b6e]
2023-06-13 13:05:47 -04:00
Ammar ELWazir 6c61aa5311 Fixes for Spack
Change-Id: Ib2ea41b8140589fbc74aa297379588cc720e0183
2023-06-13 12:02:58 -04:00
Ammar ELWazir 94e608e1ad Fixes for Spack
Change-Id: Ib2ea41b8140589fbc74aa297379588cc720e0183


[ROCm/rocprofiler commit: 6c61aa5311]
2023-06-13 12:02:58 -04:00
Galantsev, Dmitrii f46d020feb Temporarily ignore TestFrequencies
See SWDEV-391039 and SWDEV-391040 for details

Change-Id: I662ba43363d949465454ea4af4d4586b3d47a811
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: ac94bf5ed5]
2023-06-12 19:26:21 -05:00
Galantsev, Dmitrii ac94bf5ed5 Temporarily ignore TestFrequencies
See SWDEV-391039 and SWDEV-391040 for details

Change-Id: I662ba43363d949465454ea4af4d4586b3d47a811
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-12 19:26:21 -05:00
Galantsev, Dmitrii 61ac3f8ca9 --showtempgraph - Show N/A when no temp found
If temp in hwmon was missing - rocm-smi crashed.
e.g. /sys/class/drm/card1/device/hwmon/hwmon5/temp1_input

This change displays "N/A" for temp instead of crashing.

Change-Id: I02f84a466bd3acfbd9b65e7e4ca0f18e76606c3b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rocm_smi_lib commit: 713f85721b]
2023-06-12 19:16:39 -05:00
Galantsev, Dmitrii 713f85721b --showtempgraph - Show N/A when no temp found
If temp in hwmon was missing - rocm-smi crashed.
e.g. /sys/class/drm/card1/device/hwmon/hwmon5/temp1_input

This change displays "N/A" for temp instead of crashing.

Change-Id: I02f84a466bd3acfbd9b65e7e4ca0f18e76606c3b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-12 19:16:39 -05:00
Rahul Garg 0862d3120e SWDEV-378007 - Update jenkinsfile to take hipcc from hipcc project (#296)
[ROCm/hip-tests commit: 761c599c36]
2023-06-11 23:06:08 -07:00
Rahul Garg 761c599c36 SWDEV-378007 - Update jenkinsfile to take hipcc from hipcc project (#296) 2023-06-11 23:06:08 -07:00
Rahul Garg 61224b3e91 SWDEV-378007 - Update jenkinsfile to take hipcc from hipcc project (#3217)
[ROCm/hip commit: 33618001e5]
2023-06-11 22:31:46 -07:00
Rahul Garg 33618001e5 SWDEV-378007 - Update jenkinsfile to take hipcc from hipcc project (#3217) 2023-06-11 22:31:46 -07:00
James Zhu 4ba8f1fe77 kfdtest: Add test for event wait with event age tracking enable
Add 5 different test scenario to cover new event age tracking features.

Change-Id: Icab43240fd127208b18abbd7542d6444127ef0c7
Signed-off-by: James Zhu <James.Zhu@amd.com>
2023-06-10 11:41:50 -04:00
James Zhu 1ff2f1f7d8 kfdtest: Add test for event wait with event age tracking enable
Add 5 different test scenario to cover new event age tracking features.

Change-Id: Icab43240fd127208b18abbd7542d6444127ef0c7
Signed-off-by: James Zhu <James.Zhu@amd.com>


[ROCm/ROCR-Runtime commit: 4ba8f1fe77]
2023-06-10 11:41:50 -04:00
James Zhu a0cbf90b90 libhsakmt: add event age tracking
Keeping last signaled event age to avoid race conditions
for HSA_EVENTTYPE_SIGNAL when event age init value is non-zero.

Change-Id: Ifb9a11a6868e5762a9f92f579e45a0a2c8fa1017
Signed-off-by: James Zhu <James.Zhu@amd.com>
2023-06-10 11:41:50 -04:00
James Zhu 498b718e83 libhsakmt: add event age tracking
Keeping last signaled event age to avoid race conditions
for HSA_EVENTTYPE_SIGNAL when event age init value is non-zero.

Change-Id: Ifb9a11a6868e5762a9f92f579e45a0a2c8fa1017
Signed-off-by: James Zhu <James.Zhu@amd.com>


[ROCm/ROCR-Runtime commit: a0cbf90b90]
2023-06-10 11:41:50 -04:00
Ammar ELWazir 7ea04a63c5 Fixing Build Library Paths
Change-Id: If71f548dda3dd7cab3dc251b4a3e6389cfc9e4f9
2023-06-10 10:30:25 -04:00
Ammar ELWazir dfa893ed83 Fixing Build Library Paths
Change-Id: If71f548dda3dd7cab3dc251b4a3e6389cfc9e4f9


[ROCm/rocprofiler commit: 7ea04a63c5]
2023-06-10 10:30:25 -04:00
Ammar ELWazir 8350f42329 Tests fix
Change-Id: I1fe7ab12c20e83f0bfc710bfc6db6a8d03802dd5
2023-06-10 10:26:33 -04:00
Ammar ELWazir 84677d785f Tests fix
Change-Id: I1fe7ab12c20e83f0bfc710bfc6db6a8d03802dd5


[ROCm/rocprofiler commit: 8350f42329]
2023-06-10 10:26:33 -04:00
gobhardw 089fa278b3 SWDEV-388280 making ctf plugin usage similar to perfetto
Change-Id: Iccf17e8d8ff0f96701df8797cbb1ba58f9652575
2023-06-10 11:22:35 +05:30
gobhardw b107f80513 SWDEV-388280 making ctf plugin usage similar to perfetto
Change-Id: Iccf17e8d8ff0f96701df8797cbb1ba58f9652575


[ROCm/rocprofiler commit: 089fa278b3]
2023-06-10 11:22:35 +05:30
colramos-amd 7e1a29299d Comply to Python formatting
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 79eecb445e]
2023-06-09 10:04:32 -05:00
colramos-amd 79eecb445e Comply to Python formatting
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:04:32 -05:00
colramos-amd 2b360f4257 Omniperf rocomni changes
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5f6c776170]
2023-06-09 10:01:37 -05:00
colramos-amd 5f6c776170 Omniperf rocomni changes
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:01:37 -05:00
colramos-amd 7522233da8 Fix VGPR issue (#139)
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: acb9729540]
2023-06-09 10:00:56 -05:00
colramos-amd acb9729540 Fix VGPR issue (#139)
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:00:56 -05:00
Laurent Morichetti 6a82b0a038 Fix a race condition in the trap handler
status.priv may be read after returning from the trap handler, which
causes sq_interrupt_word_wave.priv to be 0 even though the s_sendmsg
instruction was initiated when status.priv was 1.

To work around this, added a s_waitcnt lgkmcnt(0) after s_sendmsg
to make sure the message is sent before continuing.

Signed-off-by: Jay Cornwall <Jay.Cornwall@amd.com>
Signed-off-by: Laurent Morichetti <Laurent.Morichetti@amd.com>
Change-Id: Ieb75005ca1559ef03d0efac80e966f521e41fcb7
2023-06-09 10:03:55 -04:00
Laurent Morichetti 3736a0ffeb Fix a race condition in the trap handler
status.priv may be read after returning from the trap handler, which
causes sq_interrupt_word_wave.priv to be 0 even though the s_sendmsg
instruction was initiated when status.priv was 1.

To work around this, added a s_waitcnt lgkmcnt(0) after s_sendmsg
to make sure the message is sent before continuing.

Signed-off-by: Jay Cornwall <Jay.Cornwall@amd.com>
Signed-off-by: Laurent Morichetti <Laurent.Morichetti@amd.com>
Change-Id: Ieb75005ca1559ef03d0efac80e966f521e41fcb7


[ROCm/ROCR-Runtime commit: 6a82b0a038]
2023-06-09 10:03:55 -04:00
Maisam Arif a9d4f69eea SWDEV-404157 - Fixed printLog delimiter parsing
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I3d8e22d185790f4325aeacc18e4bfcfe8777d356


[ROCm/rocm_smi_lib commit: 00e170c2f5]
2023-06-08 20:02:51 -05:00
Maisam Arif 00e170c2f5 SWDEV-404157 - Fixed printLog delimiter parsing
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I3d8e22d185790f4325aeacc18e4bfcfe8777d356
2023-06-08 20:02:51 -05:00
Ammar ELWazir 4560bcae9f Setting Priority for HSA Queue handling Device Profiling
Change-Id: I82072ffb73f56b6effd2878164513ce47014c33f
2023-06-08 18:11:59 -04:00
Ammar ELWazir ed2be5cfe2 Setting Priority for HSA Queue handling Device Profiling
Change-Id: I82072ffb73f56b6effd2878164513ce47014c33f


[ROCm/rocprofiler commit: 4560bcae9f]
2023-06-08 18:11:59 -04:00