Commit Graph
64512 Commits
Author SHA1 Message Date
sumanthtg 8a5b1e02a5 SWDEV-238517 - [dtest] Catch2 multiprocess tests for device files.
Changes contain Catch2 device multiprocess tests which were covered under "hip/tests/src/runtimeApi/device" and some additional tests. These test files makes use of fork call or sets visible devices env variable and validates various device aspects.

Change-Id: Iaaca37598d386104da9e5f37f92ab176bc8a2845


[ROCm/hip commit: 6a8fd2b762]
2021-07-13 08:42:41 -04:00
sumanthtg 6a8fd2b762 SWDEV-238517 - [dtest] Catch2 multiprocess tests for device files.
Changes contain Catch2 device multiprocess tests which were covered under "hip/tests/src/runtimeApi/device" and some additional tests. These test files makes use of fork call or sets visible devices env variable and validates various device aspects.

Change-Id: Iaaca37598d386104da9e5f37f92ab176bc8a2845
2021-07-13 08:42:41 -04:00
Vladislav Sytchenko 51ea4ac113 SWDEV-281658 - Disable HIP profiling for Windows
Currently generating profiling header is not supported on Windows,
hence why the feature is being disabled.

Change-Id: I1f6d70ec3d68356799c5ecc89469eb007ae894f8


[ROCm/clr commit: 08ecf21ddf]
2021-07-12 19:45:09 -04:00
Vladislav Sytchenko 08ecf21ddf SWDEV-281658 - Disable HIP profiling for Windows
Currently generating profiling header is not supported on Windows,
hence why the feature is being disabled.

Change-Id: I1f6d70ec3d68356799c5ecc89469eb007ae894f8
2021-07-12 19:45:09 -04:00
Felix Kuehling 5fac7dcc3b libhsakmt: Fix deadlocks in __fmm_release
__fmm_release is sometimes called with the aperture lock, and sometimes
without. Consistently call it with the aperture lock held and remove the
lock/unlock calls from this function.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: I80dddc64cc0703e5eed8e9f1eb65b75a2c7ae2eb
2021-07-12 18:27:55 -04:00
Felix Kuehling 14d821391e libhsakmt: Fix deadlocks in __fmm_release
__fmm_release is sometimes called with the aperture lock, and sometimes
without. Consistently call it with the aperture lock held and remove the
lock/unlock calls from this function.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: I80dddc64cc0703e5eed8e9f1eb65b75a2c7ae2eb


[ROCm/ROCR-Runtime commit: 5fac7dcc3b]
2021-07-12 18:27:55 -04:00
agunashe de94f93e57 SWDEV-293742 - script to update the copyrights end year
Change-Id: I6a9c0f2537ed839228354f7a682d0cd5adc8f4fd


[ROCm/clr commit: 5b5f934d58]
2021-07-12 17:46:57 -04:00
agunashe 5b5f934d58 SWDEV-293742 - script to update the copyrights end year
Change-Id: I6a9c0f2537ed839228354f7a682d0cd5adc8f4fd
2021-07-12 17:46:57 -04:00
German Andryeyev 43c91585b5 SWDEV-293583 - Correct a typo in hipStreamAttachMemAsync
Change-Id: I69eb4d126e36a783603e6097fc2faab661dc63cb


[ROCm/clr commit: 14019c2833]
2021-07-12 13:14:09 -04:00
German Andryeyev 14019c2833 SWDEV-293583 - Correct a typo in hipStreamAttachMemAsync
Change-Id: I69eb4d126e36a783603e6097fc2faab661dc63cb
2021-07-12 13:14:09 -04:00
Rahul Garg 97bdff9e90 SWDEV-290076 - Initial update hipamd README
Change-Id: I60c6bd7f18d3293c876e631c1329e0d6eaa01fc8


[ROCm/clr commit: 85c6e91d0b]
2021-07-12 12:53:16 -04:00
Rahul Garg 85c6e91d0b SWDEV-290076 - Initial update hipamd README
Change-Id: I60c6bd7f18d3293c876e631c1329e0d6eaa01fc8
2021-07-12 12:53:16 -04:00
German Andryeyev 2258fa423c SWDEV-293583 - correct a typo in hipStreamAttachMemAsync
Change-Id: Ib9c634053a152353ae657a00fea4b072a824c5ba


[ROCm/hip commit: a20ad647ea]
2021-07-12 12:40:14 -04:00
German Andryeyev a20ad647ea SWDEV-293583 - correct a typo in hipStreamAttachMemAsync
Change-Id: Ib9c634053a152353ae657a00fea4b072a824c5ba
2021-07-12 12:40:14 -04:00
Vladislav Sytchenko 6cbc64455e SWDEV-293871 - Update license for edited Khronos headers
We should acknowledge that we modified third party files.

Change-Id: I510e445d049faafe06bb78353431d9427f3eb20c


[ROCm/clr commit: 3cb3b5eb4b]
2021-07-12 12:19:45 -04:00
Vladislav Sytchenko 3cb3b5eb4b SWDEV-293871 - Update license for edited Khronos headers
We should acknowledge that we modified third party files.

Change-Id: I510e445d049faafe06bb78353431d9427f3eb20c
2021-07-12 12:19:45 -04:00
Anusha GodavarthySurya 84706b51f9 SWDEV-294497 - remove rocclr from packaging
Change-Id: Ic9825114ece0c84b6490c44a441a5f8af0e772fc


[ROCm/clr commit: 8ad7c705f7]
2021-07-12 01:10:37 -04:00
Anusha GodavarthySurya 8ad7c705f7 SWDEV-294497 - remove rocclr from packaging
Change-Id: Ic9825114ece0c84b6490c44a441a5f8af0e772fc
2021-07-12 01:10:37 -04:00
Felix Kuehling 19536080a8 libhsakmt: Fix deadlock in map_mmio
Unlock mutex if MMIO mapping fails. This happens on all GFXv8 GPUs.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: I1dee1cbddefd9185c24ea79377f49f8ae2c5ff57
2021-07-09 17:07:42 -04:00
Felix Kuehling 559bb50c6a libhsakmt: Fix deadlock in map_mmio
Unlock mutex if MMIO mapping fails. This happens on all GFXv8 GPUs.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Change-Id: I1dee1cbddefd9185c24ea79377f49f8ae2c5ff57


[ROCm/ROCR-Runtime commit: 19536080a8]
2021-07-09 17:07:42 -04:00
Kent Russell bdfe3a12a8 kfdtest: Ensure devices are peer-accessible for peer mapping
If the devices aren't peer-accessible, we shouldn't try to run a test
that requires that the devices be peer-accessible. Thus, add a check in
MapVramToGPUNodesTest to check for peer accessibility before executing
the peer mappings.

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: Ib79b141f8c1ac6d85f5ab49d62af62ec10b988b7
2021-07-09 15:45:01 -04:00
Kent Russell 1da08cffe1 kfdtest: Ensure devices are peer-accessible for peer mapping
If the devices aren't peer-accessible, we shouldn't try to run a test
that requires that the devices be peer-accessible. Thus, add a check in
MapVramToGPUNodesTest to check for peer accessibility before executing
the peer mappings.

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: Ib79b141f8c1ac6d85f5ab49d62af62ec10b988b7


[ROCm/ROCR-Runtime commit: bdfe3a12a8]
2021-07-09 15:45:01 -04:00
Michael LIAO 4528b90f85 Revert "SWDEV-293408 Add atomicInc_system and atomicDec_system"
This reverts commit 5ea09794fc.

Change-Id: I808b52758cc08882daa7fc889e53ca4c2fe64a61


[ROCm/clr commit: 68289d1dfe]
2021-07-09 13:47:39 -04:00
Michael LIAO 68289d1dfe Revert "SWDEV-293408 Add atomicInc_system and atomicDec_system"
This reverts commit 45205c5e53.

Change-Id: I808b52758cc08882daa7fc889e53ca4c2fe64a61
2021-07-09 13:47:39 -04:00
Ajay GunaShekar f5b87b646f Merge "SWDEV-293742 - Update copyrights end year for opencl repo" into amd-staging
[ROCm/clr commit: e37d6f831b]
2021-07-09 12:31:52 -04:00
Ajay GunaShekar e37d6f831b Merge "SWDEV-293742 - Update copyrights end year for opencl repo" into amd-staging 2021-07-09 12:31:52 -04:00
agunashe f12034df79 SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/hipother commit: 171f5d5869]
2021-07-09 12:08:39 -04:00
agunashe 171f5d5869 SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab
2021-07-09 12:08:39 -04:00
agunashe fae697b4d6 SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/clr commit: d9d9e81acb]
2021-07-09 12:08:39 -04:00
agunashe d9d9e81acb SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab
2021-07-09 12:08:39 -04:00
Vladislav Sytchenko e682f34917 SWDEV-273235 - Support versioning on Windows
Switch to using Perl for converting the Unix timestamp into a human
readable date. Perl is required anyway to run hipconfig, so this
solution should be relatively platform independent.

Change-Id: I2b09468d25daf574c74cebcac4f29d9aba5f18fb


[ROCm/clr commit: c094ba97c6]
2021-07-09 11:38:50 -04:00
Vladislav Sytchenko c094ba97c6 SWDEV-273235 - Support versioning on Windows
Switch to using Perl for converting the Unix timestamp into a human
readable date. Perl is required anyway to run hipconfig, so this
solution should be relatively platform independent.

Change-Id: I2b09468d25daf574c74cebcac4f29d9aba5f18fb
2021-07-09 11:38:50 -04:00
Christophe Paquot e3a6104868 SWDEV-281658 - Preserve the callback IDs enum ordering
This change addresses the rocprofiler and HIP backward compatibility
issues. Before this patch, each time the hip_prof_str.h header was
generated, the ordering of the callbacks IDs changed, causing
incompatibilities between tools compiled with the old header and
runtimes compiled with the new headers (or vice versa).

To make the API callback IDs stable, the previous version of the header
is read to extract the enum values so that the same values can be
assigned in the new header.

Also, to make diffing different versions of the hip_prof_str.h easier
to read, all other sections (types, macros, helper functions) are now
alphabetically ordered.

If an update to the checked-in hip_prof_str.h file is required, the
cmake build is aborted and a message printed on stderr. The build will
not be successful until the checked-in hip_prof_str.h and the generated
hip_prof_str.h match.

Change-Id: I38b920e601185f7365a76a6584df91a7e8a11798


[ROCm/clr commit: d208afcb36]
2021-07-09 11:17:09 -04:00
Christophe Paquot d208afcb36 SWDEV-281658 - Preserve the callback IDs enum ordering
This change addresses the rocprofiler and HIP backward compatibility
issues. Before this patch, each time the hip_prof_str.h header was
generated, the ordering of the callbacks IDs changed, causing
incompatibilities between tools compiled with the old header and
runtimes compiled with the new headers (or vice versa).

To make the API callback IDs stable, the previous version of the header
is read to extract the enum values so that the same values can be
assigned in the new header.

Also, to make diffing different versions of the hip_prof_str.h easier
to read, all other sections (types, macros, helper functions) are now
alphabetically ordered.

If an update to the checked-in hip_prof_str.h file is required, the
cmake build is aborted and a message printed on stderr. The build will
not be successful until the checked-in hip_prof_str.h and the generated
hip_prof_str.h match.

Change-Id: I38b920e601185f7365a76a6584df91a7e8a11798
2021-07-09 11:17:09 -04:00
Maneesh Gupta fb386f5b03 Merge "SWDEV-294276 - Fix clinfo install permissions" into amd-staging
[ROCm/clr commit: aaeed07bef]
2021-07-09 02:56:03 -04:00
Maneesh Gupta aaeed07bef Merge "SWDEV-294276 - Fix clinfo install permissions" into amd-staging 2021-07-09 02:56:03 -04:00
DURGESH KROTTAPALLI c7529444dc SWDEV-292393 - [catch2][dtest] Tests for hipMemcpyPeer and hipMemcpyPeerAsync APIs.
Added functional and negative scenarios for
hipMemcpyPeer and
hipMemcpyPeerAsync APIs

Change-Id: Ibaee0d84cb616727dc5db057bb9422702670b686


[ROCm/hip-tests commit: cc0a8fee55]
2021-07-09 01:06:30 -04:00
DURGESH KROTTAPALLI cc0a8fee55 SWDEV-292393 - [catch2][dtest] Tests for hipMemcpyPeer and hipMemcpyPeerAsync APIs.
Added functional and negative scenarios for
hipMemcpyPeer and
hipMemcpyPeerAsync APIs

Change-Id: Ibaee0d84cb616727dc5db057bb9422702670b686
2021-07-09 01:06:30 -04:00
DURGESH KROTTAPALLI 2c72166ff8 SWDEV-292393 - [catch2][dtest] Tests for hipMemcpyPeer and hipMemcpyPeerAsync APIs.
Added functional and negative scenarios for
hipMemcpyPeer and
hipMemcpyPeerAsync APIs

Change-Id: Ibaee0d84cb616727dc5db057bb9422702670b686


[ROCm/hip commit: 48c2a0fb27]
2021-07-09 01:06:30 -04:00
DURGESH KROTTAPALLI 48c2a0fb27 SWDEV-292393 - [catch2][dtest] Tests for hipMemcpyPeer and hipMemcpyPeerAsync APIs.
Added functional and negative scenarios for
hipMemcpyPeer and
hipMemcpyPeerAsync APIs

Change-Id: Ibaee0d84cb616727dc5db057bb9422702670b686
2021-07-09 01:06:30 -04:00
agunashe 65362abf36 SWDEV-293742 - Update copyrights end year for opencl repo
Change-Id: I0ce8369a7ef569ac82c6e20266d0c98331a43e08


[ROCm/clr commit: 5a0ecc8e48]
2021-07-08 21:55:55 -07:00
agunashe 5a0ecc8e48 SWDEV-293742 - Update copyrights end year for opencl repo
Change-Id: I0ce8369a7ef569ac82c6e20266d0c98331a43e08
2021-07-08 21:55:55 -07:00
Satyanvesh Dittakavi d1ed2e9a31 SWDEV-1 - Rearrange error conditions in elapsed time
- when the first argument is null API should return hipErrorInvalidValue
- but when first and second argument both are null API was returning hipErrorInvalidHandle causing catch2 event tests to fail

Change-Id: I0978ce8b8462e4baa043be75a40b5bc45b036bb6


[ROCm/clr commit: 688288c2e3]
2021-07-09 00:47:12 -04:00
Satyanvesh Dittakavi 688288c2e3 SWDEV-1 - Rearrange error conditions in elapsed time
- when the first argument is null API should return hipErrorInvalidValue
- but when first and second argument both are null API was returning hipErrorInvalidHandle causing catch2 event tests to fail

Change-Id: I0978ce8b8462e4baa043be75a40b5bc45b036bb6
2021-07-09 00:47:12 -04:00
Anusha GodavarthySurya 6bbe132eb7 SWDEV-240806 - Enable graph test on nvidia platform
Change-Id: Ia196dd7c650693155f786871671aec4dda0e886f


[ROCm/hip commit: 9c9b62f0b8]
2021-07-08 23:27:20 -04:00
Anusha GodavarthySurya 9c9b62f0b8 SWDEV-240806 - Enable graph test on nvidia platform
Change-Id: Ia196dd7c650693155f786871671aec4dda0e886f
2021-07-08 23:27:20 -04:00
Tao Sang 21ccb0cf1e SWDEV-292273 - Add cmake tests
Add test on CXX and Fortran build in cmake.
Add test on hip::device interface linking in cmake.

Change-Id: I3fe6dba05a7a140a9a19df107b7885df83d28042


[ROCm/hip-tests commit: d5142afe58]
2021-07-08 12:51:46 -04:00
Tao Sang d5142afe58 SWDEV-292273 - Add cmake tests
Add test on CXX and Fortran build in cmake.
Add test on hip::device interface linking in cmake.

Change-Id: I3fe6dba05a7a140a9a19df107b7885df83d28042
2021-07-08 12:51:46 -04:00
Tao Sang 33f4b44ab2 SWDEV-292273 - Add cmake tests
Add test on CXX and Fortran build in cmake.
Add test on hip::device interface linking in cmake.

Change-Id: I3fe6dba05a7a140a9a19df107b7885df83d28042


[ROCm/hip commit: 818aa18d59]
2021-07-08 12:51:46 -04:00
Tao Sang 818aa18d59 SWDEV-292273 - Add cmake tests
Add test on CXX and Fortran build in cmake.
Add test on hip::device interface linking in cmake.

Change-Id: I3fe6dba05a7a140a9a19df107b7885df83d28042
2021-07-08 12:51:46 -04:00