The workaround is no longer needed as the compiler emits the macro itself.
Change-Id: I6a06e73353628bcea71f6bd23503ab6d8e42a29d
[ROCm/clr commit: 37b90c2f64]
The workaround is no longer needed as the compiler emits the macro itself.
Change-Id: I6a06e73353628bcea71f6bd23503ab6d8e42a29d
[ROCm/hip commit: bf6b451ae3]
[dtest] Tests for hipMemcpy2DFromArray
and hipMemcpy2DFromArrayAsync APIs
1. Negative scenarios for both the APIs
2. Functional size check scenarios for both APIs
3. Invoke the API from Peer Device Context
4. Simple scenarios for both APIs
5. Pinned Host Memory from same & multi GPU
Change-Id: I80c84ec3f9722d18683d31be65caa1bd64054da6
[ROCm/clr commit: f9d422bcbd]
[dtest] Tests for hipMemcpy2DFromArray
and hipMemcpy2DFromArrayAsync APIs
1. Negative scenarios for both the APIs
2. Functional size check scenarios for both APIs
3. Invoke the API from Peer Device Context
4. Simple scenarios for both APIs
5. Pinned Host Memory from same & multi GPU
Change-Id: I80c84ec3f9722d18683d31be65caa1bd64054da6
[dtest] Tests for hipMemcpy2DFromArray
and hipMemcpy2DFromArrayAsync APIs
1. Negative scenarios for both the APIs
2. Functional size check scenarios for both APIs
3. Invoke the API from Peer Device Context
4. Simple scenarios for both APIs
5. Pinned Host Memory from same & multi GPU
Change-Id: I80c84ec3f9722d18683d31be65caa1bd64054da6
[ROCm/hip commit: b36936645d]
[dtest] Tests for hipMemcpy2DFromArray
and hipMemcpy2DFromArrayAsync APIs
1. Negative scenarios for both the APIs
2. Functional size check scenarios for both APIs
3. Invoke the API from Peer Device Context
4. Simple scenarios for both APIs
5. Pinned Host Memory from same & multi GPU
Change-Id: I80c84ec3f9722d18683d31be65caa1bd64054da6
Instead of throwing "Unsupported clock" errors for ASICs that don't
support a certain clock type (e.g. dcefclk on MI-series), just dump the
warning to logging.debug and don't try to read the clock
Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: If3cb9a472b03aa535a76fc24bcd9f77122090634
[ROCm/rocm_smi_lib commit: b931380f02]
Instead of throwing "Unsupported clock" errors for ASICs that don't
support a certain clock type (e.g. dcefclk on MI-series), just dump the
warning to logging.debug and don't try to read the clock
Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: If3cb9a472b03aa535a76fc24bcd9f77122090634
Old logic did not consider memory held in the scratch cache to be
free when deciding whether or not to reclaim.
Change-Id: I7f7c7549c72d743edbf7c53489fe9a453dc4177a
Old logic did not consider memory held in the scratch cache to be
free when deciding whether or not to reclaim.
Change-Id: I7f7c7549c72d743edbf7c53489fe9a453dc4177a
[ROCm/ROCR-Runtime commit: 0b7d9db964]
This test is incorrect about _Float16 overloading. Need to keep the test
passing for both old and new compiler until the compiler change is in
mainline.
Change-Id: I2f9be8957282fd0579c74f1e9f23e65c4484f3a2
[ROCm/clr commit: 932d34dc6e]
This test is incorrect about _Float16 overloading. Need to keep the test
passing for both old and new compiler until the compiler change is in
mainline.
Change-Id: I2f9be8957282fd0579c74f1e9f23e65c4484f3a2
This test is incorrect about _Float16 overloading. Need to keep the test
passing for both old and new compiler until the compiler change is in
mainline.
Change-Id: I2f9be8957282fd0579c74f1e9f23e65c4484f3a2
[ROCm/hip commit: 6eabbc83f7]
This test is incorrect about _Float16 overloading. Need to keep the test
passing for both old and new compiler until the compiler change is in
mainline.
Change-Id: I2f9be8957282fd0579c74f1e9f23e65c4484f3a2
Use default power cap exposed via sysfs to determine when to
show 'Out of Spec" warning.
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I0fa3612b50e230856b0d5a390f876b35268d9587
[ROCm/rocm_smi_lib commit: b71e07b3fb]
Use default power cap exposed via sysfs to determine when to
show 'Out of Spec" warning.
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I0fa3612b50e230856b0d5a390f876b35268d9587
On Ubuntu 20.04, in Release mode, gcc fails with this error:
In file included from /usr/include/string.h:495,
from /opt/rocm/include/hsa/hsa_api_trace.h:57,
from ../rocprofiler/src/util/hsa_rsrc_factory.h:29,
from ../rocprofiler/src/util/hsa_rsrc_factory.cpp:25:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’ at ../rocprofiler/src/util/hsa_rsrc_factory.cpp:323:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: error: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../rocprofiler/src/util/hsa_rsrc_factory.cpp: In member function ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’:
../rocprofiler/src/util/hsa_rsrc_factory.cpp:322:39: note: length computed here
322 | const int gfxip_label_len = strlen(agent_info->name) - 2;
| ~~~~~~^~~~~~~~~~~~~~~~~~
The error is caused by the following 2 lines:
const int gfxip_label_len = strlen(agent_info->name) - 2;
strncpy(agent_info->gfxip, agent_info->name, gfxip_label_len);
The size argument to strncpy should not depend on the input string.
Since the terminating character is not considered (the copy is at
most len - 2 bytes), using memcpy is preferable. Also, make sure
the destination does not overflow by clamping the size.
Change-Id: I0c5cf7e0daf4cd6fcf7092efb1d9fd4c02a6c639
On Ubuntu 20.04, in Release mode, gcc fails with this error:
In file included from /usr/include/string.h:495,
from /opt/rocm/include/hsa/hsa_api_trace.h:57,
from ../rocprofiler/src/util/hsa_rsrc_factory.h:29,
from ../rocprofiler/src/util/hsa_rsrc_factory.cpp:25:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’ at ../rocprofiler/src/util/hsa_rsrc_factory.cpp:323:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: error: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../rocprofiler/src/util/hsa_rsrc_factory.cpp: In member function ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’:
../rocprofiler/src/util/hsa_rsrc_factory.cpp:322:39: note: length computed here
322 | const int gfxip_label_len = strlen(agent_info->name) - 2;
| ~~~~~~^~~~~~~~~~~~~~~~~~
The error is caused by the following 2 lines:
const int gfxip_label_len = strlen(agent_info->name) - 2;
strncpy(agent_info->gfxip, agent_info->name, gfxip_label_len);
The size argument to strncpy should not depend on the input string.
Since the terminating character is not considered (the copy is at
most len - 2 bytes), using memcpy is preferable. Also, make sure
the destination does not overflow by clamping the size.
Change-Id: I0c5cf7e0daf4cd6fcf7092efb1d9fd4c02a6c639
[ROCm/rocprofiler commit: 304d3366af]
Implement default GPU power cap functionality in the LIB.
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: Ia6b3420beb0e4df5559c3e6d11d0667972590b53
[ROCm/rocm_smi_lib commit: 83cd2fe4f1]
Implement default GPU power cap functionality in the LIB.
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: Ia6b3420beb0e4df5559c3e6d11d0667972590b53
Implement showevent functionality in the ROCm SMI Python CLI.
It can be called using --showevents with any combination of:
VM_FAULT, THERMAL_THROTTLE, and/or GPU_RESET
For example:
./rocm-smi --showevents VM_FAULT, THERMAL_THROTTLE, GPU_RESET
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I905fd9c949e91423b79833a04ab89d6ba3760e62
[ROCm/rocm_smi_lib commit: a9e7e5a475]
Implement showevent functionality in the ROCm SMI Python CLI.
It can be called using --showevents with any combination of:
VM_FAULT, THERMAL_THROTTLE, and/or GPU_RESET
For example:
./rocm-smi --showevents VM_FAULT, THERMAL_THROTTLE, GPU_RESET
Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I905fd9c949e91423b79833a04ab89d6ba3760e62
hipIpcOpenMemHandle should return the device pointer which is
similar to the base ptr of the original allocation even if the offset
to the original pointer is passed to hipIpcGetMemHandle
Change-Id: I99c0553e8c67c15b5fed880b6a4c74bce39c3aee
[ROCm/clr commit: 88fca7bf9e]
hipIpcOpenMemHandle should return the device pointer which is
similar to the base ptr of the original allocation even if the offset
to the original pointer is passed to hipIpcGetMemHandle
Change-Id: I99c0553e8c67c15b5fed880b6a4c74bce39c3aee
Yaxun (Sam) Liu
German Andryeyev
Rachida Kebichi
DURGESH KROTTAPALLI
Kent Russell
Chauncey Hui
Sarbojit Sarkar
Sean Keely
Ori Messinger
Laurent Morichetti
Harish Kasiviswanathan
Satyanvesh Dittakavi
Elena