David Salinas
5843530a06
Revert "append the ELF flags for sram-ecc and xnack to the target triple per code object"
...
This reverts commit c61f265657 .
2019-04-18 11:49:40 -04:00
Maneesh Gupta
8309632e2d
Merge pull request #995 from david-salinas/add_sram-ecc_and_xnack_flags_to_triple
...
Append the ELF flags for sram-ecc and xnack to the target triple per code object
2019-04-16 09:10:04 +05:30
David Salinas
c61f265657
append the ELF flags for sram-ecc and xnack to the target triple per code object
2019-04-05 13:17:11 -04:00
Siu Chi Chan
e126f7254c
minor workaround for lazy binding
2019-04-02 17:28:06 -04:00
Siu Chi Chan
10d3084e20
remove visibility hidden attribute
2019-03-13 11:58:32 -04:00
Siu Chi Chan
d37f9e6b2d
remove old style triple name
2019-03-11 19:51:51 +00:00
Siu Chi Chan
824ee1aa72
move triple_to_hsa_isa into the header
2019-03-11 19:51:44 +00:00
Siu Chi Chan
30ce25e627
Support more than one bundles in a single .kernel section
...
When compiling with Early Finalization enabled in HCC,
the resulting .kernel section of the host object now may
contain more than one device code bundles. This is to
teach the HIP runtime to correctly extract all the
bundles from the .kernel section.
2018-10-18 17:00:27 -04:00
Maneesh Gupta
1ba06f63c4
Apply .clangformat to all repo source files
...
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344
2018-03-12 11:29:03 +05:30
Maneesh Gupta
72d3e679e4
Merge branch 'master' into feature_purge_genco
2018-01-29 16:02:03 +05:30
Maneesh Gupta
44de3f8309
Merge pull request #346 from scchan/fix_rhel_build
...
use assign rather than insert
2018-01-26 06:59:25 +05:30
Siu Chi Chan
8acc8365fa
use assign rather than insert
2018-01-25 16:51:29 +00:00
Kent Knox
0497424978
Fixing rocblas build failure
...
with ::Bundled_code_header constructor
Disabling hipPrintfKernel test from CI
2018-01-25 10:29:40 -06:00
Alex Voicu
b842394957
This introduces LipoProteinLipase (lpl), a simple tool for creating fat binaries. It represents a direct replacement of the creaky hccgenco.sh script, which had various issues. The format it uses is that of a code object bundle, generated by the Clang Offload Bundler. The output is always suffixed with the ".adipose" extension. It is shared with HCC. The hipcc script and associated tests are modified to use lpl. Help can be obtained by invoking lpl --help. A more computer-sciency / corporate friendly name is likely to be beneficial, which is a reason for choosing easily searchable/replaceable names such as lpl or adipose.
2017-12-08 04:22:57 +00:00
Alex Voicu
7c0b9a005b
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
Alex Voicu
89e9399427
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
Alex Voicu
c2482d1255
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00