AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
853 Commits 3 Branches 0 Tags
bf749ba8d67f2f841f25486704b5a2a36bfd34ef
Commit Graph

38 Commits

Author SHA1 Message Date
Giovanni LB 6ed22f3d62 SWDEV-444112: Fixing plugins race condition 
Change-Id: I0057d1ade4e1123b878489ff31851b25976217c6
 2024-02-01 14:11:31 -03:00
Saurabh Verma b18bc9930b Fixed format of presenting MI300 counters for individual xccs 
1. Modified rocprofiler_record_profiler_t to include xcc_index
2. Modified file plugin to add additional column XCC_Index to the csv

Change-Id: Ic526c739e16b50dca5704070ccabbcbecd994d6a
 2023-12-20 14:04:10 -05:00
gobhardw 49bd09b46c SWDEV-429377 : Fixing kernel name truncation for plugins 
Change-Id: I5875048d1773959fdd73cbff5498854e61b92af8
 2023-10-30 10:52:31 -04:00
Benjamin Welton cb190b72f1 Migrate tracer performance fixes from roctracer 
Change-Id: If9e1349537cce23b7be1d8530d795744a8cd07b1
 2023-10-19 20:34:12 +00:00
gobhardw ab066543b1 SWDEV-427969: Fixing kernel trace 
Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1

When we did file plugin changes for omniperf in v2, we removed 2 fields from header:
SIG and OBJ. However from the values we missed removing OBJ. Fix is to remove the OBJ from values.

Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1
 2023-10-19 05:56:55 -04:00
Ammar ELWazir 4f40fb8a40 SWDEV-391589: Addressing changes requested by Omniperf: 
Adding Versioning to rocprof main script
Adding Versioning to file plugins to support legacy v1 output and new v2 output
Fixing headers for v2 output

Change-Id: I352e8c8ed03871466269a792d1bfa572da58bd8a
 2023-10-16 15:19:20 -04:00
gobhardw b682ad8804 SWDEV-423972 fix kernel trace new line 
Change-Id: I7932124cfd2ef519cad9bfde1c7d5f8ea35aace0
 2023-10-05 05:41:22 -04:00
gobhardw 5d3f0a0e9e Fixing kernel-trace for file plugin 
Change-Id: I9853e7e10da2f0812c69fe5242a9be34c78496f7
 2023-09-19 23:40:54 +05:30
gobhardw a40e05c425 SWDEV-420435 solves wrong ordering of counter headers 
Change-Id: Ifc2697e1f545d6329a7bbf024f106fd3244ae80a
 2023-09-12 11:20:10 +05:30
Giovanni LB 157eacd2bb DCGPUBU-44: Added arbitrary envvars to file/dir names. Squashed some fixes. 
- Added arbitrary env-vars
- Fixed some UBs with atomic variables
- Fixed loading of file plugin
- ATT vs. kernel-trace off by one

Change-Id: I69c75f66f722e4085b5279f41afd05813628846d
 2023-08-15 17:53:57 -03:00
Ammar ELWazir d4a33cf33a Pull from Github 
Squashed commit of the following:

commit f029195705a15700380c6f832ba5d15d46fd6de7
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date:   Thu Jul 13 14:38:56 2023 -0500

    Formatting workflows for source (clang-format) and cmake (cmake-format) (#4)

    * Add .cmake-format.yaml file

    * Add formatting workflow

    * provide base input for creating PR

    * Update scheme for extracting branch name

    - disable running formatting on push to amd-staging branch

    * patch .cmake-format.yaml for find_package signature

    - apparently cmake-format doesn't format the full signature of find_package

    * run formatting (clang-format v11) (#7)

    Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

    * run cmake formatting (cmake-format) (#6)

    Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

    ---------

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit bc4d135fdd8a1a9e51235f18a5d575fd2b3735e6
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Thu Jul 13 12:55:17 2023 -0500

    Removing Build cache for potential issues with auto-generated header files (#5)

    Change-Id: I9e2319f4335e2f88585ffa6fac2bd88a1c952e6e

commit ce86dea6a311d44d880fa684eb78f3329295e2a4
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date:   Thu Jul 13 11:08:58 2023 -0500

    Fix decltype(<hsa-function>) function pointer usage (#3)

    - the following is done in several places:
        decltype(hsa_memory_allocate)* hsa_memory_allocate
    - above can cause compiler errors
    - replace decltype(<hsa-function>) with decltype(::<hsa-function>)
      - this ensures that the type within the decltype is recognized as the global scope HSA function, not the variable
    - in many places, the variable has a "_fn" suffix to prevent this issue but added '::' anyway for consistency

commit ac49fdd92a72e9c99394253a02da413a6c2e3b3a
Merge: a07946a 03a0855
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Wed Jul 12 11:36:24 2023 -0500

    Merge pull request #2 from ROCm-Developer-Tools/gerrit-amd-staging

    Pull from gerrit

commit 03a085588cffe863e8f466de67be1cfb205b675a
Merge: e88cad2 a07946a
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Wed Jul 12 10:57:30 2023 -0500

    Merge branch 'amd-staging' into gerrit-amd-staging

commit a07946a5cd4c670c83c27ad1a076a9d4567ce6d7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 15:46:04 2023 +0000

    Enabling Cached Builds

commit 525e494a7f13941077a8fd4ad6840904db4d27d4
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 04:53:54 2023 +0000

    Updating missed GPU Targets

commit 42c75862f628c9bee7cfb7dc04dff2619430efbc
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 04:43:02 2023 +0000

    Adding V1 Testing

commit 9d72fd4aee85e4b0c12e717060d2730fa5b73be1
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:34:31 2023 +0000

    Fixing Artifacts directory path

commit f4000cc558b3b2e4676f7994f7ce8c8e6f94518e
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:27:26 2023 +0000

    Fixing CMake for test build job

commit 2ce8115d4c33948c3c8f957f545a95a04e1d6cd2
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:16:18 2023 +0000

    Fixing Ubuntu CMake for ubuntu test build

commit 6d0ed439191be900748d0c025157f9d689a73ec7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 01:28:41 2023 +0000

    Removing Navi21

commit e349a7642e5ae5eb03ab9fcd0a0f74f09f78cab5
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 01:14:14 2023 +0000

    Removing Navi21

commit fefd02fe68d2a4bca7ec2e381960ad004ee9fc5b
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:42:48 2023 +0000

    Fixing CMake Job

commit 2ea46abf7bf92643efa8c549fa70346ffbd79d65
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:35:13 2023 +0000

    Fixing CMake Job

commit d99d681ed1999c5fcf291dc678b11a77205fb0f3
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:32:13 2023 +0000

    Fixing Pull Latest Dockers and CMake Jobs

commit dfc4498072d13b4a1df3a63047d34c682c3d9a29
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 23:54:21 2023 +0000

    Fixing CMake job

commit 919efe04de707f7c702031be15c3e2c5f8442cbb
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 23:52:13 2023 +0000

    Adding Pull Last dockers job

commit be1b1256e8b0e05308e8f7e7e69bee3acca55281
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:25:40 2023 -0500

    Update cmake.yml

commit 212299fa4355ae6ec18f9aaacbb79c51ea6c6f97
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:23:35 2023 -0500

    Update cmake.yml

commit 7c2c1327086a61466cc6cac39f70865c051a8bc7
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:18:53 2023 -0500

    Update cmake.yml

commit 191b5ce007e612e814c1d7a3afb4ad398f3852e1
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 16:03:22 2023 -0500

    Update cmake.yml

commit 8824113d95f3e13c7ce4d0af8e0d9d8f522a6c4a
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 16:28:09 2023 +0000

    Fixing Pull from Gerrit job name

    Change-Id: I9e7ed9a27a13ca49d62c93bdadb30f0057e4d385

commit cc3d5e4b02ffb439e8cc2b3efa53527c376f9982
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 16:21:43 2023 +0000

    Adding Staging sync job

    Change-Id: I0551f43878b0678ce4b3e74e27d62357cf95ad95

commit b9be2eee71380a2e6dd34d520e92d0c4209277a0
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 15:57:11 2023 +0000

    Fixing build.sh

    Change-Id: Ia987b0244f0875370d5fe69907b3f5e9cea914de

commit 9eee33a95a1abd656a7ac5ca10a9f245e9825431
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:39:46 2023 -0500

    Update cmake.yml

commit 7093b85a78497140e8b52632ca2a002bdaeacd62
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:33:29 2023 -0500

    Update cmake.yml

commit f54697172c72a67740f9fdfa0c217b6ea6931576
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:01:26 2023 -0500

    Update cmake.yml

commit 1b6620e16f8940386b0f4f04e69e2410d21c0e26
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 20:21:02 2023 -0500

    Update cmake.yml

commit a94bec740c6b42c4b79c87bca20fa87b99bf060d
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:46:35 2023 -0500

    Update cmake.yml

commit 85d6b29d4375a69d575c18ece8542c50f2ddfcc3
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:34:39 2023 -0500

    Update cmake.yml

commit 8c004887cf1435f1a6214c3d2455299a8a27bd4c
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:31:17 2023 -0500

    Update cmake.yml

commit a14a9168e17d9348a53c6e9c9a47ba1edb4c4509
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:25:46 2023 -0500

    Update cmake.yml

commit 000f2f40b84e6a2f7d4becdbf5aed01436ca4c83
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:08:18 2023 -0500

    Update cmake.yml

commit a28a53d56731cad848fa9133d1c4dbaa8fc7afa7
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:03:39 2023 -0500

    Update cmake.yml

commit a6a2db01027f0b01fdfbb5997ddb772c7f51b649
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 18:21:53 2023 -0500

    Update cmake.yml

commit 118ef2a88b2d44e3207c31c343da3e5e5ec6f176
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 17:55:57 2023 -0500

    Update cmake.yml

commit 03c4c232396440cd0be6d2dd7baf4ceea1c2589d
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 17:48:49 2023 -0500

    Create cmake.yml

Change-Id: I77992f15694e77cbae49c56f9ff02f4f9079235d
 2023-07-13 20:54:30 -04:00
gobhardw 9ffb34f9d4 SWDEV-408750: Reoving Record_ID from HIP api trace 
Change-Id: Iba9022246def090b1bbb90b68e67d54bab1bea31
 2023-06-30 14:40:59 +05:30
Ammar ELWazir 3ac57e167e SWDEV-403068 & SWDEV-403069: Memory Leaks fix for tracer 
Change-Id: I57ce10ae616dda9529d22d4cee15556864760d6c
 2023-06-21 06:28:47 -04:00
Ammar ELWazir ad68526537 SWDEV-401678: Fixing Record IDs for File/CLI Plugin 
Change-Id: Icf36f716b69d3b8ee3e84d73e276dbff4dbe70ae
 2023-06-20 20:39:25 -04:00
Ammar ELWazir d3c39dca88 SWDEV-391589: Fixing File plugin output text 
Change-Id: I5e1d46431ca2b93661772b062996ed62574c36f9
 2023-06-17 00:21:56 -04:00
Ammar ELWazir 8350f42329 Tests fix 
Change-Id: I1fe7ab12c20e83f0bfc710bfc6db6a8d03802dd5
 2023-06-10 10:26:33 -04:00
Giovanni LB 6e32c6d132 SWDEV-391586: Remove hsa handles and begin_ts from std::cout 
Change-Id: I0d53849dd763d07094bd769d4bf1af908e39475f
 2023-06-08 18:04:14 -04:00
Giovanni LB e078d3704c SWDEV-391596: Moved counters output to the same line as dispatch info 
Change-Id: I08076b4d4fd20cbb4632cf5cc18c4651caafe87c
 2023-06-06 17:03:20 -04:00
Giovanni LB 58d82814e1 File plugin performance improvement (upto 40%) by not using endl. 
Change-Id: Ic9be0fb144eb0fa95f8e72c2de46ee4187f071c3
 2023-06-03 09:30:06 -04:00
Giovanni LB cd5456bf1c SWDEV-391594: Added macros for MPI env-vars 
Change-Id: I373833a2ad997ba944a05f10ac8da6cfdf139fa3
 2023-06-01 06:43:40 -04:00
Giovanni LB 1b5fed173c SWDEV-391583: Set default outputdir when filename is specified 
Change-Id: I9765582cc0dc870906d0ec16aa9ca38e990e0ef8
 2023-06-01 06:43:19 -04:00
Ammar ELWazir 2591d37add Fixing Perfetto & CTF plugins for ROCtx 
Change-Id: I575dcfcac6ced4dd5973f037137f1386a684e08b
 2023-06-01 08:41:25 +00:00
Ammar ELWazir 4bcef6b8de Removing ROCMTools naming from ROCProfiler project 
Change-Id: Ibd6211e031157f68a1bc3dd8dd77385e695cb700
 2023-05-30 22:14:50 -05:00
Ammar ELWazir 08fc21ac31 SWDEV-403050: Multiple fixes for Memory Leaks in profiler 
Change-Id: Ib720a81105af13898ff745ce0cbc2a48c1f4a980
 2023-05-30 21:41:54 -05:00
Giovanni LB 099a6b88b9 SWDEV-399505: Updated file.cpp from amd-staging 
Change-Id: I8b43f98fc0fa3c7d928bcc58067fddb01018b607
 2023-05-30 21:41:54 -05:00
Saurabh Verma 8f82ff6a46 MI300 counters support for rocprof and rocprofv2(Accumulation from all xccs) 
1. Xml files updated for gfx940 counters
2. File plugin changes to allow rocprofv2 backward compatibility for results.csv
3. Changes in rocprofv2 script to use tblextr.py, to generate results.csv just like rocprof

Change-Id: I7798f4411ce01f6fbfffb126de654ed806ca7045
(cherry picked from commit 86cbaf38c436be876f0426fa27803b1e64d90378)
 2023-05-30 21:41:54 -05:00
Ammar ELWazir 6b07b139c4 Fixing Timestamps for Tracing for the trace buffer results 
Change-Id: I89b36daacb6531840ac334ba4629c73a7b8f1e79
 2023-05-25 01:59:54 +00:00
Sriraksha Nagaraj cdc74d31db SWDEV-389161:Adding fix for tensorflow app hang with rocprofv2 
Change-Id: I48ade2e853468940aa5e1fca58ba22f686d89f26
 2023-05-24 22:46:40 +00:00
Ammar ELWazir cf14bfbef0 Adding a way to define the OPS operation in the file plugin 
Change-Id: Id1810b9a34bd0af2f000c53aad328bb019768eb0
 2023-05-23 04:38:17 +00:00
gobhardw c3107fc258 SWDEV-398161, SWDEV-398764 Fixed --hsa-api for v2 
Change-Id: I1902ff463851a3485b48f7b9400f7116a073365a
 2023-05-17 17:22:44 -04:00
gobhardw 40bfdcade0 SWDEV-388249: Memory leak fix 
Change-Id: I68c62ee42e6d37fb85a1a8aa0d7a2cbda6431a8b
 2023-04-25 12:12:43 +05:30
Giovanni LB c07eff437f SWDEV-388249: WIP - Fixed few memory leaks 
Change-Id: I97eb348c7715ac166f48cee3fd3d1b702d355948
 2023-04-24 17:58:46 -03:00
Ammar ELWazir 4a33787c01 Fixing Performance Issue with API Tracing V2 
Records right now will report basic raw data, no pre-processing in API anymore, and it will be left to the tool to process data from the output of synchronous callbacks of the API tracing records output

Change-Id: I8e5845e49e1228cb2fb60ca188ee748745b6a1af
 2023-04-21 03:17:17 -04:00
Ammar ELWazir ab94b378ae SWDEV-373784: Fixed hip/hsa traces not to include roctx tags 
Change-Id: I0ffbac3a313dbd9867a85b7cea0c92fe0b9ca0b9
 2023-03-09 13:21:10 +00:00
Ammar ELWazir 38648b5194 SWDEV-373783: removing end_time for roctx traces 
Change-Id: I34ddb12cc402b0be1517a0c157922a15da7fdd11
 2023-03-09 13:21:10 +00:00
Ammar ELWazir dc69331379 Fixing rocprofilerv2 naming and CMake issues 
Change-Id: Ib6d336349a056731e5c0f35151296d6fea671360
 2023-03-09 13:21:01 +00:00
gobhardw 03c305dbd4 Making ATT work with Profilerv2 
Change-Id: Ic9334aa80e40faaaf5c1a79ba37dbe52e8d31253
 2023-03-09 13:20:35 +00:00
Ammar ELWazir 8032adb64f Adding rocprofilerv2 
Change-Id: Ic0cc280ba207d2b8f6ccae1cd4ac3184152fc1ad
 2023-03-09 13:20:33 +00:00