SWDEV-107442, SWDEV-108405 - Need to release GPU memory fence before releasing resources
When we call submitKernelInternal, we need to release GPU memory fence before release resources used in the kernel otherwise we can page fault.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/11955/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#5 edit
[ROCm/clr commit: 824a34cf54]
SWDEV-2 - Change OpenCL version number from 2296 to 2297.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2043 edit
[ROCm/clr commit: 22369c6db7]
SWDEV-107271 - [OpenCL][GFXIP9 Bring up] force Raven(gfx901) to use PAL backend
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#561 edit
[ROCm/clr commit: f42576b37c]
SWDEV-2 - Change OpenCL version number from 2295 to 2296.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2042 edit
[ROCm/clr commit: 897be96aed]
SWDEV-2 - Change OpenCL version number from 2294 to 2295.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2041 edit
[ROCm/clr commit: bcd923b89e]
SWDEV-2 - Change OpenCL version number from 2293 to 2294.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2040 edit
[ROCm/clr commit: ac1461ccc1]
Move HIP_COHERENT_HOST_ALLOC so it is read once at init time.
Add HIP_LAUNCH_BLOCKING_KERNELS, HIP_API_BLOCKING.
Update docs on debug and chicken bits.
Conflicts:
src/hip_hcc.cpp
[ROCm/clr commit: 783ac156ce]
SWDEV-107568 - [ROCm CQE][OCL][CZ] Basic 2.0 conformance test giving Segmentation fault (core dumped) at "progvar_prog_scope_uninit"
- Detect if writable program scope variables are present in the program, and if so, insert barrier each dispatch of a kernel from this program.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#48 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#21 edit
[ROCm/clr commit: b705f74166]
SWDEV-102966 - Dump code object disassembly in OpenCL rocm device.
Invoke DumpExecutableAsText from driver library.
Update build to depend on some more LLVM libraries.
LLVM changes are included, but will come through amd-common.
Driver changes will come through ROCm-OpenCL-driver.
Testing: Run some SDK samples/test_basic with AMD_OCL_BUILD_OPTIONS_APPEND=-save-temps
Reviewed by: Laurent Morichetti, German Andryeyev.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#47 edit
[ROCm/clr commit: c7d2b188de]
SWDEV-2 - Change OpenCL version number from 2292 to 2293.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2039 edit
[ROCm/clr commit: 0fff20f59d]
SWDEV-98415 - [CQE OCL][OpenCL on PAL] Failures/Crash is observed with multiple modules of ocltst
- Fix OCLImage2DFromBuffer test. Recalculate the original pitch if a view was created on the top of another ImageBuffer.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#19 edit
[ROCm/clr commit: 33de5b1e09]
SWDEV-98415 - [CQE OCL][OpenCL on PAL] Failures/Crash is observed with multiple modules of ocltst
- Fix program compilation on LC path. Add program constructor for the real device.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#14 edit
[ROCm/clr commit: 0b136f4765]
SWDEV-98415 - [CQE OCL][OpenCL on PAL] Failures/Crash is observed with multiple modules of ocltst
- Fix a regression with oflline compilation. Mark null program.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#26 edit
[ROCm/clr commit: bf9217468e]
hipcc accepts new parameter -use-staticlib and -use-sharedlib to
control linking behavior. Default is still static library.
Change-Id: I28fb9a939f8177c75abefd8b77d8118a6666d1f4
[ROCm/clr commit: fd8b1c7d41]
SWDEV-2 - Change OpenCL version number from 2291 to 2292.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2038 edit
[ROCm/clr commit: e86db9a564]
SWDEV-79309 - [ROCm][OCLonLC][AMDGPU asm] OclElf: Correctly skip symbols which have special section indexes.
[Issues]
Kernels which contain absolute symbols can't be run. Error message looks like:
"OclElf::getSymbolInfo() failed in gelf_getshdr() - Invalid argument."
[Reason]
Symbols which have special section indexes (e.g. absolute symbols)
are incorrectly handled by the compiler library.
[Solution]
Correctly skip symbols which have special section indexes in the loader.
Promote the fix into compiler/legacy-lib at once.
[Remarks/Misc]
Absolute symbols do not normally produced by OpenCL compiler,
but may come from kernels written in assembly language.
AMDGPU asm exports all symbols, even ABSOLUTE LOCAL HIDDEN INTERNAL etc.
Impossibility to disable export of useless symbols is known issue of llvm-mc
core, see https://llvm.org/bugs/show_bug.cgi?id=27201.
Note that presence of useless symbols does not make ELF invalid.
[Review] http://ocltc.amd.com/reviews/r/11921/
Evgeny Mankov (OK)
[Tests]
Tested that issue with asm kernels has gone.
PASS TeamCity - Pre-checkin for CL1347161 timestamped:2016-11-29 21:54:40 Rev:0063
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/loaders/elf/elf.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/loaders/elf/elf.cpp#36 edit
[ROCm/clr commit: 71f5fb7e8f]
SWDEV-2 - Change OpenCL version number from 2290 to 2291.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2037 edit
[ROCm/clr commit: 61a64a192b]
SWDEV-2 - Change OpenCL version number from 2289 to 2290.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2036 edit
[ROCm/clr commit: e46fadfb28]
SWDEV-2 - Change OpenCL version number from 2288 to 2289.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2035 edit
[ROCm/clr commit: 68e3bfc72d]
SWDEV-2 - Change OpenCL version number from 2287 to 2288.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2034 edit
[ROCm/clr commit: 8195a9043b]
SWDEV-2 - Change OpenCL version number from 2286 to 2287.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2033 edit
[ROCm/clr commit: 96bed3cbf4]
SWDEV-86035 - Add PAL backend to OpenCL
- Correct a fix from CL#1346120. Just remove the asserts, since size is used in the abstraction layer setup and represents cl_mem object.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#27 edit
[ROCm/clr commit: 8c56088f43]
SWDEV-2 - Change OpenCL version number from 2285 to 2286.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2032 edit
[ROCm/clr commit: 38be7dfff4]
pensun
foreman
Ben Sander
Rahul Garg
Maneesh Gupta
Aditya Atluri