Device property MaxSharedMemoryPerMultiprocessor set equal to totalGlobalMem (HIP path).
Reason: MaxSharedMemoryPerMultiprocessor should be as the same as group memory size. Group memory will not be paged out, so, the physical memory size = total shared memory size = group region size. NVCC path remains untouched: CUDA's device property MaxSharedMemoryPerMultiprocessor is reported.
hipify is updated as well.
[ROCm/clr commit: 460b501cbb]
Reason: maxThreadsPerMultiProcessor should be as the same as group memory size. Group memory will not be paged out, so, the physical memory size = total shared memory size = group region size.
NVCC path remains untouched: CUDA's device property maxThreadsPerMultiProcessor is reported.
[ROCm/clr commit: 1025341300]
SWDEV-78299 - [Brahma] Setting max single allocation size by comparing cardMemAvailableBytes with cardExtMemAvailableBytes on Brahma.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#540 edit
[ROCm/clr commit: 31c030ff18]
SWDEV-2 - Change OpenCL version number from 2032 to 2033.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1779 edit
[ROCm/clr commit: 837ab19841]
SWDEV-2 - Change OpenCL version number from 2031 to 2032.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1778 edit
[ROCm/clr commit: 4a8a26801c]
SWDEV-68792 - [OpenCL][HWS/CWSR] Adding support for Hardware Scheduler and Compute Wave Save restore (CWSR) feature on ORCA
Adding a temporary w/a for a CP uCode bug in HWS mode. Due to this bug, CP uCode loops through a RUNLIST unless there is a submission on all queues in HWS mode. This causes some overhead and performance drop in PCMark8 on CZ in HWS mode. To work around this issue, it was suggested to submit a dummy packet during initialization on all available queues on HWS mode so that CP uCode can break the loop. This w/a should be removed once CP uCode provides a final fix for this issue.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/9616/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#160 edit
[ROCm/clr commit: 45715f0c48]
For HCC path concurrentKernels is set to true since all ROCR hardware supports this feature.
For NVCC path concurrentKernels is obtained from CUDA's device property cudaDeviceProp::concurrentKernels.
[ROCm/clr commit: 4d4ca3ef3f]
SWDEV-2 - Change OpenCL version number from 2030 to 2031.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1777 edit
[ROCm/clr commit: 9b8568bedb]
SWDEV-86836 - Enhance caching library class to prepare one-stage kernel caching by:
0. Moving cache storage setup into constructor
1. Controlling cache storage size
2. Explicit cache cleanup
a. -kcache-wipe is off by default; when turned on, the caching directory would be wiped off
b. Here it's just an option. The implementation (the call of wipeCacheFolders()) will be added in the compiler library
3. Enforcing cache miss (actual compilation enforcing and adding a new entry to the cache storage).
a. -kcache-enforce-miss is off by default; when turned on, the real compilation will be enforced
b. Here it's just an option. The implementation will be added in the compiler library
ReviewBoardURL = http://ocltc.amd.com/reviews/r/9726/
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/OPTIONS.def#134 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/caching/cache.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/caching/cache.hpp#7 edit
[ROCm/clr commit: c5265e08c6]
SWDEV-2 - Change OpenCL version number from 2029 to 2030.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1776 edit
[ROCm/clr commit: e536df62e9]
SWDEV-2 - Change OpenCL version number from 2028 to 2029.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1775 edit
[ROCm/clr commit: 3c0eef3228]
SWDEV-2 - Change OpenCL version number from 2027 to 2028.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1774 edit
[ROCm/clr commit: e5cbfbac36]
SWDEV-86885 - [CQE OCL][2.0][QR][CFX] Few SDK 64 and 32 bit Samples resulting in Soft/hard hangs with faulty cl: 1233743
Unsubmit CL1233743 because of problems with CFX.
I have not been able to figure out how Cl1233743 would cause a problem. It sets a flag, to disable new code... I would expect the new code to be the problem, not the disable.
So, in case this unsubmit does not elminate the problem, CL1233686 is shelved, to use #ifndef CAL_SUPPORT around the new code in CL1226184.
CL1233743 was submitted for:
SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
CL1226184 was submitted for:
SWDEV-80442 - [QR][Adobe Premier Pro CS6] TDR/App Crash observed while resizing the video window within workspace
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#159 edit
[ROCm/clr commit: 27c1ec4857]
SWDEV-2 - Change OpenCL version number from 2026 to 2027.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1773 edit
[ROCm/clr commit: ecdfb00a01]
SWDEV-2 - Change OpenCL version number from 2025 to 2026.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1772 edit
[ROCm/clr commit: 3251b63346]
foreman
Evgeny Mankov
sunway513
dfukalov
Maneesh Gupta
Ben Sander
streamhsa
gargrahul
Sam Kolton