Commit Graph

6651 Commits

Author SHA1 Message Date
Ranjith Ramakrishnan c08a36f06a Revert "SWDEV-469045 - Replace the rocm-llvm package dependency with rocm-llvm-static for static builds"
This reverts commit 7d021f8196.

Reason for revert: <rocm-llvm package name change not required for static builds>

Change-Id: Ib2214a74162e5b015b096dc286151ecbd3ca0a80


[ROCm/clr commit: 0670697ab4]
2024-07-02 04:12:38 -04:00
Jaydeep Patel e08f11ca8e SWDEV-465088 - Bypass memcpy kind check for H2H memcpy if XNACK is enabled.
Change-Id: I3e9b23dfb1aedeaf5ea0f26668caddb277ead809


[ROCm/clr commit: 7d7db316b3]
2024-07-01 01:03:42 -04:00
Ranjith Ramakrishnan 3f890c80b5 SWDEV-470697 - Remove incorrect dependency from hip-static-devel pacakge
Remove hip-runtime-amd dependency from hip-static-devel package.

Change-Id: Id1756026cfe80dc8286c255f0d90314d3f2fd0ed


[ROCm/clr commit: 4255b606a5]
2024-06-28 14:35:26 -04:00
Anusha GodavarthySurya af6dd5d865 SWDEV-469331 - Fix issue of graph sync.
If graph has multiple branches, End command is enqueued on launch stream which
makes sure all the internal parallel streams are finsihed.

When node is removed from the graph, indegree and outdegree are not getting update correctly for parent, child nodes and
resulting in endNode not having deps on parallel commands. Resulting in graph sync issues.

Change-Id: I33cc2f21220e1c017d88099b29b542e05b683f73


[ROCm/clr commit: 9ad7e79e50]
2024-06-28 02:11:44 -04:00
Ioannis Assiouras c407812add SWDEV-468381 - Fixed use of vaddr_sub_obj in GraphMemFreeNode
Resolved an issue where a freed virtual buffer was incorrectly
added to the global mapping causing an assertion error during
teardown process.

Change-Id: I4801157a28603ce9be1ca0131982b700ff884f7a


[ROCm/clr commit: 1c6b92627d]
2024-06-27 16:20:47 -04:00
Ranjith Ramakrishnan 7d021f8196 SWDEV-469045 - Replace the rocm-llvm package dependency with rocm-llvm-static for static builds
Change-Id: I6787fa374608edb4349baab19b833980e3cb5b29


[ROCm/clr commit: d240b03969]
2024-06-26 12:58:05 -04:00
Saleel Kudchadker 17a46aa40b SWDEV-465602 - Refactor kernel arg pool allocation for graphs
- Allocate additional argument space to accomodate for kernel node
param updates

Change-Id: I2d4ea8bddd716f1191f3cbea807920d0248f8c4e


[ROCm/clr commit: 17313ec99d]
2024-06-25 18:28:03 -04:00
Rahul Manocha 0784937e1e [SWDEV-468553] - Add stream validation checks for memcpy APIs
Change-Id: Ic4495d10c8b2d2ac90f7093a08209d9cb373d2a6


[ROCm/clr commit: f309d49b32]
2024-06-24 12:47:31 -04:00
Ioannis Assiouras f07198d7e5 SWDEV-469138 - Added fix for find_package(LLVM)
Changed find_package call to prioritize the package that is
found under the rocm installation over other system locations

Change-Id: Ice93c94bbb9cdebd467d3e88bb2e4bfb7a1e76d9


[ROCm/clr commit: 6b9e89fe0c]
2024-06-20 11:03:08 -04:00
Ioannis Assiouras 8669b5d29f SWDEV-453750 - Improve dependency library detection in hip-config.cmake
Change-Id: I52a685e621f7334de2a16fd9659632967047f4a6


[ROCm/clr commit: eab2038560]
2024-06-20 11:00:02 -04:00
Ioannis Assiouras 0a42617f58 SWDEV-465236 - Changed RTCProgram::findIsa to not dlopen amdhip64 for static build
Change-Id: I322ef4ca96ea426a0953f1234e60db6cebb09886


[ROCm/clr commit: 7b0259c4b7]
2024-06-20 10:55:57 -04:00
Ioannis Assiouras 455ada60a2 SWDEV-468133 - Fixed hipDeviceGetLimit for hipLimitMallocHeapSize
Change-Id: I91bede414ebe46831509cbd24ffb53cf129d6a40


[ROCm/clr commit: 2aed4cf401]
2024-06-20 10:55:15 -04:00
Jatin Chaudhary 138caca238 SWDEV-450109 - add missing coop group operations
any, all, ballot, match_any, match_all for coalesced_group and
tiled_group. add binary_partition.

Change-Id: I8ed0e654f36d788653352a0617beb5b8d44749bc


[ROCm/clr commit: 36d58c6518]
2024-06-20 10:42:06 -04:00
taosang2 83eb6e766d SWDEV-465162 - Fix some issue with image support
Fix some small issues regarding image and mipmap support

Change-Id: I8e64223d44f37c2dbb115cbb343441a48021ba7b


[ROCm/clr commit: 1566ff7639]
2024-06-18 16:38:24 -04:00
Anusha GodavarthySurya 291f079669 SWDEV-467102 - Hidden heap init for graph capture
If the graph has kernels that does device side allocation,  during packet capture, heap is
allocated because heap pointer has to be added to the AQL packet, and initialized during
graph launch.

Handle race with wait when 2 kernels with device heap are enqueued on multiple streams.

Change-Id: I45933b77fcaf7bc8fdf1bc906462e32b5d8d3688


[ROCm/clr commit: 57156c524d]
2024-06-17 02:07:25 -04:00
Ranjith Ramakrishnan c8bc9e3f2e SWDEV-383837 - Update the package dependencies
The hip libraries depends on multiple standard shared libraries.
Corresponding packages are added to the dependency list.
Removed hipcc from hip-runtime package dependency list
Rearranged the package dependencies as well

The base (docker) images usually comes with the standard packages installed.
So even without the standard packages in dependency list, the installation will go through.
But its good to have all the required packages in the dependency list.

Change-Id: Iacab7993dffaa00efd1344d3eafb55f6317d1509


[ROCm/clr commit: 7dc71710dd]
2024-06-14 20:34:22 -04:00
Jacob Lambert 1fdc02a6e7 SWDEV-459586 - Clarify warning for amdgpu-arch failure
We more clearly define what happens in the case of amdgpu-arch
failure, and instruct developers on how to workaround the failure

Change-Id: Ifff569a7d688b6545ca457116e534a1830fa03c0


[ROCm/clr commit: 3c5b304992]
2024-06-14 15:13:37 -04:00
Branislav Brzak c2128d0af9 SWDEV-465203 - Treat 0 elf length images as invalid
This addresses:
SWDEV-465203
SWDEV-465202

Change-Id: I49fcdd537fd07585e25c5fdef37cd10815466f79


[ROCm/clr commit: f014124527]
2024-06-14 04:56:43 -04:00
Marko Arandjelovic 8b557c7318 SWDEV-441296 - Fixes related to hipTexObjectCreate unit test
- Avoid potential division by zero
 - Nullptr check

Change-Id: Ic857eb4fe968173c852eb7a67934e33fc74c055f


[ROCm/clr commit: d12af175af]
2024-06-14 03:58:34 -04:00
Ioannis Assiouras dfe46a3093 SWDEV-467069 - Added safety check in activity prof for accumulate command
Adding a safety check prevents an invalid memory access
if timestamps and kernelNames vectors are of different size.

The patch also moves the addKernelNames for the accumulate command
into dispatchAqlPacket function.

Change-Id: Iea0927e1253800403a1ae3f3d72de1e7d96476c3


[ROCm/clr commit: d44f44a5b1]
2024-06-12 21:53:03 +01:00
Ioannis Assiouras af089a2171 SWDEV-463865 - namespace changes to prevent symbol conflicts in static builds
Change-Id: I09ceb5962b7aa19156909f47167c87d6887c9cd1


[ROCm/clr commit: 3edf1501cc]
2024-06-12 16:22:27 -04:00
Ranjith Ramakrishnan 09defbc48f Move cmake config files to hip-dev/devel package
cmake config files were part of hip runtime package rather than dev/devel package
Corrected the same

Change-Id: I5e52658f28c551c830294d3b1525907f1b7cbc50


[ROCm/clr commit: b7d203edf6]
2024-06-12 12:52:11 -04:00
Anusha GodavarthySurya 44ef705022 SWDEV-461072 - Add reference to function parameter
Change-Id: I9ad5dafc6d697d12fbd1675f19f88f83ad2d7b9c


[ROCm/clr commit: 3a5cbb91b9]
2024-06-12 01:20:28 -04:00
Jaydeep Patel 2897632ad9 SWDEV-457316 - Other graph can free mem alloc node and return invalid val only if there is double mem free node in all captured graphs.
Change-Id: Icf12164bf0ecd171a4673ff4f384528e7671f944


[ROCm/clr commit: 5c77e30b18]
2024-06-12 00:44:50 -04:00
Ioannis Assiouras efba3545ca SWDEV-466601 - Fix invalid mem acccess in kernarg readback path
Change-Id: I4654ae592adc8cf9c687136d45eb1b28d99c7ae1


[ROCm/clr commit: 055e05a12a]
2024-06-10 15:13:05 +01:00
Satyanvesh Dittakavi 30c4d5805e SWDEV-464927 - Update the Get by PCI BusId logic and Hop count
- Update the intra socket weight for partitions within single socket as
it is changed to 13 by the driver.
- Use the PCIe function to distinguish the partitions of the same device
such as TPX mode in gfx942.

Change-Id: I8e64023d44e37c2dbb105cbb343441a48021ba7b


[ROCm/clr commit: 1815fc808d]
2024-06-10 04:46:50 -04:00
Ioannis Assiouras 75104df3b2 SWDEV-464648 - code and comment cleanups
Change-Id: I5ba3f1bff500b3cd5903c2f441017735e688f83f


[ROCm/clr commit: 8f42ad6aa3]
2024-06-07 22:38:09 +01:00
kjayapra-amd 41cb6dadf9 SWDEV-460948 - Changes to alloc, set, capture under single function.
Change-Id: I7b2d40e99e812b97c53535c5e63c41ad64a8f543


[ROCm/clr commit: 892071aeb2]
2024-06-06 16:57:53 -04:00
Ioannis Assiouras 0e023d1a0a SWDEV-463865 - symbol renamings to prevent conflicts in static build
Change-Id: Id7fbb638c1088c23df52fee877cd790d637b1ffb


[ROCm/clr commit: b8c2ac4de4]
2024-06-06 04:05:55 -04:00
Jaydeep Patel 47b1a7b98b SWDEV-465461 - Use command's queue instead as it might be changed while constructing memcpy command on MGPU.
Change-Id: Ia6ac40289e1eea320925203cbd52b30f3b64ad2b


[ROCm/clr commit: 774a10201f]
2024-06-05 06:47:49 +00:00
Fabian Ritter 10b3a313d2 Add __device__ specifier to HIP's warpSize constexpr variable
The warpSize variable is set to the value of the __AMDGCN_WAVEFRONT_SIZE macro,
which is a meaningless default in host code.
The resolution for SWDEV-449015 will introduce diagnostics for uses of this
macro in host code, which includes the current definition of the warpSize
variable. With the __device__ specifier, the definition of the warpSize
variable will not cause these diagnostics.

This change does not stop the variable from being used in host code since clang
intentionally does not diagnose uses of __device__ constexpr variables in host
code.

Change-Id: I0317217affe94fdf2dfd9ad0f134e68f5173245f


[ROCm/clr commit: 819e537dc5]
2024-06-04 09:32:52 -04:00
kjayapra-amd 6f2179d9d8 SWDEV-458026 - Check for hsa_handle/svm_ptr before removing from MemObjMap.
Change-Id: I967735c01c6321eeb768963ecb88667dbbe92f08


[ROCm/clr commit: fa4c1a0206]
2024-06-01 17:50:54 -04:00
Ranjith Ramakrishnan fd2eef084c SWDEV-451976 - Use cmake target for installing libraries
The installation of libraries should use the target signature rather than programs.
The TARGETS form will provide the right permission for the libraries

Change-Id: Iaaaeff960a8d85df92f5025e905082642d2225d9


[ROCm/clr commit: 775a077cb1]
2024-05-29 16:56:08 -04:00
Saleel Kudchadker a7ef9d9d39 SWDEV-301667 - Add enum for TASK command
Change-Id: I5d2712d913bdbc42bc6eaccf9eb2f8cb9976b22e


[ROCm/clr commit: f18a3405d7]
2024-05-28 14:18:46 -04:00
Tao Sang 7bf8d102fc SWDEV-433371 - Support new comgr unbundling action
Support new comgr unbundling action api to extract codebjects
in compressed and uncompressed modes.

Create HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION ENV to
toggle new path and old path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=false(default),
   uncompressed codeobject will go old path for better perf,
   compressed   codeobject will go new path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=true,
   both uncompressed and compressed codeobjects will go new
   path.

Add comgr wrapper for
   amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: I79952f132fe21249296685ee12cae05a4f9aec32


[ROCm/clr commit: d0050ce309]
2024-05-28 06:31:10 +00:00
Ajay 5b731168ca SWDEV-439581 - hip event flags clean up
Change-Id: I2197762d912da41a8b53b32b3446f0a958c988a6


[ROCm/clr commit: 6ec5074d74]
2024-05-28 06:31:10 +00:00
Jaydeep Patel af30acd46a SWDEV-461274 - Use GetDeviceById method.
Change-Id: I82a3feb8ecb5f151e09d0dae814b518fb84426e6


[ROCm/clr commit: f682ea7b3b]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 43aeeaf836 SWDEV-442738 - Link amdhip64 and hiprtc static library with dependent libraries
comgr, hsa-runtime and other libraries are linked to amdhip64 and hiprtc static library

Change-Id: I1940d8616dcb6a0f8633db3878327fa55b516a1b


[ROCm/clr commit: b9fbc98dad]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras be39d61344 SWDEV-462570 - synchronize the streams before ipcDetach
Change-Id: Ic007be31913496af0414d983f906b704c32ac02c


[ROCm/clr commit: 0eb4ba9883]
2024-05-28 06:31:10 +00:00
Ajay cea4f4290a SWDEV-439581 - hipEventBlockingSync flag for hip events
Change-Id: I0d7785a568f8007f82f999776a7ad23d0acc81b7


[ROCm/clr commit: a5a4b78606]
2024-05-28 06:31:10 +00:00
Jaydeep Patel 24a3ca5f94 SWDEV-457316 - Some validations related to Graph Node.
Free node should be added in same graph and once.
Graph clone containing mem alloc/mem free node not supported.
Destroy mem alloc/mem free node is not supported if already added in graph.

Change-Id: I40459e66d7dd84f3b5298617990313b41458c804


[ROCm/clr commit: ca3c2ac185]
2024-05-28 06:31:10 +00:00
Shilei Tian ce4e3ebe04 Revert "SWDEV-459556 - Revert "SWDEV-442724 - Remove uses of -amdgpu-early-inline-all to enable function calls""
This reverts commit e5b6537315ce9b2688ee0269ba0828a703c3e2c9.

The regressions (SWDEV-459556 and SWDEV-460260)  caused by the original patch
has been resolved.

Change-Id: I32344492b4ff88bd7e91ea47983ac15636dc77c1


[ROCm/clr commit: b0930263e5]
2024-05-28 06:31:10 +00:00
Jatin Chaudhary 026346a6c7 SWDEV-462027 - bfloat162 struct members are public
bfloat16 member is protected, bfloat162 members are public

Change-Id: Ice090401553b9526cb34d003b3996b85d538bc4e


[ROCm/clr commit: 2b290953b0]
2024-05-28 06:31:10 +00:00
Anusha GodavarthySurya 3b85ba70df SWDEV-461072 - Extend AQL Optimization for child graph nodes
Change-Id: I6baf906add7240b29ea653020a9a0b56206ee2a7


[ROCm/clr commit: 243dad92c9]
2024-05-28 06:31:10 +00:00
sdashmiz 2889266aeb SWDEV-429053 - Add check for StreamLegacy
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I402185a3b81935aaa1c8c4963407b8de21c72d8a


[ROCm/clr commit: 627ccfa502]
2024-05-28 06:31:10 +00:00
Vladana Stojiljkovic bf817aeaa3 SWDEV-454681 - Add nullptr check for memsetParams in hipDrvGraphAddMemsetNode
Change-Id: Ife8784b23179c5613c29cde27dd2975cb729aaae


[ROCm/clr commit: d543ab6a0b]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker 2969f2476b SWDEV-301667 - Better log
- Print kernelname for graph launches, its hard to correlate packets
otherwise
- Print correlation_id if any

Change-Id: Ib8db7a00e4e7c98f570e71029e61d86f5dccc2ed


[ROCm/clr commit: 72d23a02c5]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker efc2de44f0 SWDEV-451594 - Fix HDP reg readback
Change-Id: I478a968330f85c3b60ff39fb40bf3cd91acd610e


[ROCm/clr commit: 1ba74c3ce3]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 98fd53c2ef SWDEV-442738 - Static package generation for hip
Generate static package by combining binary and dev components.
Binary and dev component dependencies are added to the static package dependencies
Package name will have suffix static-dev/devel

Change-Id: I7eb187ceaf2af7dfaf6ff9f56de20dac72881a12


[ROCm/clr commit: 2ce57184d3]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras b8af347e8e SWDEV-445072 - Disable rocprofiler register for static libs
Change-Id: I38f4cc31ea196156aad65ca743787b27c02823ac


[ROCm/clr commit: 7d901666b8]
2024-05-28 06:31:10 +00:00