c10cc0ede2
fix for improper display of % of peak for instruction mix panel
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
cdeef4ebb3
minor touchup
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
a25da8d954
fix warning about unescaped control sequence
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
3197553ca6
Add version to specs/sysinfo output in order to throw warning for new fields
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
09f1455308
Added consistent 'Channel' headers to l2_per_chan, removed hardcoded 32 channels, and removed printed Nones ( #276 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
0d516f05b4
Fix bug in GUI kernel filtering
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
20d93703fc
correct small negatives in remote read/write traffic due to running in different passes
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
2c3c5fba35
fix dependency ordering in builtins
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
18dfc35c14
typo
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
c5e4a33c07
catch missing per-XCDs
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
2024-03-01 15:50:42 -06:00
c17e39189f
Enhance correct_sys_info() func and err checking
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
17a4d92c63
Remove mean for avg header in inst cache panel
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
a70dc4999d
Hide L2Banks in sysinfo and update roofline module
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
3e59c928e0
Fixing misc Mi300 typos
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
d2c3d7faf9
Misc fix for kernel name shortener
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
bd794abb12
Fix Mi300 clk timings using GRBM_GUI_ACTIVE from #255
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
2001908fd8
Carry over fixed numSQCs calc from #247
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
3ce140d04b
Including remaining metric fixes from #251
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
86b6c8e848
Renaming global spec vars. Replacing L2Banks with total_l2_chan ( #251 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
3b1b8d7b5b
Reorganize the specs module to reduce duplicate code
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-03-01 15:50:42 -06:00
4ad124a207
Fix off by one out of range kernel filtering ( #287 )
...
* Fi off by one out of range kernel filtering
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
---------
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
2024-02-29 12:38:37 -06:00
f42aa6c7e0
Supress warning: RuntimeWarning: Mean of empty slice ( #271 )
...
* Supress warning: RuntimeWarning: Mean of empty slice
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Move import to top
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Specify type of RuntimeWarning in catcher. Safer approach
Signed-off-by: colramos-amd <colramos@amd.com >
* Comply to formatting
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Jose Santos <josantos@login1.hpcfund >
Co-authored-by: colramos-amd <colramos@amd.com >
2024-02-29 12:14:46 -06:00
2a6285a16b
document updated minimum version requirements for ROCm and python
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-27 15:11:17 -06:00
f2235b7f1d
Fix for rocm-smi not getting mclk for MI100
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-26 11:47:56 -06:00
76873dd0c4
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-22 16:02:25 -06:00
5a27189c82
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-22 16:02:25 -06:00
79b877d679
code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-22 16:02:25 -06:00
852cc13f2a
Fix clocks ( #246 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-02-13 20:22:11 -06:00
c60f031558
Fix hbmBW calculation, ( #243 )
...
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Fix for earlier smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
2024-02-13 20:19:56 -06:00
b7d5d3b64b
Modify yaml configs to reflect new combined Top Stats
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-13 19:56:46 -06:00
bd83f68412
Enable the revamped Top Stats section in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-13 19:18:31 -06:00
2526e14802
Combine kernel and dispatch stats in the Top Stats section of analysis
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-13 19:17:41 -06:00
7bb211a465
Fix logic for roofline field in sysinfo
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-12 17:07:55 -06:00
33a2cd34ce
Revert sbios fix. Catch commas
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-08 12:52:07 -06:00
c8f4f74255
Escape sbios, can have commas on some systems ( #241 )
...
* escape sbios, can have commas on some systems
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Prefer to cast to str in original function
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: colramos-amd <colramos@amd.com >
2024-02-08 12:40:52 -06:00
d7b78da250
Add new l2 cache per channel headers to supported fields
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
48911111be
Enable standalone GUI with new metric reordering
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
3b8e08f589
Add numPipes field and omit 'non-functional' counters from configs
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
4c9a638e2d
Standardize syntax across all metric configs
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
f4053bc0a2
Update perfmon config for tcc
...
Co-authored-by: Nick Curtis <nicholas.curtis>
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
66fcfd3def
General spell check and typo fixing
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
d16f58b797
Add numPipes built-in-var for updated metrics
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
deef37d5a9
Update metrics, handling merge conflicts in L2 cache per channel
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
4b8f519e9b
Add full documentation for updated metrics ( #224 )
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:19:40 -06:00
b0cf695976
Fix SPGR merge warning and more descriptive CLI output
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-06 16:12:14 -06:00
eece1f4688
add an optional exit_on_error arg for the run utility and enable for a
...
subset of calls to rocm-smi
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-02-05 16:20:21 -06:00
7556316f02
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-04 12:44:47 -06:00
9b464503fe
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-04 12:44:47 -06:00
194e168414
Modify smi error detection to check for non-zero exit code
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-02 14:27:08 -06:00
4174788e59
Update metric configs incorrectly using legacy rocprof headers
...
Signed-off-by: colramos-amd <colramos@amd.com >
2024-02-01 16:22:44 -06:00
Nicholas Curtis
colramos-amd
JoseSantosAMD
Karl W Schulz
Nick Curtis