AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,112 Commits 3 Branches 0 Tags
c1d60e1f12e40af39e99f6ca0fa9db1087821dc3
Commit Graph

2012 Commits

Author SHA1 Message Date
Evgeny Mankov 499e247586 Merge pull request #262 from ChrisKitching/frontendaction 
[HIPIFY] Mostly fix preprocessor-or-template induced issues

[ROCm/hip commit: aa05b3d84e]
 2017-11-27 17:30:11 +03:00
Ben Sander 9e0e43bfd8 Merge pull request #273 from mangupta/swdev-129574 
Fix float2int rounding functions

[ROCm/hip commit: 814548407d]
 2017-11-23 12:04:36 -06:00
Maneesh Gupta 2e043b7c0e Fix float2int rounding functions 
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468


[ROCm/hip commit: 4c96882366]
 2017-11-23 09:57:24 +05:30
Evgeny Mankov 52b93658a9 Merge pull request #263 from ChrisKitching/headers 
[HIPIFY] Add hipify mappings for all CUDA headers that have HIP equivalents

[ROCm/hip commit: 4e92a034d0]
 2017-11-22 21:24:21 +03:00
Ben Sander 6e332812fc Merge pull request #264 from pzins/missing_end_marker 
Fix missing MARKER_END

[ROCm/hip commit: e8ede28ec4]
 2017-11-20 06:08:01 -06:00
Maneesh Gupta d807f528e6 Merge pull request #266 from gargrahul/fix_half2_gfx900 
Fixed half2 issue on gfx900

[ROCm/hip commit: db378fbc9e]
 2017-11-20 07:28:41 +05:30
Maneesh Gupta 2bb78b3a69 Merge pull request #265 from phani544/nvccTests 
[nvccTests]Enabled inline_asm_vadd on nvcc

[ROCm/hip commit: 1174534e85]
 2017-11-20 07:28:29 +05:30
Ben Sander 1ec5bab716 Fix test on cuda 
[ROCm/hip commit: 59956a57ca]
 2017-11-19 15:31:02 -06:00
Ben Sander 64a169fd5c Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP 
[ROCm/hip commit: 5a7a28ad29]
 2017-11-19 15:25:17 -06:00
Ben Sander dde41ae0aa Temporarily disable P2P on nvidia (fails on dual GPU) 
[ROCm/hip commit: e0c3f684ae]
 2017-11-19 15:21:37 -06:00
Alex Voicu 962bf7bfda This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility. 
[ROCm/hip commit: cffd0e14eb]
 2017-11-19 01:54:12 +00:00
Rahul Garg 5de28551c1 Fixed test case for GFX900 
[ROCm/hip commit: 9af0f9cbc1]
 2017-11-16 09:34:52 +05:30
Rahul Garg d0ee6e00fe Fixed half2 issue on gfx900 
[ROCm/hip commit: fef496d4f1]
 2017-11-15 18:52:59 +05:30
Phaneendr-kumar Lanka 65a8021933 [nvccTests]Enabled inline_asm_vadd on nvcc 
[ROCm/hip commit: 18f6e31d1d]
 2017-11-14 16:37:59 +05:30
Pierre d917c6b546 Fix missing MARKER_END 
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"


[ROCm/hip commit: 6baaed8e48]
 2017-11-13 16:13:19 -05:00
Chris Kitching 9ef5b7a506 Add an explicit check for proper rewriting of CUDA includes 
[ROCm/hip commit: ab3debb2f9]
 2017-11-13 21:02:42 +00:00
Chris Kitching 6e5f80b345 Add a preprocessor conditional to one of the tests 
Hurrah, we can cope with ifdefs now (except for kernel launches)


[ROCm/hip commit: 2344ca89f3]
 2017-11-13 20:58:55 +00:00
Chris Kitching 096136750c Use proper clang diagnostics for printing warnings 
Much pretty. Very wow

This gives users all the usual power when it comes to manipulating
clang diagnostics. People can pass -Werror can have hipify fail if
it doesn't completely translate a file, for example. Much nicer
than reinventing the wheel.


[ROCm/hip commit: 6b767a59ba]
 2017-11-13 20:58:55 +00:00
Chris Kitching 78cf713140 Use a custom FrontendAction to simplify identifier translation 
Most of what hipify does is really just replacing CUDA idenitifers
with HIP ones. CUDA function calls, preprocessor macro calls,
enum references, types, etc.

This is problematic: calls/types/enum-refs require name resolution
for the AST matcher to work. This fails in the presence of code
deleted by the preprocessor, and in two-pass template compilation.

Instead, we can simply hook the lexer and have it rewrite the
identifiers for us.

This approach means identifier transformations will work correctly
regardless of where they appear (and we get to delete lots of code)

- Fixes #260
- Helps a bit with #207 - it will still fail to translate kernel
calls in preprocessor-ignored code, but everything except kerel
launches should translate correctly now, even in
preprocessor-deleted code.


[ROCm/hip commit: 24cdc5e1d3]
 2017-11-13 20:58:54 +00:00
Chris Kitching c2d54f0154 Add hipify mappings for all CUDA headers that have HIP equivalents 
I'm particularly running into issues with `device_types.h` in real
CUDA code...


[ROCm/hip commit: 23b5d26582]
 2017-11-13 17:20:07 +00:00
Chris Kitching 1451d8fc89 Add a test that exposes #260 
[ROCm/hip commit: 9165df3848]
 2017-11-13 16:18:15 +00:00
Chris Kitching b13465cfdd Add a couple of missing CHECK directives to concurrentKernels.cu 
[ROCm/hip commit: 4ab091ce1e]
 2017-11-13 16:17:19 +00:00
Rahul Garg 93a390b9c2 Fix module_api sample 
[ROCm/hip commit: 83adf6525e]
 2017-11-13 08:56:39 +05:30
Maneesh Gupta 56d3677499 Merge pull request #250 from AlexVlx/feature_add_agent_global_support 
Support for agent globals

[ROCm/hip commit: 31bcb59f62]
 2017-11-09 07:52:09 +05:30
Maneesh Gupta 6368c2abc7 Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace 
Clean up trailing whitespace so as to reduce noise in #246.

[ROCm/hip commit: ebd58d43fa]
 2017-11-08 10:29:19 +05:30
Maneesh Gupta f71d0a049f Merge pull request #253 from mangupta/hit_add_cmakecmd 
[hit] Add support for cmake commands as part of test infra

[ROCm/hip commit: caa7174652]
 2017-11-08 09:50:29 +05:30
Alex Voicu 35d8af2001 Clean up trailing whitespace so as to reduce noise in #246. 
[ROCm/hip commit: d8e323d4b5]
 2017-11-08 00:08:55 +00:00
Ben Sander d6764bc6ba Merge pull request #254 from bensander/event_thread_safe 
Event thread safe

[ROCm/hip commit: 9fd6c18ef8]
 2017-11-07 17:59:51 +01:00
Phaneendr-kumar Lanka 6fd3d9fda5 identation change in hipPeekAtLastError 
[ROCm/hip commit: e06c546283]
 2017-11-07 09:51:32 +05:30
Ben Sander d9db9dabeb Check for null event in hipEventElapsedTime 
[ROCm/hip commit: f278f67d2d]
 2017-11-06 23:49:31 +00:00
Ben Sander 465b24123b hipStreamWaitEvent returns success if event created but not recorded 
[ROCm/hip commit: 16708dd2e0]
 2017-11-06 23:49:31 +00:00
Ben Sander f80896d58b Make hipEvent_t thread safe. 
Support re-recording of same event by different threads.

- Add criticalData structure to hipEvent_t, similar to mechanism used
  for streams, contexts, device.  Events are always locked
  after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
  including marker.  The critical state in the event can then
  be re-recorded.
- refactor hipEventElapsedTime.  Remmove stale debug code, native signal
  refs.


[ROCm/hip commit: 4a2e6f8955]
 2017-11-06 23:49:25 +00:00
Maneesh Gupta 879699fe0b [hit] Add support for cmake commands as part of test infra 
Cmake supports several builtin command-line tools. These tools can
now be specified as part of the HIT block. These commands will be
run during cmake configure step.

Change-Id: I32466c94b2fe1ecdc30249755fc027102295617d


[ROCm/hip commit: 197a7e2600]
 2017-11-06 16:53:57 +05:30
Phaneendr-kumar Lanka 2f4b59a9b9 Modified tests as per review 
[ROCm/hip commit: 9ee330451a]
 2017-11-06 15:13:36 +05:30
Phaneendr-kumar Lanka a8da9c1c3b More tests for memory,stream & error APIs 
[ROCm/hip commit: 093279b10b]
 2017-11-06 11:31:52 +05:30
Maneesh Gupta 33836c9521 Merge pull request #251 from ROCm-Developer-Tools/fix_event_state 
Set event state AFTER it is recorded.

[ROCm/hip commit: 1131c9e41a]
 2017-11-06 07:28:11 +05:30
Maneesh Gupta 8845e38efd Merge pull request #249 from bensander/warn_event 
Add HIP_DB=warn + message if sync on dangerous event.

[ROCm/hip commit: a62d5aa875]
 2017-11-06 07:25:40 +05:30
Maneesh Gupta 3746211481 Merge pull request #239 from phani544/newTests 
[newTests]Adding tests for device APIs

[ROCm/hip commit: 2f4e1983e2]
 2017-11-06 07:22:13 +05:30
Ben Sander 6a4c50cf6c Set event state AFTER it is recorded. 
[ROCm/hip commit: 4c3b65a5cd]
 2017-11-05 10:33:18 -06:00
Phaneendr-kumar Lanka 9d7c904529 [newTests]modified the test 
[ROCm/hip commit: 0599d13b0d]
 2017-11-03 14:52:19 +05:30
Phaneendr-kumar Lanka 0026b0a3d9 [newTests]Modified the test as per review comments 
[ROCm/hip commit: a764a0980d]
 2017-11-03 10:39:47 +05:30
Maneesh Gupta 04d9ec1400 Merge pull request #248 from mangupta/SWDEV-134531 
Remove libsupc++ dependency from HIP

[ROCm/hip commit: d90d431490]
 2017-11-03 08:01:59 +05:30
Alex Voicu 28eb8e2c3e This introduces correct support for agent global variables, and implements hipModuleGetGlobal as an actual equivalent for cuModuleGetGlobal. 
[ROCm/hip commit: 328c18b886]
 2017-11-03 01:44:48 +00:00
Maneesh Gupta 94a22fe015 Remove libsupc++ dependency from HIP 
Change-Id: Ib843f99dfb3057b7c28029250c2449732ea7f17f


[ROCm/hip commit: f34f5c8684]
 2017-11-02 12:29:09 +05:30
Alex Voicu b8a81d2b75 This corrects some interesting choices that were present in the HIP 
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.


[ROCm/hip commit: a619ac6f92]
 2017-11-01 22:51:22 +00:00
Ben Sander 2979a99888 Merge pull request #237 from bensander/use_ctxptr_for_p2p 
Use ctxptr for p2p

[ROCm/hip commit: 09d866a639]
 2017-11-01 18:55:25 +01:00
Ben Sander 6c60773e82 Add HIP_DB=warn + message if sync on dangerous event. 
[ROCm/hip commit: 70c25bdf8e]
 2017-11-01 10:44:34 -07:00
Ben Sander 6f3b28d27c Merge pull request #245 from scchan/centos_fixes 
various fixes for centos/rhel

[ROCm/hip commit: 86f62accfd]
 2017-11-01 18:10:29 +01:00
Siu Chi Chan d938703f9b Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11 
[ROCm/hip commit: 99d32a195f]
 2017-10-31 18:16:12 +00:00
Siu Chi Chan b6265074fa use libc++ on centos 7 and rhel 7.4 
[ROCm/hip commit: cd6996614f]
 2017-10-31 18:14:07 +00:00