Commit Graph

64521 Commits

Author SHA1 Message Date
Swargam, Rambabu f7712bd5a8 SWDEV-493276 - [catch2][dtest] Additional tests for Scratch limit change (#46)
* SWDEV-493276 - [catch2][dtest] Additional tests for Scratch limit change

* Removed the Kernel wait related scenarios

* Modified kernel operation

* Fixed PSDB NVIDIA build issue

* Restricted for Windows

* Used isSetScratchLimitSupported for all tests and modified isSetScratchLimitSupported
2025-06-10 21:25:06 +05:30
Elwazir, Ammar 7482372c0b [CMake] Removing the mention of failed while running rocminfo (#409)
* Making sure if GPU_TARGETS is given as input that we ignore the usage of rocminfo

* Update rocprofiler-sdk-utilities.cmake

* Update rocprofiler-sdk-utilities.cmake

[ROCm/rocprofiler-sdk commit: 80e058bf08]
2025-06-10 10:46:40 -05:00
Elwazir, Ammar 80e058bf08 [CMake] Removing the mention of failed while running rocminfo (#409)
* Making sure if GPU_TARGETS is given as input that we ignore the usage of rocminfo

* Update rocprofiler-sdk-utilities.cmake

* Update rocprofiler-sdk-utilities.cmake
2025-06-10 10:46:40 -05:00
cfallows-amd 5de2375db1 Fix load_kernel_top arg for GUI analyze mode (#740)
--gui option for analyze mode failing due to missing arg in load_kernel_top call in pre_processing

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: ce3ef1400e]
2025-06-10 11:27:03 -04:00
cfallows-amd ce3ef1400e Fix load_kernel_top arg for GUI analyze mode (#740)
--gui option for analyze mode failing due to missing arg in load_kernel_top call in pre_processing

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-10 11:27:03 -04:00
Brzak, Branislav c95ca33e7b SWDEV-531996 SWDEV-530154 - Use *getprocaddress to obtain Mesa functions (#504)
[ROCm/clr commit: 5fabfedbd1]
2025-06-10 13:31:32 +05:30
Brzak, Branislav 5fabfedbd1 SWDEV-531996 SWDEV-530154 - Use *getprocaddress to obtain Mesa functions (#504) 2025-06-10 13:31:32 +05:30
Kandula, Venkateshwar reddy 1562e4573c [DOCS] SWDEV-534589 Update docs with new info in kernel_trace csv output (#438)
* Update docs with new info in kernel_trace csv output and add flag for csv in docs.

* Misc.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Co-authored-by: Vaddireddy, Sushma <Sushma.Vaddireddy@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: 1c91774c6a]
2025-06-10 08:20:07 +05:30
Kandula, Venkateshwar reddy 1c91774c6a [DOCS] SWDEV-534589 Update docs with new info in kernel_trace csv output (#438)
* Update docs with new info in kernel_trace csv output and add flag for csv in docs.

* Misc.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Co-authored-by: Vaddireddy, Sushma <Sushma.Vaddireddy@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-06-10 08:20:07 +05:30
Nagaraj, Sriraksha 926a2048ba avail-fix (#444)
* avail-fix

* formating

* adding dimension info in rocprofv3

* review comments

[ROCm/rocprofiler-sdk commit: 00f5f398e3]
2025-06-09 16:53:02 -05:00
Nagaraj, Sriraksha 00f5f398e3 avail-fix (#444)
* avail-fix

* formating

* adding dimension info in rocprofv3

* review comments
2025-06-09 16:53:02 -05:00
Chris Freehill a34604bddb rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.
2025-06-09 15:42:58 -05:00
Chris Freehill 91268a6be9 rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.


[ROCm/ROCR-Runtime commit: a34604bddb]
2025-06-09 15:42:58 -05:00
Chris Freehill 3a9d14bb66 rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.
2025-06-09 15:42:58 -05:00
Chris Freehill 287986ab65 rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.


[ROCm/ROCR-Runtime commit: 3a9d14bb66]
2025-06-09 15:42:58 -05:00
vedithal-amd c7cea9c971 Revert default interface to rocprof v1 (#738)
* Add deprecation warning for rocprof v1 / v2 / v3 interfaces to use
  rocprofiler-sdk interface

[ROCm/rocprofiler-compute commit: a1ef3425c6]
2025-06-09 16:39:11 -04:00
vedithal-amd a1ef3425c6 Revert default interface to rocprof v1 (#738)
* Add deprecation warning for rocprof v1 / v2 / v3 interfaces to use
  rocprofiler-sdk interface
2025-06-09 16:39:11 -04:00
Kian Cossettini 348afae1a8 Improve rocprof-sys-avail to report VCN and JPEG metrics on supported devices (#226)
* SWDEV-535445: rocprof-sys-avail shows jpeg_activity even when unsupported

* Added vcn tracking

* jpeg and vcn description now includes supported gpus

* Add getter methods per device to check vcn and jpeg support

Add logic to check if vcn activity and vcn busy values are supported for each device.
Add logic to check if jpeg activity and jpeg busy values are supported for each device.

Co-authored-by: Sajina P Kandy <sputhala@amd.com>

* Add getter methods per device to check vcn and jpeg support (#228)

* Formatting

* Variable fix

* List of supported GPUs are now ordered

* Removed the ability to see which gpu supports jpeg and vcn activity to reduce clutter

* Formatting

* Testing for busy support

* jpeg and vcn only show if supported

* Removed commented code

* Formatting

* Applied amd_smi cpp/hpp fixes

* Added break condition for xcp loop

* Modified loops for efficiency

* Removed unneccessary macro

* Removed unneccessary includes

---------

Co-authored-by: Sajina Kandy <sputhala@amd.com>
Co-authored-by: Sajina PK <Sajina.PuthalathKandy@amd.com>

[ROCm/rocprofiler-systems commit: 0380cf58ba]
2025-06-09 16:14:53 -04:00
Kian Cossettini 0380cf58ba Improve rocprof-sys-avail to report VCN and JPEG metrics on supported devices (#226)
* SWDEV-535445: rocprof-sys-avail shows jpeg_activity even when unsupported

* Added vcn tracking

* jpeg and vcn description now includes supported gpus

* Add getter methods per device to check vcn and jpeg support

Add logic to check if vcn activity and vcn busy values are supported for each device.
Add logic to check if jpeg activity and jpeg busy values are supported for each device.

Co-authored-by: Sajina P Kandy <sputhala@amd.com>

* Add getter methods per device to check vcn and jpeg support (#228)

* Formatting

* Variable fix

* List of supported GPUs are now ordered

* Removed the ability to see which gpu supports jpeg and vcn activity to reduce clutter

* Formatting

* Testing for busy support

* jpeg and vcn only show if supported

* Removed commented code

* Formatting

* Applied amd_smi cpp/hpp fixes

* Added break condition for xcp loop

* Modified loops for efficiency

* Removed unneccessary macro

* Removed unneccessary includes

---------

Co-authored-by: Sajina Kandy <sputhala@amd.com>
Co-authored-by: Sajina PK <Sajina.PuthalathKandy@amd.com>
2025-06-09 16:14:53 -04:00
Sunday Clement dce52be686 rocr: Fix Unintentional Integer Overflow
Its safer to have the integer literal explicitly be an unsigned long
in this expression as that's what the type of the errorCode variable
resolves to, preventing any overflow errors.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-09 15:16:10 -04:00
Sunday Clement 5c7524ba3e rocr: Fix Unintentional Integer Overflow
Its safer to have the integer literal explicitly be an unsigned long
in this expression as that's what the type of the errorCode variable
resolves to, preventing any overflow errors.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>


[ROCm/ROCR-Runtime commit: dce52be686]
2025-06-09 15:16:10 -04:00
Sunday Clement d00ca2e9b7 rocr: Fix Unintended Sign Extension
ehdr->e_shentshize and ehdr->e_shnum are both 16-bit unsigned integers
and so their types get implicitly promoted to signed int automatically
during the multiplication, they must be explicitly cast into a larger
unsigned type, otherwise if the signed product is large enough the
value is sign extended resulting in incorrect values.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-09 15:16:10 -04:00
Sunday Clement 1eaee1649a rocr: Fix Unintended Sign Extension
ehdr->e_shentshize and ehdr->e_shnum are both 16-bit unsigned integers
and so their types get implicitly promoted to signed int automatically
during the multiplication, they must be explicitly cast into a larger
unsigned type, otherwise if the signed product is large enough the
value is sign extended resulting in incorrect values.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>


[ROCm/ROCR-Runtime commit: d00ca2e9b7]
2025-06-09 15:16:10 -04:00
Pryor, Adam 8663702737 [SWDEV-531379] Fix config (#183)
* [SWDEV-531379] Fix config

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: Ie1bd6903235016a185dd93fbac0a87658fb12a62

* Fix group field find

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I1f8c62615327df4b5ca916b158b4882a3d5a59d0

* fixes

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I971f3e12e293ea9e5d4d67db64d8d7217b87561c

---------

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-06-09 13:55:15 -05:00
Pryor, Adam d075194597 [SWDEV-531379] Fix config (#183)
* [SWDEV-531379] Fix config

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: Ie1bd6903235016a185dd93fbac0a87658fb12a62

* Fix group field find

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I1f8c62615327df4b5ca916b158b4882a3d5a59d0

* fixes

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I971f3e12e293ea9e5d4d67db64d8d7217b87561c

---------

Signed-off-by: adapryor <Adam.pryor@amd.com>

[ROCm/rdc commit: 8663702737]
2025-06-09 13:55:15 -05:00
Alysa Liu 9b3d15e68d rocr: Remove structurally dead code
Remove unreachable return statement.

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
2025-06-09 14:01:39 -04:00
Alysa Liu 03430838af rocr: Remove structurally dead code
Remove unreachable return statement.

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>


[ROCm/ROCR-Runtime commit: 9b3d15e68d]
2025-06-09 14:01:39 -04:00
Fei Zheng d750ea6616 TUI improvement (#732)
[ROCm/rocprofiler-compute commit: 96aa04fb13]
2025-06-09 11:29:10 -06:00
Fei Zheng 96aa04fb13 TUI improvement (#732) 2025-06-09 11:29:10 -06:00
David Galiffi ed745153b3 Update opensuse.yml (#236)
[ROCm/rocprofiler-systems commit: 92b636a219]
2025-06-09 12:47:24 -04:00
David Galiffi 92b636a219 Update opensuse.yml (#236) 2025-06-09 12:47:24 -04:00
vedithal-amd dd39c649d9 Bugfix for rocprofiler sdk interface not working in MI 200 (#733)
[ROCm/rocprofiler-compute commit: 721053bd03]
2025-06-09 12:33:25 -04:00
vedithal-amd 721053bd03 Bugfix for rocprofiler sdk interface not working in MI 200 (#733) 2025-06-09 12:33:25 -04:00
Bhardwaj, Gopesh 72daf19ca7 Gobhardw/readme update (#443)
* README update

* updating README

[ROCm/rocprofiler-sdk commit: 2c6a4834d4]
2025-06-09 21:00:09 +05:30
Bhardwaj, Gopesh 2c6a4834d4 Gobhardw/readme update (#443)
* README update

* updating README
2025-06-09 21:00:09 +05:30
Luu, Jonathan 7f7f1c0fd5 SWDEV-531400 - Remove file reorganization backward compatibility (rocprofiler) (#35)
remove backwards compatibility

Co-authored-by: Jonathan Luu <jonatluu@amd.com>
2025-06-09 11:11:41 -04:00
Luu, Jonathan 1f560d3953 SWDEV-531400 - Remove file reorganization backward compatibility (rocprofiler) (#35)
remove backwards compatibility

Co-authored-by: Jonathan Luu <jonatluu@amd.com>

[ROCm/rocprofiler commit: 7f7f1c0fd5]
2025-06-09 11:11:41 -04:00
Jason Bonnell a3b7e4fbd9 add pull_request_template.md (#729)
* add pull_request_template.md

* add bug fix or feature checkboxes

* Address feedback and align more with sdk implementation

* Add other category under PR type if needed

[ROCm/rocprofiler-compute commit: 8acfe40113]
2025-06-09 10:24:59 -04:00
Jason Bonnell 8acfe40113 add pull_request_template.md (#729)
* add pull_request_template.md

* add bug fix or feature checkboxes

* Address feedback and align more with sdk implementation

* Add other category under PR type if needed
2025-06-09 10:24:59 -04:00
U, Srihari af8650c014 Fix calculation for counter collection in perfetto (#395)
* Fix counter values acuumulation

* Updated change log

* Fix warnings

* Address comment

[ROCm/rocprofiler-sdk commit: 282834aaa7]
2025-06-09 00:44:55 -07:00
U, Srihari 282834aaa7 Fix calculation for counter collection in perfetto (#395)
* Fix counter values acuumulation

* Updated change log

* Fix warnings

* Address comment
2025-06-09 00:44:55 -07:00
Pranjal Swarup 9d94e11e2b Update dyninst to v13 (#190)
Update Dyninst submodule
Refactoring of build scripts to build TBB, Boost, ElfUtils, and LibIberty, since Dyninst build scripts no longer do.
Workflows are now building Dyninst and its dependencies.

---------

Co-authored-by: marantic-amd <marantic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 96df9b6d3e]
2025-06-06 22:52:23 -04:00
Pranjal Swarup 96df9b6d3e Update dyninst to v13 (#190)
Update Dyninst submodule
Refactoring of build scripts to build TBB, Boost, ElfUtils, and LibIberty, since Dyninst build scripts no longer do.
Workflows are now building Dyninst and its dependencies.

---------

Co-authored-by: marantic-amd <marantic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-06 22:52:23 -04:00
Fei Zheng 9a392edb21 CLI: enable mem_chart for single run (#643)
[ROCm/rocprofiler-compute commit: e5b31af2a4]
2025-06-06 16:15:56 -06:00
Fei Zheng e5b31af2a4 CLI: enable mem_chart for single run (#643) 2025-06-06 16:15:56 -06:00
Charis Poag b45713faf5 [SWDEV-530035] Fix tests ran with partitioned configurations (CPX, DPX, QPX, etc.)
Changes: - Updates to APIs to handle null pointers or RSMI_STATUS_NOT_SUPPORTED
  - Fixes to tests to handle partitioned configurations correctly
  - Synced with latest AMD SMI API changes
Change-Id: I7a932f9336ef29ccb01d3b15e2101f6136b45720


[ROCm/rocm_smi_lib commit: 12b78439d2]
2025-06-06 16:39:29 -05:00
Charis Poag 12b78439d2 [SWDEV-530035] Fix tests ran with partitioned configurations (CPX, DPX, QPX, etc.)
Changes: - Updates to APIs to handle null pointers or RSMI_STATUS_NOT_SUPPORTED
  - Fixes to tests to handle partitioned configurations correctly
  - Synced with latest AMD SMI API changes
Change-Id: I7a932f9336ef29ccb01d3b15e2101f6136b45720
2025-06-06 16:39:29 -05:00
Pratik Basyal 1440fe180c Formatting issue in code block and TOC fixed for PC Sampling (#731)
* Formatting issue in code block and TOC fixed

* Performance model reverted

[ROCm/rocprofiler-compute commit: ed05c00103]
2025-06-06 16:16:55 -04:00
Pratik Basyal ed05c00103 Formatting issue in code block and TOC fixed for PC Sampling (#731)
* Formatting issue in code block and TOC fixed

* Performance model reverted
2025-06-06 16:16:55 -04:00
Luu, Jonathan 662080e725 SWDEV-531400 - Remove file reorganization backward compatibility (aqlprof) (#90)
remove backwards compatibility

Co-authored-by: Jonathan Luu <jonatluu@amd.com>

[ROCm/aqlprofile commit: 8885887302]
2025-06-06 16:02:49 -04:00