Commit Graph

915 Commits

Author SHA1 Message Date
Benjamin Welton c45fbe91ff Add support for kernel name filtering to rocprofv2
rocprofv2 does not support the "kernel:" attribute in
input files. This commit adds support for this attribute
for cli/csv output. This is requested by Alibaba/Omniperf
to have compatible execution with both v1/v2 (JSON and CTF
are not supported here and not needed).

Filtering can also be enabled by the flag ROCPROFILER_KERNEL_FILTER.

Change-Id: I376382d9e5b10a8356df8d175b1a56396b5b51d3


[ROCm/rocprofiler commit: b32eb2bda9]
2024-08-12 13:41:39 -04:00
Giovanni LB a34d5dbc16 Fixing perfetto tracks for multigpu
Change-Id: I0b18180218fc19c8a478112e9a374e863fd3741c


[ROCm/rocprofiler commit: 00163488d7]
2024-08-08 00:59:48 -04:00
gobhardw b363586f82 issue 40 typos fix
Change-Id: I486301c42bc5691a4d8a852e0ce168f8ca7776a0


[ROCm/rocprofiler commit: 1a63cba43d]
2024-08-07 16:09:31 -04:00
Ian Trowbridge f731ae7593 SWDEV-474739: Added flag to optionally remove serialization for counter collection mode
Change-Id: I2e91fd51287fe923ec6a97b491f84f0dd9d51f62


[ROCm/rocprofiler commit: cd2ff0250e]
2024-08-07 11:36:16 -05:00
Giovanni LB 6defbd0f2e SWDEV-476512: Further rocsys fixes
Change-Id: I9ae8534a2b6b23f76514920a6c4d39025bc882bc


[ROCm/rocprofiler commit: c4adefccde]
2024-08-05 10:42:00 -04:00
Giovanni LB 9915421ec0 SWDEV-477001: Fixing line offset and copy command for webui
Change-Id: I830bc7afd552e314f931514e938ba2214a765e63


[ROCm/rocprofiler commit: 7edee28288]
2024-08-01 00:32:58 -03:00
gobhardw 977fd3861d rocsys fixes
Change-Id: I6a7a5bc93f80c9285c1eb7a4b2e97015c1598b0e


[ROCm/rocprofiler commit: 0b21b2dd7d]
2024-07-30 13:12:43 -04:00
Manjunath-Jakaraddi d8ab9e0c02 fix incorrect number of cols in csv
Change-Id: I08fae458db8077b7f40868cf173ae14cb5a5312c


[ROCm/rocprofiler commit: 55cddfebb2]
2024-07-29 10:53:35 -04:00
Giovanni LB aa02e4e5b3 SWDEV-475884: Fixing hang issue on iree, fixing bitshift on codeobj markers
Change-Id: I046312cbfa82742c7388f64b87b95a9d671b9d3d


[ROCm/rocprofiler commit: 95dae41625]
2024-07-26 17:13:51 -03:00
meserve-amd b92db40cc6 SWDEV-475540: Fix build time parsing of unions
- Fixes issue where types defined inside of a union were being skipped
  for ostream operator generation
- Also fixes issue where these types were not correctly defined in the
  resulting operators' parameters
- Fixes edge case where types with "union" in their name were being
  skipped as if they were union types

Change-Id: I736c57788cbc461e9493d4651756dc06c278430d


[ROCm/rocprofiler commit: 70268ccc9f]
2024-07-25 17:28:24 -04:00
itrowbri 2be5e3b45a Initialize PcieAccessApi* api and void* libpciaccess_handle to nullptr
Change-Id: I58306f12653a8cb532c107bc3852aa0df8f7c6b9


[ROCm/rocprofiler commit: 2a65365b46]
2024-07-24 16:16:03 -05:00
itrowbri 8d53eb2836 SWDEV-469750: Load libpciaccess-dev functions with dlopen. Removed libsystemd-dev from CMakeLists.txt
Change-Id: I314c188fabc2dd4de3b633d722599bc11a046622


[ROCm/rocprofiler commit: 4ed346aa63]
2024-07-24 11:22:32 -05:00
Benjamin Welton 9f222d2fd0 Only check lock if counter collection is used
Only check the lock if counter collection is being
attempted by the profiler. Not when it is loaded.

SWDEV-474455

Change-Id: Ie14de3c8db57e0cbd279ffca51c333a375ca8654
Signed-off-by: Benjamin Welton <bewelton@amd.com>


[ROCm/rocprofiler commit: 0be3e07388]
2024-07-22 05:24:50 -04:00
Giovanni LB 1c897ae070 SWDEV-474179: Fixing hang issue for perfetto and missing records for trace period
Change-Id: I8926565720873d7dd730c5518f60ac6521e3bbf5


[ROCm/rocprofiler commit: 95ed584e6d]
2024-07-22 01:09:47 -04:00
Giovanni LB 6fd4edbd29 SWDEV-474615: Adding barrier bit to read and stop packets
Change-Id: I895dc7389d870ed111ac3b9c400e6946023ffe97


[ROCm/rocprofiler commit: 637abbf8d7]
2024-07-19 12:45:52 -03:00
Lang Yu 2230af4b1d SWDEV-467545 - Add rocprofiler support for gfx1150/gfx1151
Change-Id: I2cddc36981f6d815c865d180a1daf1b8a7e0633f
Signed-off-by: Lang Yu <lang.yu@amd.com>


[ROCm/rocprofiler commit: 7313e52f35]
2024-07-09 22:40:10 -04:00
Giovanni LB e4e1e4857e SWDEV-470113: Fixing hang on navi33
Change-Id: I5c1d30547039a6f23ab5974f43ea63f971573108


[ROCm/rocprofiler commit: 7e199e6b7a]
2024-07-05 20:39:56 -04:00
Giovanni LB d29580c94e SWDEV-470113: Swapping test order and resetting queue.cpp variables
Change-Id: I20f3fa3cbf389ab89ba8ea8e430819c4ef837ad0


[ROCm/rocprofiler commit: 70fedc5195]
2024-07-03 15:41:37 -03:00
Giovanni LB 8ca515087a SWDEV-470113: Waiting on active signals
Change-Id: Ie99477a2f031fa0dbb7ff7c860f8b780177e6e9d


[ROCm/rocprofiler commit: 8d2f139005]
2024-06-27 15:17:56 -03:00
gobhardw b19ca5fcad Adding azure build status
Change-Id: Ic7f2ab5c175193a8b533145cc8e2ccdbb090231e


[ROCm/rocprofiler commit: d74921cfd3]
2024-06-26 12:51:06 +05:30
Giovanni LB 0f6481259c Adding ATT support for gfx12
Change-Id: I549f36061bd961347eb92795846d660069c263fc


[ROCm/rocprofiler commit: 893bcb0c10]
2024-06-21 11:25:49 -04:00
Ranjith Ramakrishnan 5d945a8144 SWDEV-464716 - Use the correct hsa devel package for RPM dependencies
hsa-rocr-devel should be used for RPM dependency.
Runtime package should depend on has-rocr

Change-Id: I61a25c47d18f14686bbb55f5ccbf1f49d27bb9b0


[ROCm/rocprofiler commit: 2b6d73d3e7]
2024-06-20 16:06:10 -07:00
gobhardw 9337232d11 README update for gerrit->github nightly sync
Change-Id: Ice31239def9f6cf4c1e8ef689d7b92df75ca3b4c


[ROCm/rocprofiler commit: 33ba37b58e]
2024-06-20 02:59:06 -04:00
jatang c8d58d1986 SWDEV-458392 - Add gfx12 support.
Change-Id: I91bb6a3329bf77f26005a345c18b63b86922028a


[ROCm/rocprofiler commit: e7b96b1e71]
2024-06-17 13:24:48 -04:00
Giovanni LB 4a09c57f1a SWDEV-468021: Improving profiler performance
Change-Id: I91921160a19aaea1fedfa40d11b83114d6a6fc65


[ROCm/rocprofiler commit: 4d0fee6637]
2024-06-14 15:29:27 -03:00
Saurabh Verma 437d39de9e RDC metrics in v1
Change-Id: Iaa8cd0a37da37729df76362f10a0bb63c317a498


[ROCm/rocprofiler commit: a63b6fcbd2]
2024-06-11 17:00:39 -05:00
Saurabh Verma 25eda9f856 Fixing occupancy metrics for MI300
Adding changes for v1 xml which was missed in change 6cf9df4ff0

Change-Id: I338f2736ee61e316522f1ce42cee74abec201499


[ROCm/rocprofiler commit: 2047bf4b8b]
2024-06-11 11:47:57 -05:00
Ammar ELWazir bb40910abe Fixing the force of using cmake python3 interpreter
Change-Id: I5d87dfa78052611856652fc887cdfa6764c51028


[ROCm/rocprofiler commit: a50d5ce4ae]
2024-06-10 16:00:09 -04:00
Saurabh Verma c41bbe21d0 SWDEV-457922: Temporary fix to prevent multiple instances of either rocprofiler v1 or v2 to be running, whether it's interception or standalone mode.
The fix works by using a pid file and a lock file, similar to how firefox prevents multiple instances.

Change-Id: I4974a80bf920eaf0376a53410573c1cc74ec17ac


[ROCm/rocprofiler commit: 056156135d]
2024-06-10 12:49:29 -04:00
AravindanC d7c2fa8867 SWDEV-460492 Update permissions, install target types of executables
Change-Id: I23828d4938ce35f2c27d86654f4e122f8886ec1d


[ROCm/rocprofiler commit: 59230206a3]
2024-06-07 17:42:32 -04:00
Ammar ELWazir 31bc8c5fde General fixes for CI
Change-Id: I16e4d1fbc71a378eba6738c6953760e8e4de525e


[ROCm/rocprofiler commit: db82c5ef62]
2024-06-07 11:22:07 -05:00
Ammar ELWazir 5d572c9bcb Fixing rocsys includes
Change-Id: Ia19030a5ad4caebe7b6703721702a1776e97455b


[ROCm/rocprofiler commit: c312e9b0f1]
2024-06-06 15:00:48 -05:00
gobhardw a67f4fdd93 SWDEV-465520: RHEL9 toolchain doesnt seem to support experimental filesystem
Change-Id: I6b1e7f42c49b1c7af412c0b68851724861c9970a


[ROCm/rocprofiler commit: 1e69b3e2f6]
2024-06-05 12:50:48 -04:00
Giovanni LB 607cfb9ee1 SWDEV-464906: Swap read and stop packets in queue.cpp
Change-Id: I2dd33a71c0cbe69fe6c2cfaf523b9f8c6500093f


[ROCm/rocprofiler commit: 140f658820]
2024-06-05 09:11:59 -04:00
gobhardw a95064a9a5 removing --kernel-trace from --sys-trace help
Change-Id: I14afd42d12bc3c2462040d5ba1f16765565fd662


[ROCm/rocprofiler commit: 341b7b1f21]
2024-06-05 11:18:58 +05:30
Ammar ELWazir bfa7ace4b4 Fixing Activities Trace Period
Change-Id: If37d8518392112cedc66ce616adaaad22c517d4a


[ROCm/rocprofiler commit: 80dce3d672]
2024-05-31 18:09:53 -05:00
Ammar ELWazir 4a716c8a66 Temp: Disabling Perfetto Test
Change-Id: I602e3e752d508a45d42bf22e40b78d53a8e436d0


[ROCm/rocprofiler commit: 2be8f71790]
2024-05-30 12:49:15 -05:00
gobhardw 8f765d2a1e Fixes multiple issues with tool
Change-Id: Ib465caa9029edc737df2c419d2ef763ec24165e1


[ROCm/rocprofiler commit: 48374bf453]
2024-05-29 01:30:09 -04:00
Ammar ELWazir d0dfb4f3e2 Adding JSON & Major fixes
Adding Chrome Tracing JSON for V2
Some fixes for the Kernel Dispatch tracing
Changes related to the HIP Runtime Destruction fix

Change-Id: I2fe1f1ef66b415df17c503a4a9fadcfa107d8c49


[ROCm/rocprofiler commit: b8726a6225]
2024-05-29 01:21:52 -04:00
Giovanni LB d24a280079 Setting output buffer to always local
Change-Id: I82bf9f4cb922221d4a2b7ae15adb0f208a0ba70e


[ROCm/rocprofiler commit: b354c54ed7]
2024-05-27 14:53:32 -04:00
Saurabh Verma 150869be6a Fix for crash Error: HsaRsrcFactory::SignalWait: signal_value(1), ret_value(-1)
Context::GetData() would crash when it tries to wait on the completion signal of the stop packet. The expected signal value after waiting in HsaRsrcFactory::SignalWait() is supposed to be 0 but sometimes it comes up as -1. The signal being checked has already decremented before. Profile::Finalize() was assigning the same completion signal to the read and stop packet. So those two packets have been assigned different completion signals. This fix only affects standalone profiling mode.

Change-Id: I4b16825019e58d95d70188a72b2cc5871e09dd81


[ROCm/rocprofiler commit: 34606db8c3]
2024-05-26 13:31:39 -04:00
Ammar ELWazir a36338a7a6 Temporary fix for SWDEV-459354
Change-Id: I13d7d600ab72d873d1dbc5d5e9b72c2ca5941488


[ROCm/rocprofiler commit: b6576393a2]
2024-05-24 10:39:32 -04:00
amd-jmacaran 3a1edf9a2d Enable ROCm External CI pipeline triggers
Change-Id: Ic025465136c9e8d36af5a67e9e0880671f59a329


[ROCm/rocprofiler commit: 654a8a27f8]
2024-05-21 12:37:49 -04:00
Giovanni LB 4dbea01f91 Scrapping a microsecond from perfetto
Change-Id: I6d9e360a1530d9cb147c64dd45dc47cfc2d13ea1


[ROCm/rocprofiler commit: 7c45264e00]
2024-05-16 11:32:17 -04:00
gobhardw 83b4bf0d06 SWDEV-443556 Fixing hip trace for hipfft applications
Change-Id: I0076911fac755d3cf485e9fb9a5a51b13d0198c3


[ROCm/rocprofiler commit: 1088305d18]
2024-05-15 02:17:46 -04:00
Ammar ELWazir f93fad8364 SWDEV-419012: Adding New Perfetto SDK & Fixing early destruction of perfetto plugin
Change-Id: Ie1d8e753f10a1ba0686b021c14b788b444499f14


[ROCm/rocprofiler commit: 5d1320928c]
2024-05-14 11:24:40 -04:00
Ammar ELWazir ac46f39b22 Remove the force of using DEB,RPM,TGZ CPACK_GENERATOR
Change-Id: I2462831a31ebe74c9c69e332b5960631bb1ef279


[ROCm/rocprofiler commit: 95241eef3b]
2024-05-13 14:42:14 -04:00
Ammar ELWazir 5c2f899ff2 SWDEV-415888: fixing issues with rocprof tool duplication for testing
Change-Id: I9168029cfc9519879bd024286ca6e2d9842deb85


[ROCm/rocprofiler commit: 988bf4f93d]
2024-05-12 16:55:20 +00:00
Giovanni LB dcb561e3fe Reducing rocprofilerv2 memory usage
Change-Id: I13c2dec763818df38868593bba0223f01132bb7a


[ROCm/rocprofiler commit: 0fc74490cd]
2024-05-09 18:57:22 -04:00
Giovanni LB 0fc6fb9cf2 Fixing crash on [deprecated] file mode
Change-Id: I39b644429d19b185f278caa039a3180c2fa3ab7c


[ROCm/rocprofiler commit: 67faf92553]
2024-05-09 06:17:07 -03:00