Commit Graph

203 Commits

Author SHA1 Message Date
Ioannis Assiouras c4d2a2c557 SWDEV-374400, SWDEV-374404 - Change error message in hipFuncGetAttribute(s) to match nvidia.
Change-Id: I95b69a49ced24115f0aebc288ea067a49b770aca


[ROCm/clr commit: 97c5f772c6]
2022-12-20 12:49:17 -05:00
pghafari 23b51242fd SWDEV-369575, SWDEV-369568, SWDEV-369574 - matching
matching cuda return value

hipModuleLaunchKernel and hipExtModuleLaunchKernel matching with cuda in
negative cases

Change-Id: I636070924c81116dccbfa74f693061c60530de45


[ROCm/clr commit: 3b143cf3a2]
2022-12-20 12:24:23 -05:00
pghafari 7190c59c65 SWDEV-369576, SWDEV-369578, SWDEV-369577, SWDEV-369579, SWDEV-369563 - matching cuda return value
SWDEV-369576, SWDEV-369578, SWDEV-369579, SWDEV-369563 - matching cuda return value

Change-Id: I21b598e959571979307238c485492eb7fe2388cc


[ROCm/clr commit: c0f779fdf1]
2022-12-16 01:12:49 -05:00
pghafari c4fc6ea3ab SWDEV-369566, SWDEV-369565, SWDEV-369564 - match with cuda return
Change-Id: I308f5344a64e5a06aa89685de9348f6722c196da


[ROCm/clr commit: 698f52acd8]
2022-12-12 09:53:18 -05:00
Ioannis Assiouras 1ac4a6e0c3 SWDEV-369572 - Check for valid stream before capture
Change-Id: I712ce136327ad459a048d84d1caeec506ed1cc39


[ROCm/clr commit: 6847427dd4]
2022-12-05 22:09:07 +00:00
Rakesh Roy 9ec5dee45c SWDEV-368881 - Revert enable hipLaunchCooperativeKernel for hipRTC compiled function
This reverts commit f870f04dd9.

Reason for revert: Doesn't match with CUDA behavior

Change-Id: I413f3d241f864c1e7c21681c5fff8f216ef54306


[ROCm/clr commit: 4f5d180ca7]
2022-11-30 03:58:29 -05:00
Rakesh Roy f870f04dd9 SWDEV-368881 - Enable hipLaunchCooperativeKernel for hipRTC compiled function
- Add helper function to validate whether a dynamic function is present or not
- If getStatFunc fails, then check whether the function passed is a valid dynamic function

Change-Id: I4141172f42dce7ff689709560c483e602b5dad4b


[ROCm/clr commit: b4d8586a11]
2022-11-29 00:35:43 -05:00
Satyanvesh Dittakavi d73204ebc4 SWDEV-363369 - Elapsed time needs only stop event timings if both start and stop events are recorded
Change-Id: I91c9ce79aacf1014ae77600d1250cfccd9dd6039


[ROCm/clr commit: 30d6497953]
2022-11-09 00:31:06 -05:00
Anusha GodavarthySurya 3d97da8522 SWDEV-356314 - Init managed vars on device kernel is launched
Change-Id: I9c30b7d0e2a490dbb2bd9c02dccaae17d76874ef


[ROCm/clr commit: 0a3e89c0cb]
2022-10-11 00:18:30 -04:00
Saleel Kudchadker ad9557a00b SWDEV-301667 - Pass all params to API Init
- Correct return for ihipLaunchKernel

Change-Id: I66e81fa635473e6e728936e4cfba9f1bc7f018ad


[ROCm/clr commit: df278887fe]
2022-09-15 22:20:02 -07:00
Anusha Godavarthy Surya ed2f9051fa SWDEV-354717 - Add support for hipExtLaunchKernel as part of stream capture
Change-Id: I22708923f454a0f4456ff99d25559daffe08c208


[ROCm/clr commit: 2b322a9087]
2022-09-01 05:02:20 +00:00
Anusha Godavarthy Surya 67706897e0 SWDEV-352951 - Add capture support for hipModuleLaunchKernel
Change-Id: Iced0846c9f753ecbb87e3f7aec2bfd72137d8c00


[ROCm/clr commit: c72942964d]
2022-08-31 22:15:02 -04:00
Anusha Godavarthy Surya 0e1f53bf87 SWDEV-350474 - Added hipExtModuleLaunchKernel API support as part of stream capture
Change-Id: I90a880ae0d3a85a0cc8380d2cb21e4759ea8151b


[ROCm/clr commit: 0d6e8e378e]
2022-08-24 11:20:22 -04:00
Ajay 7e7576a849 SWDEV-348678 - hipManagedVar to initialize on all devices
Change-Id: Id714b56e89e4930ee067f3a7472a0029057d2711


[ROCm/clr commit: b380a95597]
2022-08-10 16:54:19 +00:00
Sourabh Betigeri 5d26e66ed7 SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3


[ROCm/clr commit: 5549c8cd1b]
2022-06-14 18:06:21 -04:00
sdashmiz 9be23b6b1f SWDEV-334857 - hipModuleGetTexRef compatibilty issue
- make the defualt texref value compatible with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2ae980e435f3b0fc15b237741e3f2b97c4257e12


[ROCm/clr commit: 8d93ff521f]
2022-06-10 15:13:29 -04:00
kjayapra-amd 9bc0d08679 SWDEV-290384 - Add Linker API support in hiprtc
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0


[ROCm/clr commit: 84f94fd134]
2022-05-24 09:16:14 -04:00
Sarbojit Sarkar e22f2e1714 SWDEV-323441 - support for default stream per thread
Change-Id: I0032da0357f5cffbf5e4ec4a02435d2a128a262b


[ROCm/clr commit: fc1f02bbed]
2022-04-18 23:19:55 -04:00
Sarbojit Sarkar bb53dfb244 SWDEV-325799 - Fix segfault with hipStreamPerThread
Change-Id: Ie6d4bf55131d65590234796443373b968a21b3d2


[ROCm/clr commit: 53b4888113]
2022-03-07 06:19:05 -05:00
Saleel Kudchadker 8139cc4683 SWDEV-301667 - Fix build warnings
Change-Id: Ice23b3d1a19a7958ca5c3caff34db2934b361a98


[ROCm/clr commit: 086aee0fcb]
2022-03-02 20:49:18 -05:00
Satyanvesh Dittakavi 51f8fc06e1 SWDEV-306940 - Fix hipamd errors/warnings found by CppCheck
Change-Id: Ia93d4f5262ea4269d8031edbfd27033b887e5300


[ROCm/clr commit: 6e562f4d83]
2022-02-05 08:42:47 -05:00
Sarbojit Sarkar 8f0c0822ad SWDEV-313905 - Fix segfault
Change-Id: I7b7bbe80a169014b5d4a8de134351b9f8bf11735


[ROCm/clr commit: 017603703b]
2022-01-11 23:40:25 -05:00
Tao Sang 68c75c9fb7 SWDEV-303204 - Disable texture/image Apis on some devices
If the target device doesn't support image,
compiler will send out unavailable error if device texture apis
are called; and host texture apis will return hipErrorNotSupported.
Remove useless include/hip/amd_detail/texture_functions.h.
Add hipDeviceAttributeImageSupport attribute to check image
support in runtime.
Add __HIP_NO_IMAGE_SUPPORT(=1) macro in device code to indicate
texture apis not supported.
Change-Id: Ia891493e681a61980a2444859a90e046a9ebea39


[ROCm/clr commit: 5acc8b5102]
2021-12-04 08:14:08 -05:00
anusha GodavarthySurya 81fa107364 SWDEV-307915 - hipHccModuleLaunchKernel correct event timing
Change-Id: I397a3d6cf0cf8639666befb9ed7a357c6753741c


[ROCm/clr commit: 8d30df5ccf]
2021-10-25 21:46:46 -07:00
German Andryeyev cfed4577c0 SWDEV-303567 - Correct events for hipHccModuleLaunchKernel
Start event should be collected before the kernel launch.
End event can use the command from the kernel launch.

Change-Id: I5413c340280be680b15a44daa0c69b21ed314213


[ROCm/clr commit: 981508b2af]
2021-10-25 16:56:37 -04:00
anusha GodavarthySurya 20e5aace05 SWDEV-24806 - Added support for event wait and event record graph APIs
hip graph implementation for APIs AddEventRecordNode, AddEventWaitNode, EventRecordNodeGetEvent, EventWaitNodeGetEvent, EventRecordNodeSetEvent,EventWaitNodeSetEvent, ExecEventRecordNodeSetEvent, ExecEventWaitNodeSetEvent

Change-Id: Ifde51f4591067795d6cbf5595372cbdbd8a7bc26


[ROCm/clr commit: f6456c5e27]
2021-10-06 00:31:42 -07:00
Laurent Morichetti cb2eaff241 SWDEV-252801 - Fix return HIP_RETURN(x)
HIP_RETURN(x) is not a value, it is a statement ending with a return,
this commit replaces all instances of "return HIP_RETURN(x)" with simply
"HIP_RETURN(x)"

Change-Id: I03293b2684a65367ff55e02b3a71ea49ec7a517a


[ROCm/clr commit: 3911184607]
2021-09-09 12:19:41 -07:00
Julia Jiang 6883ccde42 SWDEV-286322 - Remove execution permission
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad


[ROCm/clr commit: 8835b897d5]
2021-08-05 14:04:06 -04:00
Tao Sang 46737b278a SWDEV-294596 - Make hipModuleGetGlobal match cuda
Make hipModuleGetGlobal match cuModuleGetGlobal behavour.
That is, if one of the first two parameters is nullptr, ignore it.

Change-Id: I3fe6dbc35a7b14aa9119df297b7885df83d28048


[ROCm/clr commit: b58355b065]
2021-07-23 23:06:56 -04:00
agunashe fae697b4d6 SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/clr commit: d9d9e81acb]
2021-07-09 12:08:39 -04:00
Rahul Garg dd95d3d23c ROCMOPS-1956 - Push restructured code to hipamd
hipamd will have AMD's ROCCLR based HIP backend implementation

Change-Id: Id7de9634519b4ce46fca71a1b61f3d5b1e3fc459


[ROCm/clr commit: 19c84bc604]
2021-06-07 21:42:44 +00:00
Tao Sang 6227f3fae2 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd


[ROCm/clr commit: 1cba7ec965]
2020-12-09 15:49:47 -05:00
Todd tiantuo Li 49910cc949 SWDEV-240803 - add hipFuncSetSharedMemConfig
Change-Id: I160b04677b3e7b99b3981ae7ecc84a0e3811d5e8


[ROCm/clr commit: a243a69e98]
2020-08-20 18:18:24 -04:00
Todd tiantuo Li 4885fa0e48 SWDEV-240803 - add hipFuncSetAttribute and hipFuncAttribute
Change-Id: I3f4d67b19d89fd348fa5b884af4a2542ee4aba60


[ROCm/clr commit: fb43f21044]
2020-08-14 17:39:29 -04:00
Jatin 216873e9c8 Adding changes for hipExtLaunchKernel for rocCLR
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b


[ROCm/clr commit: 126573df4c]
2020-06-02 14:16:41 -04:00
Maneesh Gupta 11fe5b06de Merge in the rocclr based hip runtime (#2032)
* Merge master-next changes in master (include vdi development in master branch)



[ROCm/clr commit: f2e1118d7a]
2020-04-23 09:12:06 -07:00
Aryan Salmanpour 2d45fcc1b4 [HIP] add support for NoPreSync/NoPostSync flags for Cooperative MultiDevice launch API (#1990)
[ROCm/clr commit: 4d05b4dce7]
2020-04-13 14:02:52 +05:30
Rahul Garg 63332172d6 Rename hipDrvOccupancy to hipModuleOccupancy and match CUDA syntax (#1943)
[ROCm/clr commit: 69e09a0b1b]
2020-04-07 14:02:52 +05:30
Rahul Garg 76f7af0dda use hsa_executable_get_symbol_by_name in find_kernel_by_name (#1994)
[ROCm/clr commit: f7751db2ee]
2020-04-06 15:39:30 +05:30
Rahul Garg ef7397ae35 Bump version to 3.5 (#1993)
* Switch CI testing from rocm-3.1.x to rocm-3.3.x
* Update hcc workweek for cooperative view
* bump version to 3.5

[ROCm/clr commit: c09c4cd239]
2020-04-06 15:39:10 +05:30
Jatin Chaudhary f2ea243fa5 Removing header size from formula (#1988)
Fixed a bug in the elf file size computation.

[ROCm/clr commit: eab81ca91b]
2020-04-06 15:37:07 +05:30
Siu Chi Chan 922219117b don't expose symbols from code_object_bundle (#1971)
Change-Id: I56479485aad42c3d517fe6d9055be1cd846eeb00

[ROCm/clr commit: 6ab1e864b6]
2020-03-27 14:09:07 +05:30
Sarbojit2019 4ef95f4e73 Fix few memory leaks in HIP (#1969)
[ROCm/clr commit: 4a68ab5a8c]
2020-03-27 14:08:30 +05:30
Aryan Salmanpour 89d0d9761a [hip] fix a build error when building hip with latest hcc (#1977)
there is a build error when building HIP with latest HCC from GitHub after PR#1935 merged into HIP master branch. this PR changed blockDimX to blockDim and two lines missed this change where added in the current PR.

[ROCm/clr commit: 1a1cdee6ff]
2020-03-26 17:10:42 +05:30
Joseph Greathouse 8ce72c7f06 Fix cooperative launch APIs to set hipGetLastError (#1935)
* Fix cooperative launch APIs to set hipGetLastError

Previously, the cooperative launch APIs did not properly log their
errors in the global hipGetLastError variable before returning back
to the user. As such, the APIs would leave hipSuccess in the
last error, which would break some use cases.

This fixes that problem by making a trampoline function that does
the HIP_INIT_API and ihipLogStatus.

* Add missing flag to the log of multi-GPU launch

[ROCm/clr commit: 341ef7fdca]
2020-03-25 14:39:24 -07:00
Aryan Salmanpour 1c8dc380bc [HIP] use markers to sync cooperative and normal queues (#1948)
[ROCm/clr commit: 66735bff13]
2020-03-18 11:20:43 +05:30
jglaser 76759ae09f Implement accurate max block size in hipFuncGetAttributes() (#1676)
This PR takes ensures that the maxThreadsPerBlock returned by hipFuncGetAttributes is both a multiple of the warp size and that the register usage of the maximum block does not exceed the number of available registers.

Fixes #1662

[ROCm/clr commit: ea28d64297]
2020-03-18 11:20:06 +05:30
Joseph Greathouse 04ead59f0b Fix errors in occupancy calculation function (#1926)
Fix two errors in hipOccupancyMaxActiveBlocksPerMultiprocessor.
1) Fix a possible segfault if the user passed in a null pointer for
   the numBlocks value.
2) Handle the situation when the user is asking for a block size
   that is larger than what the target device can hold within a
   single block.

[ROCm/clr commit: 6ae1b1a321]
2020-03-17 14:00:38 +05:30
Aryan Salmanpour cb8cf51d3f [HIP] return an error if blockDim exceeds maxThreadsPerBlock
[ROCm/clr commit: 70ef268add]
2020-03-10 15:26:53 -04:00
Aryan Salmanpour d011efb792 [HIP] fix formatting/code clean up and fix a bug
[ROCm/clr commit: 7009901fe0]
2020-03-09 16:03:59 -04:00