Rework of roofline binaries generated from rocm-amdgpu-bench
- removed arch identifier in bin name
- removed rocm5 bins altogether
Updated required distros for roofline
- updated distro checks and bin naming
- moved up ubuntu20.04->22.04 and sles15.3->15.6 per rocm support
Enabled ctests for mi350 for test_roof_*
- removed mi350 series check to skip these specific tests
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: 41e73650d5]
* Add test for 9fx942 number of xcds.
* Improve the structure of mi gpu specs, add num_xcds_spec_class test.
* Add to ctest.
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
[ROCm/rocprofiler-compute commit: 85bfa73e2c]
Profile mode:
Fix roofline plots for datatypes that have peakVALU only. Check for highest roofline to plot the bandwidth lines to proper height, don't rely on existence of peakMFMA for every datatype.
Analyze mode:
Add roofline-data-type option for viewing pdfs in standalone gui. Default is same as profile mode, FP32.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: c45e20f325]
* Add MI 350 hardware information
* Refactor MI GPU YAML file and corresponding interface
* Add SoC file for gfx950 architecture
* Add analysis report configs for MI 350 containing existing metrics
* Add placeholder None valued metrics for previous architectures to make
baseline comparison work
* Enable testing on MI 350
* Analysis config metric changes
- SPI changes
- Update metric formula for default SPI pipe counter
- Use efficiently collected pipe wise SPI counters
- Add SPI Wave Occupancy
- Add Scheduler-Pipe Wave Utilization
- Update formula for VGPR Writes
- Add Scheduler-Pipe FIFO Full Rate
- CPC changes
- Add CPC SYNC FIFO Full Rate
- Add CPC CANE Stall Rate
- Add CPC ADC Utilization
- SQ changes
- Add VALU co-issue efficiency
- Add F6F4 datatype metrics
- Update formula for total FLOPs by adding F6F4 counters
- Add LDS STORE / LOAD / ATOMIC metrics
- Add LDS STORE / LOAD / ATOMIC bandwidth
- Add LDS FIFO and TA ADDR / CMD / DATA FIFO full rates
* Collect TCP_TCP_LATENCY_sum only for gfx950 (MI 350)
* Do not inject SQ_ACCUM_PREV_HIRES unnecesarily
* Do not hardcode memory and shader clock speeds
* Write num_hbm_channels to sysinfo.csv instead of hbm_bw while profiling
* Move generate sysinfo.csv to pre processing step of profiling
* Add warnings to use --specs-correction for missing sysinfo.csv values during analysis phase
* Update CHANGELOG
* Analysis phase warning to use --specs-correction when needed
[ROCm/rocprofiler-compute commit: f9aa7be97c]
Rebuild of rocm-amdgpu-bench roofline binaries for MI200/MI300 systems with rocm6.
Added datatype options to roofline feature.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: 6cb5bcdbe9]
* Move console logging to logger function to avoid circular dependency in utils module
Signed-off-by: coleramos425 <colramos@amd.com>
* Apply python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
* Remove the default StreamHandler before adding the custom
If you are not explicitly removing this default handler, it could be causing duplicate outputs.
Signed-off-by: coleramos425 <colramos@amd.com>
* Fix lingering bugs from merge conflict resolution
Signed-off-by: coleramos425 <colramos@amd.com>
* Comply to python formatting and update pre-commit hook helper
Signed-off-by: coleramos425 <colramos@amd.com>
* Removing redundant console_log call as the get_mi300_num_xcds() call, otherwise ALL Mi200 profiling runs will print this message
Signed-off-by: coleramos425 <colramos@amd.com>
---------
Signed-off-by: coleramos425 <colramos@amd.com>
[ROCm/rocprofiler-compute commit: 04f92b72a9]
Added command line option to specify which datatype(s) to capture into the roofline PDF(s).
All datatypes are still collected by roofline call if applicable, but only specific datatypes are plotted into PDF outputs. Will dump out all datatypes into one graph, but separate FP from Int into two graphs if needed. Will skip datatype and give error message if the datatype is not valid on a particular gpu arch.
Default is FP32
Reworked roofline calls and plotting to be general enough such that any new datatypes added into rocm-amdgpu-bench can easily be reflected in rocprof-compute with simple modifications in roofline_calc.py.
Adjusted ctest to reflect expected default pdf outputs from roofline.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: a492e92034]
* Delete static pmc files
* Counter parsing changes
- Move counter parsing logic to another function
- Fix counter parsing regex
- Log list of counters being collected
* Sanity check counters supported by rocprof
- Emit warning instead of error since rocprof support counters
list might be inaccurate
* Do not collect these counters
- TCP_TCP_LATENCY_sum (except for gfx908 and gfx90a)
- SQC_DCACHE_INFLIGHT_LEVEL
* Update logic of writing TCC channel counter definition yaml file
* Fix bug in capture_subprocess_output() utility function
- Make logging optional in capture_subprocess_output()
* Fix formatting and tests
* Update changelong
[ROCm/rocprofiler-compute commit: 58cf702d40]
* Clean up unused functions.
* Fix number of XCDs for MI300X CPX (core partition).
* Add support for memory partition mode.
* Modify total_xcd to adapt to all gpu models.
* Run black and isort.
* Make gpu_arch regex more generic.
* Add error checking for compute partition mode num xcds.
* Set gpu_chip_id as optional.
* Fix get_gpu_model.
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
[ROCm/rocprofiler-compute commit: 2e7f82aa13]
* rocprofv3 might not collect any counters for MI 100, handle this case gracefully to prevent test failures
[ROCm/rocprofiler-compute commit: 64ccd588de]
Set locale to C.utf8 instead of en_US.UTF-8
Avoid forcing the user to use en_US.UTF-8. Most Linux systems have C.utf8.
[ROCm/rocprofiler-compute commit: 96a25e8cbc]
Added debug log for when no flops are recorded (total_flops is 0), so AI points will not be plotted.
Removed commented out print statement that is not functional- contains nonexistent method call.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: 1c237c1382]
* Analysis report block based filtering for profiling
* Profiling mode changes
- `-b` option now additionally accepts metric id(s), similar to `-b` option in analyze mode (e.g. 6, 6.2, 6.23)
- Only counters mentioned in the selected analysis report blocks will be collected
- Add parsing logic to identify hardware counters from analysis report blocks
- Add filtering logic to only write filtered counters in perfmon files
- Log not collected counters in one line
- `--list-metrics` option added in profile mode to list possible metric id(s) similar to analyze mode
- Write arguments provided during profiling in profiling_configuration.yaml file
* Analysis mode changes
- During analysis mode, only show report blocks selected during profiling
- If `-b` option is provided in analysis mode, then follow provided filters
- Do not show empty tables in analysis report
* Miscellaneous changes
- Update CHANGELOG
- Add test cases
- Instruction mix report block filter
- Instruction mix and Memory chart report block filter
- Instruction mix report block filter and CPC hardware block filter
- TA hardware block filter
- --list-metrics in profile mode should work
- Move binary handler fixtures to conftest.py to avoid importing
fixtures
- cmake file in tests directory has been updated to compile sample/vmem.hip for testing
* Public documentation changes
- Use the term "Hardware report block" instead of "Hardware block"
- Add documentation for "--list-metrics" option in profile mode
- Add example of filtering by hardware report block such as instruction
mix and wavefront launch statistics
- Add deprecation warning for hardware component (sq, tcc) based filtering
[ROCm/rocprofiler-compute commit: 55cf0e237e]
Adding FP8 datatype to roofline feature in rocprof-compute on MI300-based systems.
FP8 now shows in terminal output and roofline csv, and outputs a standalone PDF.
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
[ROCm/rocprofiler-compute commit: 848fa1dc18]
* Create VERSION.sha file while creating standalone binary
* Do not fail on VERSION.sha not found
* Add git to docker container for testing
[ROCm/rocprofiler-compute commit: 19a9365bb9]
* initial hack to fix for v3 stucking on mi100 becasue of -m parameter and missing counter csv file
* proper formating
* refactored profiler option function to take soc arch
* resolve missing step that casued error for profiler option
* fix typo of arch name
* change method of putting soc info into profiler option
* isort and black format
* add comment for the part that handles missing counter csv file
* remove unncecessary import
---------
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
[ROCm/rocprofiler-compute commit: 5ee37b3353]
* External CI: rename pipeline to rocprofiler-compute (#463)
Signed-off-by: Daniel Su <danielsu@amd.com>
* Update webui branding (#459)
* Update name and icon for browser tab to rocprofiler-compute.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Update name and icon for browser tab to rocprofiler-compute.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Update branding in documentation (#442)
* find/replace Omniperf to ROCm Compute Profiler
Signed-off-by: Peter Park <peter.park@amd.com>
* update name in Sphinx conf
Signed-off-by: Peter Park <peter.park@amd.com>
* mv what-is-omniperf.rst -> what-is-rocprof-compute.rst
Signed-off-by: Peter Park <peter.park@amd.com>
* update Tutorials section
Signed-off-by: Peter Park <peter.park@amd.com>
* add Omniperf as keyword to Conceptual section for internal search
Signed-off-by: Peter Park <peter.park@amd.com>
* update Reference section
Signed-off-by: Peter Park <peter.park@amd.com>
* black fmt conf.py
Signed-off-by: Peter Park <peter.park@amd.com>
* update profile mode and basic usage subsections
Signed-off-by: Peter Park <peter.park@amd.com>
* update how to use analyze mode subsection
Signed-off-by: Peter Park <peter.park@amd.com>
* update install section
Signed-off-by: Peter Park <peter.park@amd.com>
* fix sphinx warnings
Signed-off-by: Peter Park <peter.park@amd.com>
* fix cmd line examples in profile/mode.rst
Signed-off-by: Peter Park <peter.park@amd.com>
* update install decision tree image
Signed-off-by: Peter Park <peter.park@amd.com>
* fix TOC and index
Signed-off-by: Peter Park <peter.park@amd.com>
fix weird wording
* fix cli text: deriving rocprofiler-compute metrics...
Signed-off-by: Peter Park <peter.park@amd.com>
* update standalone-gui.rst
Signed-off-by: Peter Park <peter.park@amd.com>
* restore removed doc updates from #428
Signed-off-by: Peter Park <peter.park@amd.com>
* update ref to Omniperf in index.rst
Signed-off-by: Peter Park <peter.park@amd.com>
* fix grafana connection name to match image
Signed-off-by: Peter Park <peter.park@amd.com>
* update cmds in tutorials
Signed-off-by: Peter Park <peter.park@amd.com>
---------
Signed-off-by: Peter Park <peter.park@amd.com>
* MI300 roofline enablement in rocprofiler-compute (#470)
* MI300 roofline enablement in rocprofiler-compute
requirements.txt
- running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x
pmc_roof_perf.txt
- adding TCC_BUBBLE_sum counter to profile
soc_gfx940.py
soc_gfx941.py
soc_gfx942.py
- remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing
roofline_calc.py
- add mi300 to supported soc
- add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use
- add to a few comments
roofline-ubuntu-20_04-mi300-rocm6
- binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench
Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch.
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
* Reformatting roofline_calc.py
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
---------
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
* Update Python format checker (#471)
* Add pre commit hook for Python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
* Update formatting workflow to run on latest Python and add isort formatter
Signed-off-by: coleramos425 <colramos@amd.com>
* Fix caught yaml formatting issues
* Update pyproject file
* Add pre-commit hook instruction to CONTRIBUTING guide
* Remove target-version from black pyproject.toml
* Fixed formatting errors found with black and isort
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* Run hook: Whitespaces, fix end of file spaces
---------
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
* Bump cryptography from 43.0.0 to 43.0.1 in /docs/sphinx (#473)
Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.0 to 43.0.1.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/43.0.0...43.0.1)
---
updated-dependencies:
- dependency-name: cryptography
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix file permission on MI300 roofline binary (#477)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* Removing numpy requirements of <2 (#478)
Checks are failing if version too high and no need for lower version
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Fix crash when loading web UI roofline for gfx942 (#479)
* Fix crash when loading web UI roofline for gfx942
* Fix formatting
Signed-off-by: benrichard-amd <ben.richard@amd.com>
* Make same changs for gfx940, gfx942.
Signed-off-by: benrichard-amd <ben.richard@amd.com>
* Fix formatting in soc_gfx940 and soc_gfx941.
Signed-off-by: benrichard-amd <ben.richard@amd.com>
---------
Signed-off-by: benrichard-amd <ben.richard@amd.com>
* Rebranding name change patch (#469)
* Patch in missed name change for rebranding.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Patch in missed name change for rebranding.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Move dependabot.yml to .github/ and bump rocm-docs-core (#481)
* Move dependabot.yml to .github/
* Bump rocm-docs-core to 1.8.5
* Bump rocm-docs-core to 1.9.0
* Fix packaging for upgrading (#486)
Specify that "rocprofiler-compute" replaces / obsoletes the "omniperf" package.
* Renamed extension path from omniperf to rocprofiler_compute (#487)
Signed-off-by: Tim Gu <Tim.Gu@amd.com>
* MI300 rhel and sles roofline binaries (#480)
* Roofline bins for MI300 on rhel and sles distributions
Built from rocm-amdgpu-bench, tested on respective distro systems with MI300 hardware.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Minor modifications removing hardcoded variables in roofline files.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Modify test_profile_general.py ctest to include MI300 enablement (#498)
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* part 1 to support rocprofv3 (#492)
* rocprofv3 support initial commit
-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.
* Add rocprofv3 detection so v2 can still be used
It's hacky but it'll do for now.
* Add code path to convert rocprofv3 JSON output into CSV
* Grab correct value for Queue ID
* Use _sum suffix to sum TCC counters
Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.
* Fix incorrect counter outputs when using rocprofv3
In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.
* Remove duplicate Correlation_ID and Wave_Size in output
* Handle json output that does not contain any dispatches
Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.
* Code cleanup
* Update search path for rocprofv3 results
Rocprofv3 was updated to include the hostname in the path where
it outputs results.
* Handle accumulate counters
In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.
To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.
* Use correct GPU ID
When converting JSON -> CSV we were assigning node_id to GPU_ID. Since
the JSON contains non-GPU devices, the node_id for GPUs might not
start at 0 as expected.
This commit maps the agent ID to the appropriate GPU ID.
* Parse scratch memory per work item from JSON
* Support rocprofv3 CSV parsing
JSON decoding is very slow for large files. Include support for parsing
rocprofv3 CSV output and make that the default.
CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment
variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json
* black format after merge
* format isort
* change return of rocprof_cmd to try to resolve test's error
* hack to pick last part of rocminfo's name
* debug log of hacks
* Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* black and isort formated
* corrected line of copyright
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com>
* fix for crash of timestamp of part 1 for rocprofv3 (#499)
* fix the error caused by ignoring the lack of counter csv file from rocprofv3 for timestamp
* isort and black formated
* quick fix for gfx906 roofline (#505)
* Multi node support (#503)
* [CTest] Pipeline failures for MI300 (#483)
* Propagate new chip_id logic to testing workflow
Signed-off-by: coleramos425 <colramos@amd.com>
* Add a debug line to tests
Signed-off-by: coleramos425 <colramos@amd.com>
* Trying to set rocprofv2 generally in CTest module
Signed-off-by: coleramos425 <colramos@amd.com>
* Remove temp debugging lines from CI
Signed-off-by: coleramos425 <colramos@amd.com>
* Add roofline entry for MI300 expected files in CI tests
Signed-off-by: coleramos425 <colramos@amd.com>
* Make num_devices modifier global in scope
Signed-off-by: coleramos425 <colramos@amd.com>
* Change kernel name in PyTest to confirm rocprofv2 bug
Related to https://ontrack-internal.amd.com/browse/SWDEV-503453
Signed-off-by: coleramos425 <colramos@amd.com>
---------
Signed-off-by: coleramos425 <colramos@amd.com>
* Spatial-multiplexing: part 1 profiling stage (#465)
* rocprofv3 support initial commit
-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.
* Add rocprofv3 detection so v2 can still be used
It's hacky but it'll do for now.
* Add code path to convert rocprofv3 JSON output into CSV
* Grab correct value for Queue ID
* Use _sum suffix to sum TCC counters
Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.
* Fix incorrect counter outputs when using rocprofv3
In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.
* Remove duplicate Correlation_ID and Wave_Size in output
* Handle json output that does not contain any dispatches
Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.
* Code cleanup
* Update search path for rocprofv3 results
Rocprofv3 was updated to include the hostname in the path where
it outputs results.
* Handle accumulate counters
In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.
To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.
* debug code
* add logic code for multiplexing
* minor fix
* more fixes
* rocprofv3 support initial commit
-Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity
is exceeded and the output CSV file format is different from v1/v2.
* Add rocprofv3 detection so v2 can still be used
It's hacky but it'll do for now.
* Add code path to convert rocprofv3 JSON output into CSV
* Grab correct value for Queue ID
* Use _sum suffix to sum TCC counters
Previously we were specifying each channel for TCC counters. rocprofv3 does
not support specifing each TCC channel, and instead will auto sum given
the TCC counter name. The counter name with the _sum suffix is also
supported and is also supported in v1 and v2. So we will use the TCC
counter name with the _sum suffix.
* Fix incorrect counter outputs when using rocprofv3
In the JSON output some counters appear multime times and must be
summed to get the correct value. These summed values match the
rocprofv3 output in CSV mode and also match the rocprofv2
output.
* Remove duplicate Correlation_ID and Wave_Size in output
* Handle json output that does not contain any dispatches
Omniperf was assuming each JSON output from rocprofv3 would always contain
dispatches. This is not the case. For example, in a multi-process
workload where one of the processes does not dispatch any kernels. A JSON
file will still be output for this process but it will not contain any dispatches.
* Code cleanup
* Update search path for rocprofv3 results
Rocprofv3 was updated to include the hostname in the path where
it outputs results.
* Handle accumulate counters
In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte
counters. v3 does not have this. So we need to define our own counters
in counter_defs.yaml. For this we use the counter name + _ACCUM, for
example SQ_INSTR_LEVEL_SMEM_ACCUM.
To use rocprofv3 you will need to update counter_defs.yaml to include
these new counter definitions.
* count accu files as well
* Use correct GPU ID
When converting JSON -> CSV we were assigning node_id to GPU_ID. Since
the JSON contains non-GPU devices, the node_id for GPUs might not
start at 0 as expected.
This commit maps the agent ID to the appropriate GPU ID.
* fix error with csv file parse from json and merge during post-processing
* implemented parsing of csv files from v3 output for optimization
* Parse scratch memory per work item from JSON
* Support rocprofv3 CSV parsing
JSON decoding is very slow for large files. Include support for parsing
rocprofv3 CSV output and make that the default.
CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment
variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json
* black format after merge
* format isort
* change return of rocprof_cmd to try to resolve test's error
* hack to pick last part of rocminfo's name
* debug log of hacks
* Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* black and isort formated
* formated by isort and black
* change default rocprof's output to csv
* repaired crash caused by missing csv counter file when running for timestamp
* change name to spatial-multiplexing from multiplexing
* make necessary modification for review
* set the value of spatial_multiplexing in argument defautly to None
* repair the part that blocks regular pmc files' generation
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Simple fix for gpu model value. (#508)
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add FP64 to plot adhering to pdf name (#507)
* Replacing FP32-only plot with an FP32&FP64 combo plot. Results will likely be negligible but the plot name indicates both should be graphed.
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Remove duplicate AI plot to clean up fp32 fp64 graph
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
---------
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Add gpu series for roofline (#510)
* Add gpu_series for roofline.
* Use gpu_series in path names for roofline.
* Fix TCC on MI200 when introduce rocprofv3 (#509)
* quick fix for v2
* one more fix
* revert a bit
---------
Co-authored-by: ywang103-amd <ywang103@amd.com>
* Bump rocm-docs-core from 1.9.0 to 1.12.0 in /docs/sphinx (#511)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.12.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.9.0...v1.12.0)
---
updated-dependencies:
- dependency-name: rocm-docs-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update sample roofline plot img (#516)
* Modify path to use gpu_model instead of gpu_series to match other workload directory path creation/search points. Affects manual testing, does not seem to affect ctests. (#513)
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
* Improve formatting when displaying rocprof command. (#476)
* Improve formatting when displaying rocprof command.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Fix python formatting.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Strip unwanted characters (rocprofv1 specific) from rocprof commands.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Strip unwanted characters (rocprofv1 specific) from rocprof commands.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Save the unmodified arguments for rocprof for debug message display.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
* quick fix for mpi_support (#518)
* Pass accumulate counters to rocprofv3 using -E option (#522)
rocprofv3 has a new -E option where extra counters can be passed (see accum_counters.yaml) instead
of defining them in counter_defs.yaml.
* Unify all file handling with pathlib (#512)
* Replace occurences of os.path functions with equivalent functions from
pathlib library
* Remove unwanted imports of os.path and os
* Add coding guidelines for using pathlib instead of os.path
* Auto sync staging and mainline on a weekly cadence (#517)
Signed-off-by: coleramos425 <colramos@amd.com>
---------
Signed-off-by: Daniel Su <danielsu@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: Peter Park <peter.park@amd.com>
Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com>
Signed-off-by: Tim Gu <Tim.Gu@amd.com>
Co-authored-by: Daniel Su <danielsu@amd.com>
Co-authored-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: Peter Park <peter.park@amd.com>
Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Richard <143630488+benrichard-amd@users.noreply.github.com>
Co-authored-by: Tim Gu <Tim.Gu@amd.com>
Co-authored-by: ywang103-amd <ywang103@amd.com>
Co-authored-by: benrichard-amd <ben.richard@amd.com>
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Co-authored-by: Fei Zheng <44449748+feizheng10@users.noreply.github.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>
[ROCm/rocprofiler-compute commit: 272e5b6e32]
* Update VERSION and README to 3.0.0
* Update version mismatch of profiling data to a warning.
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
[ROCm/rocprofiler-compute commit: 152eff0df1]
- Update filenames.
- Update executable to `rocprof-compute`
- Update update package to `rocprofiler-compute`
- Update name in application output and logs
- Update name in README files
- Update testing and workflows
---------
Signed-off-by: Xuan Chen <xuchen@amd.com>
[ROCm/rocprofiler-compute commit: 31b4de1a38]
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add support for MI300X_A1
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove MI308X identification using num CUs, and format Python using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add Read the Docs
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add sphinx requirement
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove gpu_model identification using gpu_arch
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Fix Python formatting using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
[ROCm/rocprofiler-compute commit: c48e6e31cf]
cfallows-amd
Daniel Su
xuchen-amd
ywang103-amd
vedithal-amd
Fei Zheng
Ben Richard
Cole Ramos
fei.zheng
David Galiffi