Commit Graph

1840 Commits

Author SHA1 Message Date
Ajay c9c3d951f2 SWDEV-421102 - make clr compatible with c++20
Change-Id: Ia692817232caa3ee97dc0b2139645a0474b582e1


[ROCm/clr commit: 2bae1b1387]
2023-09-18 11:28:29 -04:00
kjayapra-amd 22bc3d52a3 SWDEV-417244 - Create Unique File Desc Store and guarantee no duplicates fds are opened.
Change-Id: I7be7fee52b673f0b1b3facdfbd847b57f2a47cde


[ROCm/clr commit: 85b645731c]
2023-09-13 17:03:18 -04:00
Jaydeep Patel 5b450d5551 SWDEV-418038 - Drop GPU_ENABLE_WAVE32_MODE from RTC.
Change-Id: Iac11f26714e8b3bae14cbf69933ef7c8c8be47da


[ROCm/clr commit: a37c95d7ed]
2023-09-08 02:13:41 -04:00
Anusha GodavarthySurya f464a6ade6 SWDEV-301667 - Optimize performance when graph has single branch
Three for loops iterate over all graph nodes for UpdateStream, FillCommands and
EnqueueCommands has performance drop for large graphs.

Change-Id: I077accf3a4680d5d944b73200fd6498a7a48f25c


[ROCm/clr commit: 530dc6de2a]
2023-09-07 23:35:36 -04:00
Ioannis Assiouras a0ee7e2784 SWDEV-419996 - Allow both kernelParams and extra arguments to be set to null
When kernel function expects no parameters no error should be returned
if both kernelParams and extra arguments are set to null.

Change-Id: I5941bcc400b6fb380e623bdae0233ae3e4f73815


[ROCm/clr commit: 315082e554]
2023-09-07 12:57:46 -04:00
German 5d9912f48b SWDEV-407533 - [ABI Break]Remove Wavelimiter
Change-Id: I6a2f6fb5a0c3acea93fa0200a69679783e76f5bd


[ROCm/clr commit: 7be3a5e33e]
2023-09-07 09:58:41 -04:00
Ioannis Assiouras 0066c6cb6b SWDEV-420222 - Removed implementation of hipMemcpyArray functions
hipMemcpyArrayToArray, hipMemcpyFromArrayAsync, and hipMemcpyToArrayAsync
are deprecated in cuda and are missing the headers in hip_runtime_api.h.
Removed their implementation from hip_memory.cpp.

Change-Id: I9720aec6241515c56c66b7e90a37b2ed53347eb2


[ROCm/clr commit: 2bc6661737]
2023-09-04 13:35:08 +01:00
Rahul Garg 87bbe33acd SWDEV-418360 - Continue parsing modules even when some module don't have
right binaries built for current device

Change-Id: Icc6a4233fbcede9b2dc6feb78e6bfbd761684c7f


[ROCm/clr commit: c9cf3bdc16]
2023-08-31 14:54:59 -04:00
Ioannis Assiouras f28fa0277e SWDEV-415937 - Make _IMPORT_PREFIX in hip*targets.cmake point to a relative path
Change-Id: Ib0f4321f2954254d0486d741d057f182cb2481a7


[ROCm/clr commit: 209525d6e4]
2023-08-31 08:10:50 -04:00
kjayapra-amd 76cc68ff80 SWDEV-381625 - Parse compiler and linker options from environment variable.
Change-Id: Id5a012b678e5973c4b64dff84444a909aefae006


[ROCm/clr commit: 6a0f80a03d]
2023-08-29 20:24:27 -04:00
Jaydeep Patel 6258f8254f SWDEV-375596 - Device context should not be changed while graph exec update for graph nodes other than empty and host node.
Change-Id: I89d734b111aae5b042386175d2786ce9002771b9


[ROCm/clr commit: d2655d84fd]
2023-08-27 22:58:32 -04:00
Saleel Kudchadker d7a63b9d66 SWDEV-301667 - Port optimization to save extra packet to graphs
Change-Id: Ibaf64a4efe070c42620e6e153c1862a4a0b15664


[ROCm/clr commit: e1e5d071ba]
2023-08-23 16:58:21 -04:00
Satyanvesh Dittakavi bee336d360 SWDEV-416443 - hipPointerGetAttributes should return correct type for managed memory
Change-Id: Ic197cd8c9d3f5405616ed6e4924ed5577e636b94


[ROCm/clr commit: 84eae1f0a9]
2023-08-21 07:47:32 -04:00
Vikram 5588dc0583 SWDEV-417558 - Fix dynamic linker error caused by SWDEV-378651 fix
Seems the windows linker error seen with https://gerrit-git.amd.com/c/compute/ec/clr/+/886078
also exists for linux, but only appears with dynamic linker. This fixes both usecases.

Change-Id: I1bb6df151eb1e09f75af4d461ead28bcbaa5f236


[ROCm/clr commit: 62464ca4c3]
2023-08-18 02:21:14 -04:00
Anusha GodavarthySurya b25939b4de SWDEV-415772, SWDEV-414682 - Fix childgraph node execution
Change-Id: If9ffc08d98a57b8daa5f131f72ef1bf2317f29e1


[ROCm/clr commit: f76a40c26d]
2023-08-18 00:45:00 -04:00
Vikram 41ee2ee689 SWDEV-378651 - add proper wavefrontsize link time option to hipRTC, in accordance with env variable GPU_ENABLE_WAVE32_MODE
This is a copy of http://gerrit-git.amd.com/c/compute/ec/hipamd/+/841299
Raising this here again since hipamd repo is frozen.

Change-Id: I8722ef55f78a9176e131fd5766fb11101b51f1b5


[ROCm/clr commit: cec579c006]
2023-08-15 00:12:31 -04:00
taosang2 c4bc05f0d0 SWDEV-408843 - Fix vulkan_interop failure
Fix runtime issues found in  vulkan_interop test

Change-Id: I32c9bed861ddf4fe1d7bba21dce9bd720168c399


[ROCm/clr commit: d2cfb86ddc]
2023-08-11 10:13:56 -04:00
kjayapra-amd 73facd3425 SWDEV-416262 - Adding missing AMD headers on hip files.
Change-Id: I45531004e57c664df5ce4275a49f07ebbad08b7f


[ROCm/clr commit: f2c07d9bc2]
2023-08-11 10:00:23 -04:00
kjayapra-amd 6b628eca2e SWDEV-416218 - Set the image mapped flag correctly on COMGR path.
Change-Id: I6c0908731f10c8ff5b3e159c0cfb68ce096c7bdf


[ROCm/clr commit: d18f4b1ad4]
2023-08-10 15:52:30 -04:00
Satyanvesh Dittakavi c97dd090f0 SWDEV-415439 - Address segfault issues with hiprtcLinkCreate
Change-Id: I5c5898a9d0afadc344ae2fafc371e9ed647cec6e


[ROCm/clr commit: 8ee985a67b]
2023-08-10 08:28:11 -04:00
Jaydeep Patel 60e169c0a2 SWDEV-415421 - End is relative to start and so no need to offset.
Change-Id: Icd65227d9879d9ee4e0bd2795f112b4d5e8c8e9e


[ROCm/clr commit: 34d071c767]
2023-08-10 00:41:01 -04:00
Rakesh Roy b3e340eb5d SWDEV-415265 - Fix segfault when library isn't built with current GPU arch
- Return error code instead of segfault during kernel launch when library isn't built with current gpu arch
- Fix string print bug

Change-Id: I91aaa50150fee220317cd2eb4e075d825cc448b2


[ROCm/clr commit: 76c8b3157b]
2023-08-08 00:41:54 -04:00
Ioannis Assiouras 14f3d8bcd6 SWDEV-414194 - Make hip-lang available on nvidia platform
Change-Id: Ic0082d3960aadbb7ac559140b6e84bd29a75b5cb


[ROCm/clr commit: 97403db468]
2023-08-02 05:19:34 -04:00
Maneesh Gupta e45838a25c Revert "SWDEV-389530 - [ABI Break]Match error with cuda"
This reverts commit 2b78a9c443.

Change-Id: I07aac68c76b3bc42b595330fdbbb04646b35a814


[ROCm/clr commit: 76a4bd1d7f]
2023-07-31 21:41:54 -04:00
Maneesh Gupta 045ec1919e Revert "SWDEV-264166 - [ABI Break] goodbye gcnArch, hello gcnArchName"
This reverts commit 20add33513.

Change-Id: Ia7b9ca115be4f9591b195194eed967fc6c330012


[ROCm/clr commit: 8c89d16572]
2023-07-31 21:41:12 -04:00
Jaydeep Patel 5b51ca53f4 SWDEV-412993 - As origin is passed with start, region should be end.
Change-Id: I7077484d4d8c302fb2f2714cb68c15ba5173eae3


[ROCm/clr commit: a28a5a9a38]
2023-07-28 12:56:53 -04:00
Ioannis Assiouras b8b8ae323a SWDEV-404865 - Remove unused macro definitions from hip-lang-config.cmake
Change-Id: I726884d81b9cd83355f0f26306dca04256b82a4a


[ROCm/clr commit: 9b78869e64]
2023-07-28 12:27:53 -04:00
sdashmiz 2b78a9c443 SWDEV-389530 - [ABI Break]Match error with cuda
- match error for invalid params

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2faf1191f665d8bd06d6ba315f440e87b1a5b8ab


[ROCm/clr commit: c7d8557eee]
2023-07-26 20:32:41 -04:00
kjayapra-amd 5a35c345d1 SWDEV-408889 - Add the logging message back that will print devices without COs from Bundle.
Change-Id: Ie6f95d5e9bafe6c3db192419e4d8829053cc8b65


[ROCm/clr commit: 3a2615f5aa]
2023-07-26 17:47:52 -04:00
Anusha GodavarthySurya d8022cd081 SWDEV-407568 - Move graph implementation to hip namespace
Change-Id: I7023f202a7e3eb25b17db6d3e361205594ae81a5


[ROCm/clr commit: fd97dde1e6]
2023-07-26 06:52:45 +00:00
Jatin Chaudhary 20add33513 SWDEV-264166 - [ABI Break] goodbye gcnArch, hello gcnArchName
Change-Id: I4b31284243a801f92f0be9468c25db7d027d9a13


[ROCm/clr commit: f136a576f5]
2023-07-25 02:51:29 -04:00
Jatin Chaudhary dfc4d60ec4 SWDEV-412457 - remove unused header, add correct header for cpp
Change-Id: I2192daec7c033e94097c26db6177e14558a8728d


[ROCm/clr commit: b67d055eb6]
2023-07-21 11:30:59 -04:00
Ioannis Assiouras 62b3d8f59b SWDEV-412496 - treat USE_PROF_API to always be true
Change-Id: I77cfac409215a33d11228a0f2da9ffba63c3d73a


[ROCm/clr commit: cb7776ef07]
2023-07-21 04:42:57 -04:00
Jaydeep Patel 60a3077ed4 SWDEV-410751 - Consider null amd::memory is invalid.
Change-Id: I6f175f69e922cf5d7f8128c15754e1310419ccd9


[ROCm/clr commit: a9ff2c5a43]
2023-07-18 00:12:15 -04:00
Anusha GodavarthySurya 57467ef2c7 SWDEV-392732 - Initial commit for graph doorbell optimization(AQL Buffering)
Change-Id: I451725006c54c249dc530c55d2af2a31594bf49b


[ROCm/clr commit: b0e6f99ad7]
2023-07-16 07:56:00 -04:00
Ioannis Assiouras 922c988a8a SWDEV-411086 - Provide path ROCM_PATH/llvm via the HINT argument instead of PATH in calls to find_package
PATHS have lower priority than system paths so if there is a clang installation in /usr/local find_package(Clang)
will pick that instead. To fix this provide the llvm path via the HINTS argument instead.

Change-Id: I57794a9a5c5fc26f12c60798fbc8e826c1880e13


[ROCm/clr commit: 238b973a5a]
2023-07-14 04:46:44 -04:00
sdashmiz 4dd4970313 SWDEV-408586 - set device active when malloc is called
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ib930d997b7d544d8b6fb42d2fea01fa8a4418e98


[ROCm/clr commit: 173de06658]
2023-07-13 11:39:58 -04:00
Ioannis Assiouras 41381e9557 SWDEV-407818 - Fixed bug when opening LinkerFile fstream on windows
Change-Id: If6f083d9fa83066eb2b20ab24dceaa9df7a2f0a0


[ROCm/clr commit: 791cea44f1]
2023-07-07 13:25:04 -04:00
taosang2 828c7714e0 SWDEV-408687 - Prevent updating dstXInBytes/srcXInBytes twice
Update pCopy->srcMemoryType and pCopy->dstMemoryType so
 that ihipGetMemcpyParam3DCommand() won't redetect memory
 type. This will prevent dstXInBytes and srcXInBytes getting
 updated twice with offset in hipMemoryTypeUnified type.

Change-Id: Ief4ea81941e25d22bcafd213b3b84a65eb23cf94


[ROCm/clr commit: 56daa6c489]
2023-07-05 09:22:49 -04:00
Jaydeep Patel 621b266d71 SWDEV-401781 - Auto Clean removes from map so check before remove while submit mem alloc node command.
Change-Id: Id004f75b307c2c769dee556c3d18e781830bcae1


[ROCm/clr commit: a8164d3e12]
2023-06-29 02:29:01 -04:00
kjayapra-amd 8969a60e98 SWDEV-407691 - Always unmap file if HIP Runtime unbundler is used.
Change-Id: Ica15df31dfee3c495cf067a998e7e3b7c7397f40


[ROCm/clr commit: aa7c62db37]
2023-06-28 10:20:49 -04:00
sdashmiz f07e8cbc95 SWDEV-403382 - param sanity check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibddb2be7d0543676ed9aed71ebb3f5877662c9ae


[ROCm/clr commit: 5f93a59798]
2023-06-27 19:03:34 -04:00
sdashmiz 780ab907ca SWDEV-405485 - fix the error to match cuda
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ia03a50e437c8eb189bc6578170b5ef20b470541c


[ROCm/clr commit: 41bbdfca94]
2023-06-27 15:01:14 -04:00
ajay d124c2ff0c SWDEV-407292 - hip-lang for windows
Change-Id: Id64bbfc8d62796b4f158e53f48273a09c928c8cc


[ROCm/clr commit: 09345dc7a2]
2023-06-27 14:18:58 -04:00
Julia Jiang 78fe0ef04c SWDEV-390597 - NoGpuTst test of Catch2 fails with docker
Change-Id: Ibf65e0ec57d47357e0afd119200622e223850b1e


[ROCm/clr commit: a4cccd3b0e]
2023-06-26 10:21:57 -04:00
sdashmiz 6c174f79fa SWDEV-405485 - move the param validation
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ic3a27c47a88954da866a91494bcfb8721f33ad2b


[ROCm/clr commit: 2cdaf7e80f]
2023-06-22 23:33:48 -04:00
taosang2 9aa3a87b66 SWDEV-368553 – Add missing mipmap Apis
Add missing mipmap Apis’ implementation.
Fix some bugs of mimpmap apis.
Use hipmipmappedArray to differentiate cuda
and driver apis on Nvidia.
Change-Id: I6079d9f3b2ddf4e42b9a6f7f3902322cfca02cfd


[ROCm/clr commit: f03c11491b]
2023-06-22 17:24:21 -04:00
pghafari b01ca8b9c7 SWDEV-406821 - use int32 for grid y,z till rocm 6
Change-Id: If9eee4dd5553cc81e283cb2211cc69884808d5c1


[ROCm/clr commit: 9e08ecdd16]
2023-06-22 09:42:00 -04:00
Ioannis Assiouras a1c01b7d34 SWDEV-406894 - Fix segfault when access HIPRTC_JIT_LOG_VERBOSE from options buffer
Change-Id: I24143dfb726d9a71fdb17b03d5b5dd910b54f5bb


[ROCm/clr commit: 0af9788e32]
2023-06-22 00:53:29 -04:00
Saleel Kudchadker 60b9dc4a45 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203


[ROCm/clr commit: b2240bcda5]
2023-06-20 14:26:44 -04:00