AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,127 Commits 3 Branches 0 Tags
caf446fe536be7198e408e050ae7df75598beafd
Commit Graph

238 Commits

Author SHA1 Message Date
Ben Sander caf446fe53 Allow HIP_DB to be number or string flags (ie HIP_DB=api+mem+sync) 
Add callbacks for processing env vars.

Change-Id: I4ddf50e2da56b1dae43f50657bc693b07b23c03d
 2016-10-27 23:09:31 -05:00
Ben Sander 3132c36471 Add HIP_PROFILE_START_API, HIP_PROFILE_STOP_API 
Refactor HIP_INIT_API to call recordApiTrace.

Change-Id: Ieff4b5018236f59e49e1b9841474440a34f821df
 2016-10-27 23:09:31 -05:00
Ben Sander 45e2dd4d69 Add per-thread API seqnum to debug 
Change-Id: Ib13733a3e84cd56bae13a32bae40f936c20b7543
 2016-10-27 23:09:31 -05:00
Ben Sander 7d69e858a5 Improve HIP TID printing in debug mode. 
Map long thread-id to a short one that is printed with each message.
Remove clunky stirng creation code for tid_tr.
Print TID on every message.

Change-Id: I780a91d8ce789cb4957789036b478bf5cde8c4e4
 2016-10-27 23:09:31 -05:00
Aditya Atluri 8145e1b129 reverted change for cache size query 
Change-Id: I44a1f43818cd287a2a3b6265f43d183f9bd5b71c
 2016-10-25 11:03:35 -05:00
Aditya Atluri e28f65604b correct cachesize to output correct value 
Change-Id: I5db031591eb718b0c12e78a35e4b19349de9526d
 2016-10-25 09:33:45 -05:00
Ben Sander 714968cdc6 Fix P2P for async 
Also improve HIP debug message: Add more DB_COPY1 messages. memcpyStr,
expand HIP_DB bitmask.
 2016-10-20 10:02:23 -05:00
Ben Sander d4b23da91f Add HIP_WAIT_MODE env var. 
Also weaken cases where hipSetDeviceFlags returns hipErrorInvalidValue.

Change-Id: I7f113338be6fe498eaf1ab40fd0fd6b23849bb5e
 2016-10-18 22:27:16 -05:00
Ben Sander c7303d5924 Add hipDeviceSchedule* support to queue wait 
Change-Id: Iffa7a356500b026f3737c3f5719ca9f62b10d855
 2016-10-18 22:27:16 -05:00
Ben Sander 0787c41ac0 Remove some TODO items 
Change-Id: I7e9de2e43a8584f8dc9ee6d45c8ed00ca465f591
 2016-10-18 22:27:16 -05:00
Ben Sander 403cdf93c3 Move some internal headers from "include/hip/" to src. 
Change-Id: I7041bd5c803d9318979f4a7c1d658445c614691e
 2016-10-18 22:27:16 -05:00
Maneesh Gupta 88d6cad3fb src/*: Update copyright header 
Change-Id: I455f5d0d12fe9cb39a3ba873bd22b4c25ed07cbf
 2016-10-15 22:55:22 +05:30
Ben Sander aa3e04cf9a Cleanup files from code review. 
- Remove some stale code
- Update docs
- Correct define for __HIP_ARCH_HAS_GLOBAL_INT64_ATOMICS__

Change-Id: Ic5e3cdb8269b1c18f6d2693700b55e08c4d0080e
 2016-10-15 11:51:20 -05:00
Ben Sander dcadaadb24 Add code to use new HCC API accelerator_view::dispatch_hsa_kernel. 
Disabed by default, can enable with USE_DISPATCH_HSA_KERNEL=1

Change-Id: I7a6ba76f2bada34952ed47f5335ce695fa2faea5
 2016-10-14 23:46:29 -05:00
Ben Sander 45bc107ad0 Fix HIP_USE_PRODUCT_NAME detection. 
Change-Id: I6879ec3a11845bea66a18a9328bd4eaf54713420
 2016-10-13 11:51:53 -05:00
pensun 0ac70e7184 Add ifdef guard for the feature requires ROCm1.3 
Change-Id: I7154517c47000c37fe5eb09a3c1cf2a9aacbe27c
 2016-10-13 10:57:31 -05:00
Aditya Atluri e25a1e50b3 added constant memory property to 16KB 
Change-Id: If067b4057c2e3fc0c26cf4604a1d4fac7f139b12
 2016-10-13 10:47:40 -05:00
pensun 44cc44011b Change to query device name using HSA_AMD_AGENT_INFO_PRODUCT_NAME; 
Note: this commit depends on ROCR runtime in ROCm 1.3 release.

Change-Id: I90385ef6d11ee8a1e8adae1d3fdf21747347544c
 2016-10-12 20:01:30 -05:00
Aditya Atluri e5325a1ab4 Added hipDeviceGetLimit api 
1. hipDeviceGetLimit API for HCC path is added
2. Test for hipDeviceGetLimit API is added
3. The feature added only supports querying heap size
4. Corrected indents for malloc and free device functions
5. Removed redundant data structures
6. Added g_heap_malloc_size to store the heap size

Change-Id: If48d1b0ce9270e994f1c542cc283ddbb14746bbb
 2016-10-12 19:58:48 -05:00
Aditya Atluri 2918ff273d added malloc and free device functions 
1. Added malloc and free device functions
2. Added test which check malloc and free functions
TODO: Need to add support for multiple device. Works only on one device (multi device support id NOT available).

Change-Id: Id11fc36463915d6ad46c264d5a20c8feb2d2c17c
 2016-10-12 19:08:34 -05:00
Ben Sander 250f711ed0 Add DISABLE_COPY_EXT option. 2016-10-05 12:18:42 -05:00
Ben Sander 6950d3f9e9 Add HIP_BLOCKING_SYNC environment var to control stream sync behavior. 2016-10-05 12:18:42 -05:00
Maneesh Gupta bbfc08f419 Move include/* to include/hip/* 
Change-Id: I7a7b2839b4df59c7a4c503550f99fdc9e45c0f54
 2016-10-04 22:17:18 +05:30
Ben Sander 806e58ca63 Refactor asyncCopy and syncCopy to fix deadlock case. 
- Minimize time that locks are held.
- Eliminate copy code that locked stream and ctx at same time.
    - Stream was locked to ensure thread-safe enqueue to the queue.
    - Devices were locked to query peer-lists.

Change-Id: Ibe8880bb7fb995a3da8f90ff911f212d81525018
 2016-09-27 15:45:40 -05:00
Ben Sander 4fd4168796 Add debug option to print ThreadID with each message. 
Also print messages with single fprintf to prevents threads from
interleaving.

Change-Id: Ib3999fe6b1e67b4a16cd7dcde82f3dfc99dd48ff
 2016-09-27 15:45:40 -05:00
Ben Sander f6717e326e Fix signal resource issue. 
Remove memory leak with new hc::completion_future.
Implement HIP_LAUNCH_BLOCKING with queue-level wait.

Change-Id: I45975f81c4d239fdeed7776970988d28449865dc
 2016-09-26 16:47:32 -05:00
Ben Sander 944d4eaa18 Peer-to-Peer improvements. 
- Bug fix for peer visibility.  Now contexts correctly detect when they can use SDMA for P2P vs staging buffers.
- Interface to new HCC copy_ext function.
- Improve context and peer print /debug options.
- Add comments and usage to hipPeerToPeer_simple test.
 2016-09-22 14:21:19 -05:00
Ben Sander 926aefa930 Remove unpinned_copy code. Other cleanup. 
Change-Id: Ie3f71439cf1ba729ef223d078917c403d3de879a
 2016-09-22 14:21:19 -05:00
Ben Sander 5bc18c8603 Cleanup. Remove cfs, ihipSignal_t, staging buffer calls. 
Change-Id: I8bb67c484e3a65be06a03665f059217930da2bed
 2016-09-22 14:21:19 -05:00
Ben Sander 17e21309f1 Cleanup: Remove HIP signal pool. 
Change-Id: Icebfd0509d12396cc5933d5556d68b53e1be36e0
 2016-09-22 14:21:19 -05:00
Ben Sander c365785c5c Remove HIP command dependency tracking. 
Change-Id: I991c13bc5108193959ba70f9f6f9c692c9ad3a5b
 2016-09-22 14:21:19 -05:00
Ben Sander b0509c5a58 Cleanup, remove preCopyCommand. 
Change-Id: I3768d3789a99be8136b43179d4152fa1875665cb
 2016-09-22 14:21:19 -05:00
Ben Sander 3596901c3d Change HIP async copy to call av::copy_async. 
Change-Id: I4274b63ced3940d5249c32bd9d156296529c70e8
 2016-09-22 14:21:19 -05:00
Ben Sander 8598d8c6d3 Use HCC's synchronous accelerator_view::copy 
Replace large block of HIP code with a call to HCC av::copy().

Change-Id: Ic32e1801cf8d4cd116ac02b72c41b1a1e4b6065c
 2016-09-22 14:21:19 -05:00
Ben Sander 60f797cc5a Remove USE_AV_COPY, USE_PEER_TO_PEER fallback paths. 
Change-Id: I9c20173e62029c4caebabc98784c6d7697758e4f
 2016-09-22 14:21:19 -05:00
Ben Sander 39750da9a5 Remove HIP_STAGING_BUFFER 
Code simplification/cleanup:
Remove stale fallback paths that uses something besides the unpinned engine.
Remove HIP_STAGING_BUFFER env var - now is const 2, 0 no longer has
special meaning.

Change-Id: I7d24cdd1067dd0c244e87b6a83897cb135d307e7
 2016-09-22 14:21:18 -05:00
Ben Sander 17d7fc586e Move isLargeBar to UnpinnedCopyEngine constructor. 
Change-Id: I7a7d3a40b1d4e0c6ec856658a6a70e5e70d287ce
 2016-09-22 14:21:18 -05:00
Ben Sander 77c86934c1 Refactor Staging Buffer CopyDeviceToHost 
Use copyMode.  Embed algorithm selection inside the unpinned class.

Change-Id: Ic75fd5931717a3160904402794bbed3ccd445112
 2016-09-22 14:21:18 -05:00
Ben Sander e77d75c1c1 Refactor staging buffer CopyHostToDevice. 
- Move algorithm selection inside Unpinned class.
- Refactor function names.
- Use size_t for size threshholds.

Change-Id: Iac4de652ac9d49acbf527aa0849e388b8ecd8486
 2016-09-22 14:21:18 -05:00
Ben Sander b4bc101c96 Updates docs for hipHcc* functions, move to header 2016-09-22 13:05:47 -05:00
Aditya Atluri 6cb5a13a2b added more error codes to hipErrorGetString 
Change-Id: I80c675905d94813502040fd0caa07985fa8c7dcc
 2016-09-15 11:28:18 -05:00
Aditya Atluri 2c12394d52 added new error reporting case 
Change-Id: I5f0a37dbe396412f5602d04df19d538e451c2696
 2016-09-15 10:50:26 -05:00
Aditya Atluri 5845a2d8c6 Added signal management which passes stress tests 
Change-Id: I7e1660a8ca2c5ee580a91f76eae9a58ca49f0457
 2016-09-08 14:52:51 -05:00
Ben Sander fd67689114 Add hipStreamQuery 
Change-Id: Ib0813b1065feba4fe9ae861d24cfc6f9c5f580be
 2016-09-07 15:18:34 -05:00
Ben Sander 745310399d refactor ihipPreLaunchKernel phase#1 
- Fix calls to HIP_INIT_API to pass all function arguments.
- Change ihipFunction to follow coding convention:
    - leading underscore for member fields,
    - camelCase for member fields.
- move kernel print function inside ihipPreLaunchKernel.
- add HIP_TRACE_API_COLOR, control color of messages.
- add ihipLogStatus wrapper to hipDeviceSynchronize()

Change-Id: I20bbb644da213f821404648945197254e3648fc9
 2016-09-07 15:18:34 -05:00
Aditya Atluri 26215c515d Fixed group and private memory size to AQL 
Change-Id: I6e721f63fe5697b7b90a7d25add9aa024d9dc429
 2016-09-07 12:57:18 -05:00
Ben Sander 0fdb5bf517 Fix double-lock of stream on hipModuleLaunchKernel 
Change-Id: I4ca164971c25f4eb8fbcca11d6258367bb3d2ab4
 2016-09-02 12:47:49 -05:00
Ben Sander 9ee9284306 Only use ihipLogStatus from top-level HIP functions. 
Change-Id: I07e9c088d5c16a79ed52cb008a798889a656016c
 2016-09-02 09:46:59 -05:00
Ben Sander 9a99000a62 Use create_blocking_marker for WaitEvent implementation 
Change-Id: Ib3113f69a14e48b9fe0558d7b455148e478d8eed
 2016-09-02 09:46:59 -05:00
Ben Sander 02f65a483c Refactor for stream->_av. 
- move _av into stream critical section.  ( HCC accelerator_view is not
  thread-safe but HIP steram is. )
- Refactored many places in code that need to acquire critical section.
some were previously thread races, ie enqueueing marker.

-remove support for GRID_LAUNCH_VERSION < 20
-Enable USE_AV_COPY based on HCC work-week.
- Review hipModule docs, some calrity/editing.

Change-Id: I3ce7c25ece048c3504f55ecd4683e506bb1fc8b6
 2016-09-02 09:46:59 -05:00