c124899669
Merge pull request #282 from gargrahul/texture_driver_3d_support
...
Added support for 3D texture driver apis
2017-12-18 15:39:26 +05:30
379cbfedcf
[cmake] Added target static_check for static code analysis
...
- Added static code analysis using cppcheck
- Fixed couple of warnings reported by cppcheck
Change-Id: Ie3b9b06e95ada322e7dc2ce3d6b91831e870198d
2017-12-14 12:16:44 +05:30
c4192eec7d
Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
...
Fix ilogb/ilogbf functions to return int
2017-12-12 10:47:33 +05:30
b439b45641
Fix ilogb/ilogbf functions to return int
...
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.
2017-12-05 23:14:10 +00:00
105df94cd0
Added support for
...
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array
2017-12-05 14:11:13 +05:30
76614f15af
Re-sync with upstream.
2017-12-03 23:14:58 +00:00
e186bd9533
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
2017-12-03 23:09:06 +00:00
6e2e029b39
Merge pull request #271 from bensander/cppcheck
...
Cppcheck
2017-12-02 08:36:17 -06:00
954b7dadf7
Remove stray leftover comment.
2017-12-02 00:03:10 +00:00
b8c80bd0b2
Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble.
2017-12-02 00:01:47 +00:00
5933ca7300
Fix some cppcheck style issues.
2017-12-01 20:45:34 +00:00
743c54a012
Fix warning from default cppchek.
2017-12-01 20:45:33 +00:00
33bb425013
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
4966518846
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit 4792475
2017-11-29 21:49:10 +00:00
2557000b56
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
2017-11-29 21:36:29 +00:00
93e595c267
Fix compiler version check.
2017-11-29 03:05:53 +00:00
e305d3fc94
Add missing file.
2017-11-29 02:16:44 +00:00
37c1811b2a
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
c6ab6f292b
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
45a9f4f7b1
Remove leftover agent allocated globals.
2017-11-28 19:56:04 +00:00
d5c8de3f41
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
6a0efb7ed2
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
d37a5a6008
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
cc418da654
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-28 17:23:43 +00:00
bb35299560
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
2017-11-28 17:23:06 +00:00
4b7cb0624e
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
2017-11-28 17:23:06 +00:00
e93a24bdbe
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
822743845c
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-23 09:57:24 +05:30
38029f2849
Fixed review comments
2017-11-21 21:19:06 +05:30
fb1021cc0a
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
2017-11-21 13:15:13 +00:00
24307fe5c4
Changed function hipMemcpy_2D to hipMemcpyParam2D
2017-11-21 12:36:24 +05:30
f8c1c1b38e
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
2017-11-21 02:40:34 +00:00
24f8a93ff7
Clean-up some remaining noise in program_state.cpp.
2017-11-20 22:41:46 +00:00
27bc487635
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
2017-11-20 16:33:52 +00:00
30d90dab38
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
a1e0c96689
Merge pull request #264 from pzins/missing_end_marker
...
Fix missing MARKER_END
2017-11-20 06:08:01 -06:00
eff09fcd86
-Moved coGlobals in hipModule class (takes care of multi module case)
...
-Used mutex scope for updating coGlobals
2017-11-20 16:23:18 +05:30
76f174b536
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
0cc921f103
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
e2e499461a
Removed redundant desc variable
2017-11-15 18:28:27 +05:30
edbfeeb141
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
e536eb038d
Texture code reorganized
2017-11-14 11:09:35 +05:30
e60a95d7dd
Fix missing MARKER_END
...
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
2017-11-13 16:13:19 -05:00
1518611976
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-09 23:43:07 +00:00
1851c153f6
Texture driver APIs support
2017-11-09 22:10:55 +05:30
925f97fac7
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
2017-11-09 07:52:09 +05:30
f7919a8321
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
2017-11-08 10:26:30 +00:00
0ad1308efd
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
8854dec897
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-07 00:01:22 +00:00
e71456cc6c
Check for null event in hipEventElapsedTime
2017-11-06 23:49:31 +00:00
Maneesh Gupta
Aaron En Ye Shi
Rahul Garg
Alex Voicu
Ben Sander
Pierre