AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,048 Commits 3 Branches 0 Tags
cd92bd7feed141d24da4d7a50e2b24eb3993d3cd
Commit Graph

5048 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evgeny Mankov e51880cbca Merge pull request #1416 from gargrahul/HACK_hipFreeForManangedMalloc 
[HACK] Temporary fix in hipFree for hipManagedMalloc use
 2019-09-13 18:57:21 +03:00
Evgeny Mankov 182058fa0b [HIPIFY][doc] Update README.md 
+ Adding -DLLVM_TARGETS_TO_BUILD="NVPTX" to LLVM's cmake command line for minimizing LLVM's build (tested)
+ Test logs update
+ Versions update
 2019-09-13 18:56:48 +03:00
foreman 184ee3f5a0 P4 to Git Change 1997981 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/13 11:17:32 
SWDEV-203438 - [HIP] AllGather RCCL test issue
	The test tries to launch a kernel on two devices at once and they need to communicate with each other.
	For that, it uses a custom stream for each devices.
	Problem is in getNullStream we used to call syncStreams all the time
	and it was syncing all the streams even the ones on different devices.
	So that made the second kernel launch (on 2n dev) to wait for the first kernel to finish which
	would never occur since the first one was waiting for the second one.
	The fix is to not call syncStreams from getNullStream because we sync already anyway prior in general.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#24 edit
 2019-09-13 11:28:33 -04:00
Jenkins 828e18eff7 Merge 'master' into 'amd-master' 
Change-Id: I449c7c1d18e70c4f7f25b264d7871a49b75fc77c
 2019-09-13 05:10:52 -04:00
Rahul Garg f0a1f95864 Fix typo and colon in comment 2019-09-13 03:09:01 +05:30
Rahul Garg fe47b2185c [HACK] Temporary fix for hipFree for hipManagedMalloc 2019-09-13 02:10:21 +05:30
foreman a508c497ec P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09 
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit
 2019-09-12 14:35:36 -04:00
Evgeny Mankov 6739a6d656 Merge pull request #1414 from emankov/master 
[HIPIFY] Add unsupported fp16 functions
 2019-09-12 18:53:08 +03:00
Evgeny Mankov 34540002dd [HIPIFY] Add unsupported fp16 functions 2019-09-12 18:51:25 +03:00
Evgeny Mankov 63198e0d66 Merge pull request #1413 from emankov/master 
[HIPIFY] Add more unsupported device functions
 2019-09-12 17:55:43 +03:00
Evgeny Mankov 58c1a144d1 [HIPIFY] Add more unsupported device functions 2019-09-12 17:53:25 +03:00
Jenkins 121206adf9 Merge 'master' into 'amd-master' 
Change-Id: I99fcb0d69a58ce09065991a580662660d2941f9f
 2019-09-12 06:06:14 -04:00
Evgeny Mankov 2cf9922754 Merge pull request #1410 from emankov/master 
[HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
 2019-09-11 18:13:05 +03:00
Evgeny Mankov 0426035468 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h 2019-09-11 18:07:09 +03:00
Evgeny Mankov ccf8ffc0c9 Merge pull request #1406 from emankov/master 
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
 2019-09-11 15:49:46 +03:00
Jenkins c0f79c5411 Merge 'master' into 'amd-master' 
Change-Id: I836a4d36b2f43db1e1850c55e8b174755abd414f
 2019-09-10 10:07:07 -04:00
Evgeny Mankov 56ab105e9d [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl) 
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
 2019-09-10 15:59:06 +03:00
Aditya Lad 90acfb809c Replacment of RENAME command in CMakeLists.txt (#1402) 2019-09-10 08:35:16 +00:00
foreman 66a6e703f2 P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42 
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit
 2019-09-09 14:50:37 -04:00
foreman f3e2d275c5 P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57 
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit
 2019-09-09 14:42:47 -04:00
Jenkins cbe6b65e2c Merge 'master' into 'amd-master' 
Change-Id: Ibb1dbe78aa52c8aeb77851ee1471e1edaec4c654
 2019-09-09 05:10:28 -04:00
Evgeny Mankov 29d09eb269 Merge pull request #1398 from emankov/master 
[HIPIFY] Add device functions support
 2019-09-07 19:00:00 +03:00
foreman 8167dee7d5 P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36 
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit
 2019-09-06 19:11:43 -04:00
Evgeny Mankov 6602fadc16 [HIPIFY] Add device functions support 
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.
 2019-09-06 18:34:12 +03:00
foreman 5db35686db P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22 
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit
 2019-09-06 04:33:24 -04:00
foreman ee1b139bd9 P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36 
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit
 2019-09-05 16:45:19 -04:00
foreman 3b5927d7fe P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40 
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit
 2019-09-05 14:34:47 -04:00
foreman 485caa0602 P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44 
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit
 2019-09-05 14:30:10 -04:00
foreman 9b5b4c4761 P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26 
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit
 2019-09-05 14:12:32 -04:00
Jeff Daily 8384f487ad fix bug where HIP_DB=1 seg faults at startup (#1388) 2019-09-05 10:04:19 +00:00
mhbliao 119ee4b671 [hip] Stop using noduplicate and replace it with convergent. (#1390) 2019-09-05 10:03:43 +00:00
Paul Fultz II f6cf7e4e79 Use hcc when building with hcc compiler (#1225) 
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME
 2019-09-05 10:03:04 +00:00
Evgeny Mankov 1954af4777 Merge pull request #1395 from emankov/master 
[HIPIFY][cmake][#1394] Fix
 2019-09-05 12:12:08 +03:00
Evgeny Mankov ab560d8fd2 [HIPIFY][cmake][#1394] Fix 
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7
 2019-09-05 12:08:56 +03:00
Evgeny Mankov b457b31c82 Merge pull request #1393 from emankov/master 
[HIPIFY][perl] Code cleanup (preparation for generating)
 2019-09-05 11:54:10 +03:00
Evgeny Mankov 3a034a3427 [HIPIFY][perl] Code cleanup (preparation for generating) 2019-09-05 11:52:59 +03:00
Evgeny Mankov 0ec5b95b69 Merge pull request #1391 from emankov/master 
[HIPIFY][perl] Sync hipify-perl with hipify-clang
 2019-09-05 09:07:32 +03:00
foreman 6b67514724 P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05 
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add
 2019-09-04 17:16:03 -04:00
Evgeny Mankov 2a4c008385 [HIPIFY][perl] Sync hipify-perl with hipify-clang 
Sync by means of semi-automatic generation: hipify-clang -perl
 2019-09-04 17:07:45 +03:00
Evgeny Mankov 8feb4e1c9c Merge pull request #1389 from emankov/master 
[HIPIFY][perl] Code cleanup and formatting
 2019-09-04 16:39:12 +03:00
Evgeny Mankov 5b8843a127 [HIPIFY][perl] Code cleanup and formatting 2019-09-04 16:37:26 +03:00
Evgeny Mankov c9eb8fa1e8 Merge pull request #1387 from emankov/master 
[HIPIFY][perl][#259] Fix
 2019-09-04 16:11:16 +03:00
Evgeny Mankov b98330609b [HIPIFY][perl][#259] Fix 
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );
 2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 8fe8fc18c0 Do not include cuda wappers for OMP for hip-clang (#1382) 2019-09-03 05:13:59 +00:00
Rahul Garg 6545521d6c Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381) 
This reverts commit ac62d7a5c0.
 2019-09-03 05:13:46 +00:00
Nicholas Malaya 5a6eafcbf1 Fix Broken Link in hip_porting_guide (#1376) 
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.
 2019-09-03 05:13:35 +00:00
Sarbojit2019 e1f9e08ea7 Removed hipLaunchKernel macro got missed in Merge (#1374) 2019-09-03 05:13:07 +00:00
Evgeny Mankov 7b0480aa69 Merge pull request #1385 from emankov/master 
[HIPIFY][doc] Update README.md (testing, versions)
 2019-09-02 18:20:44 +03:00
Evgeny Mankov fbf23ed231 [HIPIFY][doc] Update README.md (testing, versions) 2019-09-02 18:18:43 +03:00
Evgeny Mankov 0e70229459 Merge pull request #1384 from emankov/master 
[HIPIFY][tests] Add occupancy test
 2019-09-02 17:56:16 +03:00